On Fri, Jul 19, 2013 at 10:35:20AM -0700, Alex Wang wrote:
> Then, should we also change the "-Wno-override-init" to "-Woverride-init"?
I haven't thought about that warning option since 2009 when I
introduced it.
It looks like we're clean on -Wextra, which enables -Woverride-init
and some others.
On Thu, Jul 18, 2013 at 06:06:44PM -0700, Linda Sun wrote:
> Signed-off-by: Linda Sun
I folded in the following incremental to fix up a few style issues,
and then applied this to master.
Thanks,
Ben.
diff --git a/lib/odp-util.c b/lib/odp-util.c
index c12e2fe..5a32221 100644
--- a/lib/odp-util.
Hey,
Then, should we also change the "-Wno-override-init" to "-Woverride-init"?
I also had related warning when compiling with clang. And these two patches
fix it.
Kind Regards,
Alex Wang,
On Fri, Jul 19, 2013 at 10:09 AM, Ben Pfaff wrote:
> On Thu, Jul 18, 2013 at 06:06:44PM -0700, Linda Sun
Signed-off-by: Linda Sun
---
lib/odp-util.c | 15 ---
ofproto/ofproto-dpif-xlate.c | 10 +-
ovsdb/ovsdb-client.c |9 +++--
ovsdb/ovsdb-tool.c |9 +++--
utilities/ovs-benchmark.c| 10 --
utilities/ovs-dpctl.c
On Wed, Jul 17, 2013 at 04:45:32PM -0700, Linda Sun wrote:
> Reference arrays after its definition.
>
> Signed-off-by: Linda Sun
I have a different suggestion for netlink.c. I posted the patch here:
http://openvswitch.org/pipermail/dev/2013-July/029752.html
Will you review it, please?
Reference arrays after its definition.
Signed-off-by: Linda Sun
---
lib/netlink.c| 19 +-
lib/odp-util.c | 15 +-
ofproto/ofproto-dpif-xlate.c |7 +-
ovsdb/ovsdb-tool.c | 21 +-
utilities/ovs-dpctl.c| 23 +-
utilities/ovs-ofctl.c
