Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-07-03 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 03:24:43PM -0700, Sabyasachi Sengupta wrote: > > >It's much easier for a script to parse a number than a date. > > Well, I tried to use time_msec instead of time_wall_msec() in an attempt to > see how the output would look like. > > To me, the original proposal of printin

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Sabyasachi Sengupta
It's much easier for a script to parse a number than a date. Well, I tried to use time_msec instead of time_wall_msec() in an attempt to see how the output would look like. To me, the original proposal of printing wall clock time -- [root@rtr-29-225-196-232 ~]# ovs-appctl bfd/show por

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 06:08:02PM -0700, Sabyasachi Sengupta wrote: > >It's a little unconventional for us to use a wall clock time for this. > >I'd be more inclined to report it as "N seconds ago" or "N ms ago". Any > >particular reason to use a wall clock time? > > I've seen that all BFD other

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Justin Pettit
> On Jun 25, 2015, at 3:08 AM, Sabyasachi Sengupta > wrote: > > [root@rtr-29-225-196-232 ~]# ovs-appctl bfd/show > port3.4094 >Forwarding: true >Detect Multiplier: 3 >Concatenated Path Down: false >TX Interval: Approx 500ms >RX Interval: Approx

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-24 Thread Sabyasachi Sengupta
Hi Ben, It's a little unconventional for us to use a wall clock time for this. I'd be more inclined to report it as "N seconds ago" or "N ms ago". Any particular reason to use a wall clock time? I've seen that all BFD other outputs use "now -/+" convention, but just that I thought wall cloc

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 08:11:22AM -0700, Sabyasachi Sengupta wrote: > Extend bfd to save wall clock time of the last flap in bfd_forwarding__, > and display it throught bfd/show. This information is also exported out > to ovsdb in bfd_get_status. > > Signed-off-by: Sabyasachi Sengupta This seem

[ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-23 Thread Sabyasachi Sengupta
Extend bfd to save wall clock time of the last flap in bfd_forwarding__, and display it throught bfd/show. This information is also exported out to ovsdb in bfd_get_status. Signed-off-by: Sabyasachi Sengupta diff --git a/lib/bfd.c b/lib/bfd.c index 92fdbd8..c8122b0 100644 --- a/lib/bfd.c