Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Ben Pfaff
On Fri, Dec 12, 2014 at 12:26:38PM +0900, Simon Horman wrote: > On Thu, Dec 11, 2014 at 07:16:36PM -0800, Ben Pfaff wrote: > > On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote: > > > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > > > > On Fri, Dec 12, 2014 at 11:31:50AM +0

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 07:16:36PM -0800, Ben Pfaff wrote: > On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote: > > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > > > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > > > > On Thu, Dec 11, 2014 at 11:49:33AM -0

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Ben Pfaff
On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote: > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > > > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > > > > On Wed, Nov 19, 2014 at 09:44:58AM +0

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > > > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > > > > NMX selection method > > > > Signed-o

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Ben Pfaff
On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > > > NMX selection method > > > Signed-off-by: Simon Horman > > > > I'm not sure that it makes sense to che

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > > NMX selection method > > Signed-off-by: Simon Horman > > I'm not sure that it makes sense to check the prerequisites. It's easy > to imagine wanting to use fields as par

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Ben Pfaff
On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > NMX selection method > Signed-off-by: Simon Horman I'm not sure that it makes sense to check the prerequisites. It's easy to imagine wanting to use fields as part of the selection method when they are present, and simply omitting th

[ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-11-18 Thread Simon Horman
NMX selection method Signed-off-by: Simon Horman --- ofproto/ofproto.c | 63 +++ 1 file changed, 40 insertions(+), 23 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 00e668a..b749ca6 100644 --- a/ofproto/ofproto.c +++ b/of