Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-23 Thread Ben Pfaff
On Mon, Nov 09, 2015 at 03:22:28PM -0800, Justin Pettit wrote: > > On Nov 6, 2015, at 7:01 AM, Russell Bryant wrote: > > On 11/03/2015 06:48 PM, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > > > > I haven't tested this yet, but it all looks right to me with fresh eyes. > > > > Acked-

Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-09 Thread Justin Pettit
> On Nov 6, 2015, at 7:01 AM, Russell Bryant wrote: > > On 11/03/2015 06:48 PM, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > I haven't tested this yet, but it all looks right to me with fresh eyes. > > Acked-by: Russell Bryant Thanks for the reviews Russell and Flavio. I've pus

Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-06 Thread Russell Bryant
On 11/03/2015 06:48 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit I haven't tested this yet, but it all looks right to me with fresh eyes. Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-06 Thread Russell Bryant
On 11/06/2015 02:52 AM, Justin Pettit wrote: > >> On Nov 5, 2015, Russell Bryan wrote: > >> >>> + "inport == %s && (ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && " >> >> You've got a duplicate condition here, checking ip4.dst == IP_FMT twice. > > Yes, but I set them to two different values-

Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-05 Thread Justin Pettit
> On Nov 5, 2015, Russell Bryan wrote: > >> + "inport == %s && (ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && " > > You've got a duplicate condition here, checking ip4.dst == IP_FMT twice. Yes, but I set them to two different values--the router IP and local broadcast address: >> + "icm

Re: [ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-05 Thread Russell Bryant
On 11/03/2015 06:48 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > ovn/northd/ovn-northd.8.xml |5 + > ovn/northd/ovn-northd.c | 23 --- > 2 files changed, 21 insertions(+), 7 deletions(-) > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/north

[ovs-dev] [ICMP v2 7/7] ovn-northd: Support pinging logical router ports.

2015-11-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/northd/ovn-northd.8.xml |5 + ovn/northd/ovn-northd.c | 23 --- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml index 6f0a420..e7dec72 100644 --- a/ovn/