On 11/06/2015 02:52 AM, Justin Pettit wrote: > >> On Nov 5, 2015, Russell Bryan <rbry...@redhat.com> wrote: > >> >>> + "inport == %s && (ip4.dst == "IP_FMT" || ip4.dst == "IP_FMT") && " >> >> You've got a duplicate condition here, checking ip4.dst == IP_FMT twice. > > Yes, but I set them to two different values--the router IP and local > broadcast address: > >>> + "icmp4.type == 8 && icmp4.code == 0", >>> + op->json_key, IP_ARGS(op->ip), IP_ARGS(op->bcast)); > > Do you see a problem?
The only problem I see now is that I read this wrong and gave a bad review. :-) I'll read the patch again. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
