Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Justin Pettit
On Nov 9, 2011, at 12:54 PM, Jesse Gross wrote: > On Wed, Nov 9, 2011 at 12:12 PM, Justin Pettit wrote: >> On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote: >> Should we make the "ttl=" be "hop_limit=" as well? Otherwise, looks good. >> >> As we discussed off-line, it's probably

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Jesse Gross
On Wed, Nov 9, 2011 at 12:12 PM, Justin Pettit wrote: > On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote: > >>> Should we make the "ttl=" be "hop_limit=" as well? >>> >>> Otherwise, looks good. > > As we discussed off-line, it's probably better to use "hlimit" since it's > shorter and we're alrea

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Justin Pettit
On Nov 9, 2011, at 12:00 PM, Justin Pettit wrote: >> Should we make the "ttl=" be "hop_limit=" as well? >> >> Otherwise, looks good. As we discussed off-line, it's probably better to use "hlimit" since it's shorter and we're already breaking from other kernel naming conventions. An incrementa

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Justin Pettit
On Nov 9, 2011, at 11:53 AM, Jesse Gross wrote: > On Wed, Nov 9, 2011 at 11:21 AM, Justin Pettit wrote: >> diff --git a/lib/odp-util.c b/lib/odp-util.c >> index 3703844..4b0cee4 100644 >> --- a/lib/odp-util.c >> +++ b/lib/odp-util.c >> @@ -390,7 +390,7 @@ format_odp_key_attr(const struct nlattr *

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Jesse Gross
On Wed, Nov 9, 2011 at 11:21 AM, Justin Pettit wrote: > diff --git a/lib/odp-util.c b/lib/odp-util.c > index 3703844..4b0cee4 100644 > --- a/lib/odp-util.c > +++ b/lib/odp-util.c > @@ -390,7 +390,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds) >                       ",tos=%#"PRIx8

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Ben Pfaff
On Wed, Nov 09, 2011 at 11:21:07AM -0800, Justin Pettit wrote: > On Nov 8, 2011, at 10:52 PM, Jesse Gross wrote: > >> @@ -71,22 +71,23 @@ struct flow { > >> uint8_t dl_dst[6]; /* Ethernet destination address. */ > >> uint8_t nw_proto; /* IP protocol or low 8 bits of ARP

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-09 Thread Justin Pettit
On Nov 8, 2011, at 10:52 PM, Jesse Gross wrote: > I got a whitespace error: > Applying: Support matching and modifying IP TTL. > /home/jesse/openvswitch/.git/rebase-apply/patch:977: trailing whitespace. > Matches IP TTL or IPv6 hop limit value \fIttl\fR, which is > warning: 1 line adds whitespace

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-08 Thread Jesse Gross
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote: > Add support matching the IPv4 TTL and IPv6 hop limit fields.  This > commit also adds support for modifying the IPv4 TTL.  Modifying the IPv6 > hop limit isn't currently supported, since we don't support modifying > IPv6 headers. > > We will l

Re: [ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-08 Thread Ben Pfaff
On Tue, Nov 08, 2011 at 03:57:31PM -0800, Justin Pettit wrote: > Add support matching the IPv4 TTL and IPv6 hop limit fields. This > commit also adds support for modifying the IPv4 TTL. Modifying the IPv6 > hop limit isn't currently supported, since we don't support modifying > IPv6 headers. > >

[ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

2011-11-08 Thread Justin Pettit
Add support matching the IPv4 TTL and IPv6 hop limit fields. This commit also adds support for modifying the IPv4 TTL. Modifying the IPv6 hop limit isn't currently supported, since we don't support modifying IPv6 headers. We will likely want to change the user-space interface, since basic matchi