On Wed, Nov 9, 2011 at 9:10 AM, Justin Pettit wrote:
> On Nov 9, 2011, at 8:50 AM, Jesse Gross wrote:
>
>>> An incremental is at the end of this message.
>>
>> Looks good, thanks.
>
>
> Thanks. If it all looks good, did you want to include an Acked-by?
Sure:
Acked-by: Jesse Gross
I just didn't
On Nov 9, 2011, at 8:50 AM, Jesse Gross wrote:
>> An incremental is at the end of this message.
>
> Looks good, thanks.
Thanks. If it all looks good, did you want to include an Acked-by?
--Justin
___
dev mailing list
dev@openvswitch.org
http://ope
On Tue, Nov 8, 2011 at 11:40 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 5:12 PM, Jesse Gross wrote:
>>> @@ -385,10 +385,10 @@ format_odp_key_attr(const struct nlattr *a, struct ds
>>> *ds)
>>> ...
>>> + ds_put_format(ds,
>>> "ipv6(src=%s,dst=%s,label=0x%"PRIx32",proto=%"PRId8
>>
>> I t
On Nov 8, 2011, at 5:12 PM, Jesse Gross wrote:
> I got some sparse errors:
> /home/jesse/openvswitch/datapath/linux/flow.c:205:40: warning:
> restricted __be32 degrades to integer
> /home/jesse/openvswitch/datapath/linux/flow.c:205:25: warning:
> incorrect type in assignment (different base types)
On Nov 8, 2011, at 4:06 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:28PM -0800, Justin Pettit wrote:
>> +/* The flow label in the IPv6 header.
>> + *
>> + * Prereqs: NXM_OF_ETH_TYPE must match 0x86dd exactly.
>> + *
>> + * Format: 20-bit IPv6 flow label.
>
> In the least-significant 20 b
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
I got some sparse errors:
/home/jesse/openvswitch/datapath/linux/flow.c:205:40: warning:
restricted __be32 degrades to integer
/home/jesse/openvswitch/datapath/linux/flow.c:205:25: warning:
incorrect type in assi
On Tue, Nov 08, 2011 at 03:57:28PM -0800, Justin Pettit wrote:
> +/* The flow label in the IPv6 header.
> + *
> + * Prereqs: NXM_OF_ETH_TYPE must match 0x86dd exactly.
> + *
> + * Format: 20-bit IPv6 flow label.
In the least-significant 20 bits of the field, right?
> @@ -162,6 +163,7 @@ struct mf
Signed-off-by: Justin Pettit
---
NEWS |3 ++-
datapath/flow.c |7 +--
datapath/flow.h |7 ---
include/linux/openvswitch.h |1 +
include/openflow/nicira-ext.h |9 +
lib/classifier.c | 16 +
