Hi William,
Comments inline.
On 7/12/16, 12:06 PM, "William Tu" wrote:
>Hi Wenyu and Daniel,
>
>Thanks for your feedback.
>
>On Mon, Jul 11, 2016 at 1:50 AM, Wenyu Zhang wrote:
>> Hi William,
>>
>> In your patch, no codes about supporting ³snaplen&q
Hi William,
In your patch, no codes about supporting “snaplen" in IPFIX included. IPFIX
still get the length of packet as before, whatever the packet is truncated.
If user put a non-zero ‘snaplen’ in IPFIX sample action, the IPFIX result
should be incorrect. So the ‘snaplen’ in the flow-based I
It is caused by an environment issue.
Clear the environment and rerun the tests, all
tests passed now.
iPhone
? 2016?6?258:35?Wenyu Zhang mailto:wen...@vmware.com>>
???
All tests passed except following two cases?
1055: ofproto-dpif - Bridge IPFIX statistics checkFAILED
(o
I have fixed the issue, and sent out a new patch.
Due to the result of this feature only can been seen in the exported IPFIX
packet, the test case for it may be a big work. We may consider it with other
IPFIX features tests a litter later.
发自我的 iPhone
> 在 2016年6月25日，上午6:20，Wenyu Zhang
without this patch. We are looking at the errors and try to
fix it later.
? 2016?6?25????8:11?Wenyu Zhang mailto:wen...@vmware.com>>
???
In virtual network, users want more info about the virtual point to observe the
traffic.
It should be a string to provide clear info, not a simple inter
FIX entity "virtualObsID"(898) to export the value.
The entity is a
variable-length string.
Signed-off-by: Wenyu Zhang
---
NEWS | 11 ++--
ofproto/ipfix-enterprise-entities.def | 1 +
ofproto/ofproto-dpif-ipfix.c | 102 +++
Sorry for the stupid mistake.
I am working on it，and will verify it by running check.
发自我的 iPhone
> 在 2016年6月25日，上午4:43，Ben Pfaff 写道：
>
>> On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote:
>> In virtual network, users want more info about the virtual point to obser
al_obs_id");
>
> Maybe adding if (valid_be_cfg) check before the deference? I will
> leave you to fix it. Also I hope you can add a test case to this case.
>
> Regards,
> William
>
>
>> On Fri, Jun 24, 2016 at 1:42 PM, Ben Pfaff wrote:
>>> On Fri, Jun 2
FIX entity "virtualObsID"(898) to export the value.
The entity is a
variable-length string.
Signed-off-by: Wenyu Zhang
---
ofproto/ipfix-enterprise-entities.def | 1 +
ofproto/ofproto-dpif-ipfix.c | 96 +++
ofproto/ofproto.h | 2
Hi Ben,
I add new comments inline . May you take a look?
On 6/24/16, 10:54 AM, "Wenyu Zhang" wrote:
>Thanks for your inputs.
>
>I added some comments inline, may you help take a look?
>
>On 6/24/16, 2:18 AM, "Ben Pfaff" wrote:
>
>>On Mon, Jun 20,
Thanks for your inputs.
I added some comments inline, may you help take a look?
On 6/24/16, 2:18 AM, "Ben Pfaff" wrote:
>On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote:
>> In virtual network, users want more info about the virtual point to
>>observe the t
FIX entity "virtual_obs_id"(898) to export the value.
The entity is a
variable-length string.
Signed-off-by: Wenyu Zhang
---
ofproto/ipfix-enterprise-entities.def | 1 +
ofproto/ofproto-dpif-ipfix.c | 103 ++
ofproto/ofproto.h | 2
On 5/17/16, 3:43 AM, "Ben Pfaff" wrote:
>On Fri, May 13, 2016 at 01:46:50AM -0700, Daniel Benli Ye wrote:
>> In virtual evironment, IPFIX is unable to differentiate flows
>> between pair of VMs on different virtual network if their IP/mac
>> are same.
>>
>> Network:
>> VM1 < VNI1 >
Add logical router related vtep-ctl commands:
vtep-ctl add-lr LR
vtep-ctl del-lr LR
vtep-ctl list-lr
vtep-ctl lr-exists LR
Signed-off-by: Wenyu Zhang
---
vtep/vtep-ctl.8.in | 25 +
vtep/vtep-ctl.c| 155 +
2 files changed, 180
Add logical router related vtep-ctl commands:
vtep-ctl add-lr LR
vtep-ctl del-lr LR
vtep-ctl list-lr
vtep-ctl lr-exists LR
---
vtep/vtep-ctl.c | 155
1 file changed, 155 insertions(+)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index 048
Add supporting for tables necessary for L3 usage:
Logical_Router
Arp_Sources_Local
Arp_Sources_Remote
Signed-off-by: Wenyu Zhang
Acked-by: Shuangmin Zhang
---
vtep/vtep-ctl.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
Add supporting for tables necessary for L3 usage:
Logical_Router
Arp_Sources_Local
Arp_Sources_Remote
Signed-off-by: Wenyu Zhang
Acked-by: Shuangmin Zhang
---
vtep/vtep-ctl.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
On 12/2/15, 11:45 AM, "Ben Pfaff" wrote:
>On Tue, Dec 01, 2015 at 06:43:49PM -0800, Wenyu Zhang wrote:
>> The patch is to skip BFD packets in ipfix.
>> Bidirectional Forwarding Detection (BFD) packets are for monitoring
>> the tunnel link status and consumed b
are the UDP packets with dst
destination port 3785.
Ipfix will skip both BFD control packets and BFD echo packets.
Signed-off-by: Wenyu Zhang
---
ofproto/ofproto-dpif-ipfix.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto
Thanks for your comments. I will correct it.
On 11/30/15, 4:05 AM, "Ben Pfaff" wrote:
>On Wed, Nov 25, 2015 at 02:32:46AM -0800, Wenyu Zhang wrote:
>> This patch is to skip BFD control packets in ipfix.
>> BFD control packet should be tunnel packet with 0 tunnel id,
&
This patch is to skip BFD control packets in ipfix.
BFD control packet should be tunnel packet with 0 tunnel id,
and the inner packet is UDP packet with destination port 3784.
Signed-off-by: Wenyu Zhang
---
ofproto/ofproto-dpif-ipfix.c | 12
1 file changed, 12 insertions(+)
diff
10:01:26AM -0700, Justin Pettit wrote:
>>
>> > On Aug 5, 2015, at 3:11 AM, Wenyu Zhang wrote:
>> >
>> >
>> >> On Aug 4, 2015, at 12:17 PM, Ben Pfaff wrote:
>> >>
>> >> On Tue, Aug 04, 2015 at 04:05:58AM +, Wenyu Z
> On Aug 4, 2015, at 12:17 PM, Ben Pfaff wrote:
>
> On Tue, Aug 04, 2015 at 04:05:58AM +0000, Wenyu Zhang wrote:
>> In ipfix and sflow, the sampling rate can be set as 1, which means
>> 100%. And in order to make 100% packets sampled, I work out a patch
>> in datap
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom32() generate the number of UINT32_MAX.
And none packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
net/openvswitch/actions.c |5 -
1 file changed
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom_u32() generate the number of UINT32_MAX.
And none packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
net/openvswitch/actions.c |4 +++-
1 file changed
you
mean that it is not necessary here?
Bests,
Wenyu
> On Aug 4, 2015, at 12:37 AM, Ben Pfaff wrote:
>
> On Sun, Aug 02, 2015 at 11:54:09PM -0700, Wenyu Zhang wrote:
>> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
>> should be sampled even the
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom_u32() generate the number of UINT32_MAX.
And none packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
net/openvswitch/actions.c |4 +++-
1 file changed
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom32() generate the number of UINT32_MAX.
And none packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
net/openvswitch/actions.c |4 +++-
1 file changed
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom32() generate the number of UINT32_MAX.
And none packet need be sampled when the probability is 0.
---
lib/odp-execute.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
dif
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
should be sampled even the prandom32() generate the number of UINT32_MAX.
And no packet need be sampled when the probability is 0.
Signed-off-by: Wenyu Zhang
---
datapath/actions.c |4 +++-
1 file changed, 3
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
essage-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Saturday, August 16, 2014 2:25 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v10] Extend OVS IPFIX exporter to export tunnel headers
On Fri, Aug 15, 2014 at 12:53 AM, Wenyu Zhang
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
I am working on it, will send the updated patch later.
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Friday, August 15, 2014 2:59 PM
To: Ben Pfaff
Cc: Wenyu Zhang; Romain Lenglet; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v9] Extend OVS IPFIX
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Thursday, August 14, 2014 8:37 AM
To: Wenyu Zhang
Cc: Ben Pfaff; Jesse Gross; Romain Lenglet; dev@openvswitch.org
Subject: Re: [PATCH v8] Extend OVS IPFIX exporter to export tunnel headers
On Wed, Aug 13, 2014 at
>> Signed-off-by: Wenyu Zhang
>> Acked-by: Romain Lenglet
>
> This patch renumbers OVS_TUNNEL_KEY_ATTR_OAM and
> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS. Is that really OK?
>
It is not ok.
There are another fixes to kernel part which I was going to do before pushing
this
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
Sorry, please ingore it. There is a mistake in the patch, I will resend the
patch soon.
-Original Message-
From: Wenyu Zhang
Sent: Friday, August 08, 2014 6:12 PM
To: Wenyu Zhang; Romain Lenglet; pshe...@nicira.com; b...@nicira.com; Jesse
Gross; dev@openvswitch.org
Subject: [PATCH v8
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
> > I'm not sure why tnl_xlate_init() has this new code:
> > /* The tp_src and tp_dst members in flow_tnl are set to be always
> > * wildcarded, not to unwildcard them here. */
> > wc->masks.tunnel.tp_src = 0;
> > wc->masks.tunnel.tp_dst = 0; Does it have any visibl
Thanks for reviewing it. I am working on address the comments. And I add some
new comments inline.
Bests,
Wenyu
Important
-
This needs a rebase because openvswitch.h has moved.
There are sparse warnings and errors. I'll append a patch to fix these.
In datapath/flow_netlink.c, ipv4_
sampling
upcalls in IPFIX exporter. Make the IPFIX exporter generate IPFIX template
sets with enterprise elements for the tunnel info, save the tunnel info
in IPFIX cache entries, and send IPFIX DATA with tunnel info.
Add flowDirection element in IPFIX templates.
Signed-off-by: Wenyu Zhang
Acked-by
May you share checkpatch.pl? I try to look up it in ovs but not find.
Bests,
Wenyu
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Wednesday, July 23, 2014 7:50 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH
Tunnel Source Transport Port. */
>
> WARNING: line over 80 characters
> #783: FILE: include/linux/openvswitch.h:350:
> + OVS_TUNNEL_KEY_ATTR_TP_DST, /* u16 Tunnel Destination Transport Port. */
>
> ERROR: code indent should use tabs where possible
> #799: FILE: include/linux
My comments inline.
发自我的 iPhone
在 2014-7-23，4:02，"Pravin Shelar" 写道：
> On Mon, Jul 21, 2014 at 8:35 PM, Wenyu Zhang wrote:
>> Thanks for the review, my comments inline.
>>
>> Bests,
>> Wenyu
>> -Original Message-
>> From: Pravin Sh
Thanks for the review, my comments inline.
Bests,
Wenyu
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Tuesday, July 22, 2014 6:56 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v5] Extend OVS IPFIX
Hello Pravin,
I added some new comments inline, may you take a look? Please ingore the firest
reply if you haven't looked at it.
And I have sent out patch v5, with the addressed comments except two points I
have explained in comments.
Bests,
Wenyu
-Original Message-
From: Wenyu
Thanks for the review. My comments inline.
Bests,
Wenyu
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Saturday, July 19, 2014 3:51 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v4] Extend OVS IPFIX
I have addressed all the comments and sent out another version of the patch,
may you help?
Thanks
Wenyu
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Friday, July 18, 2014 12:00 PM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Friday, July 18, 2014 1:20 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v3] Extend OVS IPFIX exporter to export tunnel headers
On Thu, Jul 17, 2014 at 3:05
ust a moment ago. May you help?
Bests,
Wenyu
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Thursday, July 17, 2014 1:03 AM
To: Wenyu Zhang
Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v3] Extend OVS IPFIX exporter to export t
device.
Bests,
Wenyu
From: Joe Stringer [mailto:joestrin...@nicira.com]
Sent: Tuesday, July 01, 2014 1:12 PM
To: Wenyu Zhang
Cc: Romain Lenglet; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2] Extend OVS IPFIX exporter to export tunnel
headers
Is there any chance we could get some unit
Thanks for your help.
And how about "ovs-appctl ofproto/trace ovs-dummy" command? The manual about
ovs-vswitchd says that it can generate a packet with "-generate" option.
Can it fit my requirement?
Bests,
Wenyu
- Original Message -
From: "Jesse Gross&quo
I am trying to simulate traffic in test cases to test IPFIX feature.
For normal traffic, I can use "ovs-appctl netdev-dummy/receive " to simulate
it, just refer to the netflow and sflow cases in tests/ofproto-dpif.at
And I can capture the IPFIX packets on lo interface as expected.
But fo
55 matches
Mail list logo
