I have fixed the issue, and sent out a new patch. Due to the result of this feature only can been seen in the exported IPFIX packet, the test case for it may be a big work. We may consider it with other IPFIX features tests a litter later.
发自我的 iPhone > 在 2016年6月25日，上午6:20，Wenyu Zhang <wen...@vmware.com> 写道： > > Thanks for your catch. > Iam working on it. > > 发自我的 iPhone > >> 在 2016年6月25日，上午4:55，William Tu <u9012...@gmail.com> 写道： >> >> Hi Wenyu, >> >> I was debugging a little bit and the issue is a NULL pointer deference >> of be_cfg at virtual_obs_id = smap_get(&be_cfg->other_config, >> "virtual_obs_id"); >> >> Maybe adding if (valid_be_cfg) check before the deference? I will >> leave you to fix it. Also I hope you can add a test case to this case. >> >> Regards, >> William >> >> >>>> On Fri, Jun 24, 2016 at 1:42 PM, Ben Pfaff <b...@ovn.org> wrote: >>>> On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: >>>> In virtual network, users want more info about the virtual point to >>>> observe the traffic. >>>> It should be a string to provide clear info, not a simple interger ID. >>>> >>>> Introduce "other-config: virtual_obs_id" in IPFIX, which is a string >>>> configured by user. >>>> Introduce an enterprise IPFIX entity "virtualObsID"(898) to export the >>>> value. The entity is a >>>> variable-length string. >>>> >>>> Signed-off-by: Wenyu Zhang <wen...@vmware.com> >>> >>> Hi Wenyu. >>> >>> I reverted this commit because it dumps core in test 1048 "ofproto-dpif >>> - Flow IPFIX sanity check" with the following backtrace. It crashes >>> the same way whether I use your original commit or my modified one. >>> >>> #0 hmap_first_with_hash (hmap=<optimized out>, hmap=<optimized out>, >>> hash=<optimized out>) at ../lib/hmap.h:328 >>> #1 smap_find__ (smap=0x94, key=key@entry=0x817f7ab "virtual_obs_id", >>> key_len=14, hash=2537071222) at ../lib/smap.c:366 >>> #2 0x0812b9d7 in smap_get_node (smap=0x9738a276, >>> key=0x817f7ab "virtual_obs_id") at ../lib/smap.c:198 >>> #3 0x0812ba30 in smap_get (smap=0x94, key=0x817f7ab "virtual_obs_id") >>> at ../lib/smap.c:189 >>> #4 0x08055a60 in bridge_configure_ipfix (br=<optimized out>) >>> at ../vswitchd/bridge.c:1237 >>> #5 bridge_reconfigure (ovs_cfg=0x94) at ../vswitchd/bridge.c:666 >>> #6 0x080568d3 in bridge_run () at ../vswitchd/bridge.c:2972 >>> #7 0x0804c9dd in main (argc=10, argv=0xffd8b934) >>> at ../vswitchd/ovs-vswitchd.c:112 >>> >>> When you're ready, please post a fixed version. Please start from the >>> version that I committed. >>> >>> Before you post a patch, run the unit tests. >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=MJBX2NeoFFE5o-wzhi1dy7zWKBNufpc6ky5q7EaQJBo&m=YK-ciEyP0lB9loxNsFHuW5TCW0xNKneVS3R9D-CunQo&s=GYVyJZTPKYoaidcS5nQES3WHzwOjvINyEuv41aVqlTg&e= >>> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
