Re: [ovs-dev] [PATCH v3] docs: directly convert dot diagrams into eps for generating PDF

2015-02-11 Thread Shu Shen
On Fri, Feb 06, 2015 at 11:14:13PM -0800, Ben Pfaff wrote: > On Tue, Feb 03, 2015 at 11:53:29PM -0800, Shu Shen wrote: > > The previous workflow is to convert dot diagrams into .pic format and > > embed into manpages; double borders and arrows were not used in dot but > &g

[ovs-dev] [PATCH] docs: fix overlapping 'weak' edges in ovs-vswitchd.conf.db.5

2015-02-11 Thread Shu Shen
he ends of a weak edge won't be at the same rank and allows mutlple 'weak' edges to be visible. Signed-off-by: Shu Shen --- ovsdb/ovsdb-dot.in | 1 - 1 file changed, 1 deletion(-) diff --git a/ovsdb/ovsdb-dot.in b/ovsdb/ovsdb-dot.in index 006d7ed..134ce22 100755 --- a/ovsdb/ovsdb

[ovs-dev] [PATCH v3] docs: directly convert dot diagrams into eps for generating PDF

2015-02-03 Thread Shu Shen
n addition, 'constraint=false' option is removed from weak references to allow positioning of node boxes to avoid overlapping between multiple edges between "Mirror" and "Port" in ovs-vswitchd.conf.db. Signed-off-by: Shu Shen --- Changes made in V3: - .eps files a

[ovs-dev] [PATCH v2] ofproto: add support of OFPR_ACTION_SET as packet-in reason for OF1.4+

2015-02-03 Thread Shu Shen
This patch adds support for OFPR_ACTION_SET as the packet-in reason when a Packet-In message is triggered by an output action within an action-set. By default reason code OFPR_ACTION_SET is enabled for async messages when Openflow 1.4+ is used. A test case is included. Signed-off-by: Shu Shen

Re: [ovs-dev] [PATCH] ofproto: add support of OFPR_ACTION_SET as packet-in reason for OF1.4+

2015-02-03 Thread Shu Shen
> On Feb 3, 2015, at 3:39 PM, Ben Pfaff wrote: > >> On Mon, Feb 02, 2015 at 04:18:19PM -0800, Shu Shen wrote: >> This patch adds support for OFPR_ACTION_SET as the packet-in reason when >> a Packet-In message is triggered by an output action within an >> acti

Re: [ovs-dev] [PATCH v2] docs: directly convert dot diagrams into eps for generating PDF

2015-02-03 Thread Shu Shen
Let me think about it - seems there is a need to separate the eps files from install-man target. It's really the dist-docs scripts that needs the eps files. Shu > On Feb 3, 2015, at 3:52 PM, Ben Pfaff wrote: > >> On Fri, Jan 30, 2015 at 04:02:40PM -0800, Shu Shen wrote

[ovs-dev] [PATCH] ofproto: add support of OFPR_ACTION_SET as packet-in reason for OF1.4+

2015-02-02 Thread Shu Shen
This patch adds support for OFPR_ACTION_SET as the packet-in reason when a Packet-In message is triggered by an output action within an action-set. By default reason code OFPR_ACTION_SET is enabled for async messages when Openflow 1.4+ is used. A test case is included. Signed-off-by: Shu Shen

[ovs-dev] [PATCH v2] docs: directly convert dot diagrams into eps for generating PDF

2015-01-30 Thread Shu Shen
n addition, 'constraint=false' option is removed from weak references to allow positioning of node boxes to avoid overlapping between multiple edges between "Mirror" and "Port" in ovs-vswitchd.conf.db. Signed-off-by: Shu Shen --- Changes made in V2: - Filter out .eps fil

Re: [ovs-dev] [PATCH] docs: directly convert dot diagrams into eps for generating PDF

2015-01-30 Thread Shu Shen
> This does seem like an improvement in many ways. > > Now, however, the manpage-check target fails for me with: > > vswitchd/vswitch.eps:81: warning: can't find special character `' > vtep/vtep.eps:81: warning: can't find special character `' > Makefile:4634: recipe for target 'manpa

[ovs-dev] [PATCH] docs: directly convert dot diagrams into eps for generating PDF

2015-01-27 Thread Shu Shen
n addition, 'constraint=false' option is removed from weak references to allow positioning of node boxes to avoid overlapping between multiple edges between "Mirror" and "Port" in ovs-vswitchd.conf.db. Signed-off-by: Shu Shen --- build-aux/dist-docs | 4 +-- ovsdb/automake.

[ovs-dev] [PATCH] travis: support versioning of DPDK and options to specify git repo and tag

2015-01-02 Thread Shu Shen
RNEL=3.18 DPDK=1 DPDK_VER=1.7.1sp1 DPDK_GIT=https://github.com/shushen/dpdk Signed-off-by: Shu Shen --- .travis.yml | 2 +- .travis/build.sh | 18 ++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index b91327d..7056f54 10064

[ovs-dev] [PATCH v2] ofproto: add support of OFPR_GROUP as packet-in reason for OF1.4+

2014-12-04 Thread Shu Shen
message triggered by group action. Signed-off-by: Shu Shen --- DESIGN.md| 1 + OPENFLOW-1.1+.md | 1 + ofproto/connmgr.c| 39 ++-- ofproto/ofproto-dpif-xlate.c | 2 +- tests/ofproto-dpif.at| 88

[ovs-dev] [PATCH] ofproto: add support of OPRO_GROUP as packet-in reason for OF1.4+

2014-11-25 Thread Shu Shen
message triggered by group action. Signed-off-by: Shu Shen --- DESIGN.md| 1 + OPENFLOW-1.1+.md | 1 + ofproto/connmgr.c| 39 ++-- ofproto/ofproto-dpif-xlate.c | 2 +- tests/ofproto-dpif.at| 88

Re: [ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-25 Thread Shu Shen
rom: Shu Shen Sent: Friday, November 21, 2014 4:27 PM To: dev@openvswitch.org Cc: Shu Shen Subject: [PATCH] ofproto: fix checking of packet_in_mask in async config The check shall use wire protool reasons, which could be different from the internal packet-in reason. Signed-off-by: Shu Shen --- ofpr

Re: [ovs-dev] [PATCH v2] ofproto: support OFPR_GROUP reason for OF1.4 packet-in.

2014-11-21 Thread Shu Shen
switch.org/pipermail/dev/2014-November/049117.html Support of OFPR_GROUP will come later as another patch. Hope this improvement will help review and increase the chance to be accepted :-). Thanks, Shu -Original Message----- From: Shu Shen Sent: Thursday, November 13, 2014 9:57 AM To: dev@openv

[ovs-dev] [PATCH] ofproto: fix checking of packet_in_mask in async config

2014-11-21 Thread Shu Shen
The check shall use wire protool reasons, which could be different from the internal packet-in reason. Signed-off-by: Shu Shen --- ofproto/connmgr.c | 2 +- tests/ofproto-dpif.at | 62 +++ 2 files changed, 63 insertions(+), 1 deletion

[ovs-dev] [PATCH 2/2] ofproto-dpif: fix OF1.4 packet-in wire protocol version

2014-11-21 Thread Shu Shen
Previously even when OF1.4 is used between the controller and the switch, packet-in messages has OF1.3 as wire protocol version. Signed-off-by: Shu Shen --- lib/ofp-msgs.h | 2 +- lib/ofp-util.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ofp-msgs.h b/lib/ofp

[ovs-dev] [PATCH 1/2] ofproto-dpif: add test case for OF1.4 packet-in

2014-11-21 Thread Shu Shen
The test case current fails and shows a bug when OF1.4 is used between the controller and the switch, the packet-in message still uses OF1.3 wire protocol version. Signed-off-by: Shu Shen --- tests/ofproto-dpif.at | 44 1 file changed, 44 insertions

[ovs-dev] [PATCH v2] ofproto: support OFPR_GROUP reason for OF1.4 packet-in.

2014-11-13 Thread Shu Shen
enable OFPR_GROUP reporting. Signed-off-by: Shu Shen --- DESIGN.md| 1 + OPENFLOW-1.1+.md | 1 + lib/ofp-msgs.h | 2 +- lib/ofp-util.c | 4 +- ofproto/connmgr.c| 41 +++-- ofproto/ofproto-dpif-xlate.c | 2

Re: [ovs-dev] Initial support of OF1.4 packet-in reasons

2014-11-13 Thread Shu Shen
It appears the patch is failing a testcase 'ofproto - event filtering (OpenFlow 1.3)'. I have a fix running through Travis now and will submit a V2 of the patch tomorrow morning. Sorry for letting the failed test case slip through. Thanks, Shu -Original Message----- From: Shu

[ovs-dev] [PATCH 2/2] Add support of OFPR_GROUP reason for OF1.4 packet-in messages

2014-11-12 Thread Shu Shen
Signed-off-by: Shu Shen --- DESIGN.md| 1 + OPENFLOW-1.1+.md | 1 + lib/ofp-msgs.h | 2 +- lib/ofp-util.c | 27 -- ofproto/connmgr.c| 4 +- ofproto/ofproto-dpif-xlate.c | 2 +- tests/ofproto-dpif.at

[ovs-dev] [PATCH 1/2] Extending Packet-In reasons definition

2014-11-12 Thread Shu Shen
Signed-off-by: Shu Shen --- include/openflow/openflow-common.h | 5 - lib/ofp-util.c | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/openflow/openflow-common.h b/include/openflow/openflow-common.h index 0915c91..4a7486b 100644 --- a

[ovs-dev] Initial support of OF1.4 packet-in reasons

2014-11-12 Thread Shu Shen
This patch set updates OF1.4 support of packet-in reasons. Only OFPR_GROUP is differentiated and could be reported as additional reason at this moment. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto: Fix supported group types.

2014-11-10 Thread Shu Shen
Ben, You are correct. I've corrected it and submitted v2 of the patch. Thanks, Shu -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Monday, November 10, 2014 3:57 PM To: Shu Shen Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] ofproto: Fix supported group

[ovs-dev] [PATCH v2] ofproto: Fix supported group types.

2014-11-10 Thread Shu Shen
Previously the types field is uninited and leds to no supported type being reported in OFPMP_GROUP_FEATURES message. Signed-off-by: Shu Shen --- ofproto/ofproto.c | 1 + tests/ofproto.at | 14 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b

[ovs-dev] [PATCH] ofproto: Fix supported group types.

2014-11-10 Thread Shu Shen
Previously the types field is uninited and leds to no supported type being reported in OFPMP_GROUP_FEATURES message. Signed-off-by: Shu Shen --- ofproto/ofproto.c | 3 +++ tests/ofproto.at | 11 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b