On Fri, Feb 06, 2015 at 11:14:13PM -0800, Ben Pfaff wrote: > On Tue, Feb 03, 2015 at 11:53:29PM -0800, Shu Shen wrote: > > The previous workflow is to convert dot diagrams into .pic format and > > embed into manpages; double borders and arrows were not used in dot but > > introduced in .pic conversion; edge routing in .pic was also worse than > > dot. > > > > The updated workflow specifies directly in dot diagram double > > boarders for "root set" nodes and solid/bold styles and arrows for > > edges. The converted .eps diagram has improved routing. The .eps diagram > > is embedded into PDF using groff PSPIC marco package when converting the > > manpages. PSPIC package is automatically loaded by groff when output to > > PS/PDF. > > > > In addition, 'constraint=false' option is removed from weak > > references to allow positioning of node boxes to avoid overlapping > > between multiple edges between "Mirror" and "Port" in > > ovs-vswitchd.conf.db. > > > > Signed-off-by: Shu Shen <shu.s...@radisys.com> > > I guess this seems like a regression to me. Before, I could type "make > sandbox" then "groffer ovs-vswitchd.conf.db" and get a nice PDF manpage > with an E-R diagram. After, the diagram is gone.
I looked at "groffer" script and I couldn't find a way to pass it an external dependency (.eps files). groffer copies the manpages to a /tmp folder and generates device files from there. Therefore, even if I managed to have .eps files installed properly along with the man page, they are not copied over to /tmp folders. The only way to make groffer work is to use embedded PIC diagram. The other choice is to keep embedded PIC diagram in the manpage and only have dist-docs replace with eps files when generating PDFs - but would this be too much a kludge to justify the benefit? Maybe I shall just drop the patch - and only include the fix for overlapping multiple edges by removing "constraint=fale"? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
