lculation
to be performed. It does this by persisting a copy of
the localvif_to_ofport and tunnel information in the
controller module, rather than in the physical.c module
as was the case with previous commits.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan
"dev" wrote on 10/05/2016 01:19:34 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: Ben Pfaff
> Cc: dev@openvswitch.org
> Date: 10/05/2016 01:20 PM
> Subject: Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode
> Sent by: "dev"
>
> Ben Pfaff
ovs_idl_txn is checked before various routines (like patch_run) execute.
However, flow calculation and installation does not also check this
variable, which can lead to oscillations as described in [1].
[1] http://openvswitch.org/pipermail/dev/2016-October/080247.html
Signed-off-by: Ryan Moats
Ben Pfaff wrote on 10/05/2016 01:04:36 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 10/05/2016 01:04 PM
> Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode
>
> On Wed, Oct 05, 2016 at 12:52:57PM -0500, Ryan Moats wrote:
Ben Pfaff wrote on 10/05/2016 12:37:26 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 10/05/2016 12:37 PM
> Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode
>
> On Tue, Oct 04, 2016 at 05:11:37PM -0500, Ryan Moats wrote:
lculation
to be performed. It does this by persisting a copy of
the localvif_to_ofport and tunnel information in the
controller module, rather than in the physical.c module
as was the case with previous commits.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan
Ben Pfaff wrote on 10/04/2016 12:14:32 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 10/04/2016 12:14 PM
> Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode
>
> On Wed, Aug 31, 2016 at 03:22:44PM +, Ryan Moats wrote
ue is only seen in the master branch.
Fixes: df70a7731 ("ofproto-dpif-xlate: Allow translating without side-effects.")
Signed-off-by: Ryan Moats
---
ofproto/ofproto-dpif-xlate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-x
When run with valgrind, ovn-nbctl.c and tests/test-ovn.c reveal
memory leaks of their own. This patch cleans these up so that
they don't create noise when looking for leaks in the OVN daemon
processes.
Signed-off-by: Ryan Moats
---
ovn/utilities/ovn-nbctl.c | 1 +
tests/test-ovn.c
Chandra Sekhar Vejendla/San Jose/IBM@IBMUS wrote on 09/02/2016 02:34:35 PM:
> From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS
> To: dev@openvswitch.org
> Cc: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS, Ryan
Moats/Omaha/IBM@IBMUS
> Date: 09/02/2016 02:35 PM
> Subject: [PATCH]
"dev" wrote on 08/19/2016 08:06:50 PM:
> From: Ramu Ramamurthy
> To: dev@openvswitch.org
> Cc: Suryanarayan Ramamurthy/San Jose/IBM@IBMUS
> Date: 08/19/2016 08:07 PM
> Subject: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl
> Sent by: "dev"
>
> From: Ramu Ramamurthy
>
> The following
Ben Pfaff wrote on 09/01/2016 12:02:53 PM:
> From: Ben Pfaff
> To: dev@openvswitch.org
> Cc: Ben Pfaff , Ryan Moats/Omaha/IBM@IBMUS
> Date: 09/01/2016 12:04 PM
> Subject: [PATCH] ovn-controller: Fix memory leak in
> recv_S_TLV_TABLE_REQUESTED().
>
> Nothing freed
When unpersisting patch_datapaths, missed that the key field
needed to be freed to avoid a memory leak. This patch fixes
same.
Signed-off-by: Ryan Moats
---
ovn/controller/ovn-controller.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn
pings (ofp-util.c:10077)
by 0x472A3A: ofputil_decode_tlv_table_reply (ofp-util.c:10159)
by 0x40C2B1: recv_S_TLV_TABLE_REQUESTED (ofctrl.c:209)
by 0x40C2B1: ofctrl_run (ofctrl.c:471)
by 0x406C8F: main (ovn-controller.c:439)
Signed-off-by: Ryan Moats
---
ovn/controller/ofctrl.c |
Ben Pfaff wrote on 08/31/2016 04:26:37 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev , Jesse Gross
> Date: 08/31/2016 04:26 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module
> back to full processing
>
> On Wed, Aug 31,
Ben Pfaff wrote on 08/31/2016 02:45:36 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/31/2016 02:45 PM
> Subject: Re: [ovs-dev] [ovs-dev, v2,3/4] Unpersist data structures
> for address sets.
>
> On Wed, Aug 31, 2016 at 01:5
"dev" wrote on 08/31/2016 12:53:27 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: Ben Pfaff
> Cc: dev@openvswitch.org
> Date: 08/31/2016 12:53 PM
> Subject: Re: [ovs-dev] [ovs-dev, v2, 3/4] Unpersist data structures
> for address sets.
> Sent by: "dev"
Ben Pfaff wrote on 08/31/2016 12:46:17 PM:
> From: Ben Pfaff
> To: Jesse Gross
> Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev
> Date: 08/31/2016 12:46 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module
> back to full processing
>
> On Tue, Aug 30,
Ben Pfaff wrote on 08/31/2016 12:38:34 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/31/2016 12:38 PM
> Subject: Re: [ovs-dev,v2,3/4] Unpersist data structures for address sets.
>
> On Wed, Aug 31, 2016 at 03:22:45PM +0
This patch converts the encaps module back to full processing, but
does not remove all persistence of associated data strcutures.
Signed-off-by: Ryan Moats
---
ovn/controller/encaps.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/ovn
With the removal of incremental processing, it is no longer
necessary to persist the data structures for storing address
sets. Simplify things by removing this complexity.
Side effect: fixed a memory leak in expr_macros_destroy that
is evidenced by this change.
Signed-off-by: Ryan Moats
lculation
to be performed. It does this by persisting a copy of
the localvif_to_ofport and tunnel information in the
controller module, rather than in the physical.c module
as was the case with previous commits.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan
e
ovn/controller/lflow.c module.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
include/ovn/actions.h | 4 -
ovn/controller/binding.c| 154 ++
ovn/controller/binding.h| 1 -
ovn/controller/enc
encaps.c module - it's not clear
how to revert that while still maintaining 100% unit test pass.
v1->v2:
removed poll_immediate_wake() from encaps.c that will lead to
ovn-controller pegging a cpu.
Ryan Moats (4):
ovn-controller: Back out incremental processing
ovn-controller: add qu
("ovn-controller:
Back out incremental processing").
Signed-off-by: Ryan Moats
---
ovn/controller/lflow.c | 166 -
ovn/lib/expr.c | 1 +
2 files changed, 42 insertions(+), 125 deletions(-)
diff --git a/ovn/controller/lfl
16cb ("ovn-controller:
Back out incremental processing").
Signed-off-by: Ryan Moats
---
ovn/controller/encaps.c | 34 +++---
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c
index d99ba05..8444
cessing").
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
ovn/controller/ofctrl.c | 2 +
ovn/controller/ovn-controller.c | 73 -
ovn/controller/ovn-controller.h | 1 +
ovn/controller/patch.c |
oller/lflow.c module.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
include/ovn/actions.h | 4 -
ovn/controller/binding.c| 154 ++
ovn/controller/binding.h| 1 -
ovn/controller/encaps.c
encaps.c module - it's not clear
how to revert that while still maintaining 100% unit test pass.
Note: these patches previously existed as individually versioned patches.
There is no change from v7, v4, v1, and v1 (in order).
Ryan Moats (4):
ovn-controller: Back out incremental processing
Ben Pfaff wrote on 08/30/2016 05:05:14 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/30/2016 05:05 PM
> Subject: patch series
>
> It looks like you have 4 separate patches that are connected and in
> which 3 of them
Ryan Moats/Omaha/IBM@IBMUS wrote on 08/28/2016 05:51:38 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: dev@openvswitch.org
> Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS
> Date: 08/28/2016 05:51 PM
> Subject: [PATCH] ovn-controller: Convert encaps module back to full
proces
Ryan Moats/Omaha/IBM@IBMUS wrote on 08/28/2016 05:51:02 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: dev@openvswitch.org
> Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS
> Date: 08/28/2016 05:51 PM
> Subject: [PATCH] Unpersist data structures for address sets.
>
> With the r
16cb ("ovn-controller:
Back out incremental processing").
Signed-off-by: Ryan Moats
---
ovn/controller/encaps.c | 34 +++---
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c
index d99ba05..8444
("ovn-controller:
Back out incremental processing").
Signed-off-by: Ryan Moats
---
ovn/controller/lflow.c | 166 -
ovn/lib/expr.c | 1 +
2 files changed, 42 insertions(+), 125 deletions(-)
diff --git a/ovn/controller/lfl
("ovn-controller:
Back out incremental processing").
Signed-off-by: Ryan Moats
---
ovn/controller/lflow.c | 166 -
ovn/lib/expr.c | 1 +
2 files changed, 42 insertions(+), 125 deletions(-)
diff --git a/ovn/controller/lfl
Ben Pfaff wrote on 08/27/2016 11:45:57 AM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/27/2016 11:46 AM
> Subject: Re: [PATCH v3] ovn-controller: add quiet mode
>
> On Fri, Aug 26, 2016 at 07:23:22PM -0500, Ryan Moats wrote:
&
oller/lflow.c module.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
v6->v7: corrected a memory leak found during follow-on
patch testing
include/ovn/actions.h | 4 -
ovn/controller/binding.c| 154 ++
ovn/co
cessing").
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
ovn/controller/ofctrl.c | 2 +
ovn/controller/ovn-controller.c | 73 -
ovn/controller/ovn-controller.h | 1 +
ovn/controller/patch.c |
Ryan Moats/Omaha/IBM@IBMUS wrote on 08/26/2016 04:36:20 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: dev@openvswitch.org
> Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS
> Date: 08/26/2016 04:36 PM
> Subject: [PATCH v3] ovn-controller: add quiet mode
>
> As discussed in [1],
oller/lflow.c module.
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
include/ovn/actions.h | 4 -
ovn/controller/binding.c| 154 ++
ovn/controller/binding.h| 1 -
ovn/controller/encaps.c
Ben Pfaff wrote on 08/26/2016 06:23:57 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/26/2016 06:24 PM
> Subject: Re: [ovs-dev,v5] ovn-controller: Back out incremental processing
>
> On Fri, Aug 26, 2016 at 04:15:47PM -0
lculation
to be performed.
This commit depends on f5d916cb ("ovn-controller:
Back out incremental processing")
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
ovn/controller/ofctrl.c | 2 ++
ovn/control
Ben Pfaff wrote on 08/26/2016 03:37:07 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/26/2016 03:37 PM
> Subject: Re: [ovs-dev,v2] ovn-controller: add quiet mode
>
> On Mon, Aug 22, 2016 at 03:25:05AM +, Ryan Moats wrote:
&
Ben Pfaff wrote on 08/26/2016 03:27:56 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/26/2016 03:28 PM
> Subject: Re: [ovs-dev,v5] ovn-controller: Back out incremental processing
>
> On Fri, Aug 26, 2016 at 01:30:59PM +0
s
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
v1->v2:
- removed some obvious memory leaks left behind in physical.c
v2->v3:
- removed some less obvious memory leaks created by
non-persisting ofctrl.c
v3->v4:
- unpers
enStack DevStack and Vagrant
> deployment
> with networking-ovn.
>
> I briefly spoke with Ryan Moats about this problem and he plans to
> investigate
> further.
>
> - Richard Theis
My analysis is that this is due to the local_datapath structure becoming
stale because it is not
Guru Shetty wrote on 08/25/2016 03:11:42 PM:
> From: Guru Shetty
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/25/2016 03:11 PM
> Subject: Re: [ovs-dev] [PATCH v4] ovn-controller: Back out
> incremental processing
>
> On 25 August 2016 at 13:04, Guru
Russell Bryant wrote on 08/25/2016 12:45:44 PM:
> From: Russell Bryant
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/25/2016 12:46 PM
> Subject: Re: [ovs-dev] [PATCH v4] ovn-controller: Back out
> incremental processing
>
> On Wed, Aug 24, 2016 at 9:30 PM,
lflows, od, S_SWITCH_OUT_ACL, 34000, ds_cstr
(&match),
> actions);
> +ds_destroy(&match);
> }
> }
> }
> --
Looks good to me on inspection, but I've not tried it out...
Acked-by: Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
e array
of
> router ports.
>
> This change is best viewed ignoring white space only changes.
LGTM
Acked-by: Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
redundant data and code within ovsdb-server.
> -
> -Currently, ovsdb-server separately composes database update
> -information to send to each of its clients. This is fine for a
> -small number of clients, but it wastes time and memory when
> -hundreds of clients
"dev" wrote on 08/16/2016 04:50:37 PM:
> From: "Rodriguez Betancourt, Esteban"
> To: "dev@openvswitch.org"
> Date: 08/16/2016 04:50 PM
> Subject: [ovs-dev] [PATCH] json: Use reference counting in json objects
> Sent by: "dev"
>
> After profiling OVSDB insert performance it was found
> that s
"dev" wrote on 08/16/2016 02:27:30 PM:
> From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS
> To: dev@openvswitch.org
> Date: 08/16/2016 02:33 PM
> Subject: [ovs-dev] [PATCH v2] ovn: Delete stale MAC_Binding records
> Sent by: "dev"
>
> Entries in MAC_Binding table are not deleted when the logica
Ryan Moats/Omaha/IBM wrote on 08/25/2016 09:19:49 AM:
> From: Ryan Moats/Omaha/IBM
> To: Justin Pettit
> Cc: dev@openvswitch.org
> Date: 08/25/2016 09:19 AM
> Subject: Re: [ovs-dev] [PATCH 2/3] daemon: Minor tweaking of man
> page fragment.
>
> "dev" wrote on
ll be granted two additional
> + capabilities, namely CAP_NET_ADMIN and
> + CAP_NET_RAW. The capability change will apply even
> + if the new user is root.
>
>
>
> --
LGTM
Acked-by: Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
e(7) for more
> + details.
> - ovsdb-server:
> * New "monitor_cond" "monitor_cond_update" and "update2" extensions
to
> RFC 7047.
> --
Since patchsets 2 and 3 didn't make it to my mailbox, please consider this
an ack for the e
s
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
Co-authored-by: Guru Shetty
---
include/ovn/actions.h | 4 -
ovn/controller/binding.c| 154 ++-
ovn/controller/binding.h| 1 -
ovn/controller/enc
Guru Shetty wrote on 08/24/2016 03:57:41 PM:
> From: Guru Shetty
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/24/2016 03:58 PM
> Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out
> incremental processing
>
> On 24 August 2016 at 11:12, Ryan Mo
Guru Shetty wrote on 08/24/2016 01:07:47 PM:
> From: Guru Shetty
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/24/2016 01:08 PM
> Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out
> incremental processing
>
> On 24 August 2016 at 11:03, Rya
Guru Shetty wrote on 08/24/2016 12:46:55 PM:
> From: Guru Shetty
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/24/2016 12:47 PM
> Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out
> incremental processing
>
> On 23 August 2016 at 22:40, Ry
Parsing logical flow actions with ovnacts_parse* that include
string constants current leak memory. Add calls to ovnacts_free
to recapture said memory.
Signed-off-by: Ryan Moats
---
ovn/controller/lflow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovn/controller/lflow.c b/ovn
stacking does not clean up the
Datapath_Binding because of a stale MAC_Binding entry, while with the
patch, everything cleans up correctly.
Lastly, I've run the stock rally create-and-delete-routers job and verified
that all Datapath_Binding entries for routers created by rally are cleaned
up correc
rmail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
v1->v2:
- removed some obvious memory leaks left behind in physical.c
v2->v3:
- removed some less obvious memory leaks created by
non-persisting ofctrl.c
ovn/controller/binding.c| 120 +--
ovn
rmail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
v1->v2:
removed some obvious memory leaks left behind in physical.c
ovn/controller/binding.c| 120 +---
ovn/controller/binding.h| 1 -
ovn/controller/encaps.c | 111 ++-
ovn/co
"dev" wrote on 08/22/2016 08:56:50 PM:
> From: Flavio Fernandes
> To: dev@openvswitch.org
> Date: 08/22/2016 08:57 PM
> Subject: [ovs-dev] [PATCH v1] ovn: ensure datapath removal is proper
> Sent by: "dev"
>
> Adding a unit test in ovn.at, to exercise the cleanup of
> OF rules related to a logi
Russell Bryant wrote on 08/22/2016 07:56:41 AM:
> From: Russell Bryant
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: Justin Pettit , ovs dev
> Date: 08/22/2016 07:57 AM
> Subject: Re: [ovs-dev] [RFC] ovn: minimize the impact of a
compromisedchassis
>
> On Sun, Aug 21, 2016 a
Hui Kang/Watson/IBM wrote on 08/21/2016 10:23:21 PM:
> From: Hui Kang/Watson/IBM
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/21/2016 10:23 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: add quiet mode
>
> I did observe that the previous incre
lculation
to be performed.
This commit depends on f5d916cb ("ovn-controller:
Back out incremental processing")
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
v2->v1:
- moved calls to force_full_process in patch.c to avoid defeating
"dev" wrote on 08/21/2016 03:02:12 PM:
> From: Justin Pettit
> To: Russell Bryant
> Cc: ovs dev
> Date: 08/21/2016 07:30 PM
> Subject: Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised
chassis
> Sent by: "dev"
>
>
> > On Aug 16, 2016, at 6:52 AM, Russell Bryant wrote:
> >
> > Th
Ben Pfaff wrote on 08/19/2016 02:36:42 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev , Numan Siddique
> Date: 08/19/2016 02:37 PM
> Subject: Re: incremental updates (was: Re: [ovs-dev] [PATCH 2/2]
> ovn/TODO: Add items proposed for 2.7 in OVN IRC me
lculation
to be performed.
This commit depends on f5d916cb ("ovn-controller:
Back out incremental processing")
[1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
ovn/controller/ofctrl.c | 2 ++
ovn/control
ful ACL rules in this dapapath, we must
> +/* If there are any stateful ACL rules in this datapath, we must
> * send all IP packets through the conntrack action, which handles
> * defragmentation, in order to match L4 headers. */
> if (has_stateful) {
And woul
rmail/dev/2016-August/078272.html
Signed-off-by: Ryan Moats
---
Note: while this passes all of the current ovn unit and e2e
tests, I'm not 100% sure it is fully correct as a fair number
of the reported issues are not captured in the test suite.
ovn/controller/binding.c
Ben Pfaff wrote on 08/20/2016 10:32:50 AM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 08/20/2016 10:33 AM
> Subject: another possible cause of incremental update problems
>
> There are additional possible causes of incremental update prob
Ben Pfaff wrote on 08/19/2016 10:50:17 AM:
> From: Ben Pfaff
> To: dev@openvswitch.org
> Cc: Ben Pfaff , Ryan Moats/Omaha/IBM@IBMUS, Ramu
> Ramamurthy
> Date: 08/19/2016 10:50 AM
> Subject: [PATCH] ovn-controller: Fix memory leak of
> keep_local_datapath_by_uuid.
&g
Ben Pfaff wrote on 08/19/2016 10:11:59 AM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: Numan Siddique , ovs dev
> Date: 08/19/2016 10:12 AM
> Subject: incremental updates (was: Re: [ovs-dev] [PATCH 2/2] ovn/
> TODO: Add items proposed for 2.7 in OVN IRC meeting
"dev" wrote on 08/19/2016 12:07:36 AM:
> From: Numan Siddique
> To: Ben Pfaff
> Cc: ovs dev
> Date: 08/19/2016 12:07 AM
> Subject: Re: [ovs-dev] [PATCH 2/2] ovn/TODO: Add items proposed for
> 2.7 in OVN IRC meeting.
> Sent by: "dev"
>
> On Thu, Aug 18, 2016 at 11:44 PM, Ben Pfaff wrote:
>
Ben Pfaff wrote on 08/15/2016 07:28:18 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/16/2016 01:54 AM
> Subject: Re: [ovs-dev, v5] Add read-only option to ovs-dpctl and
> ovs-ofctl commands.
>
> On Mon, Aug 15, 2016 at 06:4
ovs-dpctl and ovs-ofctl lack a read-only option to prevent
running of commands that perform read-write operations. Add
it and the necessary scaffolding to each.
Signed-off-by: Ryan Moats
---
lib/command-line.c | 51 +
lib/command-line.h | 6 +-
lib/db-ctl
Ben Pfaff wrote on 08/14/2016 10:06:41 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/14/2016 10:06 PM
> Subject: Re: [ovs-dev, v2] ovn-controller: Remove flows created for
> now deleted SB database rows.
>
> On Fri, Aug 12,
Ensure that rows created for deleted port binding and
multicast group rows are cleared when doing full processing.
Signed-off-by: Ryan Moats
---
v2->v3:
- correctly clear old hmap (that's what I get for not reading the hmap_clear
code first)
v1->v2:
- replace use of ssets
modified to include the wrapper
scripts as part of files to be installed.
Tests have been added to make sure that the wrapper scripts
don't actually do anything when asked to perform a write operation.
Signed-off-by: Ryan Moats
---
debian/openvswitch-common.install | 2 +
debian/openvs
ovs-dpctl and ovs-ofctl lack a read-only option to prevent
running of commands that perform read-write operations. Add
it and the necessary scaffolding to each.
Signed-off-by: Ryan Moats
---
v1->v2:
Fixed typo in usage string
lib/command-line.c | 50 +
lib/comm
t for ovs-appsetlog
Added new scripts into approriate debian package definitions.
Ryan Moats (2):
Add read-only option to ovs-dpctl and ovs-ofctl commands.
Add wrapper scripts for *ctl commands
debian/openvswitch-common.install | 2 +
debian/openvswitch-switch.install | 2 +
debian
Ben Pfaff wrote on 08/14/2016 10:22:33 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/14/2016 10:22 PM
> Subject: Re: [ovs-dev, v3, 1/2] Add read-only option to ovs-dpctl
> and ovs-ofctl commands.
>
> On Mon, Aug 15, 2016 a
rt term fix, do not use a dictionary with multiple
elements for the partial map test case.
Change-Id: Ibdec10ebd895051321b9bff7d9fe8a7e0bd9eb88
Signed-off-by: Ryan Moats
---
tests/ovsdb-idl.at | 8
tests/test-ovsdb.py | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --gi
Ben Pfaff wrote on 08/14/2016 07:38:08 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org, Matthew Mulsow/Austin/IBM@IBMUS
> Date: 08/14/2016 07:38 PM
> Subject: Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell
> quoting inos-release.
>
&
modified to include the wrapper
scripts as part of files to be installed.
Tests have been added to make sure that the wrapper scripts
don't actually do anything when asked to perform a write operation.
Signed-off-by: Ryan Moats
---
debian/openvswitch-common.install | 2 +
debian/openvs
ovs-dpctl and ovs-ofctl lack a read-only option to prevent
running of commands that perform read-write operations. Add
it and the necessary scaffolding to each.
Signed-off-by: Ryan Moats
---
v1->v2:
Fixed typo in usage string
lib/command-line.c | 50 +
lib/comm
dded new scripts into approriate debian package definitions.
Ryan Moats (2):
Add read-only option to ovs-dpctl and ovs-ofctl commands.
Add wrapper scripts for *ctl commands
debian/openvswitch-common.install | 2 +
debian/openvswitch-switch.install | 2 +
debian/ovn-common.install
Ben Pfaff wrote on 08/14/2016 12:36:31 AM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/14/2016 12:36 AM
> Subject: Re: [ovs-dev] [PATCH v2 1/2] Add dry-run option to ovs-
> dpctl and ovs-ofctl commands.
>
> On Thu, Aug 04,
ot;$VERSION_ID"`
> elif (lsb_release --id) >/dev/null 2>&1; then
> SYSTEM_TYPE=`lsb_release --id -s`
> system_release=`lsb_release --release -s`
> --
> 2.1.3
I've not seen this problem in our tests, but I have seen in it our wild,
so...
Acked-by: Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff wrote on 08/14/2016 06:33:45 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: d...@openvswitch.com
> Date: 08/14/2016 06:33 PM
> Subject: Re: [ovs-dev] [PATCH v5 1/2] ovsdb: Add/use partial set updates.
>
> On Sat, Aug 06, 2016 at 05:46:29PM -0
Commit f1ab6e06 ("Add/user partial set updates.) incorrectly
did not include HPE attribution for derived files
lib/ovsdb-set-op.[ch]. Add the attribution to correct this.
Signed-off-by: Ryan Moats
---
lib/ovsdb-set-op.c | 3 ++-
lib/ovsdb-set-op.h | 3 ++-
2 files changed, 4 insertions(
Ben Pfaff wrote on 08/12/2016 04:48:26 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 08/12/2016 04:48 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created
> for now deleted SB database rows.
>
> On Fri, Au
Ensure that rows created for deleted port binding and
multicast group rows are cleared when doing full processing.
Signed-off-by: Ryan Moats
---
v1->v2:
- replace use of ssets for storing UUIDs as strings with hmaps for
storing the UUID structs themselves
- include an optimizat
, I'd like it even better if
it had test cases that would help me understand the changes that weren't
picked up by the original code, because that's a potential future
regression.
Assuming that is handled in a follow-on patch, consider this an ack on
both parts 2 and 3...
Acked-by: Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ssibly needs to be updated, we are currently allocating
> a new name for it. This is not necessary and in fact nothing uses the
> name, which then results in the memory being leaked.
>
> Fixes: 1d45d5a9 ("ovn-controller: Change encaps_run to work
incrementally.")
> S
> ---
This all looks does what it promises, so let's get the immediate
out of the way:
Acked-by: Ryan Moats
Having said that, I'm still concerned about what happens in the
kernel during an ovs-vswitchd restart...
I *think* everything will be fine for active connections whose
fl
56, so why not
> do it? That's why I think that this is a reasonable change.
>
> VMware-BZ: #1708786
> Signed-off-by: Ben Pfaff
> ---
Yes, it's annoying, but arguing with FIPS reminds me of bringing a knife
to a gun fight...
The patch looks sane so ...
Acked-by: Ryan
1 - 100 of 765 matches
Mail list logo
