Thanks Ben. Some of the changes were taken care but unfortunately missed to be
included in the latest patch as it's a bit confusion to me right now which
patch has what changes due to integration testing I do with vlan/vlan-qinq/mpls
and I frequently rebase to latest. Patch with 2nd code review
Ravi,
I spent some time to test your most recent version of this patch.
Using the very simple test environment that I described before
consisting of just two machines talking to each other with a single
level of tagging I encountered several issues. These included not
only the hardware offloadin
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Friday, March 23, 2012 9:44 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org; bda...@nicira.com
Subject: Re: MPLS important comments (was: Re: [ovs-dev] Patch for MPLS)
On Thu, Mar 22, 2012 at 11:03:10AM -0700, Ben Pfaff wrote:
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Thursday, March 22, 2012 10:56 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Wed, Mar 14, 2012 at 06:17:46PM +0100, ker...@telekom.de wrote:
> We do
Maybe we can use this thread to discuss offloading features for mpls and vlan
qinq.
>
> are you referring to TSO/LRO?
TSO, checksum offload, vlan tag insertion. LRO is on receive so it
won't be affected by this.
I think checksum offloading should be independant of vlan headers, not
sure why
I don't have any NICS which support hardware offloading. I have tested both
user and kernel space and looked at the outputs from wireshark and tcpdump to
make sure relevant actions for the flows are exercised and relevant mpls shim
or vlan qinq headers are pushed into the packet.
-Original
-Original Message-
From: Jesse Gross [mailto:je...@nicira.com]
Sent: Thursday, March 22, 2012 6:16 PM
To: Kerur, Ravi
Cc: b...@nicira.com; dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Thu, Mar 22, 2012 at 3:00 PM, wrote:
> Ok thanks w
Ok thanks will wait for Jesse's inputs on kernel code. Sent latest patch in our
automated unit-test discussion.
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Thursday, March 22, 2012 11:03 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: Re: MPLS important comment
Hi Jesse,
Please note that I work in labs environment and I volunteer my time for this
and I have very limited resources to test. I have done testing related to
complete mpls actions via the test-program written which is in
tests/test-mpls.c. I have done basic vlan/mpls integration testing as w
