Re: [ovs-dev] [vlans v2 5/5] Implement "native VLAN" feature.

2011-09-25 Thread Philippe Jung
Le 24/09/2011 02:17, Ben Pfaff a écrit : > Significant updates by Ben Pfaff, including: > > * Comment, coding style, indentation updates. > * Documentation improved. > * Added tests. > * Dropped PORT_VLAN_EMPTY. > --- With patches "vlans v2" 1 to 5 applied to yesterday git head, all my tests passe

Re: [ovs-dev] [vlans 5/5] Implement "native VLAN" feature.

2011-09-13 Thread Philippe Jung
Le 08/09/2011 21:43, Ben Pfaff a écrit : > On Fri, Aug 26, 2011 at 01:19:40PM -0700, Ben Pfaff wrote: >> From: Philippe Jung >> >> Significant updates by Ben Pfaff, including: >> >> * Comment, coding style, indentation updates. >> * Documentation i

Re: [ovs-dev] [vlans 5/5] Implement "native VLAN" feature.

2011-09-08 Thread Philippe Jung
Le 08/09/2011 21:43, Ben Pfaff a écrit : > On Fri, Aug 26, 2011 at 01:19:40PM -0700, Ben Pfaff wrote: >> From: Philippe Jung >> >> Significant updates by Ben Pfaff, including: >> >> * Comment, coding style, indentation updates. >> * Documentation i

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-25 Thread Philippe Jung
Le 25/08/2011 01:07, Ben Pfaff a écrit : > > Hi Philippe. Just dropping you a note to let you know that I haven't > forgotten your patch. I spent some time writing a separate commit > that fixes the bug that you reported and posted it in this thread, > along with some unit tests for VLANs: >

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-23 Thread Philippe Jung
Le 23/08/2011 01:16, Ben Pfaff a écrit : > On Tue, Aug 23, 2011 at 12:54:19AM +0200, Philippe Jung wrote: >> If needed, I can post my OpenOffice table where I have written all >> tests I have performed > > That would actually be great. I'd like to convert them to unit t

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-22 Thread Philippe Jung
Le 22/08/2011 22:27, Ben Pfaff a écrit : > I think you're right. I guess nobody (except you) tests trunking a > limited set of VLANs. We should fix this, thanks for the bug report. Please find enclosed the new version of the patch to add native VLAN feature. Compared to previous version, major

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-22 Thread Philippe Jung
Le 18/08/2011 10:19, Jesse Gross a écrit : > On Aug 18, 2011 2 > I would make the change everywhere. The above list looks good, although > I think it might be better to reverse the native names (i.e. > "native-tagged" instead of "tagged-native") as it groups things together > a little better. >

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-17 Thread Philippe Jung
Le 17/08/2011 03:37, Jesse Gross a écrit : > > This is the same as native vlan, right? If so, I think that is a > better name as it is more common and PVID sounds like it should refer > to private vlans. Yes, also called default VLAN. Do I make the change just in comments or also in the new col

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-16 Thread Philippe Jung
Le 03/08/2011 18:30, Ben Pfaff a écrit : > On Sat, Jul 30, 2011 at 01:41:04AM +0200, Philippe Jung wrote: >> This patchs adds the PVID (Port VLAN ID) tagging feature to the >> switch ports: >> - When an untagged packet is received by a switch port from an >> external d

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-08-03 Thread Philippe Jung
Le 03/08/2011 18:30, Ben Pfaff a écrit : Your implementation is against Open vSwitch 1.1.1. To commit it, you will have to rewrite it against the Git "master" branch. A lot of code has moved around in the meantime, so this will require a little bit of work. Will do this way. The patch was sen

[ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

2011-07-29 Thread Philippe Jung
Hi, This patchs adds the PVID (Port VLAN ID) tagging feature to the switch ports: - When an untagged packet is received by a switch port from an external device, the packet is tagged with PVID; - Tagged packets received by a switch port from an external device are unchanged; - When a tagge