Thanks for the review Ben.
I have merged this to master.
On Mon, Nov 5, 2012 at 12:31 PM, Ben Pfaff wrote:
> On Mon, Nov 05, 2012 at 12:30:11PM -0800, Ben Pfaff wrote:
> > On Mon, Nov 05, 2012 at 11:18:53AM -0800, Mehak Mahajan wrote:
> > > ofputil_format_version uses type
Thanks for the review Ben.
I have taken care of the double blank line in NEWS.
The backport to 1.9 is done.
I will push this shortly.
thanx!
mehak
On Mon, Nov 5, 2012 at 12:29 PM, Ben Pfaff wrote:
> On Mon, Nov 05, 2012 at 11:13:58AM -0800, Mehak Mahajan wrote:
> > This commit updates
ofputil_format_version uses type 'size_t' to print version whereas
expected type is 'unsigned int'.
Signed-off-by: Mehak Mahajan
---
lib/ofp-util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 146e538..ae54
This commit updates NEWS and debian/changelog to reflect that
commit 8087f5ff (Process RARP packets with ethertype 0x8035
similar to ARP packets.) is going to be backported intto 1.9.0, so
that they should no longer be listed as post-1.9 features.
Signed-off-by: Mehak Mahajan
---
NEWS
ates NEWS and debian/changelog to reflect that
> commit 8087f5ff (Process RARP packets with ethertype 0x8035
> similar to ARP packets.) is going to be backported intto 1.9.0, so
> that they should no longer be listed as post-1.9 features.
>
> On Mon, Nov 05, 2012 at 10
..
thanx!
mehak
On Mon, Nov 5, 2012 at 10:47 AM, Ben Pfaff wrote:
> On Mon, Nov 05, 2012 at 10:44:43AM -0800, Mehak Mahajan wrote:
> > The commit 8087f5ff (Process RARP packets with ethertype 0x8035
> > similar to ARP packets.) needs to be backported to 1.9. This commit
> >
The commit 8087f5ff (Process RARP packets with ethertype 0x8035
similar to ARP packets.) needs to be backported to 1.9. This commit
appropriately updates the NEWS and debian/changelog.
Signed-off-by: Mehak Mahajan
---
NEWS |5 ++---
debian/changelog |5 +++--
2 files
With this commit, OVS will match the data in the RARP packets having
ethertype 0x8035, in the same way as the data in the ARP packets.
Signed-off-by: Mehak Mahajan
---
NEWS |2 +
datapath/flow.c |9 +++--
include/openflow/nicira-ext.h |6
Hi Ben,
I have updated the documentation in NEWS and ovs-ofctl as suggested by you.
I will upload a new patch for review by you and Jesse.
thanx!
mehak
On Wed, Oct 31, 2012 at 4:46 PM, Ben Pfaff wrote:
> On Wed, Oct 31, 2012 at 04:22:14PM -0700, Mehak Mahajan wrote:
> > With this co
With this commit, OVS will accept the traffic with eth_type RARP.
Signed-off-by: Mehak Mahajan
---
NEWS |1 +
datapath/flow.c |9 +++--
include/openflow/nicira-ext.h |6 ++--
lib/flow.c|6 ++-
lib/match.c
Hey Ben,
Thanks a lot for reviewing this.
On Wed, Oct 31, 2012 at 3:26 PM, Ben Pfaff wrote:
> On Wed, Oct 31, 2012 at 01:39:25PM -0700, Mehak Mahajan wrote:
> > With this commit, OVS will accept the traffic with eth_type RARP.
> >
> > Signed-off-by: Meh
With this commit, OVS will accept the traffic with eth_type RARP.
Signed-off-by: Mehak Mahajan
---
datapath/flow.c |3 ++-
lib/flow.c |6 --
lib/match.c | 17 -
lib/meta-flow.c |3 ++-
lib/nx-match.c |3
Pfaff wrote:
> On Tue, Oct 30, 2012 at 09:44:52PM -0700, Mehak Mahajan wrote:
> > With this commit, OVS will accept the traffic with eth_type RARP.
> >
> > Signed-off-by: Mehak Mahajan
> > ---
> > datapath/flow.c |3 ++-
> > 1 files changed, 2 insertions
With this commit, OVS will accept the traffic with eth_type RARP.
Signed-off-by: Mehak Mahajan
---
datapath/flow.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index c70daee..c5f1b53 100644
--- a/datapath/flow.c
+++ b/datapath
Thanks for the review Jesse.
~ Mehak
On Wed, Oct 24, 2012 at 3:19 PM, Jesse Gross wrote:
> On Tue, Oct 23, 2012 at 7:17 PM, Mehak Mahajan
> wrote:
> > With this commit, the datapath will process the ARP header for
> > RARP packets. It also fixes a bug whereby if
With this commit, the datapath will process the ARP header for
RARP packets. It also fixes a bug whereby if the ARP opcode is
something other than ARP request or reply, the key_len is not
adjusted to include ARP info.
Signed-off-by: Mehak Mahajan
---
datapath/flow.c | 14 +-
lib
Hey Jesse, Ben,
Thanks for reviewing this.
I have updated the commit message and also fixed the indentation.
I will send out an updated patch.
thanx!
mehak
On Tue, Oct 23, 2012 at 6:37 PM, Jesse Gross wrote:
> On Tue, Oct 23, 2012 at 1:39 PM, Mehak Mahajan
> wrote:
> > With this
700, Mehak Mahajan wrote:
> > With this commit, the datapath will process the ARP header for
> > RARP packets, both request and reply.
> >
> > Signed-off-by: Mehak Mahajan
>
> It looks very much to me like all defined ARP opcodes (at least the
> ones listed here:
With this commit, the datapath will process the ARP header for
RARP packets, both request and reply.
Signed-off-by: Mehak Mahajan
---
datapath/flow.c | 23 +++
lib/flow.c | 11 ---
2 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/datapath
Hey Ethan,
Thanks for the review.
I will push these changes soon.
thanx!
mehak
On Sat, Oct 20, 2012 at 10:50 AM, Ethan Jackson wrote:
> Thanks for doing this,
>
> Acked-by: Ethan Jackson
>
>
> On Wed, Oct 17, 2012 at 6:23 PM, Mehak Mahajan
> wrote:
>
Hey Ethan,
Thanks for the review.
I will make these changes before pushing the patches.
thanx!
mehak
On Sat, Oct 20, 2012 at 10:49 AM, Ethan Jackson wrote:
> > -if (f->nw_proto == IPPROTO_ICMP) {
> > +if (f->dl_type == htons(ETH_TYPE_IP) &&
> > +f->nw_proto == IPPROTO_ICMP) {
>
With this commit, the datapath will process the ARP header for
RARP packets, both request and reply.
Signed-off-by: Mehak Mahajan
---
datapath/flow.c |6 --
lib/flow.c |4 +++-
lib/packets.c |2 +-
lib/packets.h |3 ++-
4 files changed, 10 insertions(+), 5 deletions
With a previous commit 953cc1888321346e6c4175fbc0a3f66d34913ea3, the
ovs logs were re-formatted such that they can be input into the
ofproto/trace. For ARP packets, ofproto/trace expects arp_tpa/arp_spa
instead of nw_dst/nw_src.
Signed-off-by: Mehak Mahajan
---
lib/match.c|3
ly if the packet is an IP packet and the
nw_proto is ICMP.
Signed-off-by: Mehak Mahajan
---
lib/match.c|6 --
tests/ofp-print.at |2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/match.c b/lib/match.c
index f5da97f..e53a11a 100644
--- a/lib/match.c
+++
will make debugging easier.
Signed-off-by: Mehak Mahajan
---
lib/flow.c| 88 ++--
lib/match.c | 82 +
lib/match.h |1 +
tests/ofp-print.at|6 ++--
tests/ofproto
will make debugging easier.
Signed-off-by: Mehak Mahajan
---
lib/flow.c| 88 ++-
lib/match.c | 91 +++--
lib/match.h |1 +
tests/ofp-print.at| 16
tests
will make debugging easier.
Signed-off-by: Mehak Mahajan
---
lib/flow.c| 171 ++---
tests/ofp-print.at|6 +-
tests/ofproto-dpif.at | 56
tests/ofproto.at | 12 ++--
4 files changed, 142 insertions(+), 103
Hey Isaku,
Thanks for the patch.
I have applied it to master.
thanx!
mehak
On Wed, Sep 26, 2012 at 12:12 AM, Isaku Yamahata wrote:
> Thus ovsdb-client aborts as follows.
>
> > # ovs-vsctl set-manager ptcp:6634
> > # ovsdb-client get-schema tcp:127.0.0.1:6634
> > 2012-09-14T05:38:26Z|1|jsonr
at 11:09:39AM -0700, Mehak Mahajan wrote:
> > Hey Isaku,
> >
> > I am not sure I understand this patch completely. Your patch seems to
> suggest
> > that we are not populating the "options" values from the database ? Are
> you
> > sugges
Looks good.
thanx!
mehak
On Thu, Sep 20, 2012 at 11:13 AM, Ben Pfaff wrote:
> From: Anupam Chanda
>
> Two instances of ofputil_flow_update had the priority field uninitialized.
> This would cause flow updates to contain undefined priority values.
>
> This bug was introduced by commit 81a76618
Hey Isaku,
I am not sure I understand this patch completely. Your patch seems to
suggest that we are not populating the "options" values from the database ?
Are you suggesting that in case of passive connections we do not
call ovsdb_jsonrpc_session_set_options() ?
On Fri, Sep 14, 2012 at 1:56 AM,
Looks good.
Thanx!
Mehak
On Mon, Aug 20, 2012 at 10:33 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> tests/ofproto-dpif.at |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
> index 1e5856f..cc5d770 100644
> -
Looks good.
Thanx!
Mehak
On Mon, Aug 20, 2012 at 10:33 AM, Ben Pfaff wrote:
> Several of the tests start daemons and then need to make sure that the
> daemons get killed when the test completes, even if it completes in the
> middle due to an early failure. Until now, they have been using manua
Looks good.
thanx!
mehak
On Fri, Aug 17, 2012 at 1:59 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-print.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> index 3f5b6be..99e6456 100644
Looks good.
thanx!
mehak
On Fri, Aug 17, 2012 at 2:00 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index dd5f4b
wrote:
> On Thu, Aug 16, 2012 at 01:36:47PM -0700, Mehak Mahajan wrote:
> > Currently, if a controller having a nonzero id registers to get a
> > OFPR_INVALID_TTL async message, it will not receive it. This is because
> > compose_dec_ttl() only sent the invalid ttl p
igned-off-by: Mehak Mahajan
---
include/openflow/nicira-ext.h | 30
lib/ofp-actions.c | 105 +++-
lib/ofp-actions.h | 16 ++-
lib/ofp-parse.c | 38 ++-
lib/ofp-util.def |
Hey Ben,
Thanks for the reviews. I am posting a new patch addressing your concerns.
thanx!
mehak
On Thu, Aug 16, 2012 at 10:44 AM, Ben Pfaff wrote:
> This is getting really close.
>
> On Wed, Aug 15, 2012 at 03:00:10PM -0700, Mehak Mahajan wrote:
> > sta
Hey Ben,
Looks good.
thanx!
mehak
On Wed, Aug 15, 2012 at 4:19 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ovsdb-idl.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
> index 534beb0..61188
igned-off-by: Mehak Mahajan
---
include/openflow/nicira-ext.h | 30 +++
lib/ofp-actions.c | 110 +++-
lib/ofp-actions.h | 16 +-
lib/ofp-parse.c | 59 +-
lib/ofp-util.def |
On Wed, Aug 15, 2012 at 1:20 PM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 11:51:12AM -0700, Mehak Mahajan wrote:
> > On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
> >
> > > On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > > >
Hey Ben,
On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > --- a/include/openflow/nicira-ext.h
> > +++ b/include/openflow/nicira-ext.h
> > @@ -291,7 +291,8 @@ enum nx_action_subtype {
>
for the former
it will be dec_ttl and for the latter it will be dec_ttl(id1,id2) ?
thanx!
mehak
On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > --- a/include/openflow/nicira-ext.h
> > +++ b/include/openfl
Thanks for the review Ben.
I will backport it to 1.8.
thanx!
mehak
On Wed, Aug 15, 2012 at 10:27 AM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 12:12:01AM -0700, Mehak Mahajan wrote:
> > The size of each slave is a uint16_t. This means that each slave needs
> 2 bytes
>
igned-off-by: Mehak Mahajan
---
include/openflow/nicira-ext.h | 40 ++-
lib/ofp-actions.c | 115 +++-
lib/ofp-actions.h | 16 +-
lib/ofp-parse.c | 42 +++-
lib/ofp-util.def |
bytes to be allocated
at the end of nx_action_bundle.
Signed-off-by: Mehak Mahajan
---
lib/bundle.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/bundle.c b/lib/bundle.c
index c6b1f75..e0f8e6b 100644
--- a/lib/bundle.c
+++ b/lib/bundle.c
@@ -217,7 +217,7
ing and decoding. You should
> add some, at least to the "ovs-ofctl parse-flows" test in
> ovs-ofctl.at.
>
> > Subject: Adding Nicira vendor extension action
> > NXAST_DEC_TTL_CNT_IDS.
>
> Could you just make that "Add" rather than "Adding"
r ids.
Signed-off-by: Mehak Mahajan
---
include/openflow/nicira-ext.h | 23 ++
lib/ofp-actions.c | 90 +
lib/ofp-actions.h | 69 ++-
lib/ofp-parse.c | 28 +
li
OVS provides a utility to create ICMP packets for the purpose of
testing using ovs-appctl netdev-dummy/receive. These packets created
by flow_compose() earlier did not have the ICMP checksum in them.
With this commit, the checksum will be added to these test ICMP
packets.
Signed-off-by: Mehak
On Mon, Aug 6, 2012 at 3:25 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> v1->v2: Remove trailing whitespace. Split RSPAN question into
> two questions and properly explain treatment of packets that
> come in on an RSPAN output VLAN.
>
> FAQ | 116
> +
Sure. Will do before the merge.
Thanks for the reviews Ethan.
thanx!
mehak
On Thu, Aug 2, 2012 at 3:58 PM, Ethan Jackson wrote:
> Looks good to me.
>
> > #include "packets.h"
> > #include "unaligned.h"
> > #include "vlog.h"
> > +#include "csum.h"
>
> Minor nit-pick, could you please insert t
OVS provides a utility to create IP packets for the purpose of testing
using ovs-appctl netdev-dummy/receive. These packets created by
flow_compose() earlier did not have the IP checksum in them. With this
commit, the checksum with be added to these test IP packets.
Signed-off-by: Mehak Mahajan
Commit f973f2af (Make the location of the database separately configurable.)
introduced the environment variable OVS_DBDIR which specifies the path for
the conf.db. With this commit, .conf.db.~lock~ will also be created in the
DBDIR.
Signed-off-by: Mehak Mahajan
---
tests/ofproto-macros.at
Thanks Ben.
I pushed this to master.
thanx!
mehak
On Wed, Aug 1, 2012 at 5:38 PM, Ben Pfaff wrote:
> On Wed, Aug 01, 2012 at 05:10:36PM -0700, Mehak Mahajan wrote:
> > Signed-off-by: Mehak Mahajan
>
> Looks good, please push.
>
__
Signed-off-by: Mehak Mahajan
---
python/ovs/dirs.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/ovs/dirs.py b/python/ovs/dirs.py
index a5717fc..e4b37f9 100644
--- a/python/ovs/dirs.py
+++ b/python/ovs/dirs.py
@@ -5,5 +5,5 @@ import os
PKGDATADIR
Sure ... Makes sense.
I will modify it, and since practically the complete patch is changed, I
will sent out another patch.
Thanks!
Mehak
On Wed, Aug 1, 2012 at 12:57 PM, Ethan Jackson wrote:
> > I agree its cleaner, but I am still inclined to keep it as is because
> sizeof
> > *ip does not con
I agree its cleaner, but I am still inclined to keep it as is because
sizeof *ip does not contain the options which should also be included in
computing the IP checksum. IP_IHL takes the header length and uses that
which is what the IP Checksum calculations should use. What do you think ?
thanx!
Thanks for pointing that out. I have modified the comment to be in line
with the changes.
diff --git a/lib/flow.c b/lib/flow.c
index bc88718..fd31333 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -1010,7 +1010,8 @@ flow_set_vlan_pcp(struct flow *flow, uint8_t pcp)
* 'flow'.
*
* (This is useful
Makes sense.
I will make the change.
thanx!
mehak
On Mon, Jul 30, 2012 at 5:06 PM, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 05:03:38PM -0700, Mehak Mahajan wrote:
> > Signed-off-by: Mehak Mahajan
> > ---
> > include/openflow/openflow-1.0.h |3 ++-
> > 1
Signed-off-by: Mehak Mahajan
---
include/openflow/openflow-1.0.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/openflow/openflow-1.0.h b/include/openflow/openflow-1.0.h
index d71b007..97380fa 100644
--- a/include/openflow/openflow-1.0.h
+++ b/include/openflow
OVS provides a utility to create IP packets for the purpose of testing
using ovs-appctl netdev-dummy/receive. These packets created by
flow_compose() earlier did not have the IP checksum in them. With this
commit, the checksum with be added to these test IP packets.
Signed-off-by: Mehak Mahajan
Hey Ben,
Looks good to me.
thanx!
mehak
On Fri, Jul 27, 2012 at 1:23 PM, Ben Pfaff wrote:
> Would someone review this please? It should not be hard.
>
> Thanks,
>
> Ben.
>
> On Sat, Jul 21, 2012 at 09:56:28AM -0700, Ben Pfaff wrote:
> > Rob Sherwood reported a bug in OVS treatment of ofp10_ma
Hey Ben,
The patch looks good to me.
As a side note, I do not see the documentation about OVS not forwarding the
Extreme Discovery Protocol bpdus in vswitch.xml
thanx!
mehak
On Wed, Jul 25, 2012 at 12:59 PM, Ben Pfaff wrote:
> Commit c93f9a78c349 (packets: Update the reserved protocols list.)
Hey Ben,
Looks good to me.
thanx!
mehak
On Fri, Jul 20, 2012 at 10:51 AM, Ben Pfaff wrote:
> At one point I got the "lcov" utilities to work well with OVS. Then I
> didn't try to use them again for a year or so, and when I did I found that
> it didn't work at all. I wasn't able to fix the pr
Hey Ben,
Looks good to me.
thanx!
mehak
On Fri, Jul 20, 2012 at 10:39 AM, Ben Pfaff wrote:
> The daemon code works fine, these tests didn't. No one has debugged them
> over a period of years so we might as well remove them.
>
> Signed-off-by: Ben Pfaff
> ---
> tests/daemon.at | 46 ---
Hey Ben,
Looks good to me.
thanx!
mehak
On Mon, Jul 9, 2012 at 11:45 PM, Ben Pfaff wrote:
> When an output OF1.0 match uses OFP_VLAN_NONE to match only when the 802.1Q
> header is not present, it is somewhat contradictory to specify any value
> for the VLAN PCP, since none can be present witho
Hey Ben,
Looks good to me.
thanx!
mehak
On Thu, Jul 12, 2012 at 12:29 PM, Ben Pfaff wrote:
> Commit 0c449c5683a improved action error logging for one case, but we might
> as well do it for the other case too.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-actions.c | 31 +++--
700, Mehak Mahajan wrote:
> > For the service controllers to receive any asynchronous messages, the
> > miss_send_len must be set to a non-zero value (refer to DESIGN). On
> > receiving the NXT_SET_ASYNC_CONFIG message, the miss_send_len is set
> > to the default value unless it
message.
Signed-off-by: Mehak Mahajan
---
DESIGN| 10 --
include/openflow/nicira-ext.h |3 +++
ofproto/ofproto.c |4
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/DESIGN b/DESIGN
index f9345d1..a3a62b2 100644
--- a/DESIGN
On Sun, Jun 24, 2012 at 12:43:24PM -0700, Mehak Mahajan wrote:
> > For the service controllers to receive any asynchronous messages, the
> > miss_send_len must be set to a non-zero value (refer to DESIGN). On
> > receiving the NXT_SET_ASYNC_CONFIG message, the miss_send_len is s
message.
Signed-off-by: Mehak Mahajan
---
DESIGN|7 +--
ofproto/ofproto.c |3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/DESIGN b/DESIGN
index f9345d1..23dca06 100644
--- a/DESIGN
+++ b/DESIGN
@@ -17,8 +17,11 @@ given controller receives OpenFlow
Hey Ben,
Thanks for the review and for retesting this.
I pushed this to master in the morning with changes to the commit message.
thanx!
mehak
On Thu, Jun 21, 2012 at 11:30 AM, Mehak Mahajan wrote:
> sure will do that..
>
>
> On Thu, Jun 21, 2012 at 10:12 AM, Ben Pfaff wrote:
sure will do that..
On Thu, Jun 21, 2012 at 10:12 AM, Ben Pfaff wrote:
> On Wed, Jun 20, 2012 at 09:24:34PM -0700, Mehak Mahajan wrote:
> > This patch reapplies the changes that were reverted with the commit
> 59efa47
> > (Revert DSCP update changes.). It also addresses the
dscp value.), that caused numerous unit test failures on some systems (as
diagnosed by valgrind).
Signed-off-by: Mehak Mahajan
---
lib/jsonrpc.c|6 +-
lib/rconn.c |6 ++
lib/rconn.h |1 +
ofproto/connmgr.c|6 ++
vswitchd/vswitch.xml | 14
I have made these changes.
Pushed to master.
Thanks Ben, Ravi.
On Tue, Jun 19, 2012 at 7:51 PM, Ben Pfaff wrote:
> On Tue, Jun 19, 2012 at 07:19:44PM -0700, Mehak Mahajan wrote:
> > In commit b2e18d(No need to restart DB / OVS on changing dscp value.),
> the
> > dscp value was
In commit b2e18d(No need to restart DB / OVS on changing dscp value.), the
dscp value was wrongly set after the reconnect.
Signed-off-by: Mehak Mahajan
---
lib/jsonrpc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index ce5d2b4
thanx!
I made the changes and pushed the patch to master.
On Tue, Jun 19, 2012 at 9:12 AM, Ben Pfaff wrote:
> On Fri, Jun 08, 2012 at 12:04:14PM -0700, Mehak Mahajan wrote:
> > With this change there is no need to restart the DB or OVS on
> configuring a
> > different value
new
configured dscp value.
Signed-off-by: Mehak Mahajan
---
lib/jsonrpc.c|3 +++
lib/rconn.c |6 ++
lib/rconn.h |1 +
ofproto/connmgr.c|6 ++
vswitchd/vswitch.xml | 14 ++
5 files changed, 22 insertions(+), 8 deletions(-)
diff
M -0700, Mehak Mahajan wrote:
> > Hey Ben,
> >
> > rconn_connect() expects target and name which are not available to
> > rconn_set_dscp().
> >
> > thanx!
> > mehak
> >
> > On Fri, Jun 15, 2012 at 10:43 AM, Ben Pfaff wrote:
> >
> > >
Hey Ben,
rconn_connect() expects target and name which are not available to
rconn_set_dscp().
thanx!
mehak
On Fri, Jun 15, 2012 at 10:43 AM, Ben Pfaff wrote:
> On Thu, Jun 14, 2012 at 05:31:07PM -0700, Mehak Mahajan wrote:
> > I have taken care of the json connection.
> >
Please ignore
"I don't think it would be possible to change the jsonrpc_session_set_dscp
as it takes as its argument jsonrpc_session and not ovsdb_jsonrpc_session "
in the previous email ...
On Thu, Jun 14, 2012 at 5:31 PM, Mehak Mahajan wrote:
> Hi Ben,
>
> I hav
e:
> On Thu, Jun 07, 2012 at 10:48:25PM -0700, Mehak Mahajan wrote:
> > With this change there is no need to restart the DB or OVS on
> configuring a
> > different value for the manager or controller connection respectively. On
> > detecting a change in the dscp value on the
new
configured dscp value.
Signed-off-by: Mehak Mahajan
---
lib/jsonrpc.c |8 +-
lib/jsonrpc.h |4 ++-
lib/rconn.c|7 ++
lib/rconn.h|1 +
lib/socket-util.c |1 +
ofproto/connmgr.c | 46
new
configured dscp value.
Signed-off-by: Mehak Mahajan
---
lib/rconn.c|7
lib/rconn.h|1 +
lib/socket-util.c | 85 ++--
ofproto/connmgr.c | 46
vswitchd
The CFM packets that are out of sequence or contain invalid cfm_interval were
previously not ignored. The behavior is changed with this patch to not
process those CFM frames.
Signed-off-by: Mehak Mahajan
---
lib/cfm.c| 61 ++---
lib
Hey,
Thank Ben and Ethan for your comments.
I have taken care of them.
We are now setting all possible faults when we get the heartbeat message.
thanx!
mehak
On Thu, Apr 5, 2012 at 4:00 PM, Ethan Jackson wrote:
> > -rmp->recv = true;
> > -if (!fault) {
> > +
The CFM packets that are out of sequence or contain invalid cfm_interval were
previously not ignored. The behavior is changed with this patch to not
process those CFM frames.
Signed-off-by: Mehak Mahajan
---
lib/cfm.c| 21 ++---
lib/cfm.h|4
The CFM packets that are out of sequence or contain invalid cfm_interval were
previously not ignored. The behavior is changed with this patch to not
process those CFM frames.
Signed-off-by: Mehak Mahajan
---
lib/cfm.c|9 -
lib/cfm.h|4 +++-
vswitchd
The changes display the cfm_health of an interface. The cfm_health
is an exponential weighted moving average of the health of all
remote_mpids. The value can vary from 0 to 100, 100 being very healthy
and 0 being unhealthy.
Feature #10363
Requested-by: Ethan Jackson
Signed-off-by: Mehak
The changes display the cfm_health of an interface. The cfm_health
is an exponential weighted moving average of the health of all
remote_mpids. The value can vary from 0 to 100, 100 being very healthy
and 0 being unhealthy.
Feature #10363
Requested-by: Ethan Jackson
Signed-off-by: Mehak
Hi Ben
On Wed, Apr 4, 2012 at 2:15 PM, Ben Pfaff wrote:
> On Wed, Apr 04, 2012 at 11:38:42AM -0700, Mehak Mahajan wrote:
> > The changes display the cfm_health of an interface. The cfm_health
> > is an exponential weighted moving average of the health of all
> > remote_
The changes display the cfm_health of an interface. The cfm_health
is an exponential weighted moving average of the health of all
remote_mpids. The value can vary from 0 to 100, 100 being very healthy
and 0 being unhealthy.
Feature #10363
Requested-by: Ethan Jackson
Signed-off-by: Mehak
The changes display the cfm_health of an interface. The cfm_health
is an exponential weighted moving average of the health of all
remote_mpids. The value can vary from 0 to 100, 100 being very healthy
and 0 being unhealthy.
Feature #10363
Requested-by: Ethan Jackson
Signed-off-by: Mehak
The changes display the cfm_health of an interface. The cfm_health
is an exponential weighted moving average of the health of all
remote_mpids. The value can vary from 0 to 100, 100 being very healthy
and 0 being unhealthy.
Feature #10363
Requested-by: Ethan Jackson
Signed-off-by: Mehak
Thanks Ben, Justin.
I just pushed the changes to master.
thanx!
mehak
On Fri, Mar 23, 2012 at 11:20 PM, Justin Pettit wrote:
> On Mar 23, 2012, at 6:32 PM, Ben Pfaff wrote:
>
> > On Fri, Mar 23, 2012 at 06:12:00PM -0700, Mehak Mahajan wrote:
> >> Ethan's change c
default_value));
-}
-
^L
/* Port mirroring. */
thanx!
mehak
On Fri, Mar 23, 2012 at 3:54 PM, Ben Pfaff wrote:
> On Fri, Mar 23, 2012 at 03:49:44PM -0700, Mehak Mahajan wrote:
> > The changes allow the user to specify a separate dscp v
connmgr_run() and passing to rconn_create().
I will repost the patch with all the changes.
On Fri, Mar 23, 2012 at 2:22 PM, Ben Pfaff wrote:
> On Fri, Mar 23, 2012 at 02:13:32PM -0700, Mehak Mahajan wrote:
> > Done ... Hopefully this is the last set of whitespaces :)
>
> You can make
Hi Ben,
Thanks for your comments.
Please find my questions/comments inline.
On Fri, Mar 23, 2012 at 1:25 PM, Ben Pfaff wrote:
> On Thu, Mar 22, 2012 at 10:24:33PM -0700, Mehak Mahajan wrote:
> > The changes allow the user to specify a separate dscp value for the
> > controller
98 matches
Mail list logo
