Hey Ben,

Looks good to me.

thanx!
mehak

On Mon, Jul 9, 2012 at 11:45 PM, Ben Pfaff <b...@nicira.com> wrote:

> When an output OF1.0 match uses OFP_VLAN_NONE to match only when the 802.1Q
> header is not present, it is somewhat contradictory to specify any value
> for the VLAN PCP, since none can be present without an 802.1Q header, but
> the match output by Open vSwitch did so.  This fixes it.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
>  lib/ofp-util.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index 99f92a8..9fda563 100644
> --- a/lib/ofp-util.c
> +++ b/lib/ofp-util.c
> @@ -234,6 +234,7 @@ ofputil_cls_rule_to_ofp10_match(const struct cls_rule
> *rule,
>      } else if (rule->wc.vlan_tci_mask & htons(VLAN_CFI)
>                 && !(rule->flow.vlan_tci & htons(VLAN_CFI))) {
>          match->dl_vlan = htons(OFP10_VLAN_NONE);
> +        ofpfw |= OFPFW10_DL_VLAN_PCP;
>      } else {
>          if (!(rule->wc.vlan_tci_mask & htons(VLAN_VID_MASK))) {
>              ofpfw |= OFPFW10_DL_VLAN;
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to