Re: [ovs-dev] NSH Option 2 implementation

2016-08-11 Thread Li, Johnson
ns of an output action. > How can the OF controller modify the newly inserted SMAC and DMAC fields > with set_field actions after the output action? > > I can double check and possibly its conceptually a bit broken but at least in > the > context of the l3 VPN patchset I believe you

Re: [ovs-dev] NSH Option 2 implementation

2016-08-11 Thread Li, Johnson
> > + [ovs-dev] > > Further comments below. > > BR, Jan > > > -Original Message- > > From: Li, Johnson [mailto:johnson...@intel.com] > > Sent: Thursday, 11 August, 2016 03:36 > > Subject: RE: NSH Option 2 implementation > > >

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-13 Thread Li, Johnson
> > Please see previous comments in this thread, such as this one: > http://openvswitch.org/pipermail/dev/2016-July/074980.html > We are trying to remove the dependency on Simon's patch set, but we have similar implementation for the datapath, this is duplicated effort. So we have to wait for Si

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-12 Thread Li, Johnson
> -Original Message- > From: Li, Johnson > Sent: Wednesday, July 13, 2016 1:26 AM > To: dev@openvswitch.org > Cc: Li, Johnson > Subject: [RFC PATCH v2 00/13] Add Network Service Header Support > > --- > Change Log: > V1->V2: 1. Add prototype for MD ty

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Li, Johnson
> > On Tue, Jun 21, 2016 at 6:50 PM, Li, Johnson wrote: > >> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson > wrote: > > [JL] Yes, Mengke had renamed the command line and mapping table from > > xx-geneve-yy To xx-tlv-yy. However, the flow fields are still named &

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-21 Thread Li, Johnson
> On Mon, Jun 20, 2016 at 9:02 PM, Li, Johnson wrote: > > 2) Add framework codes (or full implementation) for MD type 2 support of > > the NSH header. According to the discussion at > > http://comments.gmane.org/gmane.network.openvswitch.devel/53788 >

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-20 Thread Li, Johnson
> > > > > Regards > > _Sugesh > > > > > > [Sugesh] I feel, match_set for every nsh field is a overkill > > especially when we implement NSH type-2? Can we do this some more > optimized way? > > Consider the MD2 type as well when defining the match_set definitions. > > > [JL] I will try to use MACR

Re: [ovs-dev] [CudaMailTagged] [RFC PATCH 09/14] parse NSH key in key_extract of openvswitch

2016-06-19 Thread Li, Johnson
> Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > > Sent: Tuesday, June 7, 2016 7:10 PM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [CudaMailTagged] [RFC PATCH 09/14] parse NSH key in > > key_extract of openv

Re: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for match fields

2016-06-19 Thread Li, Johnson
> > Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > > Sent: Thursday, June 16, 2016 10:52 AM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [RFC PATCH 07/14] Add APIs to set NSH keys for > > match fields > > >

Re: [ovs-dev] [CudaMailTagged] [RFC PATCH 03/14] Add NSH keys as match fields for user space flow table

2016-06-19 Thread Li, Johnson
> Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > > Sent: Tuesday, June 7, 2016 7:10 PM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [CudaMailTagged] [RFC PATCH 03/14] Add NSH keys as > > match fields for user

Re: [ovs-dev] [RFC PATCH 01/14] Add VxLAN-GPE extension for the Openvswitch

2016-06-19 Thread Li, Johnson
> Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Johnson Li > > Sent: Thursday, June 16, 2016 10:52 AM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [RFC PATCH 01/14] Add VxLAN-GPE extension for the > > Openvswitch > > > >

Re: [ovs-dev] [RFC PATCH 01/14] Add VxLAN-GPE extension for the Openvswitch

2016-06-15 Thread Li, Johnson
>"dev" wrote on 06/16/2016 04:51:34 AM: > > + return -EMSGSIZE; > > + > > + nla_nest_end(skb, exts); > > Nit: since this is almost identical to the previous block, I think > a refactoring where this block is abstracted into a helper or a > macro might make for easier

Re: [ovs-dev] [RFC PATCH 02/14] Add NSH fields for Openvswitch flow key

2016-06-14 Thread Li, Johnson
> On Tue, Jun 14, 2016 at 5:37 AM, Johnson Li wrote: > > Openvswitch could use the fields of Network Serivce Header(NSH) as key > > to steer traffic to the Virtual Network Functions(VNF). > > > > Signed-off-by: Johnson Li > > I only see patch 2/14. Are there supposed to be more? Sorry to make c

Re: [ovs-dev] [CudaMailTagged] [RFC PATCH 00/14] Add Network Service Header Support

2016-06-07 Thread Li, Johnson
> > https://github.com/horms/openvswitch.git > > This patch set depends on Simon's patch. > > This series has too many dependencies on unmerged code to really make > sense to review carefully at this point but I have some general > comments: > Yes, the patch set depends on Simon's patch set

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Li, Johnson
> -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Friday, April 22, 2016 12:44 AM > To: Li, Johnson > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space > data path > > On Wed, Apr 20, 2016 at

Re: [ovs-dev] [PATCH v2] Add VxLAN-GBP support for user space data path

2016-04-20 Thread Li, Johnson
> -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Thursday, April 21, 2016 4:23 AM > To: Li, Johnson > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v2] Add VxLAN-GBP support for user space > data path > > On Wed, Apr 20, 2016 at

Re: [ovs-dev] [PATCH] Add VxLAN-GBP support for user space data path

2016-04-19 Thread Li, Johnson
> -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Tuesday, April 19, 2016 11:22 PM > To: Li, Johnson > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH] Add VxLAN-GBP support for user space data > path > > On Tue, Apr 19, 2016 at 3:20 AM,