[ovs-dev] is it unnecessary code line? datapath/flow.c #line 1303

2012-11-08 Thread JieYue Ma
Hi, I am reading ovs code, while in function ovs_flow_to_nlattrs, we have ... if (swkey->eth.tci || swkey->eth.type == htons(ETH_P_8021Q)) { if (nla_put_be16(skb, OVS_KEY_ATTR_ETHERTYPE, htons(ETH_P_8021Q)) || nla_put_be16(skb, OVS_KEY_ATTR_VLAN, swkey->eth.tci))

[ovs-dev] [QUESTION] the flow expire time

2012-10-26 Thread JieYue Ma
Hi, During my observation, it seems that the flow expire time has some kind of heuristic algo to compute. I add some log for flow miss, and start to ping from A to B. At first, the flow from A to B seems to miss almost every 5 seconds, but as time goes by, the miss interval enlarges, which means t

Re: [ovs-dev] Gso testing with respect to stt tunnel

2012-09-24 Thread JieYue Ma
Which STT patches you've tried? I've tried a patch from Simon Horman, it works well, you need to patch both kernel and OVS. BTW, during my perf test, the performance downgrades a lot, even worse than GRE tunnel. Has anyone tried these patches and got a different result? I also noticed OVS gonna p