Re: [ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-07 Thread Flynn, Dennis R (Dennis)
Hi Joe, Yes, over-zealous checking on my part. Thanks for finding and fixing this. Acked-by: Dennis Flynn From: Joe Stringer [joestrin...@nicira.com] Sent: Wednesday, May 06, 2015 5:44 PM To: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re

Re: [ovs-dev] [PATCH 1/4] ovs-vsctl: Create AutoAttach records on demand, for backward compatibility.

2015-03-20 Thread Flynn, Dennis R (Dennis)
Thanks for fixing this. Acked-by: Dennis Flynn -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Friday, March 20, 2015 2:53 AM To: dev@openvswitch.org Cc: Ben Pfaff; Flynn, Dennis R (Dennis); Alex Wang Subject: [PATCH 1/4] ovs-vsctl: Create AutoAttach records on demand

Re: [ovs-dev] [PATCH 00/32] Auto-Attach series plus refinements

2015-03-02 Thread Flynn, Dennis R (Dennis)
Hi Ben, We have completed our testing with your additional refinements and everything looks good. I have the following comments after reviewing your changes. Once these are addressed to your satisfaction we are good to go with committing these changes. lib/lldp/lldp.c - Remove lingeri

Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

2015-02-26 Thread Flynn, Dennis R (Dennis)
ldp/lldp.c - lib/lldp/lldpd-structs.c - lib/lldp/lldpd.c - lib/lldp/lldpd.h - lib/ovs-lldpd.c (Windriver) Thanks, Dennis -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Monday, February 23, 2015 12:21 AM To: Flynn, Dennis R (Denni

Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

2015-02-23 Thread Flynn, Dennis R (Dennis)
: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set On Sun, Feb 22, 2015 at 11:45:29AM -0800, Ben Pfaff wrote: > On Fri, Feb 20, 2015 at 02:17:11PM -0500, drfl...@avaya.com wrote: > > Fro

Re: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5)

2015-02-18 Thread Flynn, Dennis R (Dennis)
: Flynn, Dennis R (Dennis) Sent: Tuesday, February 10, 2015 9:37 AM To: 'Ben Pfaff' Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5) Ben, My apologies for the delay getting back to you on this topic. I am working on getting the

Re: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5)

2015-02-11 Thread Flynn, Dennis R (Dennis)
, January 28, 2015 11:09 AM To: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5) Hi. I spent some more time on this series last night. I think that it needs some basic tests before I'll feel comfortable wi

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard (v4)

2015-01-16 Thread Flynn, Dennis R (Dennis)
submission. From your perspective do you require that the new AA unit tests be in place before accepting the AA code? Do you have any further insight regarding the "Code Complete" date for OvS 2.4? Regards, Dennis -Original Message----- From: Flynn, Dennis R (Dennis) Sent:

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard (v4)

2015-01-14 Thread Flynn, Dennis R (Dennis)
is based. We will look at porting those unit tests to the OvS unit test framework. Dennis -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Tuesday, January 13, 2015 6:36 PM To: Flynn, Dennis R (Dennis) Cc: Keene, Carl (Carl); dev@openvswitch.org Subject: Re: [ovs-dev

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard (v4)

2015-01-07 Thread Flynn, Dennis R (Dennis)
Thanks for the update. Please let us know if there is anything you need us to work on. Dennis -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, January 07, 2015 11:54 AM To: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 0/3

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard

2014-10-14 Thread Flynn, Dennis R (Dennis)
cant compute >logic. So - support for PBB does not make support for AAC unnecessary. -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Tuesday, October 14, 2014 10:42 AM To: Flynn, Dennis R (Dennis) Cc: Ludovic Beliveau; dev@openvswitch.org Subject: Re: [ovs-dev] [

Re: [ovs-dev] [PATCH 1/3] auto-attach: Initial support for Auto-Attach standard

2014-10-14 Thread Flynn, Dennis R (Dennis)
Hi Ben, Thank you for the thorough review of the auto attach patches! We will address all your comments/concerns and be back in touch. Thanks again, Dennis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff Sent: Monday, October 13, 2014 6:49 PM To

Re: [ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard

2014-10-14 Thread Flynn, Dennis R (Dennis)
Our initial goal is to make OVS an auto attach client. We are watching with great interest the progress of the recently submitted 802.1ah (PBB) patch. PBB is the datapath on top of which the SPB control plane is layered and thus could lay the groundwork for adding auto attach server support to O

[ovs-dev] Status of patch adding Auto Attach feature

2014-10-13 Thread Flynn, Dennis R (Dennis)
Hi, A while back (Oct. 2) we posted a series of patches offering support for the Auto Attach feature. A description of this feature can be found here. http://openvswitch.org/pipermail/dev/2014-October/046651.html I'm curious to know if anyone has had a chance to look at this. Thanks, Dennis F

[ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

2014-10-01 Thread Flynn, Dennis R (Dennis)
This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit delivers auto-attach support to the OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is modified to define the new auto-attach entries. The man pages a

[ovs-dev] [PATCH 2/3] auto-attach: Add auto-attach support to ofproto layer

2014-10-01 Thread Flynn, Dennis R (Dennis)
diff --git a/lib/odp-util.h b/lib/odp-util.h index 11b54dd..61b71b1 100644 --- a/lib/odp-util.h +++ b/lib/odp-util.h @@ -40,6 +40,7 @@ struct pkt_metadata; SPR(SLOW_BFD,"bfd","Consists of BFD packets") \ SPR(SLOW_LACP, "lacp", "Consists of LACP packets")

[ovs-dev] [PATCH 0/3] auto-attach: Add support for IETF Auto Attach standard

2014-10-01 Thread Flynn, Dennis R (Dennis)
This patch sequence provides OVS support for the IETF Auto-Attach SPBM draft standard. This standard describes a compact method of using IEEE 802.1AB Link Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path Bridging (SPB) network to automatically attach network devices to in

[ovs-dev] Contribute Auto-Attach SPBm support to Open vSwitch

2014-09-19 Thread Flynn, Dennis R (Dennis)
Greetings OVS Team, We have been working on adding OVS support for the IEEE/IETF Auto-Attach SPBm draft standard. This standard describes a compact method of using IEEE 802.1AB Link Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path Bridging (SPBm) network to automatical