Ben, My apologies for the delay getting back to you on this topic.
I am working on getting the tests you requested in place. As you suggest I will focus on adding a few tests to validate that we are sending well-formed LLDP packets. Specifically I will concentrate on validating the TLVs contained within LLDPPDUs generated for Auto Attach. As I mentioned in an earlier email I am coming up to speed on the OvS unit test framework but will back in touch with a new patch version ASAP. Regards, Dennis -----Original Message----- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, January 28, 2015 11:09 AM To: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 0/3] Add support for IETF Auto Attach standard (v5) Hi. I spent some more time on this series last night. I think that it needs some basic tests before I'll feel comfortable with it. Otherwise, there's no way to have any confidence that it hasn't been broken as part of changes in OVS as OVS evolves, or, more immediately, as part of style changes that I want to apply before it goes in. The part that I'm most concerned about is making sure that lldp packets being sent out are well-formed and contain the information that they should. Will you please work on getting some tests ready? Then we ought to be able to get this in pretty quickly. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
