Acked-by: Eitan Eliahu
It would be good if we could verify that the driver is compiled and run when
compiled with VS Update 4 and Winddk 8.1.
Thanks
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Tuesday, July 14, 2015 11:57
Alin, it is a different one.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, July 13, 2015 11:58 AM
To: Ben Pfaff; Sorin Vinturis
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start mes
Hi Sorin,
Thank you for addressing my comments. Can we please use a flag which indicates
that the a dump process is in progress rather than setting the whole buffer to
zero?
Besides of that, everything is good.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.o
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, July 13, 2015 10:18 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: update extension information
This patch sets
Thanks for addressing the issue!
Acked-by: Eitan Eliahu
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, July 13, 2015 9:59 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header
Alin, it seems that RtlUnicodeStringToAnsiString() can't be called in an
elevated IRQL.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, July 13, 2015 10:06 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapa
Hi Alin,
Can you please explain why the FilterID is used to maintain the number of
transmitted bytes?
The FilterID is sent to WFP when we add a filter so the filter can be deleted
later by specifying this ID. Once the ID is modified the removal of the filter
will fail.
I think we want to use as
Hi Sorin,
Please consider to have the dump state as part of the usermode instance
(regardless if dump initiated or not). This would save the whole housekeeping
around this insignificant dynamic memory allocation.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswi
Yes, this would make the parse function to fail and in fact it will access the
policy array beyond its boundary.
Thanks Alin and Ben,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, July 01, 2015 5:13 PM
To: Ben Pfaff; Eitan Eliahu
th-windows and ignores it for the moment to maintain binary
> compatibility.
>
> Signed-off-by: Alin Gabriel Serdean
> Acked-by: Eitan Eliahu
> ---
> This patch should be applied on master and branch-2.4
> v2: add acked-by
This patch makes me worry a bit. The Linux kernel and OVS us
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Wednesday, July 01, 2015 11:49 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [PATCH 2/2] Undefined symbol make_unix_socket
Hi Eitan,
It would be a nice
consider to use the pool handle (ovsPool.ndisHandle) instaed.
Thanks,
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Wednesday, July 01, 2015 8:50 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Solved
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Wednesday, July 01, 2015 8:27 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [PATCH] datapath-windows: Failed initialization for datapath
tunnel ports
Hi Sorin,
Can you explain which change broke this code.
I recall validating connectivity on STT and I believe Nithin validated on STT
and on VXLAN channel as well.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday,
Hi Sorin,
Thank you for debugging this issue.
I think that the NBL context signature is used for code validation only (think
about a signature we put in an object for the purpose of validating this object
when executing in a different context).
Can you think about another way to fix this issue (e
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, July 01, 2015 1:04 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Avoid double incrementation of tx
VXLAN packet
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, July 01, 2015 1:13 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Duplicate tag for STT pools
All pool allocations
Hi Alin,
Should we implement OVS system logging for Windows through the use of
"Application Event Logging"?
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Tuesday, June 30, 2015 9:28 AM
To: dev@openvswitch.org
Subject: [ovs
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Tuesday, June 30, 2015 9:27 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/2] OVS_UNUSED is defined indirectly
Currently OVS_UNUSED is defined
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Tuesday, June 30, 2015 9:39 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: OVS_PACKET_ATTR_PROBE
Since commit:
https
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Thursday, June 25, 2015 10:19 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] [PATCH v3][branch-2.4] dpif_probe_feature not
suported in windows
If it gets too involved have your user mode hack instead.
Thanks Alin.
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, June 25, 2015 8:38 AM
To: Eitan Eliahu; Nithin Raju
Cc: Ben Pfaff; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH
: Thursday, June 25, 2015 7:30 AM
To: Nithin Raju; Eitan Eliahu
Cc: Ben Pfaff; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows
datapath
Both are hacks IMO.
We could respond to DPIF_FP_PROBE but I prefer to do it in userspace until we
address the
I'm wondering if we could fail this call in the datapath level by examining the
DPIF_FP_PROBE bit in the flags.
If it is too hard we can still live with user mode code change.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
Sent: Wed
10:26 AM
To: Eitan Eliahu
Cc: Nithin Raju; dev@openvswitch.org
Subject: RE: [PATCH v2] datapath-windows: Return success for already existing
WFP objects
Hi Eitan/Nithin,
In normal execution flow all WFP objects are released after the extension is
disabled. The patch was meant to address the cases
Hi Sorin,
Could you please let us know what are the cases where these object are already
existed? I just want to be sure that we free all these objects when stopping
the extension.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Acked-by: Eitan Eliahu
Thanks Sorin.
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Tuesday, June 16, 2015 2:36 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: BSOD when disabling the
extension
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Monday, June 15, 2015 12:52 PM
To: dev@openvswitch.org
Cc: Gurucharan Shetty
Subject: [ovs-dev] [PATCH ovn] ofctrl: Don't use desig
Hi Sorin,
Can you please forward stack trace?
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Monday, June 15, 2015 7:49 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2] datapath-windows: BSOD when disabling the
ext
No need to apologize Sorin. We will get everything addressed. Sorry if you felt
like we pushed you.
Thanks for the patch,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Friday, June 12, 2015 5:27 AM
To: Nithin Raju
Cc: dev@openvsw
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Thursday, June 11, 2015 5:53 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Correctly complete the original
NBL with
.
Signed-off-by: Eitan Eliahu
Co-authored-by: Saurabh Shah
Signed-off-by: Saurabh Shah
---
INSTALL.Windows.md | 40 ++--
datapath-windows/automake.mk | 2 +
datapath-windows/ovsext/Actions.c | 64 --
datapath-windows/ovsext/Debug.h| 1
Yes, will do.
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Saturday, June 06, 2015 1:52 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling
protocol - Initial implementation
On Wed, May 27
This change include an initial implementable of STT.
The following should be added:
[1] Checksum offload (SW and HW)
[2] LSO (SW and HW)
[3] IP layer WFP callout for IP segments
Testing: link layer connection through ping works. File transfer.
Signed-off-by: Eitan Eliahu
Co-authored-by: Saurabh
river. It should be fine to block the user mode thread during the WFP
transaction processing.
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, May 20, 2015 11:04 AM
To: Eitan Eliahu; Sorin Vinturis; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 3/4] netlink: su
Acked-by: Eitan Eliahu
Thanks.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Tuesday, May 19, 2015 10:02 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] ARP lookup and next hop functionality on windows
This patch
Acked-by: Eitan Eliahu
Thanks Alin.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, May 04, 2015 9:45 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Fix warning from the powershell
module
This
Hi Alin,
It looks good besides some minor comments.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Monday, May 04, 2015 8:35 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] ARP lookup and next hop functionality on wind
This change include an initial implementable of STT.
The following should be added:
[1] Checksum offload (SW and HW)
[2] LSO (SW and HW)
[3] IP layer WFP callout for IP segments
Testing: link layer connection through ping works. File transfer.
Signed-off-by: Eitan Eliahu
Co-authored-by: Saurabh
This change include an initial implementable of STT.
The following should be added:
[1] Checksum offload (SW and HW)
[2] LSO (SW and HW)
[3] IP layer WFP callout for IP segments
Testing: link layer connection through ping works. File transfer.
Signed-off-by: Eitan Eliahu
Co-authored-by: Saurabh
Hi Alin,
I'm wondering if you addressed the issue of installation on Windows Server 2012.
Unless we install the 8.0 driver, the driver load would fail.
Thanks,
Eitan
> Begin forwarded message:
>
> From: Alin Serdean
> To: "dev@openvswitch.org"
> Date: April 28, 2015 at 3:36:28 PM PDT
> Subject
6.40 filter will fail to register itself on Windows Server 2012 and will get
unloaded.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, April 29, 2015 3:12 PM
To: Eitan Eliahu
Cc: Alin Serdean; Gurucharan Shetty; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 1/3
We will fix the transaction error message copy in the kernel in a separate
change.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
Sent: Wednesday, April 29, 2015 7:45 AM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev]
Besides that LG.
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, April 29, 2015 7:38 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink
socket like
Thanks for the review.
> On Apr 29, 2
Hi Nithin,
Sorry, I come late on this one, change looks good.
We need to check if the IRP output buffer is big enough to fit the transaction
message before copying it. Otherwise, we need to return error and break the
NetLink connection.
Thanks,
Eitan
-Original Message-
From: dev [mail
Acked-by: Eitan Eliahu
Thanks Nithin for the prompt fix.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Thursday, April 16, 2015 9:23 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] INSTALL.Windows: external.1 should be
transactions in the
same batch.
Thanks you for working on the driver side. I thought I will start to work on it
but please go ahead.
Eitan
-Original Message-
From: Nithin Raju
Sent: Thursday, April 16, 2015 9:06 AM
To: Eitan Eliahu
Cc: Sorin Vinturis; dev@openvswitch.org
Subject: Re
al Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Wednesday, April 15, 2015 9:10 PM
To: Nithin Raju; Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v4] netlink-socket: Exit NL transaction loop when
EINVAL is returned
Returning error on driv
LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=SoJBySQ9Ab0iZ66kD5oQW1lNQi2mdEyB-hkYI_568PY&s=qlfxf-x6rCbgRjcbZqeI1d7oSV9FpZDsQr1jdgHz_wI&e=
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
lib/netlink-socket.c | 9 +
1 file changed, 9 insertions
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, April 15, 2015 3:42 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 2/2] datapath-windows: Removed assert from
FilterNetPnPEvent
Sorin,
As we discussed before we need to communicate an error from the BFE state
change callback to the driver. Until we have this code could you please add an
assert here:
+if (FWPM_SERVICE_RUNNING == bfeState) {
+status = OvsTunnelFilterInitialize(driverObject);
+if (!NT_SU
Acked-by: Eitan Eliahu
Thanks Sorin,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, April 15, 2015 2:31 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2] netlink-socket: Exit NL transaction loop when
EINVAL
The DeviceIOControl() error should correspond to a transport error in Linux or
to a system error.
We need to transfer all transaction failures through the reply buffer
(nlmsghdr+nlmsgerr) and return success for the DeviceIOControl().
I am aware that we didn't follow the exact semantics in the
Yes, some cases where the transaction is completed with an error we need to
increase the "done" counter, This case would be different than the case where
the transaction didn't go through.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Hi Sorin, I am somewhat confused about this change. Have you concluded that the
filter could not be initialized unless a provider is already registered?
I am trying to understand the relationships between this change and the change
you check in before (also, to address the issue that the BFE had
Hi Sorin,
This is much better (it is hard to protect on the object using the object
itself).
Thank you!
Eitan
Acked-by: Eitan Eliahu Thanks, Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Friday, April 03, 2015 8:41 AM
To
->refCount will generate a memory
violation.
Also, I think gOvsSwitchContext need to be memory synchronized with a memory
barrier.
Thanks,
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Thursday, April 02, 2015 3:12 PM
To: Eitan Eliahu;
Hi Sorin,
Can you please explain how the case where FilterDetach is called on a
different core concurrently with the Release and between switchContext is
checked for NULL and the swicthContext->refCount is referenced ? (where it is
marked >>)
It seems that FilterDetach would set gOvsSwit
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 11/11] datapath-windows: Added specific pool tag for
vport code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 10/11] datapath-windows: Added specific pool tag for
user code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 09/11] datapath-windows: Added specific pool tag for
switch code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 08/11] datapath-windows: Added specific pool tag for
oid code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 07/11] datapath-windows: Added specific pool tag for
iphelper code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 06/11] datapath-windows: Added specific pool tag for
vxlan code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 05/11] datapath-windows: Added specific pool tag for
flow code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 04/11] datapath-windows: Added specific pool tag for
event code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 02/11] datapath-windows: Added specific pool tag for
datapath code
All memory
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 03/11] datapath-windows: Added specific pool tag for
buffermgmt code
All MDL
Just fyi, memory leaks can be detected when Verifier is installed. The system
would Bugcheck and the stack could be examined. But, it is still useful to
have different tags for different memory allocations.
Thanks Sorin.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswit
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, March 25, 2015 1:14 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 01/11] datapath-windows: Support for
allocating/releasing memory with tag
I'm fine with this change.
Thanks Ben and Sorin.
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, March 24, 2015 10:01 AM
To: Eitan Eliahu
Cc: Sorin Vinturis; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system pro
Acked-by: Eitan Eliahu
Thanks Sorin.
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Tuesday, March 24, 2015 12:29 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider
:40 PM
To: Sorin Vinturis; Eitan Eliahu
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider
handling
As I explained in the patch description, I have added this change because, at
driver initialization phase, the system provider failed to be added due
ext !
OvsTunnelEngineOpen(&handle);
How do you prevent it?
Also, can you please explain which issue you ran into which triggered this
change?
Thank you,
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Monday, March 23, 2015 1:37 AM
To: Eitan Eliahu
Hi Sorin,
Thank you for posting this change.
Here are few comments:
[1] Please call OvsTunnelEngineClose(&handle) only if the handle is not zero.
(you might want to add an assertion if it zero).
[2] I'm somewhat confused about the registration for engine state change. As I
understand you check t
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Tuesday, March 17, 2015 3:31 PM
To: dev@openvswitch.org
Cc: Gurucharan Shetty; Hemanth Kumar Mantri
Subject: [ovs-dev] [PATCH] INSTALL.Windows.md
I don't have a strong opinion but once the installer is included in the OVS
tree all directory structure is fixed so there is no ambiguity on how or where
the installer collects the files. It will also avoid having more than one copy
of the same file.
It would be nice also if the installer an
I think we can drop 32bit support once the 64bit is there.
Thanks!
Eitan
-Original Message-
From: Nithin Raju
Sent: Monday, March 16, 2015 11:10 PM
To: Alessandro Pilotti
Cc: Eitan Eliahu; dev@openvswitch.org
Subject: Re: [ovs-dev] OVS Windows MSI installer
> On Mar 15, 2015, at 7
Hi Sorin,
It would be probably better to make this call synchronous as the thread has
nothing else to do. The WFP transaction in the driver is guaranteed to being
completed so we should be ok here.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Thursday, March 12, 2015 5:43 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 2/3] datapath-windows: Support for multiple VXLAN
tunnels
At
Alessandro, How the MSI solution find files from the OVS build that need to be
included?
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Sunday, March 15, 2015 6:30 PM
To: Alessandro Pilotti
Cc: dev@openvswitch.org
Subject
(x86 and x86-64)?
Thanks,
Eitan
-Original Message-
From: Alessandro Pilotti [mailto:apilo...@cloudbasesolutions.com]
Sent: Sunday, March 15, 2015 6:11 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: OVS Windows MSI installer
Hi Eitan,
> On 16 Mar 2015, at 02:57, Eitan Eli
Hi Alessandro,
I couldn't find the driver binary as part of the installer. Also, can you
explain how uninstlaation is done and the case where a driver is already loaded.
Thank you!
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alessandro Pilotti
Sen
Hi Ben,
Sorin plans to address some issues once he is back.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu
Sent: Wednesday, January 07, 2015 1:16 PM
To: Sorin Vinturis; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath
Thanks!
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Wednesday, February 11, 2015 6:00 PM
To: dev@openvswitch.org
Cc: Gurucharan Shetty
Subject: [ovs-dev] [PATCH v2] tests: Enable running parallel unit
Eitan
-Original Message-
From: Gurucharan Shetty [mailto:shet...@nicira.com]
Sent: Friday, February 06, 2015 7:39 AM
To: Eitan Eliahu
Cc: Nithin Raju; dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-dev] [PATCH] appveyor: Build windows kernel datapath.
> Would be nice to have a
Would be nice to have an option for Release or debug build. User mode code too.
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Thursday, February 05, 2015 10:39 PM
To: Gurucharan Shetty
Cc: dev@openvswitch.org; Gurucharan Shetty
Subject: Re
Looks like user mode does not use pre-compiled headers, but the driver does.
-Original Message-
From: Eitan Eliahu
Sent: Thursday, February 05, 2015 1:39 PM
To: 'Gurucharan Shetty'; Ben Pfaff
Cc: dev; Gurucharan Shetty
Subject: RE: [ovs-dev] [PATCH 2/2] appveyor: Provide a
Testing on a single CPU machine is problematic (even if it would have run
fast), but the build itself has its own advantage. The driver build should be
much quicker.
Do we use precompiled header option?
https://msdn.microsoft.com/en-us/library/2yzw0wyd.aspx
Thanks,
Eitan
-Original Message-
Alin, looks good only minor thing :
+rc = STATUS_SUCCESS
Is redundant
Thanks,
Eitan
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
Sent: Tuesday, February 03, 2015 11:25 AM
To: dev@openvswitch.org
Subject
transaction fails but we might just
fail the transaction.
I think once we have the IOCTL synced we can go ahead with this challenging
change.
Eitan
-Original Message-
From: Eitan Eliahu
Sent: Tuesday, January 20, 2015 9:07 AM
To: 'Sorin Vinturis'
Subject: RE: [ovs-dev] [PATCH v2
Hi Sorin,
Thank you for addressing the issues, specifically, executing the engine from a
thread running in lower IRQL.
Can you please add some comments on the testing you performed? Where you able
to shortcut the fast path and to open the VXLAN UDP port in user mode so
packets will go through t
...@nicira.com]
Sent: Thursday, January 15, 2015 9:07 AM
To: Eitan Eliahu
Cc: Thomas Graf; dev; YAMAMOTO Takashi
Subject: Re: [ovs-dev] OVN architecture
On Thu, Jan 15, 2015 at 8:55 AM, Eitan Eliahu wrote:
> Shared libraries on Windows could be implemented as DLLs (Dynamic Link
> Libraries) wit
Shared libraries on Windows could be implemented as DLLs (Dynamic Link
Libraries) with some custom support for versioning.
This means also that updates of new versions of the DLLs should controlled by
a custom installer.
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org]
t fails on with FWP_E_TXN_IN_PROGRESS.
Thank you,
Eitan
-Original Message-
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com]
Sent: Wednesday, January 07, 2015 11:59 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support for custom VXLAN
tunnel por
Hi Sorin, thank you for working on this.
Do you thing the default port filter had to be created during initialization ?
On another thing, since OvsTunnelAddFilterEx is called with IRQL = PASSIVE and
no lock is handled it may be called from multiple thread contexts. I am not
sure if opening. Clo
Acked-by: Eitan Eliahu
Thanks for addressing my comment.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Monday, December 08, 2014 9:43 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/2] datapath-windows: return bool from
Acked-by: Eitan Eliahu
Thanks!
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Monday, December 08, 2014 9:43 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/2] datapath-windows: refactor
BuildReplyMsgFromMsgIn
Hi Nithin,
It may be out of the scope of this change but for consistency reason all NL
function should return BOOLEAN rather than NTSTATUS.
This should apply NlFillOvsMsg() and NlFillNlHdr() too.
BOOLEAN ok;
+ok = NlFillOvsMsg(&nlBuffer, msgIn->nlMsg.nlmsgType, NLM_F_MULTI,
But the func
Acked-by: Eitan Eliahu
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Wednesday, December 03, 2014 7:56 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/3] datapath-windows: nuke unused code in Flow.c
Signed-off-by: Nithin Raju
1 - 100 of 378 matches
Mail list logo
