Re: [ovs-dev] [PATCH v2] ipfix: Add ingress and egress interface in exporting flows

2016-07-17 Thread Daniel Ye
to:b...@ovn.org] Sent: Tuesday, July 05, 2016 7:43 AM To: Daniel Ye Cc: Ben Pfaff ; Justin Pettit ; Wenyu Zhang ; Wang Qiong ; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] ipfix: Add ingress and egress interface in exporting flows The odp_ports aren't meaningful at all outside of O

[ovs-dev] Request for subscribing this alias

2016-07-11 Thread Daniel Ye
Hi, Could you please help to put my email address in this alias? I have subscribed several times, but I didn't get any notifications. Thanks. Bests, Daniel Benli Ye ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovs-dev, PATCHv3] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-11 Thread Daniel Ye
nly use the original packet size and the metadata in flow. I don't get any idea about how we set 'snaplen' in IPFIX. Is it better to have this field in sample action? Wait for Ben's input. Bests, Daniel From: William Tu Sent: Sunday, July 1

[ovs-dev] [ovs-dev, PATCHv3] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-10 Thread Daniel Ye
Hi William, I saw that you submitted the patch below. It's about adding 'snaplen' for sample action and sFlow. https://patchwork.ozlabs.org/patch/645013/ I'm still confused whether sFlow uses the openflow sample action. In my opinion, sFlow only uses the datapath sample action, not the sample a

Re: [ovs-dev] Bridge IPFIX statistics check question

2016-07-06 Thread Daniel Ye
CTED PASS” on Windows. Thanks, Paul From: Daniel Ye [mailto:dani...@vmware.com] Sent: Wednesday, July 6, 2016 3:28 PM To: Paul Boca Subject: RE: Bridge IPFIX statistics check question Hi Paul, It’s a test case issue and I am planning to fix it when adding a new test case like the port usage of sFl

Re: [ovs-dev] [PATCH v2] ipfix: Add ingress and egress interface in exporting flows

2016-07-04 Thread Daniel Ye
Hi Ben, Thanks for review. In my opinion, the ofp_port may be the same on different bridge. If so, we still don’t differentiate the flows in this scenario. That’s why I choose to use odd_port. Bests, Daniel > On Jul 5, 2016, at 5:22 AM, Ben Pfaff wrote: > > On Thu, Jun 30, 2016 at 08:48:43PM -

Re: [ovs-dev] Valgrind errors on Bridge IPFIX statistics check

2016-06-26 Thread Daniel Ye
HI William and Ben, Thanks for catching and fixing this problem. I applied the patch and tested. The problem is gone. Thanks. Bests, Daniel > On Jun 27, 2016, at 5:54 AM, Ben Pfaff wrote: > > On Sun, Jun 26, 2016 at 11:28:44AM -0700, William Tu wrote: >> Hi, >> >> Valgrind reports the error be

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Daniel Ye
OK, I got it and I will handle this. Bests, Daniel > On Jun 25, 2016, at 12:22 PM, Ben Pfaff wrote: > > On Sat, Jun 25, 2016 at 04:12:04AM +0000, Daniel Ye wrote: >> It’s because of the "packet send error" statistic. The test of checking >> IPFIX statistics s

Re: [ovs-dev] [PATCH V3] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Daniel Ye
Hi Ben, It’s because of the "packet send error" statistic. The test of checking IPFIX statistics set collector as “127.0.0.1:4739”. Test code: - dnl Sample every packet using bridge-based sampling. AT_CHECK([ovs-vsctl -- set bridge br0 ipfix=@fi

[ovs-dev] Please ingore "[ovs-dev, v5] ipfix: support tunnel information for Flow IPFIX"

2016-06-12 Thread Daniel Ye
Hi Ben, Please ignore "[ovs-dev,v5] ipfix: support tunnel information for Flow IPFIX" https://patchwork.ozlabs.org/patch/634130/ In patch v5, I changed probability of flow-based IPFIX to support 32 bits unsigned int. However, after thinking it over again, 16 bit unsigned int probability which c

Re: [ovs-dev] [PATCH v3] ipfix: support tunnel information for Flow IPFIX

2016-06-10 Thread Daniel Ye
Hi Ben, Yes, my first idea is to do adjust_sample_acion() action in commit_odp_tunnel_action(), but it can hardly handle the problem that if there are two or more user world sample action and each has a sampling_port, like the last case in my new added testing. We add a flow in the user world l

Re: [ovs-dev] [PATCH v3] ipfix: add support for exporting ipfix statistics

2016-06-10 Thread Daniel Ye
. I'm appending a further incremental diff I suggest folding in, because I noticed a few more style nits. Thanks, Ben. On Fri, Jun 10, 2016 at 02:10:00AM +, Daniel Ye wrote: Hi Ben, Thanks for your review. For the test case, I didn’t get an error in my test machine. I suspected tha

Re: [ovs-dev] [PATCH v3] ipfix: add support for exporting ipfix statistics

2016-06-09 Thread Daniel Ye
Hi Ben, Thanks for your review. For the test case, I didn’t get an error in my test machine. I suspected that IPFIX packets are not all sent before dump IPFIX stats, so 'sleep 1' is added to make sure all the IPFIX packets are sent. Bests, Daniel Benli Ye > On Jun 10, 2016, at 5:33 AM, Ben Pfa

Re: [ovs-dev] [PATCH v1] Support port level IPFIX

2016-04-29 Thread Daniel Ye
s improving the existing OpenFlow “sample” action. Some more comments inline below. On Apr 25, 2016, at 8:48 PM, Daniel Ye mailto:dani...@vmware.com>> wrote: Hi Ben, Thanks for your review. I have sent a second patch with signed-off tag. Please review it again. For your comments, I listed the

Re: [ovs-dev] [PATCH v1] Support port level IPFIX

2016-04-25 Thread Daniel Ye
, Daniel Benli Ye -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Saturday, April 23, 2016 12:55 AM To: Daniel Ye Cc: Wenyu Zhang; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Support port level IPFIX On Tue, Apr 19, 2016 at 03:55:10PM +0800, Daniel Benli Ye wrote: &g