Hi Ben,
Thanks for your review. For the test case, I didn’t get an error in my test
machine. I suspected that IPFIX packets are
not all sent before dump IPFIX stats, so 'sleep 1' is added to make sure all
the IPFIX packets are sent.
Bests,
Daniel Benli Ye
> On Jun 10, 2016, at 5:33 AM, Ben Pfaff <b...@ovn.org> wrote:
>
> On Wed, Jun 08, 2016 at 06:45:25PM +0800, Benli Ye wrote:
>> It is meaningful for user to check the stats of IPFIX.
>> Using IPFIX stats, user can know how much flows the system
>> can support. It is also can be used for performance check
>> of IPFIX.
>
> Thanks for posting v3!
>
> I think that this is close. I suggest folding in the appended
> incremental change.
>
> I get test failures with this applied. I'm attaching them. Can you
> take a look?
>
> Thanks,
>
> Ben.
>
> diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h
> index 489933e..747c5bc 100644
> --- a/ofproto/ofproto-provider.h
> +++ b/ofproto/ofproto-provider.h
> @@ -1362,7 +1362,7 @@ struct ofproto_class {
> *flow_exporters_options, size_t n_flow_exporters_options);
>
> /*
> - * Get IPFIX stats on 'ofproto' according to the exporter of birdge
> + * Get IPFIX stats on 'ofproto' according to the exporter of bridge
> * IPFIX or flow based IPFIX.
> *
> * OFPERR_NXST_NOT_CONFIGURED as a return value indicates that bridge
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index b53fe8e..9ec47a1 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilities/ovs-ofctl.8.in
> @@ -264,13 +264,13 @@ This command uses an Open vSwitch extension that is
> only in Open
> vSwitch 2.6 and later.
> .
> .IP "\fBdump\-ipfix\-flow \fIswitch
> -Prints to the console the statistics of flow based IPFIX for
> -\fIswitch\fR. If flow based IPFIX is configured on the \fIswitch\fR,
> +Prints to the console the statistics of flow-based IPFIX for
> +\fIswitch\fR. If flow-based IPFIX is configured on the \fIswitch\fR,
> statistics of all the collector set ids on the \fIswitch\fR will be
> printed. Otherwise, print error message.
> .IP
> -Refer to ovs-vswitchd.conf.db(8) for more details on configuring flow
> -based IPFIX and collector set id.
> +Refer to \fBovs-vswitchd.conf.db\fR(5) for more details on configuring
> +flow-based IPFIX and collector set ids.
> .IP
> This command uses an Open vSwitch extension that is only in Open
> vSwitch 2.6 and later.
> @@ -2322,7 +2322,7 @@ When sending samples to IPFIX collectors, the unsigned
> 32-bit integer
> Observation Point ID sent in every IPFIX flow record. Defaults to 0.
> .RE
> .IP
> -Refer to \fBovs\-vswitchd.conf.db\fR(8) for more details on
> +Refer to \fBovs\-vswitchd.conf.db\fR(5) for more details on
> configuring sample collector sets.
> .IP
> This action was added in Open vSwitch 1.10.90.
> <testsuite.log><testsuite.log>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
