On Wed, Oct 19, 2016 at 12:58 PM, Ben Pfaff wrote:
> On Tue, Oct 11, 2016 at 12:33:22PM -0700, Andy Zhou wrote:
> > Without this fix, the added test will core dump.
> >
> > Signed-off-by: Andy Zhou
>
> Thanks!
>
> Acked-by: Ben Pfaff
>
Thanks for the rev
r all 15 patches in the series,
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Oct 14, 2016 at 2:52 AM, Babu Shanmugam wrote:
>
>
> On Friday 14 October 2016 04:00 AM, Andy Zhou wrote:
>
>
>
> Done. Now it shows the following.
>
> [root@h2 ovs]# crm configure show
>>
>> node 1: h1 \
>>
>> attributes
>>
>&
On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff wrote:
> The commit that this fixes is from 2009.
>
> Reported-by: Kai-Wei Fan
> Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.")
> Signed-off-by: Ben
On Wed, Oct 12, 2016 at 10:57 PM, Babu Shanmugam
wrote:
>
>
> On Thursday 13 October 2016 07:26 AM, Andy Zhou wrote:
>
>
>
> On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam
> wrote:
>
>>
>>
>> On Friday 07 October 2016 05:33 AM, Andy Zhou wrote:
>
On Thu, Oct 13, 2016 at 11:26 AM, Ben Pfaff wrote:
> On Wed, Oct 12, 2016 at 01:51:39PM -0400, Russell Bryant wrote:
> > 1) Add support to ovsdb-server for read-only remotes. The port reachable
> > by ovn-controller would only accept read-only connections.
>
> Andy, is this something that you ca
On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam wrote:
>
>
> On Friday 07 October 2016 05:33 AM, Andy Zhou wrote:
>
>> Babu, Thank you for working on this. At a high level, it is not clear
>> to me the boundary between ocf scripts and the ovn-ctl script -- i.e. which
manual intervention.
> However, a long time ago we introduced the "on_exit" mechanism that
> obsoletes this. This commit eliminates a lot of the old litter of kill
> invocations, which also makes those tests easier to read.
>
> Signed-off-by: Ben Pfaff
Acked-by: Andy Zhou
her why the race happened, but the change looks
good to me.
Acked-by: Andy Zhou
There are two additional targets that have the similar pattern, wonder if
we should change them as well...
diff --git a/tests/automake.mk b/tests/automake.mk
index f022feb..c170ae7 100644
--- a/tests/automake.
On Fri, Oct 7, 2016 at 10:04 AM, Ben Pfaff wrote:
> Also vertical tabs, whatever those are.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Without this fix, the added test will core dump.
Signed-off-by: Andy Zhou
---
tests/ovn.at | 4
tests/test-ovn.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index caf9f98..1f65e75 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> It's pretty unlikely that a human would write expressions like these, but
> they can come up in machine-generated expressions and it seems best to
> simplify them in an efficient way.
>
> Signed-off-by: Ben Pfaff
&
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> The test didn't check for x == 0/0 or x != 0/0 cases, and thus they were
> buggy.
>
> Also, add "expression" as a keyword for tests that only had "expressions"
> (plural).
>
> S
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> The test added by this commit is very specific to the particular problem,
> whereas a more general test would be better. A later commit adds the
> general test.
>
> Signed-off-by: Ben Pfaff
>
A
ch/list.h:245: assertion
> !ovs_list_is_empty(list) failed in ovs_list_front()
> Aborted (core dumped)
>
> This commit fixes this and related problems.
>
> The test added by this commit is very specific to the particular problem,
> whereas a more general test would be better. A l
On Fri, Oct 7, 2016 at 9:23 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote:
> This should make it that much easier to track down the code that emitted
> a particular flow.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
Also tested in the OVN sandbox.
On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote:
> Future commits will add a user.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
This is the first time I encountered a linked-list being built statically.
Very cool trick!
___
dev
Babu, Thank you for working on this. At a high level, it is not clear to
me the boundary between ocf scripts and the ovn-ctl script -- i.e. which
aspect is managed by which entity. For example, 1) which scripts are
responsible for starting the ovsdb servers. 2) Which script should manage
the fai
On Tue, Oct 4, 2016 at 1:37 PM, Ben Pfaff wrote:
> On Wed, Sep 28, 2016 at 10:00:19AM +0530, bscha...@redhat.com wrote:
> > v2 -> v3:
> > - Handling few edged cases in the OCF script as suggested by
> > Andrew Beekhof
> >
> > This patch contains changes required to run a pacemaker resou
On Mon, Oct 3, 2016 at 12:51 PM, Russell Bryant wrote:
>
>
> On Sun, Oct 2, 2016 at 3:34 AM, Frederick Kautz wrote:
>
>> I recall hearing that someone was adding etcd v3 support to OVN. Does
>> anyone have any info on whether this is still happening?
>>
>
>
On Mon, Sep 26, 2016 at 8:30 PM, Ben Pfaff wrote:
> On Tue, Sep 20, 2016 at 01:27:08PM -0700, Andy Zhou wrote:
> > The newly added replication logic makes it possible for a monitor to
> > receive delete and insertion of the same row back to back, which
> > was not possible b
On Mon, Sep 26, 2016 at 8:32 PM, Ben Pfaff wrote:
> On Tue, Sep 20, 2016 at 05:49:47PM -0700, Andy Zhou wrote:
> > Found by inspection.
> >
> > The 'replication_dbs' structure was not freed after use.
> > Fix by adding a new function replication_dbs_destr
Found by inspection.
The 'replication_dbs' structure was not freed after use.
Fix by adding a new function replication_dbs_destroy().
Also remove unnecessary global pointer variables initializer.
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 21 ++---
1 file c
On Tue, Sep 20, 2016 at 4:39 PM, Joe Stringer wrote:
> On 20 September 2016 at 13:27, Andy Zhou wrote:
> > The newly added replication logic makes it possible for a monitor to
> > receive delete and insertion of the same row back to back, which
> > was not possible b
://openvswitch.org/pipermail/dev/2016-September/079315.html
Reported-by: Alin Serdean
Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079586.html
Co-authored-by: Joe Stringer
Signed-off-by: Andy Zhou
---
ovsdb/monitor.c | 41 -
1 file
ut this new implementation
> leaves me more confident due to its simplicity.
>
> Reported-by: Joe Stringer
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/
> 079315.html
> Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
> Sign
void *arg_ OVS_UNUSED)
> {
> -unixctl_command_reply(conn, get_blacklist_tables());
> +char *reply = get_blacklist_tables();
> +unixctl_command_reply(conn, reply);
> +free(reply);
> }
>
On Fri, Aug 19, 2016 at 9:32 AM, Numan Siddique wrote:
> This command will be useful to query if the ovsdb-server
> instance is active or backup.
>
> Signed-off-by: Numan Siddique
> ---
> ovsdb/ovsdb-server.1.in | 4
> ovsdb/ovsdb-server.c| 17 +
> tests/ovsdb-server.a
On Fri, Sep 2, 2016 at 1:55 PM, Ben Pfaff wrote:
> On Wed, Aug 31, 2016 at 07:32:41PM -0700, Andy Zhou wrote:
> > Added the '--no-sync' option base on feedbacks of current
> > implementation.
> >
> > Added appctl command "ovsdb-server/sync-status" b
>
> I tested the v3 version pulling from your github, and I am not seeing an
>> crashes.
>>
>
>
> Thanks for testing. I added your name to tested-by in the V3 patch.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
state variable is updated from replication_run().
Added a test to simulate the integration of HA manager with OVSDB
server using replication.
Other documentation and API improvements.
Tested-by: Numan Siddique
Signed-off-by: Andy Zhou
---
Documentation/OVSDB-replication.md | 2 +-
ovsdb/json
On Tue, Aug 30, 2016 at 2:35 PM, Ben Pfaff wrote:
> On Fri, Aug 26, 2016 at 04:15:53PM -0700, Andy Zhou wrote:
> > Current replication uses blocking transactions, which are error prone
> > in practice, especially in handling RPC connection flapping to the
> > active server.
On Thu, Aug 25, 2016 at 6:48 AM, wrote:
> This patch adds support to start_ovsdb() function in ovn-ctl to start the
> ovn db servers in standby mode. This can be done in the following ways
> 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to
>set the addresses of the mas
On Tue, Aug 30, 2016 at 4:17 AM, Numan Siddique wrote:
>
>
> On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou wrote:
>
>>
>>
>> On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique
>> wrote:
>>
>>>
>>>
>>> On Sat, Aug 27, 2016 at 4:4
On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique wrote:
>
>
> On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou wrote:
>
>> Added the '--no-sync' option base on feedbacks of current
>> implementation.
>>
>> Added appctl command "ovsdb-server/sync-stat
On Thu, Aug 25, 2016 at 10:38 PM, Numan Siddique
wrote:
>
>
> On Thu, Aug 25, 2016 at 5:37 AM, Andy Zhou wrote:
>
>> The main purpose of this series patch 6 (OVSDB: Reimplement
>> replication. Using a state machine). Patch 7 includes
>> a few replication usabil
ocumentation and API improvements.
Signed-off-by: Andy Zhou
--
I hope to get some review comments on the command line and appctl
interfaces for replication. Since 2.6 is the first release of those
interfaces, it is easier to making changes, compare to future
releases.
v1->v2: Fix cre
Current replication uses blocking transactions, which are error prone
in practice, especially in handling RPC connection flapping to the
active server.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 17 +-
ovsdb/replication.c | 608
Fix a memory leak in case of error. The error object was not properly
disposed. Since the error to reset DB is not expected, log it and
exit.
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/ovsdb/replication.c b
It seems odd that the currently replication implementation moves the
struct db from ovsdb-server.c (file private) to replication.h (global).
This patch moves the 'struct db' defintion back into ovsdb-server.c,
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-serv
591.html
Only the last patch (7) is changed from v1->v2
Andy Zhou (7):
ovsdb: Properly handle error returned from from reset_database()
ovsdb: Add blacklist_tables
ovsdb: Add request_ids
ovsdb: (Re)hide struct db in ovsdb-server.c
test: Improve replication unit tests
OVSDB: Reimp
Replication test currently uses many sleeps that slowes the test down
and may not be reliable. Remove those sleeps when possible.
OVSDB servers needs to be killed on test failure. Use on_exit() to
ensure cleanup happens, so they don't have to be handled for each
testing step.
Signed-off-by:
re patches will make use of this facility.
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 84 ++---
1 file changed, 80 insertions(+), 4 deletions(-)
diff --git a/ovsdb/replication.c b/ovsdb/replication.c
index ebd348c..815730d 100644
-
yrun' option to
set_blacklist_tables() API to make this feature available to the
command line option parsing and unixctl command parsing.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 47
ovsdb/replication.c | 153 +-
It seems odd that the currently replication implementation moves the
struct db from ovsdb-server.c (file private) to replication.h (global).
This patch moves the 'struct db' defintion back into ovsdb-server.c,
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-serv
ocumentation and API improvements.
Signed-off-by: Andy Zhou
--
I hope to get some review comments on the command line and appctl
interfaces for replication. Since 2.6 is the first release of those
interfaces, it is easier to making changes, compare to future
releases.
---
Documentation/OVSDB-
yrun' option to
set_blacklist_tables() API to make this feature available to the
command line option parsing and unixctl command parsing.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 47
ovsdb/replication.c | 153 +-
The main purpose of this series patch 6 (OVSDB: Reimplement
replication. Using a state machine). Patch 7 includes
a few replication usability enhancements that has been requested
on the mailing list.
Andy Zhou (7):
ovsdb: Properly handle error returned from from reset_database()
ovsdb: Add
Replication test currently uses many sleeps that slowes the test down
and may not be reliable. Remove those sleeps when possible.
OVSDB servers needs to be killed on test failure. Use on_exit() to
ensure cleanup happens, so they don't have to be handled for each
testing step.
Signed-off-by:
Current replication uses blocking transactions, which are error prone
in practice, especially in handling RPC connection flapping to the
active server.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 17 +-
ovsdb/replication.c | 608
re patches will make use of this facility.
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 84 ++---
1 file changed, 80 insertions(+), 4 deletions(-)
diff --git a/ovsdb/replication.c b/ovsdb/replication.c
index ebd348c..815730d 100644
-
Fix a memory leak in case of error. The error object was not properly
disposed. Since the error to reset DB is not expected, log it and
exit.
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/ovsdb/replication.c b
On Fri, Aug 19, 2016 at 11:48 AM, Numan Siddique
wrote:
>
>
> On Wed, Aug 17, 2016 at 11:24 PM, Andy Zhou wrote:
>
>>
>>
>> On Wed, Aug 17, 2016 at 8:30 AM, Numan Siddique
>> wrote:
>>
>>> Hi Andy,
>>> I have started working on int
t; > CC: Chandra S Vejendla
> > Reported-by: Ramu Ramamurthy
> > Fixes: 8439c2ebd823 ("ovn: Support for GARP for NAT IPs via localnet")
> > Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
>
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Aug 19, 2016 at 1:40 AM, Valentine Sinitsyn <
valentine.sinit...@gmail.com> wrote:
> On 19.08.2016 02:44, Andy Zhou wrote:
>
>>
>>
>> On Thu, Aug 18, 2016 at 1:41 PM, Valentine Sinitsyn
>> mailto:valentine.sinit...@gmail.com>>
>> wrote
On Thu, Aug 18, 2016 at 1:41 PM, Valentine Sinitsyn <
valentine.sinit...@gmail.com> wrote:
> On 18.08.2016 23:49, Andy Zhou wrote:
>
>>
>>
>> On Thu, Aug 18, 2016 at 8:34 AM, Valentine Sinitsyn
>> mailto:valentine.sinit...@gmail.com>>
>> wrote:
>
On Thu, Aug 18, 2016 at 8:34 AM, Valentine Sinitsyn <
valentine.sinit...@gmail.com> wrote:
> On 18.08.2016 17:42, Russell Bryant wrote:
>
>>
>> On Thu, Aug 18, 2016 at 2:30 AM, Valentine Sinitsyn
>> mailto:valentine.sinit...@gmail.com>>
>> wrote:
>>
>> Hi everyone,
>>
>> Russel
On Wed, Aug 17, 2016 at 8:30 AM, Numan Siddique wrote:
> Hi Andy,
> I have started working on integrating ovsdb-server HA support with
> pacemaker (via OCF heartbeat, i.e ocf:heartbeat).
>
Thanks for working on it.
>
> Few comments below.
>
>
>
>>
>> >>> Thanks for helping out.
>> >>>
>> >>> G
On Mon, Aug 15, 2016 at 1:50 PM, Russell Bryant wrote:
>
>
> On Mon, Aug 15, 2016 at 4:45 PM, Andy Zhou wrote:
>
>>
>>
>> On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote:
>>
>>>
>>>
>>> On Mon, Aug 15, 2016 at 2:54 PM, Andy
On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote:
>
>
> On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou wrote:
>
>>
>>
>> On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote:
>>
>>>
>>>
>>> On Tue, Aug 9, 2016 at 7:49 PM, Andy Z
On Sat, Aug 13, 2016 at 5:37 PM, Ben Pfaff wrote:
> Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call
> ovs_list_remove() on the clause's 'node' member, but it should only be
> called once.
>
> Signed-off-by: Ben
On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote:
>
>
> On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou wrote:
>
>> Automatically launch backup server for OVN SB database that replicates
>> all transactions of the active server. This can be handy for
>> expe
On Sat, Aug 13, 2016 at 10:23 PM, Ben Pfaff wrote:
> On Wed, Aug 03, 2016 at 04:57:05PM -0700, Andy Zhou wrote:
> > When ovsdb-sever is running in the backup state, it would be nice to
> > make sure there is no un-intended changes to the backup database.
> >
> > This p
On Sat, Aug 13, 2016 at 10:14 PM, Ben Pfaff wrote:
> On Wed, Aug 03, 2016 at 04:57:04PM -0700, Andy Zhou wrote:
> > Found by inspection
> >
> > Signed-off-by: Andy Zhou
>
> It's not obvious from the context that this can cause a problem, but I
> think it&#x
On Wed, Aug 10, 2016 at 9:51 AM, Ben Pfaff wrote:
> On Tue, Aug 09, 2016 at 12:50:31PM -0700, Andy Zhou wrote:
> > Use ds_get_line() instead of hand rolling it. Rearrange the logic
> > to removes some duplication.
> >
> > Signed-off-by: Andy Zhou
> >
>
Automatically launch backup server for OVN SB database that replicates
all transactions of the active server. This can be handy for
experimenting with the newly added replication feature.
Signed-off-by: Andy Zhou
---
tutorial/ovs-sandbox | 15 +++
1 file changed, 15 insertions
Use ds_get_line() instead of hand rolling it. Rearrange the logic
to removes some duplication.
Signed-off-by: Andy Zhou
---
v1->v2: rebase to current master.
---
utilities/ovs-vsctl.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/utilities/ovs-vsctl.
option.
>
> [1] https://github.com/openvswitch/ovn-scale-test
> [2] https://github.com/openvswitch/ovn-scale-test/
> blob/master/rally_ovs/plugins/ovs/scenarios/ovn.py#L255
>
> Signed-off-by: Kyle Mestery
>
>
Thanks for the v2.
Acked-by: Andy Zhou
Since one aspect of
On Fri, Aug 5, 2016 at 9:08 AM, Daniel Levy wrote:
> Tested this and it works, however it needs a rebase.
>
The rebase may be caused by patches ahead of this one in the series.
Thanks for testing and reporting.
>
> --
> Sincerely,
> Daniel Levy
> ___
xplicitly. This is
> more in line with other test make target ('check',
> 'check-system-userspace').
>
> CC: Andy Zhou
> Signed-off-by: Daniele Di Proietto
> ---
> tests/automake.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
On Thu, Aug 4, 2016 at 11:14 PM, Russell Bryant wrote:
>
>
> On Thu, Aug 4, 2016 at 8:17 PM, Andy Zhou wrote:
>
>>
>> On Wed, Jul 27, 2016 at 1:04 PM, Andy Zhou wrote:
>>
>>>
>>>
>>> On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant
On Wed, Jul 27, 2016 at 1:04 PM, Andy Zhou wrote:
>
>
> On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant wrote:
>
>>
>>
>> On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou wrote:
>>
>>>
>>>
>>> On Tue, Jul 26, 2016 at 11:59 AM, Russell
On Thu, Aug 4, 2016 at 11:39 AM, Kyle Mestery wrote:
> On Thu, Aug 4, 2016 at 12:56 PM, Andy Zhou wrote:
> >
> >
> > On Thu, Aug 4, 2016 at 6:54 AM, Kyle Mestery
> wrote:
> >>
> >> While running the ovn-scale-test [1] port-binding tests [2], I notice a
Use ds_get_line() instead of hand rolling it. Rearrange the logic
to removes some duplication.
Signed-off-by: Andy Zhou
---
utilities/ovs-vsctl.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index
On Thu, Aug 4, 2016 at 6:54 AM, Kyle Mestery wrote:
> While running the ovn-scale-test [1] port-binding tests [2], I notice a
> continual stream of messages such as this:
>
> 2016-08-04 13:05:28.705 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-]
> bind lport_0996bf_cikzNO to sandbox-172.16.200.
-sync-from option.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.1.in | 18 +++
ovsdb/ovsdb-server.c| 58 -
ovsdb/replication.c | 34 ++---
ovsdb/replication.h | 8 +++
tests/ovsdb-server
Pollblock requires the run() function to be paired with a wait()
function. Add one for replication.
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 3 +++
ovsdb/replication.c | 8
ovsdb/replication.h | 1 +
3 files changed, 12 insertions(+)
diff --git a/ovsdb/ovsdb-server.c b
ing client connections will be reset. After reconnect, all
clinet transactions will then be accepted.
Signed-off-by: Andy Zhou
---
manpages.mk | 2 ++
ovsdb/active-backup.man | 14 ++
ovsdb/automake.mk| 1 +
ovsdb/execution.c
Found by inspection
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ovsdb/replication.c b/ovsdb/replication.c
index 19626a5..de6eec1 100644
--- a/ovsdb/replication.c
+++ b/ovsdb/replication.c
@@ -150,6 +150,7 @@ void
On Mon, Aug 1, 2016 at 2:44 PM, Andy Zhou wrote:
>
>
> On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto <
> mario.cabr...@hpe.com> wrote:
>
>> Hi,
>>
>> The replication_init() function initializes the set that contains the
>> names of t
On Mon, Aug 1, 2016 at 10:08 AM, William Tu wrote:
> Thanks, I've submitted v2 which removes the 'const'.
>
LGTM. Pushed to master. Thanks for working on this.
>
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Aug 1, 2016 at 5:00 PM, Andy Zhou wrote:
>
>
> On Mon, Aug 1, 2016 at 2:41 PM, Andy Zhou wrote:
>
>> From: Mario Cabrera
>>
>> Currently disconnecting from the replicator server means closing the
>> jsonrpc
>> connection and destroying the m
On Mon, Aug 1, 2016 at 2:41 PM, Andy Zhou wrote:
> From: Mario Cabrera
>
> Currently disconnecting from the replicator server means closing the
> jsonrpc
> connection and destroying the monitored table names and blacklisted table
> names.
>
> This patch makes a distiti
On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto <
mario.cabr...@hpe.com> wrote:
> Hi,
>
> The replication_init() function initializes the set that contains the
> names of the
> tables to be monitored and the set that contains the names of the tables
> to be
> excluded from replication
From: Mario Cabrera
Currently disconnecting from the replicator server means closing the jsonrpc
connection and destroying the monitored table names and blacklisted table
names.
This patch makes a distition between disconnecting from the remote server,
applicable when the replication incurs in a
On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote:
> The "hacking" plugin for flake8 is not currently compatible with flake8
> 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the
> docs to indicate this incompatibility.
>
> Signed-off-by: Russell
On Wed, Jul 27, 2016 at 12:48 PM, Andy Zhou wrote:
>
>
> On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff wrote:
>
>> On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote:
>> > Release the memory of reply message of the initial "monitor" request.
>>
it removed the memory leak reported.
I think declare 'where' as 'struct json' instead of 'const struct json'
will make the code easier to read.
Acked-by: Andy Zhou
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant wrote:
>
>
> On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou wrote:
>
>>
>>
>> On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote:
>>
>>>
>>>
>>> On Tue, Jul 26, 2016 at 2:41 PM, Andy
On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff wrote:
> On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote:
> > Release the memory of reply message of the initial "monitor" request.
> >
> > Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.ht
zes to 0.
>
Right, I will drop the NULL initializations.
>
> Acked-by: William Tu
>
Thanks for the review. I will push to master in a minute.
>
> On Tue, Jul 26, 2016 at 1:08 PM, Andy Zhou wrote:
> > This patch removes rpc related memory leak reported below.
> >
>
Fix replication test titles to fit changes committed by
63b35ecc06cbd16bc0e93d1e26021d81c413a485.
Signed-off-by: Andy Zhou
---
tests/ovsdb-server.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index e70498d..6c10164 100644
Release the memory of reply message of the initial "monitor" request.
Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html
Signed-off-by: Andy Zhou
---
ovsdb/replication.c | 4
1 file changed, 4 insertions(+)
diff --git a/ovsdb/replication.c b/ovsdb/replicati
This patch removes rpc related memory leak reported below.
Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html
Signed-off-by: Andy Zhou
---
ovsdb/ovsdb-server.c | 1 +
ovsdb/replication.c | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ovsdb/ovsdb
On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote:
>
>
> On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote:
>
>>
>>
>> On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote:
>>
>>>
>>>
>>> On Mon, Jul 25, 2016 at 8:15 PM, Andy
On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote:
>
>
> On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou wrote:
>
>> Hi, Rayn and Russell,
>>
>
> Can we move this discussion to the ovs dev mailing list? Feel free to
> just add it in a reply if you'd like.
On Mon, Jul 25, 2016 at 8:26 AM, William Tu wrote:
> Hi,
>
> Valgrind reports definitely memory leak in the testcase
> 1826: ovsdb-server.at:1081 insert monitored table, update excluded
> table
> Can someone take at look? Thank you~
>
> ==52969== 144 (48 direct, 96 indirect) bytes in 1 blocks
On Fri, Jul 22, 2016 at 5:02 PM, Ben Pfaff wrote:
> On Fri, Jul 22, 2016 at 04:37:52PM -0700, Andy Zhou wrote:
> > The ovsdb replication feature is not specific to the ovsdb socket types.
> > Switching the tests to use Unix domain socket simplifies the tests.
> >
> &g
The ovsdb replication feature is not specific to the ovsdb socket types.
Switching the tests to use Unix domain socket simplifies the tests.
Signed-off-by: Andy Zhou
---
tests/ovsdb-server.at | 70 ++-
1 file changed, 30 insertions(+), 40
1 - 100 of 1579 matches
Mail list logo
