Switch too memmove(RtlMoveMemory) instead of copy and predefined allocated
buffer.
Currently if we receive a pop_vlan action, and the vlan tag is inside the
Ethernet frame(not in the net buffer list information) we change the frame
without checking if the it was a vlan tagged or not.
This patch c
This patch allows online compacting to be done under Windows.
To achieve the above we need to close all file handles before trying to
rename the file, switch from rename to MoveFileEx (because rename/MoveFile
fails if the destination exists), reopen the right type of log after the
rename.
If we c
Skip symlinks checks on Windows.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovsdb-server.at | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index d04941b..df51f80 100644
--- a/tests/ovsdb-server.at
+++ b/tes
Add support for online compacting on Windows.
Also add a unit test for it
Alin Gabriel Serdean (2):
ovsdb windows: Allow online compacting
tests: windows ovsdb online compact
ovsdb/file.c | 56 +++
tests/ovsdb-server.at | 18 +
This patch adds the offline compacting (ovsdb-tool compact) to be run on
Windows.
On Windows we are missing "--run" so in return we start ovsdb-server,
run the ovsdb-client dump command and after issue a command to the
ovsdb-server to close.
Also on Windows we do not check for symlinks, so skip t
ofpbuf_const_initializer takes only two parameters see:
https://github.com/openvswitch/ovs/blob/master/include/openvswitch/ofpbuf.h#L96
the compiler only gives the following warning:
lib/netdev-windows.c(229) : warning C4020: 'ofpbuf_const_initializer' :
too many actual parameters
which in resu
Use bitwise comparison when checking flags set by the kernel for the
device.
Signed-off-by: Alin Gabriel Serdean
---
lib/netdev-windows.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c
index 423a00b..f5e809e 100644
--- a/lib/ne
'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Conntrack.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsex
The purpose of this patch is to make the code more readable and
fix a static analyzer warning.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Geneve.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ov
The purpose of this patch is to make the code more readable and
fix a static analyzer warning.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Gre.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/G
The purpose of this patch is to make the code more readable and
fix a static analyzer warning.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Stt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/S
The purpose of this patch is to make the code more readable and
fix a static analyzer warning.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vxlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovse
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Wednesday, October 19, 2016 11:50 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] dpif-netdev: Fix windows build.
>
> OVS_ALIGNED_VAR(
OpenSSL version changed from 1.0.2h to 1.0.2j.
This patch bumps the version for the appveyor config.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 0fd003b..8a6694b 100644
--- a/app
On Windows we do not register "tap" as an interface type since it is not
supported.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovn-controller.at | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at
index 00ee482..b1211a5 10
This patch updates the ovsdb monitor tests to use it.
The --detach argument is needed to make the unixctl for the ovsdb-client,
to send commands.
Fixes hanging test:
1889: monitor-cond-change
Signed-off-by: Alin Gabriel Serdean
---
v2: Reduce the scope of --detach. Test several times to make su
Please disregard this patch I'll post a new series.
> -Original Message-
> From: Alin Serdean
> Sent: Wednesday, September 21, 2016 12:08 AM
> To: dev@openvswitch.org
> Cc: Alin Serdean
> Subject: [PATCH 3/5] datapath-windows: read overrun in gre.c
>
&
Please disregard this patch I'll post a new series.
> -Original Message-
> From: Alin Serdean
> Sent: Wednesday, September 21, 2016 12:07 AM
> To: dev@openvswitch.org
> Cc: Alin Serdean
> Subject: [PATCH 1/5] datapath-windows: read overrun in vxlan.c
>
&
Please disregard this patch I'll post a new series.
> -Original Message-
> From: Alin Serdean
> Sent: Wednesday, September 21, 2016 12:08 AM
> To: dev@openvswitch.org
> Cc: Alin Serdean
> Subject: [PATCH 2/5] datapath-windows: read overrun in stt.c
>
&
Please disregard this patch I'll post a new series.
> -Original Message-
> From: Alin Serdean
> Sent: Wednesday, September 21, 2016 12:08 AM
> To: dev@openvswitch.org
> Cc: Alin Serdean
> Subject: [PATCH 4/5] datapath-windows: read overrun in geneve.c
>
&
'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Conntrack.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsex
Fix possible read overrun.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Geneve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c
index 5712e4d..65e547f 100644
--- a/datapath-windows/ovsext/
Fix possible read overrun.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Stt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c
index ad322d2..cc0f912 100644
--- a/datapath-windows/ovsext/Stt.c
+++
Fix possible read overrun.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c
index 1976b08..a0c953b 100644
--- a/datapath-windows/ovsext/Gre.c
+++
Fix possible read overrun.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovsext/Vxlan.c
index ddd8d8e..8a681a9 100644
--- a/datapath-windows/ovsext/Vxl
Until the effort of the python series is integrated, disable the python3
tests under Windows.
Signed-off-by: Alin Gabriel Serdean
---
tests/atlocal.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 55070d8..f518cda 100644
--- a/tests/atlocal.in
+++
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, September 16, 2016 3:51 AM
> To: Alin Serdean
> Cc: Andy Zhou ;
>
> Subject: Re: [ovs-dev] [PATCH] replication: Be more careful about JSON
> parsing and simplify code.
>
> I
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
ovsdb/monitor.c | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
index 5e3c847..a590943 100644
--- a/ovsdb/monitor.c
+++ b/ovsdb/
Sorry to bump on this problem again, but the issue reproduces from time to time
while testing under windows.
Applying (http://openvswitch.org/pipermail/dev/2016-September/079315.html)
would fix the symptom.
STACK_TEXT:
00c0`e63cf680 7ff7`f9306607 : 0264`7e439f00 `
Windows allows '--detach' argument to be used.
This patch updates the ovsdb monitor tests to use it.
Fixes hanging test:
1889: monitor-cond-change
Signed-off-by: Alin Gabriel Serdean
---
tests/ovsdb-monitor.at | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
On Windows we require service_start to be called to parse and setup
requirements for '--detach' argument.
Affected binaries: ovn-trace, ovsdb-client, ovs-testcontroller.
Subsequent patches will be sent to adapt the tests with the new features.
Signed-off-by: Alin Gabriel Serdean
---
ovn/utiliti
On the Windows side we still have to integrate multiple internal/external
ports. As it was discussed before, I was wondering if they could be integrated
in 2.6.
Thanks,
Alin.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/list
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, August 26, 2016 6:54 PM
> To: Alin Serdean
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] Windows: Allow online compacting
>
> On Fri, Aug 12, 2016 at 07:39:32AM +, Alin
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
Acked-by: Paul Boca
---
v5: Rebase
v4: Address comments (fix aligment, switch go
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v5: Rebase
v4: Address comments
v3: Add acked
v2: Rebase
---
INSTALL.Windows.
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
Acked-by: Alin Gabriel Serdean
Thanks,
Alin.
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam
> Venugopal
> Sent: Tuesday, September 13, 2016 12:47 AM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2] Windows: Update the Driver and MSI
> p
Thanks a lot for the patch.
All in all the patch looks good. Just please move informations to Product.wxs
(i.e.
https://github.com/cloudbase/openvswitch-hyperv-installer/commit/4a0a0b90d278d4e11e84d8f83ff28ff58ae0934f).
> +
> +
Are not needed. We already check for windows version whe
gt;
> >> Signed-off-by: Paul-Daniel Boca
> >>
> > Applied, thank you.
>
> Does this need to be applied to branch-2.6 as well?
[Alin Serdean] Yes, please.
> ___
> dev mailing list
> dev@openvswitch.org
> h
"error C2233: 'specs' : arrays of objects containing zero-size arrays are
illegal"
https://ci.appveyor.com/project/blp/ovs
I think it was caused by commit:
https://github.com/openvswitch/ovs/commit/dfe191d5faa60d34a64e3bd1040fd6fa02b4889c
___
dev mail
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca
> Sent: Monday, August 29, 2016 10:11 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in
> conntrack
>
> In
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
> Sent: Thursday, September 1, 2016 9:45 AM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2] datapath-windows: add assert in
> OvsHashFlow()
>
> Signed
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Anand
> Kumar
> Sent: Wednesday, August 31, 2016 11:33 PM
> To: dev@openvswitch.org
> Cc: Anand Kumar
> Subject: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel
>
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v4: Address comments
v3: Add acked
v2: Rebase
---
INSTALL.Windows.md | 143 ++
removed in next version.
>+switchContext->countInternalVports--;
Sai - Is this ASSERT really necessary?
Alin - yes, the assert is needed for roleover
>+ASSERT(switchContext->countInternalVports >= 0);
>+OvsInternalAdapterDown(vport->portNo,
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v4: Address comments
v3: Add acked
v2: Rebase
---
INSTALL.Windows.md | 143 ++
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
Hi Sai,
Thanks a lot for the review!
Comments inlined.
Alin.
> -Original Message-
> From: Sairam Venugopal [mailto:vsai...@vmware.com]
> Sent: Wednesday, August 10, 2016 1:16 AM
> To: Alin Serdean ;
> dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 2/3] dat
Sorry I forgot about it!
Thanks for the review I will respin the patch and add you as co-author.
Thanks,
Alin.
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 12, 2016 7:59 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] Windows: Report absolute file name
On
Thanks for the review.
Comments inlined.
Alin.
-Original Message-
From: Sairam Venugopal [mailto:vsai...@vmware.com]
Sent: Friday, August 12, 2016 7:46 PM
To: Alin Serdean ; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] stream-windows: Disconnect faulty named pipes
Hi Alin,
How
Disconnect named pipes that failed connection.
Found by testing.
Signed-off-by: Alin Gabriel Serdean
---
lib/stream-windows.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/stream-windows.c b/lib/stream-windows.c
index e0fe012..637920b 100644
--- a/lib/stream-windows.c
+++ b/lib/stre
On Windows if a file path contains ":" we can safely say it is an absolute
file name.
This patch allows file_name checks to report correctly when using
"abs_file_name".
Found by testing.
Signed-off-by: Alin Gabriel Serdean
---
lib/util.c | 4
1 file changed, 4 insertions(+)
diff --git a/
This patch allows online compacting to be done under Windows.
To achieve the above we need to close all file handles before trying to
rename the file, switch from rename to MoveFileEx (because rename/MoveFile
fails if the destination exists), reopen the right type of log after the
rename.
Signed-
> > While it's an alternative, I feel like going down that path is hasty
> > and for my use case I will probably just patch our local fork of
> > OpenvSwitch.
> >
> > Why so hostile towards this change? Is there a better forum I can
> > explain why I believe this problem should be reconsidered?
>
> > Is there really anyone that can justify the way socket paths are
> > created should contain the PID? You clearly saw the problem with it in
> > the Windows code base, but yet pushed on to keep it in the Linux one.
> > I simply do not see why you're not taking this patch as a way to
> > encourag
Hi Sai,
Thanks for the update!
Comments inlined.
Thanks,
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Saturday, August 6, 2016 12:46 AM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v3 2/3
Thanks!
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Wednesday, August 3, 2016 5:27 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v7] Windows: Local named pipe implementation
On 2 August 2016 at 11:19, Alin Serdean
mailto:aserd...@cloudbasesolutions.com
Thanks for the review! I agree with the comments and will update the
documentation/respin a new series once the Patch 2/3 is reviewed.
Thanks,
Alin.
> Sai:
[Alin Gabriel Serdean: ] Did you also have a comment here?
> >+In our example, this is how Œovs-vsctl show¹ looks like with the NICs
> >sep
+Ben +Guru
Thanks a lot for the review!
To be short the subject of interest is the sanitization of the input during
queries.
You need to have root access or know how the remote management was created and
have access to it, thus you could do worse things.
WQL is based on DMTF(https://www.dmtf.
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
Acked-by: Paul Boca
---
v3: Add acked
v2: Rebase
---
datapath-windows/ovsext/Ac
This patch updates the documentation on how to set up OVS with multiple
NICs.
Also update the documentation to show users how new internal ports are
created
Signed-off-by: Alin Gabriel Serdean
Acked-by: Paul Boca
---
v3: Add acked
v2: Rebase
---
---
INSTALL.Windows.md | 143 +++
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
1161. ofproto-dpif.at:8585: testing ofproto-dpif - conntrack - ct_label
datapath flow ...
./ofproto-dpif.at:8586: ovsdb-tool create conf.db
$abs_top_srcdir/vswitchd/vswitch.ovsschema
./ofproto-dpif.at:8586: ovsdb-server --detach --no-chdir --pidfile --log-file
--remote=punix:$OVS_RUNDIR/db.sock
Error log:
1153. ofproto-dpif.at:8215: testing ofproto-dpif - conntrack - output action ...
./ofproto-dpif.at:8216: ovsdb-tool create conf.db
$abs_top_srcdir/vswitchd/vswitch.ovsschema
./ofproto-dpif.at:8216: ovsdb-server --detach --no-chdir --pidfile --log-file
--remote=punix:$OVS_RUNDIR/db.soc
De la: Guru Shetty [mailto:g...@ovn.org]
Trimis: Thursday, July 28, 2016 7:41 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v4] Windows: Local named pipe implementation
On 26 July 2016 at 12:57, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>>
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
FYI
> -Mesaj original-
> De la: Ben Pfaff [mailto:b...@ovn.org]
> Trimis: Friday, July 29, 2016 11:53 PM
> Către: Alin Serdean
> Cc: Guru Shetty ; Sairam Venugopal
> ; Nithin Raju ; Justin Pettit
> ; Alessandro Pilotti
> Subiect: Re: OVS branching 2.6
>
>
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
This patch adds multiple internal ports support to the windows datapath.
All tunnels types have been updated to accommodate this new functionality.
Signed-off-by: Alin Gabriel Serdean
Co-authored-by: Sorin Vinturis
---
v2: Rebase
---
datapath-windows/ovsext/Actions.c | 41 +-
datapath-windows
When an OID for an exeternal NIC create is done first try to find it
by its friendly name.
Also when an OID NIC delete is requested only remove it from the hyper-v
hash array not from both.
Some parts of the code have been cleaned since they are not used anymore.
Signed-off-by: Alin Gabriel Serde
This patch updates the documentation in how to set up OVS with multiple
NICs.
Signed-off-by: Alin Gabriel Serdean
---
v2: Rebase
---
INSTALL.Windows.md | 70 +++---
1 file changed, 67 insertions(+), 3 deletions(-)
diff --git a/INSTALL.Windows.md b
This patch updates the following commands in the vswitch:
ovs-vsctl add-br br-test
ovs-vsctl del-br br-test
ovs-vsctl add-br br-test:
This command will now create an internal port on the MSFT virtual switch
using the WMI interface from Msvm_VirtualEthernetSwitchManagementService
leveraging
s not enforce a safe read for
> gOvsSwitchContext->dpNo. Use the gOvsSwitchContext->dispatchLock for
> accessing the parameter.
>
> v2: Address review comments from Alin Serdean and Yin Lin (around keeping
> OvsGetOpenInstance safe).
>
> Signed-off-by: Sairam Venugopal
> -
> -Mesaj original-
> De la: Alin Serdean
> Trimis: Tuesday, July 26, 2016 4:08 PM
> Către: 'Sairam Venugopal' ; dev@openvswitch.org
> Subiect: RE: [ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for
> multiple event queue in Event.c
>
> I wanted
I wanted to ask you about OvsWaitEventIoctl lock but you fixed in 5/7
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Tuesday, July 26, 2016 3:05 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev
existing
> workflow.
>
> v2: Address review comments from Alin Serdean (Not default values to 0 and
> instead read from msgIn). Added Acked-By
>
> Signed-off-by: Sairam Venugopal
> Acked-by: Paul Boca
> ---
> datapath-windows/ovsext/Datapath.c | 66
> ++
gt; subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and
> store it as part of OVS_EVENT_SUBSCRIBE structure.
>
> v2: Squashed patches 2/9 and 5/9 into one. Addressed review comments
> from Yin Lin and Alin Serdean
>
> Signed-off-by: Sairam Venugopal
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:03 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to
> Windows
>
> Used su
LGTM.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:03 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python
> daemon on Window
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Tuesday, July 26, 2016 3:01 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable
> on Windows
>
> O
_get_osfhandle returns an errno value not a GetLastErrorValue.
(https://msdn.microsoft.com/en-us/library/ks2530z6(v=vs.120).aspx)
Signed-off-by: Alin Gabriel Serdean
---
lib/daemon-windows.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/daemon-windows.c b/lib/daemon-win
gt; De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Monday, July 25, 2016 11:19 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for
> multiple event queue in Event.c
>
> I added the
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
This patch drops the TCP so
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Thursday, July 21, 2016 9:52 PM
> Către: Alin Serdean ; Yin Lin
>
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c
> around su
Just one comment inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 8/9] datapath-windows: Update
> OvsReadEventCmdHandler in Datapath.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack delete
> and new event
Looks good. Just a few questions from my side so I get up to speed with the
changes in events.
Why do we need a lock per eventid ?
> +typedef struct _OVS_CT_EVENT_ENTRY {
> +OVS_CT_ENTRY entry;
> +UINT8 type;
> +UINT64 pad[10];
> +} OVS_CT_EVENT_ENTRY, *POVS_CT_EVENT_ENTRY;
Why such
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 6/9] datapath-windows: Modify
> OvsCreateNlMsgFromCtEntry to
It looks like a mistake was done when setting them up, don't know if it such a
good idea to propagate it.
Thanks,
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Friday, July 22, 2016 11:15 PM
> Către: Alin Serdean ;
>
Looks good just one question inlined.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast
> conntrack
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 3/9] datapath-windows: Explicitly name vport
> related event
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 2/9] datapath-windows: Add supported netlink
> family protoc
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, July 14, 2016 2:39 AM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH 1/9] datapath-windows: Rename
> OVS_EVENT_ENTRY to OVS_VPORT
I would prefer if you did the squash because it makes it easier to revert/look
over later on.
I will review the patches as is.
Thanks,
Alin.
> -Mesaj original-
> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
> Trimis: Thursday, July 21, 2016 9:19 PM
> Către: Alin Ser
k specific to
> gOvsSwitchContext inside OvsGetOpenInstance() and not rely on
> EventQueue lock to enforce it.
>
> Thanks,
> Sairam
>
>
>
>
> On 7/21/16, 6:58 AM, "Alin Serdean"
> wrote:
>
> >> -Mesaj original-
> >
> >
Către: Alin Serdean
Cc: Yin Lin ; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs
Hi Alin,
I know this can be confusing but after a second thought I think mine is
correct. Your suggestion is equivalent to (abbreviated):
!(port == geneve && port =
@Guru, @Ben what do you suggest?
> -Mesaj original-
> De la: Paul Boca
> Trimis: Thursday, July 21, 2016 7:36 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [ovs-dev] [PATCH V7 12/16] python tests: Ported Python
> daemon to Windows
>
> Hi Alin
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean
> Trimis: Thursday, July 21, 2016 4:30 PM
> Către: Yin Lin ; dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs
>
> Hi Yin,
>
1 - 100 of 799 matches
Mail list logo
