On Mon, May 19, 2014 at 11:14 PM, Ben Pfaff wrote:
> On Fri, May 09, 2014 at 07:35:21PM +0300, Alexandru Copot wrote:
>> On Fri, May 9, 2014 at 6:42 PM, Ben Pfaff wrote:
>> > On Tue, May 06, 2014 at 09:28:29PM +0300, Alexandru Copot wrote:
>> >> Allow port_mod messa
On Tue, May 13, 2014 at 9:55 AM, Alexandru Copot wrote:
> On Tue, May 13, 2014 at 4:18 AM, Ben Pfaff wrote:
>> On Sun, May 11, 2014 at 09:39:32PM +0300, Alexandru Copot wrote:
>>> On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff wrote:
>>> > Signed-off-by: Ben Pfaff
&g
On Tue, May 13, 2014 at 4:18 AM, Ben Pfaff wrote:
> On Sun, May 11, 2014 at 09:39:32PM +0300, Alexandru Copot wrote:
>> On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff wrote:
>> > Signed-off-by: Ben Pfaff
>>
>> >
>> > diff --git a/lib/ofp-msgs.h b/lib/ofp
On Sat, May 10, 2014 at 5:40 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
>
> diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
> index df7569e..b548f6b 100644
> --- a/lib/ofp-msgs.h
> +++ b/lib/ofp-msgs.h
> @@ -162,8 +162,10 @@ enum ofpraw {
>
> /* OFPT 1.0 (12): struct ofp_port_status, stru
On Fri, May 9, 2014 at 6:42 PM, Ben Pfaff wrote:
> On Tue, May 06, 2014 at 09:28:29PM +0300, Alexandru Copot wrote:
>> Allow port_mod messages in a bundle and apply them to copies
>> of struct ofport. The final state is commited to the original
>> data structure and n
On Thu, May 8, 2014 at 9:56 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> build-aux/extract-ofp-msgs | 1 +
> include/openflow/openflow-1.4.h| 41 +++-
> include/openflow/openflow-common.h | 3 +-
> lib/ofp-msgs.h | 14 ++--
> lib/ofp-util.
This function is needed by the OF1.4 bundles.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/ofproto.c | 2 +-
ofproto/ofproto.h | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index cf3f271..6b25b9b 100644
--- a
Allow port_mod messages in a bundle and apply them to copies
of struct ofport. The final state is commited to the original
data structure and notifications are sent.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/bundles.c | 189
This will be later used by OF1.4 bundles to check added messages.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/ofproto.c | 33 +++--
ofproto/ofproto.h | 5 +
2 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/ofproto/ofproto.c b
These tests verify that echo requests and barriers are
processed when bundles are open, while queuing other
messages for later processing.
The port_mod tests verify that changes to ports are correctly
reflected after applying bundles.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
tests
When at least one OF1.4 bundle is open, only bundle related
messages are processed by the switch. The rest are queued and
processed after the bundles are done.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/connmgr.c | 124 ++
1
f a single bundle at a time.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
Alexandru Copot (5):
ofproto: Refactor handle_port_mod() by extracting validity check
ofproto: Export update_port_config() for future use
ofproto/bundles: Use staging area for port_mod messages
ofproto/conn
This is only the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
We also enable OF1.4 for all the tests.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v6:
* return error code for invalid inner message size
v5
This is only the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
We also enable OF1.4 for all the tests.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v5:
* fold tests patch
* add ofputil_encode_bundle_add
Also fix some tests that can now properly print packets
with the new protocol version.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/ofp-print.c| 3 +++
tests/ofp-print.at | 6 +++---
tests/ofp-util.at | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib
This is only the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
Signed-off-by: Alexandru Copot
---
v4:
* adjust copyright
* fix style issues
* remove all locking
* delete bundles in ofconn_destroy()
v3:
* rebase
Also fix some tests that can now properly print packets
with the new protocol version.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v4: moved version print change here
---
lib/ofp-print.c| 3 +++
tests/ofp-print.at | 6 +++---
tests/ofp-util.at | 2 +-
3 files changed, 7
This is only the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v4:
* adjust copyright
* fix style issues
* remove locking in ofconn
* delete bundles in
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v4: rebase
v3: small fix
v2: rebase
---
tests/ofp-print.at | 125 ++
tests/ofproto-macros.at | 4 +-
tests/ofproto.at| 234
3 files changed, 361
This series adds the basic communication handlers for the bundles
functionality. The actual message pre-validation and commits are
not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
Alexandru Copot (3):
Add basic implementation for OpenFlow 1.4 bundles
tests: add some
Thanks a lot for the feedback. You can find my answers inline.
We will get back with v4 asap.
On Thu, Apr 10, 2014 at 9:38 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:29AM +0300, Alexandru Copot wrote:
>> This is only the communication part of the bundles functionality.
>
On Thu, Apr 10, 2014 at 10:19 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:31AM +0300, Alexandru Copot wrote:
>> These tests can now properly print packets with the new protocol version.
>>
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel Baluta
>
> I gu
On Thu, Apr 10, 2014 at 9:41 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:30AM +0300, Alexandru Copot wrote:
>> This also enables OF1.4 for all the tests.
>>
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel Baluta
>
> It's good as far as it goes,
This is only the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v3:
* rebase
* adjusted to use ofpbuf_l3()
* bug fixes
v2: rebase
---
lib/learning-switch.c | 2
These tests can now properly print packets with the new protocol version.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
tests/ofp-print.at | 6 +++---
tests/ofp-util.at | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index
This also enables OF1.4 for all the tests.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
v3: small fix
v2: rebase
---
tests/ofp-print.at | 125 ++
tests/ofproto-macros.at | 4 +-
tests/ofproto.at| 234
This series adds the basic communication handlers for the bundles
functionality. The actual message pre-validation and commits are
not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
Alexandru Copot (3):
Add basic implementation for OpenFlow 1.4 bundles
tests: add some
On Mar 28, 2014 11:27 PM, "Ben Pfaff" wrote:
>
> On Fri, Mar 28, 2014 at 09:24:42PM +0200, Alexandru Copot wrote:
> > On Wed, Mar 26, 2014 at 7:11 AM, Ben Pfaff wrote:
> >
> > > OpenFlow 1.4 Role Status Message
> > > -
On Wed, Mar 26, 2014 at 7:11 AM, Ben Pfaff wrote:
> OpenFlow 1.4 Role Status Message
>
>
> OpenFlow 1.4 section 7.4.4 ``Controller Role Status Message''
> defines a new message sent by a switch to notify the controller that
> its role (whether it is a master or a
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
Changes since v1:
* rebase
* add "--enable-of14" to OVS_VSWITCHD_START
---
tests/ofp-print.at | 124 +
tests/ofproto-macros.at | 4 +-
tests/ofproto.at
This patch implements the communication part of the bundles functionality.
The actual message pre-validation and commits are not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
Changes since v1: rebase
---
lib/learning-switch.c | 2 +
lib/ofp-errors.h | 52
These tests can now properly print packets with the new protocol version.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
Changes since v1: rebase
---
tests/ofp-print.at | 6 +++---
tests/ofp-util.at | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/ofp
This series adds the basic communication handlers for the bundles
functionality. The actual message pre-validation and commits are
not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
Alexandru Copot (3):
Add basic implementation for OpenFlow 1.4 bundles
tests: add OpenFlow
On Sun, Mar 23, 2014 at 11:58 PM, Ben Pfaff wrote:
> I decided that the best thing to do here was to do it myself, so I
> committed your patch 1/5 (with a few adjustments) followed by a patch
> that disables OF1.4 unless one specifies --enable-of14 on the
> ovs-vswitchd command line. This should
On Tue, Mar 18, 2014 at 12:07 AM, Ben Pfaff wrote:
>> >
>> > The one bit that I'm concerned about is that it allows OpenFlow 1.4 to
>> > be enabled even though there are unimplemented messages that will cause
>> > Open vSwitch to abort if ovs-vswitchd receives one.
>>
>> This was my concern too af
On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff wrote:
> On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote:
>> This defines the version number for OpenFlow 1.4 so that the switch
>> can actually use it. The ovsdb schema is also modified.
>>
>> Signed-off
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
include/openflow/openflow-1.4.h | 45 +
1 file changed, 45 insertions(+)
diff --git a/include/openflow/openflow-1.4.h b/include/openflow/openflow-1.4.h
index 332a0d3..f012e25 100644
--- a/include
On Mon, Mar 3, 2014 at 11:52 PM, Ben Pfaff wrote:
> On Mon, Mar 03, 2014 at 11:51:48PM +0200, Alexandru Copot wrote:
>> On Mon, Mar 3, 2014 at 11:00 PM, Ben Pfaff wrote:
>> > The above data structure isn't needed; OVS already handles experimenter
>> > error cod
On Mon, Mar 3, 2014 at 11:00 PM, Ben Pfaff wrote:
> The above data structure isn't needed; OVS already handles experimenter
> error codes through infrastructure in ofp-error.h. You can update that
> file with any new error types or codes.
>
> The various generic "property" definitions here have t
This series adds the basic communication handlers for the bundles
functionality. The actual message pre-validation and commits are
not implemented.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
Alexandru Copot (5):
openflow-1.4.h: Add bundle structure definitions
ofproto: Allow the use
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
include/openflow/openflow-1.4.h | 114
1 file changed, 114 insertions(+)
diff --git a/include/openflow/openflow-1.4.h b/include/openflow/openflow-1.4.h
index 332a0d3..a6645b9 100644
--- a/include
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
tests/ofp-print.at | 124 +
tests/ofproto-macros.at | 2 +-
tests/ofproto.at| 234
3 files changed, 359 insertions(+), 1 deletion(-)
diff --git a/tests
This defines the version number for OpenFlow 1.4 so that the switch
can actually use it. The ovsdb schema is also modified.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
build-aux/extract-ofp-errors | 3 +-
build-aux/extract-ofp-msgs | 8 +--
include/openflow/openflow
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/learning-switch.c | 2 +
lib/ofp-errors.h | 52 +++
lib/ofp-msgs.h| 10 ++
lib/ofp-print.c | 95 +++
lib/ofp-util.c| 57
lib/ofp-util.h| 20
lib/rconn.c
These tests can now properly print packets with the new protocol version.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
tests/ofp-errors.at | 2 ++
tests/ofp-print.at | 6 +++---
tests/ofp-util.at | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/ofp
Hello,
I want to announce that I want to work on the bundles feature for OpenFlow 1.4.
This way we can avoid duplicating the effort.
Most of the bundle features are easy to implement so this is what I am going to
do first. However, the actual commit of the messages will be a challenge. I am
think
Signed-off-by: Alexandru Copot
---
ovsdb/ovsdb-tool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
index 11e61e6..5e2b71b 100644
--- a/ovsdb/ovsdb-tool.c
+++ b/ovsdb/ovsdb-tool.c
@@ -524,7 +524,7 @@ do_show_log(int argc, char *argv
It contains only Set-Async-Config and Role status message definitions.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
The OFPACPT_ and OFPTFPT_ are still named like this. It's the
way they are defined in the header file in the specification.
build-aux/extract-ofp-msgs
length arrays from messages and
added comments for them
- refactored parts of ofp_print_role_message()
- added ofp-print.at test
- sparse fixes
Alexandru Copot (2):
include/openflow: Add OpenFlow 1.4 header file
add support for sending OFPTYPE_ROLE_STATUS messages
build-aux/extract-ofp-msgs
When a controller changes its role to MASTER, the others are marked
as SLAVE. This patch makes it possible to notify the controllers
of this change.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
include/openflow/openflow-1.4.h | 3 +-
lib/ofp-print.c | 65
On Wed, Oct 9, 2013 at 12:31 AM, Ben Pfaff wrote:
> Thank you for the contribution.
>
> My only overall comment is that this series seems to be broken up into
> too many patches. I think that it's logically a one or two patch
> series.
Thank you for the feedback. I will try to address all the is
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/ofp-util.c | 27 +++
lib/ofp-util.h | 2 ++
2 files changed, 29 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 9bc30a7..cdc9f16 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3923,6
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/ofp-util.c | 17 +
lib/ofp-util.h | 10 ++
2 files changed, 27 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 173b534..9bc30a7 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3906,6 +3906,23
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/learning-switch.c | 1 +
lib/ofp-msgs.h| 6 ++
lib/ofp-print.c | 2 ++
lib/rconn.c | 1 +
ofproto/ofproto.c | 1 +
5 files changed, 11 insertions(+)
diff --git a/lib/learning-switch.c b/lib/learning
It contains only Set-Async-Config and Role status message definitions.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
build-aux/extract-ofp-msgs | 3 +
include/openflow/automake.mk| 4 +
include/openflow/openflow-1.4.h | 163
include
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/ofp-print.c | 51 +++
1 file changed, 51 insertions(+)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 0feabe1..1894778 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -1886,6
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/connmgr.c | 15 +++
ofproto/connmgr.h | 2 ++
2 files changed, 17 insertions(+)
diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
index 8a4195d..0a21b3d 100644
--- a/ofproto/connmgr.c
+++ b/ofproto/connmgr.c
@@ -864,6
This series adds the required functionality for notifying controllers
with the OFPT_ROLE_STATUS message introduced in OpenFlow 1.4.
Currently, this message is sent only when another controller asks
that his role is changed to master.
Alexandru Copot (6):
include/openflow: Add OpenFlow 1.4
On Sat, Sep 7, 2013 at 7:54 PM, Ben Pfaff wrote:
> On Sat, Sep 07, 2013 at 03:36:21PM +0300, Alexandru Copot wrote:
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel Baluta
>
> "sparse" reported that the byte order conversions were reversed, so I
> folded this in
This only checks the default settings.
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
tests/ofproto.at | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 38bfb02..44f81b8 100644
--- a/tests/ofproto.at
+++ b
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
lib/ofp-print.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 518f9af..b280a37 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -2374,8 +2374,6 @@ ofp_to_string__(const
Signed-off-by: Alexandru Copot
Cc: Daniel Baluta
---
ofproto/connmgr.c | 9 +
ofproto/connmgr.h | 3 +++
ofproto/ofproto.c | 29 -
3 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
index 1e9ef5b..2f315e6
This series adds a handler for OFPT_GET_ASYNC_REQUEST which
sends an OFPT_GET_ASYNC_REPLY with the configured settings.
It also allows printing reply messages with the existing code
used for OFPT_SET_ASYNC.
Finally, there is a basic test which checks the default reply output.
Alexandru Copot (3
Signed-off-by: Alexandru Copot
---
lib/dpif-netdev.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 46eb743..0d489ba 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -407,6 +407,7 @@ do_add_port(struct dp_netdev
This series fixes a behaviour found in a comment in dpif-netdev.c
by rejecting loopback devices when trying to add them as a port.
Alexandru Copot (2):
netdev: update IFF_LOOPBACK flag for linux and bsd devices
dpif-netdev: Do not allow adding loopback devices
lib/dpif-netdev.c | 9
Signed-off-by: Alexandru Copot
---
lib/netdev-bsd.c | 6 ++
lib/netdev-linux.c | 6 ++
2 files changed, 12 insertions(+)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index fdea10b..3eb29ea 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -1428,6 +1428,9 @@ nd_to_iff_flags
On Fri, Aug 30, 2013 at 7:10 PM, Ben Pfaff wrote:
> [redirecting to ovs-dev]
>> > * OFPT_FLOW_MOD ability to delete flows in all tables.
>> I would like to do this.
>
> Thanks!
I would like to work on event filtering (OFPT_SET_ASYNC). However, it seems that
OFPT_SET_ASYNC is already implemented
67 matches
Mail list logo
