Re: [ovs-dev] [PATCH] move ovn/lib/.h to include/ovn

On Mon, Jul 25, 2016 at 3:04 PM, Aaron Rosen wrote: > This patch is done to enable in tree building of the ovn-utils python > wrapper. This is similar to what was done in: > ee89ea7b477bb4fd05137de03b2e8443807ed9f4 > > Signed-off-by: Aaron Rosen > --- > include/automa

Re: [ovs-dev] [PATCH v4] ovn: expose c validator to python

Note: this patch is rebased on top of : [PATCH] move ovn/lib/.h to include/ovn On Mon, Jul 25, 2016 at 3:07 PM, Aaron Rosen wrote: > This patch exposes the c function expr_parse_string() to be called via > python. The motivation for this is so that clients interfacing with > ovn can

[ovs-dev] [PATCH v4] ovn: expose c validator to python

unnoticed due to the client writing invalid data. This should hopefully help catch errors like this earlier as it can now be detected on the client side and an error can be raised. Signed-off-by: Aaron Rosen --- include/ovn/expr.h | 1 + ovn/lib/expr.c | 107

[ovs-dev] [PATCH] move ovn/lib/.h to include/ovn

This patch is done to enable in tree building of the ovn-utils python wrapper. This is similar to what was done in: ee89ea7b477bb4fd05137de03b2e8443807ed9f4 Signed-off-by: Aaron Rosen --- include/automake.mk | 1 + include/ovn/actions.h | 141 include/ovn

Re: [ovs-dev] [PATCH 0/2] Python JSON parser improvements

I'm facing this same issue with the _ovn-utils.c Python C extension patch I posted. If this gets approved I believe I need to so the same thing for the following files: ovn/lib/actions.h ovn/lib/expr.h ovn/lib/lex.h On Tue, Jul 12, 2016 at 2:37 PM, Terry Wilson wrote: > These patches should ad

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

Yea I totally agree. In the latest patch I sent out it skips these tests if the user doesn't have the ovs python lib installed. I'll try and see what I can do to fix this. On Wed, Jul 13, 2016 at 10:56 AM, Ben Pfaff wrote: > On Mon, Jul 04, 2016 at 12:17:54PM -0700, Aaron Rosen

Re: [ovs-dev] [PATCH v3] ovn: expose c validator to python

can get everything running/install from tree. - rebase and update code Thanks, Aaron On Tue, Jul 5, 2016 at 1:32 PM, Aaron Rosen wrote: > This patch exposes the c function expr_parse_string() to be called via > python. The motivation for this is so that clients interfacing with >

[ovs-dev] [PATCH v3] ovn: expose c validator to python

This patch exposes the c function expr_parse_string() to be called via python. The motivation for this is so that clients interfacing with ovn can call this method in order to validate the data they are writting to ovn. Previously, there were several bugs in the neutron/ovn integration that went u

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

Thanks for the review. Response inline On Sun, Jul 3, 2016 at 12:04 PM, Ben Pfaff wrote: > On Thu, Jun 30, 2016 at 02:27:19PM -0700, Aaron Rosen wrote: > > This patch exposes the c function expr_parse_string() to be called via > > python. The motivation for this is so that clie

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

Yea sorry about that. I'll try and make sure I do that next time around. Aaron On Fri, Jul 1, 2016 at 7:39 AM, Ryan Moats wrote: > "dev" wrote on 06/30/2016 04:27:19 PM: > > > From: Aaron Rosen > > To: dev@openvswitch.org > > Cc: Aaron Rosen > >

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

aron On Thu, Jun 30, 2016 at 2:27 PM, Aaron Rosen wrote: > This patch exposes the c function expr_parse_string() to be called via > python. The motivation for this is so that clients interfacing with > ovn can call this method in order to validate the data they are writting > to ovn.

[ovs-dev] [PATCH] ovn: expose c validator to python

This patch exposes the c function expr_parse_string() to be called via python. The motivation for this is so that clients interfacing with ovn can call this method in order to validate the data they are writting to ovn. Previously, there were several bugs in the neutron/ovn integration that went u

Re: [ovs-dev] [PATCH] update .gitignore files for debian build artifacts

, Jun 22, 2016 at 1:04 PM, Aaron Rosen wrote: > After running: `fakeroot debian/rules binary` > > These files are left uncommitted to the source tree and should be ignored. > > Signed-off-by: Aaron Rosen > --- > .gitignore| 1 + > debian/.gitignore | 3 +++ >

[ovs-dev] [PATCH] update .gitignore files for debian build artifacts

After running: `fakeroot debian/rules binary` These files are left uncommitted to the source tree and should be ignored. Signed-off-by: Aaron Rosen --- .gitignore| 1 + debian/.gitignore | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 077a178

Re: [ovs-dev] [PATCH] ovn: expose c validator to python

think I should be able to sort through this though. Aaron On Mon, Jun 20, 2016 at 1:12 PM, Aaron Rosen wrote: > This patch exposes the c function expr_parse_string() to be called via > python. The motivation for this is so that clients interfacing with > ovn can call this method

[ovs-dev] [PATCH] ovn: expose c validator to python

unnoticed due to the client writing invalid data. This should hopefully help catch errors like this earlier as it can now be detected on the client side and an error can be raised. Signed-off-by: Aaron Rosen --- ovn/lib/actions.c | 106 ovn

[ovs-dev] [PATCH] Fix python 3 errors in ovs-bugtool.in

The patch b00bdc728e7a0ae697b4fc59a4f9958b688c6789 enabled flake8-checking to be run on ovs-bugtool.in which failed due to python3 issues. This patch fixes those issues. Signed-off-by: Aaron Rosen --- utilities/bugtool/ovs-bugtool.in | 45 +--- 1 file changed

Re: [ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to flake8-check.

This patch seemed to break the build with some flake8 python3 errors for me. I have a patch coming up to fix it. On Thu, Jun 9, 2016 at 11:06 AM, Guru Shetty wrote: > > > > > > > > All of these didn't appear to make the patchworks queue, > > so the following is an ack of the whole series - I've

Re: [ovs-dev] ovn: is it possible to add validation on acl match

Sure! On Tue, Jun 7, 2016 at 10:18 AM, Ben Pfaff wrote: > That's an interesting idea, do you want to take a shot at it? > > On Tue, Jun 07, 2016 at 10:09:42AM -0700, Aaron Rosen wrote: > > If we want to provide a validator to the caller (i.e the neutron plugin) > > w

Re: [ovs-dev] ovn: is it possible to add validation on acl match

n't do it, but it might be less painful in > Python. > > On Fri, May 20, 2016 at 11:55:30AM -0700, Aaron Rosen wrote: > > Would you mind giving an example of what this would look like? > > > > On Friday, May 20, 2016, Ben Pfaff wrote: > > > > > Another

Re: [ovs-dev] [PATCH] Add *.c *.h to datapath/linux/.gitignore

Done, see, "Subject: [PATCH] Add *.c to datapath/linux/.gitignore" On Mon, Jun 6, 2016 at 11:06 AM, Jesse Gross wrote: > On Thu, Jun 2, 2016 at 6:02 PM, Aaron Rosen wrote: > > This should prevent any additional files from sneaking in here. > > > > Signed-o

[ovs-dev] [PATCH] Add *.c to datapath/linux/.gitignore

This should prevent any additional *.c files from sneaking in here. Signed-off-by: Aaron Rosen --- datapath/linux/.gitignore | 52 +-- 1 file changed, 1 insertion(+), 51 deletions(-) diff --git a/datapath/linux/.gitignore b/datapath/linux/.gitignore

Re: [ovs-dev] [PATCH] Add additional files to datapath/linux/.gitignore

This can be ignored I think: "[PATCH] Add *.c *.h to datapath/linux/.gitignore" is a better solution. On Thu, Jun 2, 2016 at 2:18 PM, Aaron Rosen wrote: > After compiling ovs these files always show up as uncommitted. > > Signed-off-by: Aaron Rosen > --- > datap

[ovs-dev] [PATCH] Add *.c *.h to datapath/linux/.gitignore

This should prevent any additional files from sneaking in here. Signed-off-by: Aaron Rosen --- datapath/linux/.gitignore | 54 ++- 1 file changed, 2 insertions(+), 52 deletions(-) diff --git a/datapath/linux/.gitignore b/datapath/linux/.gitignore

[ovs-dev] [PATCH] Add additional files to datapath/linux/.gitignore

After compiling ovs these files always show up as uncommitted. Signed-off-by: Aaron Rosen --- datapath/linux/.gitignore | 11 +++ 1 file changed, 11 insertions(+) diff --git a/datapath/linux/.gitignore b/datapath/linux/.gitignore index a4a930d..25d9804 100644 --- a/datapath/linux

Re: [ovs-dev] ovn: is it possible to add validation on acl match

Pfaff wrote: > > Would it be useful to provide a parser in Python for matches and > > actions? Then most issues could be found before anything is sent to the > > database. > > > > (At this point I'm brainstorming.) > > > > On Fri, May 20, 2016 at 09:29:28

Re: [ovs-dev] ovn: is it possible to add validation on acl match

; (At this point I'm brainstorming.) > > On Fri, May 20, 2016 at 09:29:28AM -0700, Aaron Rosen wrote: > > Makes sense, getting the logging in OpenStack and in northd should > > definitely help improve visibility for us to detect this sooner. Even > > though we won't be abl

Re: [ovs-dev] ovn: is it possible to add validation on acl match

ssell Bryant wrote: > > > On Thu, May 19, 2016 at 11:51 PM, Ben Pfaff wrote: > >> On Thu, May 19, 2016 at 08:42:15PM -0700, Aaron Rosen wrote: >> > I'm wondering if it would be possible to add any additional validation >> on >> > the match column i

[ovs-dev] ovn: is it possible to add validation on acl match

Hi, I'm wondering if it would be possible to add any additional validation on the match column in the ACL table (and potentially other places in the future)? For example, we had a silly bug in the ovn plugin where if someone created a security group rule and specified the protocol number as 6 ins

Re: [ovs-dev] [PATCH RFC] ovn: distributed logical port for VM metadata access

Hi Ramu, On Tue, Apr 19, 2016 at 8:12 AM, Ramu Ramamurthy wrote: > On Mon, Apr 18, 2016 at 2:55 PM, Aaron Rosen > wrote: > > I like this idea as well. > > > > The one question I have with is is how we should determine which ip > address > > to select for

Re: [ovs-dev] [PATCH RFC] ovn: distributed logical port for VM metadata access

I like this idea as well. The one question I have with is is how we should determine which ip address to select for the 'distributed' port? In your example above you picked 10.0.0.100. I'm wondering if there is a more flexible way to handle this. It seems to me like this ip needs to be selected a

[ovs-dev] ovs complication problem on 3.13.0-83-generic

Hi, The OpenStack infra CI nodes upgraded it's kernels from 3.13.0-79-generic to 3.13.0-83-generic and now ovs is failing to compile with the following error: 2016-03-17 20:42:27.078

Re: [ovs-dev] [PATCH] Fix command typo in INSTALL.SSL.md

reg does not take a TYPE so 'switch' should be removed? Aaron On Tue, Nov 3, 2015 at 12:40 PM, Ben Pfaff wrote: > On Tue, Nov 03, 2015 at 12:29:21PM -0800, Aaron Rosen wrote: > > Signed-off-by: Aaron Rosen > > --- > > INSTALL.SSL.md | 2 +- > > 1 fil

[ovs-dev] [PATCH] Fix command typo in INSTALL.SSL.md

Signed-off-by: Aaron Rosen --- INSTALL.SSL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL.SSL.md b/INSTALL.SSL.md index 06be303..f294a27 100644 --- a/INSTALL.SSL.md +++ b/INSTALL.SSL.md @@ -202,7 +202,7 @@ more secure. 1. Run the following command on the Open

Re: [ovs-dev] OVN - L3 Gap between NB schema and Neutron

n for that or not, i think you > > > could > > > configure it as default gateway with out this extension, but with the > > > extension you > > > can define routing between the two routers. > > > > > > > > > > > > >

Re: [ovs-dev] proposed OVN port security specification (was: Re: Allowed Address Pairs - OVN)

Hi Ben, This looks great to me. One thing I was wondering is if the ACL interface that ovn will expose would also allow us to implement this? That said, I think having this port_security column directly on the port will definitely simplifies the integration work needed in neutron so I'm definitely

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

y because now it becomes > > possible to trivially iterate through the ports that belong to a switch, > > which was difficult before the schema change. > > > > This commit will break the Neutron integration until that is changed to > > handle the new database schema.

Re: [ovs-dev] Allowed Address Pairs - OVN

Hi, The allowed address pair extension was added to the neutron api to allow protocols like VRRP to work. All it dictates are mac_address/ip_address(cidrs) that are allowed to pass through a neutron port. rest inline On Wed, Jul 1, 2015 at 10:47 AM, Ben Pfaff wrote: > On Wed, Jul 01, 2015 at 1

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

Sounds good, thanks Ben! From: Ben Pfaff Sent: Friday, June 26, 2015 2:50 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. On Fri, Jun 26, 2015 at 09:35:04PM +

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

inline From: Ben Pfaff Sent: Friday, June 26, 2015 2:12 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. On Fri, Jun 26, 2015 at 08:05:53PM +, Aaron Rosen wrote

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

: Ben Pfaff Sent: Friday, June 26, 2015 12:51 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. OVSDB can't enforce those exact semantics. OVSDB can express operations like "add element X

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

faff Sent: Friday, June 26, 2015 11:37 AM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. On Fri, Jun 26, 2015 at 05:20:16PM +0000, Aaron Rosen wrote: > I just tested out this patch and it seems to work as expecte

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

ugh I just wanted to make sure. Thanks, Aaron From: Ben Pfaff Sent: Thursday, June 25, 2015 4:57 PM To: Aaron Rosen Cc: dev@openvswitch.org Subject: Re: [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema. Thanks. Of cou

Re: [ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

any). > > This commit makes some pretty pervasive changes to ovn-northd, but they > are mostly beneficial to the code readability because now it becomes > possible to trivially iterate through the ports that belong to a switch, > which was difficult before the schema change. >

Re: [ovs-dev] Neutron Container integration.

eal solution to implement for container support. Best, Aaron From: Gurucharan Shetty Sent: Wednesday, April 22, 2015 10:01 AM To: Thomas Graf Cc: Russell Bryant; dev; Aaron Rosen; Armando Migliaccio Subject: Re: [ovs-dev] Neutron Container inte

Re: [ovs-dev] [PATCH] Adds way to determine db changes from Idl.run()

he original function behavior the same and expose this >> as a separate function >> >> def foo(...): >> >> >> def run(...): >> return self.foo(...)[0] >> >> where foo is a better function name - update? run_details? >> run_w

Re: [ovs-dev] [PATCH] Adds way to determine db changes from Idl.run()

ion name - update? run_details? > run_with_changes? run_diff? _run? No opinion there. > > -Reid > > > On Fri, Aug 9, 2013 at 2:30 PM, Aaron Rosen wrote: > >> Right, this would break things for anyone checking the return value of >> idl.run(). The only alternative I

Re: [ovs-dev] [PATCH] Adds way to determine db changes from Idl.run()

: > On Tue, Aug 06, 2013 at 02:45:35PM -0700, Aaron Rosen wrote: > > This patch changes what is being returned from Idl.run() to a tuple > > (changed, changes) so one can determine what changes have occurred to > > the database without having to read the entire table. > &g

Re: [ovs-dev] [PATCH] Adds way to determine db changes from Idl.run()

This patch changes what is being returned from Idl.run() to a tuple (changed, changes) so one can determine what changes have occurred to the database without having to read the entire table. Signed-off-by: Aaron Rosen --- python/ovs/db/idl.py | 16 ++-- tests/test-ovsdb.py

[ovs-dev] [PATCH] Adds way to determine db changes from Idl.run()

This patch changes what is being returned from Idl.run() to a tuple (changed, changes) so one can determine what changes have occurred to the database without having to read the entire table. Signed-off-by: Aaron Rosen --- python/ovs/db/idl.py | 16 ++-- tests/test-ovsdb.py

Re: [ovs-dev] [PATCH] ofproto-dpif: Don't output to in_port even if in_port is OFPP_LOCAL.

Yep, Thanks Aaron Signed-off-by: Aaron Rosen diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d19b6f7..8903a7f 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4545,11 +4545,9 @@ xlate_output_action__(struct action_xlate_ctx *ctx, case