Re: [ovs-dev] [PATCH v3 06/12] cmap: Remove prefetching in cmap_find_batch().

2016-10-17 Thread Daniele Di Proietto
2016-10-14 7:37 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > prefetching the data in to the caches isn't improving the performance in > cmap_find_batch(). Moreover its found that there is slight improvement > in performance with out prefetching. > > This patch removes pr

Re: [ovs-dev] [PATCH v3 02/12] flow: Add comments to mf_get_next_in_map().

2016-10-17 Thread Daniele Di Proietto
2016-10-14 7:37 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > This patch adds comments to mf_get_next_in_map() to make it more > comprehensible. > > Signed-off-by: Jarno Rajahalme > Acked-by: Bhanuprakash Bodireddy > Acked-by: Antonio Fischetti > The tags here look we

Re: [ovs-dev] [PATCH v3 00/12] Improve performance of OVS-DPDK classifier.

2016-10-17 Thread Daniele Di Proietto
Thanks for the series, I applied most of it to master. I sent some comments on the few remaining patches. Thanks again, Daniele 2016-10-14 7:37 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > This patch series is aimed at improving the performance of OVS-DPDK > dpcls. >

Re: [ovs-dev] [PATCH v3 01/12] dpcls: Use 32 packet batches for lookups.

2016-10-17 Thread Daniele Di Proietto
2016-10-14 7:37 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > This patch increases the number of packets processed in a batch during a > lookup from 16 to 32. Processing batches of 32 packets improves > performance and also one of the internal loops can be avoided here. >

Re: [ovs-dev] [PATCH v4 2/7] system-common-macros: Add macros to check for and test 802.1ad.

2016-10-17 Thread Joe Stringer
On 23 September 2016 at 12:16, Eric Garver wrote: > Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). > > Signed-off-by: Eric Garver > # ADD_OVS_TUNNEL([type], [bridge], [port], [remote-addr], [overlay-addr]) > # > # Add an ovs-based tunnel device in the root namespace, with name

Re: [ovs-dev] [PATCH v4 0/7] system-traffic: add 802.1ad test cases

2016-10-17 Thread Joe Stringer
On 23 September 2016 at 12:16, Eric Garver wrote: > This series adds 802.1ad test cases for the check-* make targets. It is > meant as a counterpart to the 802.1ad work currently going on and being > discussed on the dev list. > > User space support for 802.1ad is being worked on by Xiao Liang (ba

Re: [ovs-dev] [PATCH 15/15] ovsdb-idl: Check internal graph in OVSDB tests.

2016-10-17 Thread Andy Zhou
On Wed, Oct 5, 2016 at 8:16 PM, Ben Pfaff wrote: > Some upcoming tests will add extra trickiness to the IDL internal graph. > This worries me, because the IDL doesn't have any checks for its graph > consistency. This commit adds some. > > Signed-off-by: Ben Pfaff > For all 15 patches in the se

Re: [ovs-dev] [PATCH v3 03/12] flow: Skip invoking expensive count_1bits() with zero input.

2016-10-17 Thread Jarno Rajahalme
> On Oct 17, 2016, at 2:10 AM, Fischetti, Antonio > wrote: > > Thanks Jarno, one question below. > > Antonio > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org >> ] On Behalf Of Jarno >> Rajahalme >> Sent: Friday, October 14,

Re: [ovs-dev] [PATCH v2] ovsdb: implement read-only remote connection type

2016-10-17 Thread Ben Pfaff
On Fri, Oct 14, 2016 at 02:05:54PM -0400, Lance Richardson wrote: > This change set adds a new optional access-type specifier to > remote connection descriptors for ovsdb-server. > > Examples: > --remote=ptcp:ro:0:192.168.0.10 > --remote=punix:ro:asocket.sock > --remote=pssl:ro:0:192.1

Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak on error path.

2016-10-17 Thread Ben Pfaff
On Fri, Oct 14, 2016 at 01:11:07PM -0700, Andy Zhou wrote: > On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff wrote: > > > The commit that this fixes is from 2009. > > > > Reported-by: Kai-Wei Fan > > Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.") > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] Subject: [PATCH] ovs-monitor-ipsec: ipsec_vxlan support and IPsec tunnel mode options support.

2016-10-17 Thread Ben Pfaff
No, we wouldn't normally add or remove a feature in a release that has already been made. If you need this in OVS 2.5, then you can apply the commit locally, with "git cherry-pick" or similar. On Mon, Oct 17, 2016 at 06:40:58AM +, Muthukrishnan Thangasamy wrote: > Dear Ben , > > > Thanks yo

Re: [ovs-dev] If the latest OVS support ECN

2016-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2016 at 08:22:50AM +, zhangyali (D) wrote: > I plan to construct a test bed with ovs, but now I encountered a > problem about if the latest ovs support for ECN (Explicit Congestion > Notification). Hope I could get your help. Thanks in advance. OVS can match and set the ECN bit

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-17 Thread Kavanagh, Mark B
> >OK, Thanks for your info. > >BTW, you mentioned the gap, is it the tunneling tso can't work correctly for >multi-segments >mbuf, and after some packets, guest is unable to xmit packets(dpdk driver >failed to work any >more)? At the time, the gap was that the tunnel header was not replicated a

Re: [ovs-dev] OVS 2.6.1 release?

2016-10-17 Thread Ben Pfaff
On Mon, Oct 17, 2016 at 09:14:33AM -0400, Russell Bryant wrote: > Can we do a 2.6.1 release in the near future? The latest Python commit is > needed for OpenStack. I'd support that. Justin usually makes the releases, and he's traveling on vacation this week, so we may not hear from him for a whi

Re: [ovs-dev] [PATCH 2/9] doc: Convert INSTALL to rST

2016-10-17 Thread Russell Bryant
On Mon, Oct 17, 2016 at 8:19 AM, Stephen Finucane wrote: > On 15 Oct 22:01, Russell Bryant wrote: > > On Sat, Oct 15, 2016 at 9:57 PM, Russell Bryant wrote: > > Very minor nit ... I think I would find it easier to review these if > > content changes were separate from the md to rst conversion.

Re: [ovs-dev] [PATCH 1/9] dist-docs: Add support for rST

2016-10-17 Thread Russell Bryant
On Mon, Oct 17, 2016 at 8:21 AM, Stephen Finucane wrote: > On 15 Oct 21:20, Russell Bryant wrote: > > On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane > wrote: > > I added this line here: > > > > +title=`grep -A 1 -e "^=" $srcdir/$file | sed -n 2p` > > > > To get a proper title for

[ovs-dev] OVS 2.6.1 release?

2016-10-17 Thread Russell Bryant
Can we do a 2.6.1 release in the near future? The latest Python commit is needed for OpenStack. For reference, here's the current list of commits from 2.6.0 to branch-2.6. e681dc6 Python-IDL: getattr after mutate fix b72183a rhel-systemd: Delay shutting down the services c222d7a doc: Update DPDK

[ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-17 Thread Jiri Benc
It's not allowed to push Ethernet header in front of another Ethernet header. It's not allowed to pop Ethernet header if there's a vlan tag. This preserves the invariant that L3 packet never has a vlan tag. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab

[ovs-dev] [PATCH net-next v12 8/9] openvswitch: allow L3 netdev ports

2016-10-17 Thread Jiri Benc
Allow ARPHRD_NONE interfaces to be added to ovs bridge. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman Signed-off-by: Jiri Benc --- net/openvswitch/vport-netdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(

[ovs-dev] [PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-10-17 Thread Jiri Benc
From: Simon Horman This allows GRE tunnels to send and receive both layer 2 packets (packets with an ethernet header) and layer 3 packets (packets without an ethernet header). Signed-off-by: Simon Horman Signed-off-by: Jiri Benc --- v12: removed the non-gre hunks (now part of previous patches

[ovs-dev] [PATCH net-next v12 6/9] openvswitch: netlink: support L3 packets

2016-10-17 Thread Jiri Benc
Extend the ovs flow netlink protocol to support L3 packets. Packets without OVS_KEY_ATTR_ETHERNET attribute specify L3 packets; for those, the OVS_KEY_ATTR_ETHERTYPE attribute is mandatory. Push/pop vlan actions are only supported for Ethernet packets. Based on previous versions by Lorand Jakab a

[ovs-dev] [PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

2016-10-17 Thread Jiri Benc
We'll need it to alter packets sent to ARPHRD_NONE interfaces. Change do_output() to use the actual L2 header size of the packet when deciding on the minimum cutlen. The assumption here is that what matters is not the output interface hard_header_len but rather the L2 header of the particular pack

[ovs-dev] [PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

2016-10-17 Thread Jiri Benc
Update Ethernet header only if there is one. Signed-off-by: Jiri Benc --- net/openvswitch/actions.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index dc8bb97e2258..064cbcb7b0c5 100644 --- a/net/open

[ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-17 Thread Jiri Benc
Support receiving, extracting flow key and sending of L3 packets (packets without an Ethernet header). Note that even after this patch, non-Ethernet interfaces are still not allowed to be added to bridges. Similarly, netlink interface for sending and receiving L3 packets to/from user space is not

[ovs-dev] [PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-10-17 Thread Jiri Benc
On tx, use hard_header_len while deciding whether to refragment or drop the packet. That way, all combinations are calculated correctly: * L2 packet going to L2 interface (the L2 header len is subtracted), * L2 packet going to L3 interface (the L2 header is included in the packet lenght), * L3 p

[ovs-dev] [PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

2016-10-17 Thread Jiri Benc
Use a hole in the structure. We support only Ethernet so far and will add a support for L2-less packets shortly. We could use a bool to indicate whether the Ethernet header is present or not but the approach with the mac_proto field is more generic and occupies the same number of bytes in the struc

[ovs-dev] [PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

2016-10-17 Thread Jiri Benc
At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. Support for layer 3 GRE tunnels is also added by this patchset. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding

Re: [ovs-dev] [PATCH 1/9] dist-docs: Add support for rST

2016-10-17 Thread Stephen Finucane
On 15 Oct 21:20, Russell Bryant wrote: > On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane wrote: > > > This will eventually go away once Sphinx starts doing all this work for > > us. For now, however, let's make sure we don't break the OVS website. > > > > This introduces a new dependency for th

Re: [ovs-dev] [PATCH 2/9] doc: Convert INSTALL to rST

2016-10-17 Thread Stephen Finucane
On 15 Oct 22:01, Russell Bryant wrote: > On Sat, Oct 15, 2016 at 9:57 PM, Russell Bryant wrote: > > > > > On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane > > wrote: > > > >> Signed-off-by: Stephen Finucane > >> --- > >> CONTRIBUTING.md | 6 +- > >> FAQ.md | 10 +

Re: [ovs-dev] [PATCH v3 03/12] flow: Skip invoking expensive count_1bits() with zero input.

2016-10-17 Thread Fischetti, Antonio
Thanks Jarno, one question below. Antonio > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno > Rajahalme > Sent: Friday, October 14, 2016 5:03 PM > To: Bodireddy, Bhanuprakash > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3 03/12] flow:

[ovs-dev] If the latest OVS support ECN

2016-10-17 Thread zhangyali (D)
Hi all, I plan to construct a test bed with ovs, but now I encountered a problem about if the latest ovs support for ECN (Explicit Congestion Notification). Hope I could get your help. Thanks in advance. Best, Yali ___ dev mailing list dev@openvswitch