2016-10-14 7:37 GMT-07:00 Bhanuprakash Bodireddy <
bhanuprakash.bodire...@intel.com>:

> prefetching the data in to the caches isn't improving the performance in
> cmap_find_batch(). Moreover its found that there is slight improvement
> in performance with out prefetching.
>
> This patch removes prefetching from cmap_find_batch().
>
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com>
> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com>
> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com>
>

I tested this patch in isolation and on my system I didn't notice any
improvements for a single flow (with EMC disabled), I noticed a slight drop
instead with 128 flows in the classifier.

Probably this is due to the fact that I didn't apply yet the first patch of
the series (the one that increases the batch to 32), so I guess I'll defer
this patch until we can apply the rest of the series.

Also, if you guys see an improvement (and since you got some evidence with
VTune), I don't think it matters that on one particular system (mine) I
can't see any benefit.

Thanks,

Daniele
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to