Re: [ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

2016-09-23 Thread Ansis Atteka
On 21 September 2016 at 03:26, Pravin B Shelar wrote: > OVS IPsec tunnel support has issues: > 1. It only works for GRE. > 2. only works on Debian. > 3. It does not allow user to match on packet-mark >on packet received on tunnel ports. > > This patch deprecates support for IPsec tunnel port.

Re: [ovs-dev] [PATCH] netdev-dpdk: More correct log message on vhost_driver_unregister failure.

2016-09-23 Thread Daniele Di Proietto
Makes sense to me, applied to master and branch-2.6 Thanks, Daniele On 23/09/2016 06:17, "Ilya Maximets" wrote: >Current error message incorrect for the client mode. > >Fixes: c1ff66ac80b5 ("netdev-dpdk: vHost client mode and reconnect") >Signed-off-by: Ilya Maximets >--- > lib/netdev-dpdk.

Re: [ovs-dev] [PATCH] netdev-dpdk: Add missed lock in set_config for vhost client mode.

2016-09-23 Thread Daniele Di Proietto
Thanks for the fix, applied to master and branch-2.6 On 23/09/2016 06:17, "Ilya Maximets" wrote: >'vhost_driver_flags' and 'vhost_id' are mutable and must be protected >by 'dev->mutex'. > >Fixes: 2d24d165d6a5 ("netdev-dpdk: Add new 'dpdkvhostuserclient' port type") >Signed-off-by: Ilya Maxime

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 12:13, Justin Pettit wrote: > >> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote: >> >> On 23 September 2016 at 01:53, Justin Pettit wrote: >>> >>> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h >>> index 5ab026c..9d53623 100644 >>> --- a/incl

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-23 Thread pravin shelar
On Fri, Sep 23, 2016 at 12:54 PM, Ansis Atteka wrote: > On Fri, Sep 23, 2016 at 1:12 AM, pravin shelar wrote: >> On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote: >>> >>> >>> On 20 September 2016 at 20:52, Pravin B Shelar wrote: OVS IPsec tunnel support has issues: 1. It only

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-23 Thread Ansis Atteka
On Fri, Sep 23, 2016 at 1:12 AM, pravin shelar wrote: > On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote: >> >> >> On 20 September 2016 at 20:52, Pravin B Shelar wrote: >>> >>> OVS IPsec tunnel support has issues: >>> 1. It only works for GRE. >>> >>> 2. only works on Debian. >>> >>> 3. It d

Re: [ovs-dev] [PATCH v2] ovn-vtep: fix arping from vtep-gw physical port

2016-09-23 Thread Darrell Ball
On Thu, Sep 22, 2016 at 1:07 PM, Ramu Ramamurthy wrote: > Currently, arping from a vtep-gw physical-switch port to > a VIF IP address does not work. > > When a physical-switch-port arps for an IP address > of a VIF, that arp packet comes into the VIF hypervisor via a > vxlan tunnel. That arp pack

Re: [ovs-dev] [PATCH 4/4] ovn-controller: Flush conntrack entries for newly allocated zones.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 10:14 AM, Ben Pfaff wrote: > > On Fri, Sep 23, 2016 at 01:53:03AM -0700, Justin Pettit wrote: >> Flush any existing conntrack entries for a zone when that zone is >> allocated to a new logical port. >> >> Signed-off-by: Justin Pettit > > Also would be nice to have a test

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl: Return result of transaction in ovsdb_idl_loop_commit_and_wait().

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 9:56 AM, Ben Pfaff wrote: > > On Fri, Sep 23, 2016 at 01:53:01AM -0700, Justin Pettit wrote: >> From: Ben Pfaff >> >> This will have a caller in the future. >> >> Signed-off-by: Ben Pfaff >> Signed-off-by: Justin Pettit > > I guess I can't review this; presumably, you

[ovs-dev] [PATCH v4 6/7] system-traffic: 802.1ad: Add push/pop test cases.

2016-09-23 Thread Eric Garver
Two test cases to push and pop an outer tag between two "customer" bridges. One to push/pop 0x88a8. One to push/pop a second 0x8100. Signed-off-by: Eric Garver --- tests/system-traffic.at | 112 1 file changed, 112 insertions(+) diff --git a/test

[ovs-dev] [PATCH v4 2/7] system-common-macros: Add macros to check for and test 802.1ad.

2016-09-23 Thread Eric Garver
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). Signed-off-by: Eric Garver --- tests/system-common-macros.at | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 1dfdcf

[ovs-dev] [PATCH v4 4/7] system-traffic: 802.1ad: Add conntrack ping tests for CVLANs.

2016-09-23 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 107 1 file changed, 107 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 83c7b8a2f4e5..bb0cb02804f9 100644 --- a/tests/system-traffic.at +++ b/tests/system

[ovs-dev] [PATCH v4 3/7] system-traffic: 802.1ad: Add datapath ping tests for CVLANs.

2016-09-23 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 62 + 1 file changed, 62 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4dabd90356a1..83c7b8a2f4e5 100644 --- a/tests/system-traffic.at +++ b/tests/system-

[ovs-dev] [PATCH v4 0/7] system-traffic: add 802.1ad test cases

2016-09-23 Thread Eric Garver
This series adds 802.1ad test cases for the check-* make targets. It is meant as a counterpart to the 802.1ad work currently going on and being discussed on the dev list. User space support for 802.1ad is being worked on by Xiao Liang (based on Thomas F Herbert's work). Kernel support is already p

[ovs-dev] [PATCH v4 1/7] system-userspace-macros: allow passing sed args to OVS_TRAFFIC_VSWITCHD_STOP()

2016-09-23 Thread Eric Garver
Passing sed arguments to OVS_TRAFFIC_VSWITCHD_STOP() was being ignored for check-system-userspace. This is useful to selective ignore log messages. Signed-off-by: Eric Garver --- tests/system-userspace-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-use

[ovs-dev] [PATCH v4 5/7] system-traffic: 802.1ad: Add vlan_limit test case.

2016-09-23 Thread Eric Garver
Verify that vlan_limit works as expected and preserves legacy dl_type matching behavior. Signed-off-by: Eric Garver --- tests/system-traffic.at | 36 1 file changed, 36 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index bb0cb0

[ovs-dev] [PATCH v4 7/7] system-traffic: 802.1ad: Add dot1q-tunnel test case.

2016-09-23 Thread Eric Garver
Test case for dot1q-tunnel between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4d31e5452914..9b0ae5547

[ovs-dev] [PATCH] netdev-linux: double tagged packets should use 0x88a8

2016-09-23 Thread Eric Garver
We need to check if a packet is double tagged. If so make sure to push 0x88a8 instead of 0x8100. Without this a simple port redirect of 802.1ad frames means the outer tag gets translated from 0x88a8 to 0x8100 by the userspace datapath. This only affected kernels that don't use TP_STATUS_VLAN_TPID_

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote: > > On 23 September 2016 at 01:53, Justin Pettit wrote: >> >> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h >> index 5ab026c..9d53623 100644 >> --- a/include/openflow/nicira-ext.h >> +++ b/include/openflow/nicira-

Re: [ovs-dev] [PATCH v2] ovn: Initialize the databases.

2016-09-23 Thread Guru Shetty
On 22 September 2016 at 09:54, Ben Pfaff wrote: > On Mon, Sep 19, 2016 at 03:52:55AM -0700, Gurucharan Shetty wrote: > > Without initializing the databases, commands of the form > > 'ovn-nbctl --wait=sb ls-add ls0' will simply hang. > > > > Signed-off-by: Gurucharan Shetty > > Thanks! > > Acked-

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 11:29 AM, Guru Shetty wrote: > > > > On 23 September 2016 at 11:25, Justin Pettit wrote: > > > On Sep 23, 2016, at 11:21 AM, Guru Shetty wrote: > > > > > > > > I changed the sentence to the following, since I was worried that "key" was > > being used in different cont

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 11:25, Justin Pettit wrote: > > > On Sep 23, 2016, at 11:21 AM, Guru Shetty wrote: > > > > > > > > I changed the sentence to the following, since I was worried that "key" > was being used in different contexts in that paragraph: > > > > The name contains a prefix

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 11:21 AM, Guru Shetty wrote: > > > > I changed the sentence to the following, since I was worried that "key" was > being used in different contexts in that paragraph: > > The name contains a prefix > of ct-zone- followed by the name of the logical >

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
> > > > I changed the sentence to the following, since I was worried that "key" > was being used in different contexts in that paragraph: > > The name contains a prefix > of ct-zone- followed by the name of the logical > port or the gateway router. > > Are you good with it?

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 11:12 AM, Guru Shetty wrote: > > > > On 23 September 2016 at 11:01, Justin Pettit wrote: > > > On Sep 23, 2016, at 10:19 AM, Guru Shetty wrote: > > > > > > > > On 23 September 2016 at 01:53, Justin Pettit wrote: > > If ovn-controller is restarted, it may choose differ

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 11:01, Justin Pettit wrote: > > > On Sep 23, 2016, at 10:19 AM, Guru Shetty wrote: > > > > > > > > On 23 September 2016 at 01:53, Justin Pettit wrote: > > If ovn-controller is restarted, it may choose different conntrack zones > > than had been previously used, which cou

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 10:19 AM, Guru Shetty wrote: > > > > On 23 September 2016 at 01:53, Justin Pettit wrote: > If ovn-controller is restarted, it may choose different conntrack zones > than had been previously used, which could cause the wrong conntrack > entries to be associated with a log

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 01:53, Justin Pettit wrote: > If ovn-controller is restarted, it may choose different conntrack zones > than had been previously used, which could cause the wrong conntrack > entries to be associated with a logical port. This commit stores in the > integration bridge's OV

Re: [ovs-dev] [PATCH] CONTRIBUTING.md: Improve recommended command for Fixes: header.

2016-09-23 Thread Aaron Conole
Ben Pfaff writes: > It usually makes sense to CC the author of the commit being fixed. > > The CC tag wasn't mentioned before, so describe it too. > > Signed-off-by: Ben Pfaff > --- ACK. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/

Re: [ovs-dev] [PATCHv2] ovs-lib: Fix SELinux contexts for created dirs.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 06:25, Ansis Atteka wrote: > > > On 23 September 2016 at 03:25, Joe Stringer wrote: >> >> ovs-lib creates several directories directly from the script, but >> doesn't make any attempt to ensure that the correct SELinux context is >> applied to these directories. As a resul

Re: [ovs-dev] [PATCH 4/4] ovn-controller: Flush conntrack entries for newly allocated zones.

2016-09-23 Thread Ben Pfaff
On Fri, Sep 23, 2016 at 01:53:03AM -0700, Justin Pettit wrote: > Flush any existing conntrack entries for a zone when that zone is > allocated to a new logical port. > > Signed-off-by: Justin Pettit Also would be nice to have a test. Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Ben Pfaff
On Fri, Sep 23, 2016 at 01:53:02AM -0700, Justin Pettit wrote: > If ovn-controller is restarted, it may choose different conntrack zones > than had been previously used, which could cause the wrong conntrack > entries to be associated with a logical port. This commit stores in the > integration br

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 01:53, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > NEWS | 1 + > debian/changelog | 10 ++ > include/openflow/nicira-ext.h | 9 + > include/openvswitch/ofp-msgs.h | 4 > lib/dpif.c

Re: [ovs-dev] [PATCH v3 3/7] system-traffic: 802.1ad: Add datapath ping tests for CVLANs.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 05:51, Eric Garver wrote: > On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote: >> On 14 September 2016 at 17:26, Eric Garver wrote: >> > Signed-off-by: Eric Garver >> >> Hi Eric, >> >> I tried this series again on a variety of kernels and these initial >> ping

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 8:42 AM, Ben Pfaff wrote: > > On Fri, Sep 23, 2016 at 01:53:00AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > ct_dpif_flush() and dpif_ct_flush() are almost identical. Why do we > need both? > > Acked-by: Ben Pfaff Just an oversight. I'll add my lo

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl: Return result of transaction in ovsdb_idl_loop_commit_and_wait().

2016-09-23 Thread Ben Pfaff
On Fri, Sep 23, 2016 at 01:53:01AM -0700, Justin Pettit wrote: > From: Ben Pfaff > > This will have a caller in the future. > > Signed-off-by: Ben Pfaff > Signed-off-by: Justin Pettit I guess I can't review this; presumably, you've reviewed it. ___

Re: [ovs-dev] [PATCH v3 3/7] system-traffic: 802.1ad: Add datapath ping tests for CVLANs.

2016-09-23 Thread Eric Garver
Joe, I have a pretty straight forward fix for the TPID issue. I'll be sending it to ovs-dev shortly. However, I had to make a small change to one of my tests to support it. So I'll be sending out another rev of this test series as well. Thanks. Eric. On Fri, Sep 23, 2016 at 08:51:42AM -0400, Er

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Ben Pfaff
On Fri, Sep 23, 2016 at 01:53:00AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit ct_dpif_flush() and dpif_ct_flush() are almost identical. Why do we need both? Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswit

[ovs-dev] [PATCH] CONTRIBUTING.md: Improve recommended command for Fixes: header.

2016-09-23 Thread Ben Pfaff
It usually makes sense to CC the author of the commit being fixed. The CC tag wasn't mentioned before, so describe it too. Signed-off-by: Ben Pfaff --- CONTRIBUTING.md | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 68

Re: [ovs-dev] [PATCH] ovn-northd: Fix overlapping ARP/ND resolution logical flows.

2016-09-23 Thread Ben Pfaff
On Thu, Sep 22, 2016 at 11:28:11PM -0700, Justin Pettit wrote: > > > On Sep 22, 2016, at 8:59 PM, Ben Pfaff wrote: > > > > IPv4 and IPv6 packets have separate flows and should not overlap with a > > catch-all flow that treats all packets like IPv4. It's unpredictable what > > flow actually gets

Re: [ovs-dev] [PATCHv2] ovs-lib: Fix SELinux contexts for created dirs.

2016-09-23 Thread Ansis Atteka
On 23 September 2016 at 03:25, Joe Stringer wrote: > ovs-lib creates several directories directly from the script, but > doesn't make any attempt to ensure that the correct SELinux context is > applied to these directories. As a result, the created directories end > up with type var_run_t rather

[ovs-dev] [PATCH] netdev-dpdk: More correct log message on vhost_driver_unregister failure.

2016-09-23 Thread Ilya Maximets
Current error message incorrect for the client mode. Fixes: c1ff66ac80b5 ("netdev-dpdk: vHost client mode and reconnect") Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index ec43a08..

[ovs-dev] [PATCH v2] netdev-dpdk: Introduce dpdk_mp_mutex.

2016-09-23 Thread Ilya Maximets
'dpdk_mutex' protects two independent things: list of dpdk devices and list of memory pools. Let's spit it in two to avoid global blocking inside 'netdev_dpdk.*_reconfigure()' as possible. Signed-off-by: Ilya Maximets --- I think, that this patch still useful. What do you think, Daniele? Versio

[ovs-dev] [PATCH] netdev-dpdk: Add missed lock in set_config for vhost client mode.

2016-09-23 Thread Ilya Maximets
'vhost_driver_flags' and 'vhost_id' are mutable and must be protected by 'dev->mutex'. Fixes: 2d24d165d6a5 ("netdev-dpdk: Add new 'dpdkvhostuserclient' port type") Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/net

[ovs-dev] Returned mail: see transcript for details

2016-09-23 Thread Bounced mail
Dear user dev@openvswitch.org, Your account has been used to send a large amount of unsolicited e-mail messages during the last week. We suspect that your computer was compromised and now runs a trojan proxy server. We recommend that you follow the instructions in order to keep your computer s

[ovs-dev] OVN and IPFIX

2016-09-23 Thread Valentine Sinitsyn
Hi, Suppose we want to collect per-port IPFIX statistics in an OVN-managed virtual network. Looks like the most straightforward way to do this is to add a Flow_Sample_Collector_Set entry and a flow with sample() action to match the given port (think physical one, for simplicity). However,

Re: [ovs-dev] [PATCH v3 3/7] system-traffic: 802.1ad: Add datapath ping tests for CVLANs.

2016-09-23 Thread Eric Garver
On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote: > On 14 September 2016 at 17:26, Eric Garver wrote: > > Signed-off-by: Eric Garver > > Hi Eric, > > I tried this series again on a variety of kernels and these initial > ping over cvlan tests are failing for check-system-userspace on

[ovs-dev] Returned mail: see transcript for details

2016-09-23 Thread Automatic Email Delivery Software
The original message was received at Fri, 23 Sep 2016 17:41:15 +0530 from openvswitch.org [132.207.104.252] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

[ovs-dev] Returned mail: Data format error

2016-09-23 Thread Bounced mail
The original message was received at Fri, 23 Sep 2016 17:26:12 +0530 from [143.164.73.30] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listi

[ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Justin Pettit
If ovn-controller is restarted, it may choose different conntrack zones than had been previously used, which could cause the wrong conntrack entries to be associated with a logical port. This commit stores in the integration bridge's OVS "Bridge" table the mapping to the conntrack zone. Signed-of

[ovs-dev] [PATCH 2/4] ovsdb-idl: Return result of transaction in ovsdb_idl_loop_commit_and_wait().

2016-09-23 Thread Justin Pettit
From: Ben Pfaff This will have a caller in the future. Signed-off-by: Ben Pfaff Signed-off-by: Justin Pettit --- lib/ovsdb-idl.c | 35 ++- lib/ovsdb-idl.h | 2 +- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c

[ovs-dev] [PATCH 4/4] ovn-controller: Flush conntrack entries for newly allocated zones.

2016-09-23 Thread Justin Pettit
Flush any existing conntrack entries for a zone when that zone is allocated to a new logical port. Signed-off-by: Justin Pettit --- ovn/controller/ofctrl.c | 76 - ovn/controller/ofctrl.h | 8 +++-- ovn/controller/ovn-controller.c | 25 +++

[ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 1 + debian/changelog | 10 ++ include/openflow/nicira-ext.h | 9 + include/openvswitch/ofp-msgs.h | 4 lib/dpif.c | 14 ++ lib/dpif.h | 1

[ovs-dev] Cannot forward bpdu through openvswitch

2016-09-23 Thread Dani Camps
Dear all, I am using OVS 2.1.2 I want to configure a switch with two ports to transparently forward what comes to one port to the other. These are the rules that I am using: cookie=0x0, duration=77674.340s, table=0, n_packets=0, n_bytes=0, idle_age=65534, hard_age=65534, in_port=1 actions=outpu

[ovs-dev] Returned mail: Data format error

2016-09-23 Thread drh
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev