[ovs-dev] Message could not be delivered

2016-08-15 Thread Mail Delivery Subsystem
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] vlog: fix the crash caused by option syslog-method

2016-08-15 Thread Binbin Xu
When we start ovs-appctl with no argument option "syslog-method", the process crashed. backtrace: 0 0x004180c4 in vlog_set_syslog_method (method=0x0) at lib/vlog.c:587 1 0x00408b27 in parse_command_line (argv=0x7fff097e83b8, argc=2) at utilities/ovs-appctl.c:175 2 main (argc=2,

[ovs-dev] [PATCH monitor_cond V14 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

2016-08-15 Thread Liran Schour
Use struct uuid * on [add|remove]_clause on columns which are references to tables. That prevents use-after-free errors. Signed-off-by: Liran Schour --- ovsdb/ovsdb-idlc.in| 40 python/ovs/db/types.py | 13 ++--- 2 files changed, 30 insertions

[ovs-dev] [PATCH monitor_cond V14 2/2] ovn: implementation of conditional monitoring usage

2016-08-15 Thread Liran Schour
Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Performance evaluation: OVN is the main candidate for conditional monitoring usage.

Re: [ovs-dev] [PATCH monitor_cond V13 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

2016-08-15 Thread Liran Schour
Ben Pfaff wrote on 15/08/2016 07:29:05 PM: > On Mon, Aug 15, 2016 at 04:03:52PM +0300, Liran Schour wrote: > > Use struct uuid * on [add|remove]_clause on columns which are references to > > tables. That prevents use-after-free errors. > > > > Signed-off-by: Liran Schour > > This seems reason

Re: [ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-15 Thread Ben Pfaff
(Apparently I've been sitting on this since yesterday, sorry.) On Thu, Aug 11, 2016 at 05:51:39PM +0530, Numan Siddique wrote: > When ovn-controller reconnects to the ovs-vswitchd, it deletes all the > OF flows in the switch. It doesn't install the flows again, leaving > the datapath broken unless

Re: [ovs-dev] [PATCH 3/3] Prepare for post-2.6.0 (2.6.90).

2016-08-15 Thread Justin Pettit
> On Aug 15, 2016, at 8:00 PM, Ben Pfaff wrote: > > On Sat, Aug 06, 2016 at 08:51:26PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff We're branched for 2.6. Thanks, everyone! --Justin ___ dev mailing list d

Re: [ovs-dev] [PATCH 3/3] Prepare for post-2.6.0 (2.6.90).

2016-08-15 Thread Ben Pfaff
On Sat, Aug 06, 2016 at 08:51:26PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] Prepare for 2.6.0.

2016-08-15 Thread Ben Pfaff
On Sat, Aug 06, 2016 at 08:51:25PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] NEWS: Add reference to OVN in the post-2.5 release.

2016-08-15 Thread Ben Pfaff
On Sat, Aug 06, 2016 at 08:51:24PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 3/3] Prepare for post-2.6.0 (2.6.90).

2016-08-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b762515..794390e 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v2.6.0 +- + +

[ovs-dev] [PATCH 2/3] Prepare for 2.6.0.

2016-08-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 116 +-- 3 files changed, 114 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 53dc137..b762515 100644 --- a/NEWS +++ b/NEWS @

[ovs-dev] [PATCH 1/3] NEWS: Add reference to OVN in the post-2.5 release.

2016-08-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index e989d64..53dc137 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post-v2.5.0 - + - First supported release of OVN. See ovn-architecture(7) for more + details.

Re: [ovs-dev] [PATCH v5 7/8] expr: New function expr_parse_microflow().

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 07:41:15PM -0700, Justin Pettit wrote: > > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > > > This allows "ovstest test-ovn evaluate-expr" work with arbitrary > > microflows rather than just a few restricted variables, but the main point > > is to enable the upcoming

Re: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

2016-08-15 Thread Darrell Ball
On Wed, Aug 10, 2016 at 2:53 AM, Liran Schour wrote: > Darrell Ball wrote on 09/08/2016 08:02:06 PM: > > > On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour wrote: > > "dev" wrote on 03/08/2016 09:09:48 AM: > > > > > From: Darrell Ball > > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org

Re: [ovs-dev] [PATCH v5 7/8] expr: New function expr_parse_microflow().

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > This allows "ovstest test-ovn evaluate-expr" work with arbitrary > microflows rather than just a few restricted variables, but the main point > is to enable the upcoming "ovn-trace" utility to accept arbitrary > microflows in a format that seem

Re: [ovs-dev] [PATCH v5 6/8] expr: New function expr_evaluate().

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 07:30:36PM -0700, Justin Pettit wrote: > > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > > > An upcoming commit will need to evaluate individual expressions outside the > > context of a classifier. test-ovn already had a function to do this but it > > wasn't genera

Re: [ovs-dev] [PATCH v5 5/8] ovn-northd: Copy name in logical datapath southbound representations.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 05:23:21PM -0700, Justin Pettit wrote: > > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > > > This makes it easier to debug based on the southbound database without > > looking at the northbound representation. This commit adds the name > > to "ovn-sbctl dump-flows"

Re: [ovs-dev] [PATCH v5 4/8] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 05:18:40PM -0700, Justin Pettit wrote: > > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > > index 2c89613..a7d3131 100644 > > --- a/lib/meta-flow.c > > +++ b/lib/meta-flow.c > > @@ -1962,6 +1962,80 @@ mf_check__(co

Re: [ovs-dev] [PATCH v5 6/8] expr: New function expr_evaluate().

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > An upcoming commit will need to evaluate individual expressions outside the > context of a classifier. test-ovn already had a function to do this but it > wasn't general-purpose, so this commit makes a general-purpose version and > adopts it f

Re: [ovs-dev] [PATCH V6] netdev-dpdk: Set pmd thread priority

2016-08-15 Thread Daniele Di Proietto
I found a crash if apply this patch, "dpdk-lcore-mask" is not set and "-c 0x1" is passed to "dpdk-extra". Also, I believe Flavio had a comment on the previous version of this patch. Would it be enough to use setpriority(2)? Thanks, Daniele 2016-08-15 8:19 GMT-07:00 Bhanuprakash Bodireddy < bha

Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-15 Thread Daniele Di Proietto
Given that the branching is imminent I pushed the patch to master (after fixing some clang warnings), to get it into 2.6, as I'm happy with the interface. Sean, if we settle on a better interface to suit your needs, I'm fine with changing it in the next few days. Thanks for the series, Daniele

Re: [ovs-dev] [ovs-dev, v5] Add read-only option to ovs-dpctl and ovs-ofctl commands.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 06:47:29PM +, Ryan Moats wrote: > ovs-dpctl and ovs-ofctl lack a read-only option to prevent > running of commands that perform read-write operations. Add > it and the necessary scaffolding to each. > > Signed-off-by: Ryan Moats I folded in a few changes, see below,

Re: [ovs-dev] [PATCH v5 5/8] ovn-northd: Copy name in logical datapath southbound representations.

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > This makes it easier to debug based on the southbound database without > looking at the northbound representation. This commit adds the name > to "ovn-sbctl dump-flows" output and it will be even more useful in > an upcoming commit. > > Signe

Re: [ovs-dev] [PATCH v5 4/8] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index 2c89613..a7d3131 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c > @@ -1962,6 +1962,80 @@ mf_check__(const struct mf_subfield *sf, const struct > flow *flow, > } > } > > +/* Se

Re: [ovs-dev] Hitless resynchronisation of forwarding state

2016-08-15 Thread Jarno Rajahalme
> On Aug 8, 2016, at 3:46 PM, Jan Scheurich wrote: > >> From: Jarno Rajahalme [mailto:ja...@ovn.org] >> Sent: Friday, 29 July, 2016 20:38 >> >>> Twice the memory of the steady state footprint would still be a significant >> burden, in particular if that memory would have to reside on hugepages

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix memory leak in ovsdb_idl_condition_add_clause().

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 03:08:04PM -0400, Flaviof wrote: > On Sat, Aug 13, 2016 at 7:58 PM, Ben Pfaff wrote: > > > The function always allocated a clause but didn't use it if it was > > going to be a duplicate. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Flavio Fernandes Thanks, applie

Re: [ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 04:05:39PM -0400, Flaviof wrote: > On Sun, Aug 14, 2016 at 12:52 AM, Ben Pfaff wrote: > > > The conditional replication code had hardly any comments. This adds some. > > > > This commit also fixes a number of style problems, factors out some code > > into a helper functio

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix double-remove in ovsdb_idl_condition_reset().

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 01:40:36PM -0700, Andy Zhou wrote: > On Sat, Aug 13, 2016 at 5:37 PM, Ben Pfaff wrote: > > > Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call > > ovs_list_remove() on the clause's 'node' member, but it should only be > > called once. > > > > Signed-off-by:

Re: [ovs-dev] [PATCH v4] ofproto: Reduce bundle memory use.

2016-08-15 Thread Jarno Rajahalme
> On Aug 15, 2016, at 11:19 AM, Ben Pfaff wrote: > > On Mon, Aug 15, 2016 at 10:57:32AM -0700, Ben Pfaff wrote: >> On Mon, Aug 15, 2016 at 10:43:45AM -0700, Jarno Rajahalme wrote: >>> On Aug 14, 2016, at 5:34 PM, Ben Pfaff wrote: On Mon, Aug 08, 2016 at 11:26:30AM -0700, Jarno

Re: [ovs-dev] [PATCH v5 3/8] lex: Integrate error handling into struct lexer.

2016-08-15 Thread Ben Pfaff
Thanks for all the comments, I fixed all of them. A few responses: On Mon, Aug 15, 2016 at 03:26:05PM -0700, Justin Pettit wrote: > > On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > diff --git a/ovn/lib/lex.c b/ovn/lib/lex.c > > index 95edeaf..a05edfa 100644 > > --- a/ovn/lib/lex.c > > +++ b/o

Re: [ovs-dev] [PATCH v5 3/8] lex: Integrate error handling into struct lexer.

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c > index b56fcd5..b6350ae 100644 > --- a/ovn/lib/actions.c > +++ b/ovn/lib/actions.c > @@ -1,4 +1,4 @@ > -/* > + /* > * Copyright (c) 2015, 2016 Nicira, Inc. My guess is that this change to th

Re: [ovs-dev] [PATCH 2/3] FAQ: Add question on Packet loss with RFC2544 tests

2016-08-15 Thread Daniele Di Proietto
Applied to master, thanks 2016-08-14 11:35 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > Signed-off-by: Bhanuprakash Bodireddy > --- > FAQ.md | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/FAQ.md b/FAQ.md > index 2f50b96..22345c3 100644 > --- a

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Russell Bryant
On Mon, Aug 15, 2016 at 5:05 PM, Andy Zhou wrote: > > > On Mon, Aug 15, 2016 at 1:50 PM, Russell Bryant wrote: > >> >> >> On Mon, Aug 15, 2016 at 4:45 PM, Andy Zhou wrote: >> >>> >>> >>> On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote: >>> On Mon, Aug 15, 2016 at 2:54 PM,

[ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

2016-08-15 Thread Pravin B Shelar
With use of LCO support we can finally enable SG and CSUM features for GSO backport. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index f973fb4.

[ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

2016-08-15 Thread Pravin B Shelar
This basically backport commit: commit 179bc67f69b6cb53ad68cfdec5a917c2a2248355 Author: Edward Cree Date: Thu Feb 11 20:48:04 2016 + net: local checksum offload for encapsulation The arithmetic properties of the ones-complement checksum mean that a correctly checks

[ovs-dev] [PATCH 2/3] datapath: compat: handle_offloads: remove csum_help param.

2016-08-15 Thread Pravin B Shelar
Related to following upstream commit: commit 6fa79666e24d32be1b709f5269af41ed9e829e7e Author: Edward Cree Date: Thu Feb 11 21:02:31 2016 + net: ip_tunnel: remove 'csum_help' argument to iptunnel_handle_offloads All users now pass false, so we can remove it, and remove t

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Andy Zhou
On Mon, Aug 15, 2016 at 1:50 PM, Russell Bryant wrote: > > > On Mon, Aug 15, 2016 at 4:45 PM, Andy Zhou wrote: > >> >> >> On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote: >> >>> >>> >>> On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou wrote: >>> On Thu, Aug 11, 2016 at 1:22 PM,

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Aaron Conole
Daniele Di Proietto writes: > 2016-08-15 11:39 GMT-07:00 Mooney, Sean K : > >> >> >> >> >> *From:* Daniele Di Proietto [mailto:diproiet...@ovn.org] >> *Sent:* Monday, August 15, 2016 6:29 PM >> *To:* Mooney, Sean K >> *Cc:* dev@openvswitch.org; Loftus, Ciara >> *Subject:* Re: [ovs-dev] Remote O

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Do not attempt to initialise flow control for 'dpdkr' ports

2016-08-15 Thread Daniele Di Proietto
Applied to master, thanks 2016-08-15 2:36 GMT-07:00 Ciara Loftus : > Only 'dpdk' ports support flow control. This patch stops 'dpdkr' ports > from attempting to initialise this feature as this port type does not > support it. > > Fixes: 9fd39370c12c ("netdev-dpdk: Add Flow Control support.") > Si

Re: [ovs-dev] [PATCH] netdev-dpdk: Use rte_eth_is_valid_port instead of manual check

2016-08-15 Thread Daniele Di Proietto
Thanks, applied to master 2016-08-12 9:10 GMT-07:00 Mauricio Vasquez : > On 08/12/2016 05:57 PM, Ciara Loftus wrote: > >> Signed-off-by: Ciara Loftus >> > It is a necessary fix, specially if hotplug will be introduced. > Acked-by: Mauricio Vásquez B > >> --- >> lib/netdev-dpdk.c | 5 +++-- >>

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Russell Bryant
On Mon, Aug 15, 2016 at 4:45 PM, Andy Zhou wrote: > > > On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote: > >> >> >> On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou wrote: >> >>> >>> >>> On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote: >>> On Tue, Aug 9, 2016 at 7:49 PM, A

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Daniele Di Proietto
2016-08-15 11:39 GMT-07:00 Mooney, Sean K : > > > > > *From:* Daniele Di Proietto [mailto:diproiet...@ovn.org] > *Sent:* Monday, August 15, 2016 6:29 PM > *To:* Mooney, Sean K > *Cc:* dev@openvswitch.org; Loftus, Ciara > *Subject:* Re: [ovs-dev] Remote OVS feature discovery > > > > Hi Sean, > >

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Andy Zhou
On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant wrote: > > > On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou wrote: > >> >> >> On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote: >> >>> >>> >>> On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou wrote: >>> Automatically launch backup server for OVN S

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix double-remove in ovsdb_idl_condition_reset().

2016-08-15 Thread Andy Zhou
On Sat, Aug 13, 2016 at 5:37 PM, Ben Pfaff wrote: > Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call > ovs_list_remove() on the clause's 'node' member, but it should only be > called once. > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Russell Bryant
On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou wrote: > > > On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote: > >> >> >> On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou wrote: >> >>> Automatically launch backup server for OVN SB database that replicates >>> all transactions of the active server. Thi

Re: [ovs-dev] [PATCH v5 2/8] ovn-util: Add common functions for the default NB and SB databases.

2016-08-15 Thread Justin Pettit
> On Aug 14, 2016, at 3:24 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > Acked-by: Ryan Moats I gave an ack for v3 not realizing that we were already up to v5. Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org http

Re: [ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

2016-08-15 Thread Flaviof
On Sun, Aug 14, 2016 at 12:52 AM, Ben Pfaff wrote: > The conditional replication code had hardly any comments. This adds some. > > This commit also fixes a number of style problems, factors out some code > into a helper function, and moves some struct declarations from a public > header, that we

Re: [ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread pravin shelar
On Mon, Aug 15, 2016 at 10:04 AM, Jesse Gross wrote: > On Mon, Aug 15, 2016 at 9:57 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca >> Author: Martynas Pumputis >> Date: Tue Aug 9 16:24:50 2016 +0100 >> >> openvswitch: do not ig

Re: [ovs-dev] [PATCH v3 3/9] ovn-util: Add common functions for the default NB and SB databases.

2016-08-15 Thread Justin Pettit
> On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix memory leak in ovsdb_idl_condition_add_clause().

2016-08-15 Thread Flaviof
On Sat, Aug 13, 2016 at 7:58 PM, Ben Pfaff wrote: > The function always allocated a clause but didn't use it if it was > going to be a duplicate. > > Signed-off-by: Ben Pfaff > Acked-by: Flavio Fernandes > --- > lib/ovsdb-idl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

[ovs-dev] [PATCH v5] ovn: Support for GARP for NAT IPs via localnet

2016-08-15 Thread Chandra S Vejendla
In cases where a DNAT IP is moved to a new router or the SNAT IP is reused with a new mac address, the NAT IPs become unreachable because the external switches/routers have stale ARP entries. This commit aims to fix the problem by sending GARPs for NAT IPs via locanet A new options key "nat-addres

[ovs-dev] Read the MESSAGE from naughty Kimmy Kreuziger, Dev

2016-08-15 Thread Kimmy Kreuziger
Hey man my superstar ;)Would you mind to finding a young and nice girl? =)My name is Kimmy. I am from Ukraine .Have you ever heard that the loveliest girls in the world live in my country? Don't even doubt!my page is here: http://ofcegnam.datingsd。ru It's my photo "Kimmy80" src="http://ofcegnam

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-15 Thread Andy Zhou
On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant wrote: > > > On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou wrote: > >> Automatically launch backup server for OVN SB database that replicates >> all transactions of the active server. This can be handy for >> experimenting with the newly added replicat

[ovs-dev] [PATCH v5] Add read-only option to ovs-dpctl and ovs-ofctl commands.

2016-08-15 Thread Ryan Moats
ovs-dpctl and ovs-ofctl lack a read-only option to prevent running of commands that perform read-write operations. Add it and the necessary scaffolding to each. Signed-off-by: Ryan Moats --- lib/command-line.c | 51 + lib/command-line.h | 6 +- lib/db-ctl-

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Mooney, Sean K
From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Monday, August 15, 2016 6:29 PM To: Mooney, Sean K Cc: dev@openvswitch.org; Loftus, Ciara Subject: Re: [ovs-dev] Remote OVS feature discovery Hi Sean, I'm not familiar with OpenStack, so I'm not sure that my comments make sense for

Re: [ovs-dev] [PATCH v3 2/9] ovn: Rewrite logical action parsing and encoding library.

2016-08-15 Thread Ben Pfaff
Thanks for the review. I've applied this patch to master. I applied most of your comments in the obvious way, so I just snipped them below. A few responses: On Mon, Aug 15, 2016 at 11:12:19AM -0700, Justin Pettit wrote: > > On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote: > > +while (!lexer_ma

Re: [ovs-dev] Are there plans to add options for finetuning SSL server connection options?

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 11:22:32AM -0700, Ethan Rahn wrote: > Currently the ovs-server's set of SSL server options seem related to which > certificates to use. Under stream-ssl.c I see that there's no ability to > configure the TLS protocol nor ciphersuites used. I'm considering adding > these conf

Re: [ovs-dev] [PATCH v2] Python IDL Partial Set and Map Updates

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 11:03:30AM -0700, Amitabha Biswas wrote: > This patch fixes a couple of bugs in commit a59912a0 > (python: add support for partial map and partial set updates) > and reverses a simplication added in commit 884d9bad > (Simplify partial map Py3 IDL test) to make the Python3 te

[ovs-dev] Are there plans to add options for finetuning SSL server connection options?

2016-08-15 Thread Ethan Rahn
Hello, Currently the ovs-server's set of SSL server options seem related to which certificates to use. Under stream-ssl.c I see that there's no ability to configure the TLS protocol nor ciphersuites used. I'm considering adding these configuration options, but I want to make sure that I'm not goin

Re: [ovs-dev] [PATCH v8 3/3] tests: Add a new MTU test.

2016-08-15 Thread Daniele Di Proietto
On 14/08/2016 20:13, "Ben Pfaff" wrote: >On Fri, Aug 12, 2016 at 07:56:55PM -0700, Daniele Di Proietto wrote: >> Also, netdev-dummy needs to call netdev_change_seq_changed() in >> set_mtu(). >> >> Signed-off-by: Daniele Di Proietto > >This introduces a novel, and smart, usage of the ovs-vs

Re: [ovs-dev] [PATCH v4] ofproto: Reduce bundle memory use.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 10:57:32AM -0700, Ben Pfaff wrote: > On Mon, Aug 15, 2016 at 10:43:45AM -0700, Jarno Rajahalme wrote: > > > > > On Aug 14, 2016, at 5:34 PM, Ben Pfaff wrote: > > > > > > On Mon, Aug 08, 2016 at 11:26:30AM -0700, Jarno Rajahalme wrote: > > >> Instead of storing the (big) s

Re: [ovs-dev] [PATCH v3 2/9] ovn: Rewrite logical action parsing and encoding library.

2016-08-15 Thread Justin Pettit
> On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote: > > > diff --git a/include/ovn/actions.h b/include/ovn/actions.h > index a395ce9..d24db59 100644 > --- a/include/ovn/actions.h > +++ b/include/ovn/actions.h > @@ -20,16 +20,261 @@ > ... > +#define OVNACTS \ > +O

[ovs-dev] [PATCH v2] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
This patch fixes a couple of bugs in commit a59912a0 (python: add support for partial map and partial set updates) and reverses a simplication added in commit 884d9bad (Simplify partial map Py3 IDL test) to make the Python3 test cases passes. The following changes have been made: 1. Allow multipl

[ovs-dev] [PATCH v2] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
v1->v2: * Remove unused _init_mutations_if_needed function ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] NSH Option 2 implementation

2016-08-15 Thread Mooney, Sean K
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jesse Gross > Sent: Monday, August 15, 2016 6:12 PM > To: Jan Scheurich > Cc: dev@openvswitch.org; Manuel Buil ; Simon > Horman ; László Sürü > ; Miguel Angel Muñoz Gonzalez > ; Multanen, Eric W > > Subje

Re: [ovs-dev] [PATCH v4] ofproto: Reduce bundle memory use.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 10:43:45AM -0700, Jarno Rajahalme wrote: > > > On Aug 14, 2016, at 5:34 PM, Ben Pfaff wrote: > > > > On Mon, Aug 08, 2016 at 11:26:30AM -0700, Jarno Rajahalme wrote: > >> Instead of storing the (big) struct ofputil_flow_mod, create the new > >> rule and/or create the rule

Re: [ovs-dev] [PATCH v4] ofproto: Reduce bundle memory use.

2016-08-15 Thread Jarno Rajahalme
> On Aug 14, 2016, at 5:34 PM, Ben Pfaff wrote: > > On Mon, Aug 08, 2016 at 11:26:30AM -0700, Jarno Rajahalme wrote: >> Instead of storing the (big) struct ofputil_flow_mod, create the new >> rule and/or create the rule criteria for matching at bundle message >> insert time. This change reduces

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Rx checksum offloading feature on DPDK physical ports.

2016-08-15 Thread Jesse Gross
On Mon, Aug 8, 2016 at 3:03 AM, Sugesh Chandran wrote: > To enable checksum offloading at rx side while adding a port, add the > 'rx-checksum-offload' option to the 'ovs-vsctl add-port' command-line as > below, > > 'ovs-vsctl add-port br0 dpdk0 -- \ > set Interface dpdk0 type=dpdk options:rx-chec

Re: [ovs-dev] [PATCH v1] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
I must have overlooked removing that routine. It’s not needed. I’ll push v2. Thanks Amitabha > On Aug 15, 2016, at 9:22 AM, Ben Pfaff wrote: > > On Mon, Aug 15, 2016 at 02:21:55AM -0700, Amitabha Biswas wrote: >> This patch fixes a couple of bugs in commit a59912a0 >> (python: add support for p

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Daniele Di Proietto
Hi Sean, I'm not familiar with OpenStack, so I'm not sure that my comments make sense for every possible use case. I'm not 100% sure an explicit feature discovery interface is required. If an interface is well designed it should be possible to discover features by "probing". We never had any pr

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Daniele Di Proietto
Hi Sean, I'm not familiar with OpenStack, so I'm not sure that my comments make sense for every possible use case. I'm not 100% sure an explicit feature discovery interface is required. If an interface is well designed it should be possible to discover features by "probing". We never had any pr

Re: [ovs-dev] NSH Option 2 implementation

2016-08-15 Thread Jesse Gross
On Fri, Aug 12, 2016 at 1:01 AM, Jan Scheurich wrote: > The only clean way to avoid that now would be to maintain the monolithic > push/pop_nsh semantic of the Yi Yang patch and always push/pop NSH header and > outer MAC header together. Together with Simon's patch we could still achieve > NSH

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Daniele Di Proietto
Hi Sean, 2016-08-15 9:04 GMT-07:00 Mooney, Sean K : > Hi Daniele > Sorry to top post but I have just read back over the last > couple of revisions of this patch. > No problem, thanks for stepping in. As I said many times during the review of this series I'm not sure what the best interface woul

Re: [ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread pravin shelar
On Sat, Aug 13, 2016 at 10:11 AM, Jesse Gross wrote: > On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca >> Author: Martynas Pumputis >> Date: Tue Aug 9 16:24:50 2016 +0100 >> >> openvswitch: do not i

Re: [ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread Jesse Gross
On Mon, Aug 15, 2016 at 9:57 AM, Pravin B Shelar wrote: > Upstream commit: > commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca > Author: Martynas Pumputis > Date: Tue Aug 9 16:24:50 2016 +0100 > > openvswitch: do not ignore netdev errors when creating tunnel vports > > The cre

[ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread Pravin B Shelar
Upstream commit: commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca Author: Martynas Pumputis Date: Tue Aug 9 16:24:50 2016 +0100 openvswitch: do not ignore netdev errors when creating tunnel vports The creation of a tunnel vport (geneve, gre, vxlan) brings up a correspond

[ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Mooney, Sean K
Hi I would like to bring up a recurring problem that Has arisen several times with enabling new ovs features in OpenStack. OpenStack neutron supports many different network backend Including ovs which is currently the most common . As OpenStack has to support multiple versions of ovs both to prov

Re: [ovs-dev] [PATCH 1/2] datapath: backport: OVS: Ignore negative headroom value

2016-08-15 Thread pravin shelar
On Sat, Aug 13, 2016 at 10:08 AM, Jesse Gross wrote: > On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 5ef9f289c4e698054e5687edb54f0da3cdc9173a >> Author: Ian Wienand >> Date: Wed Aug 3 15:44:57 2016 +1000 >> >> OVS: Ignore negative headro

Re: [ovs-dev] [ovs-dev, v4, 1/2] Add read-only option to ovs-dpctl and ovs-ofctl commands.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 03:53:26AM +, Ryan Moats wrote: > ovs-dpctl and ovs-ofctl lack a read-only option to prevent > running of commands that perform read-write operations. Add > it and the necessary scaffolding to each. > > Signed-off-by: Ryan Moats I still get tons of patch rejects, dun

Re: [ovs-dev] [ovs-dev, v3] ovn-controller: Remove flows created for now deleted SB database rows.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 04:11:31AM +, Ryan Moats wrote: > Ensure that rows created for deleted port binding and > multicast group rows are cleared when doing full processing. > > Signed-off-by: Ryan Moats Applied, thanks! ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH monitor_cond V13 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 04:03:52PM +0300, Liran Schour wrote: > Use struct uuid * on [add|remove]_clause on columns which are references to > tables. That prevents use-after-free errors. > > Signed-off-by: Liran Schour This seems reasonable but there's a ton of repetitive code here. Could you f

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Use passed ctx in XLATE_REPORT_ERROR.

2016-08-15 Thread Jesse Gross
On Mon, Aug 15, 2016 at 9:22 AM, Ben Pfaff wrote: > On Mon, Aug 15, 2016 at 08:21:19AM -0700, Jesse Gross wrote: >> XLATE_REPORT_ERROR is a macro that takes struct xlate_ctx as an >> argument but also implicitly uses 'ctx' from the local function >> scope. This is works with current uses but it re

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Use passed ctx in XLATE_REPORT_ERROR.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 08:21:19AM -0700, Jesse Gross wrote: > XLATE_REPORT_ERROR is a macro that takes struct xlate_ctx as an > argument but also implicitly uses 'ctx' from the local function > scope. This is works with current uses but it really should be > using the argument. > > Signed-off-by:

Re: [ovs-dev] [PATCH v1] Python IDL Partial Set and Map Updates

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 02:21:55AM -0700, Amitabha Biswas wrote: > This patch fixes a couple of bugs in commit a59912a0 > (python: add support for partial map and partial set updates) > and reverses a simplication added in commit 884d9bad > (Simplify partial map Py3 IDL test) to make the Python3 te

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Mooney, Sean K
Hi Daniele Sorry to top post but I have just read back over the last couple of revisions of this patch. I noticed that you requested that the vhost-driver-mode flag be removed From the Open_vSwitch table. The vhost-driver-mode flag was included in The original patch for two reasons 1 to configure t

Re: [ovs-dev] [PATCH v5] netdev-dpdk: Set pmd thread priority

2016-08-15 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Daniele Di Proietto [mailto:diproiet...@ovn.org] >Sent: Wednesday, July 27, 2016 10:10 PM >To: Kavanagh, Mark B >Cc: Bodireddy, Bhanuprakash ; >dev@openvswitch.org >Subject: Re: [PATCH v5] netdev-dpdk: Set pmd thread priority > >Thanks for the patch, the implemen

[ovs-dev] [PATCH V6] netdev-dpdk: Set pmd thread priority

2016-08-15 Thread Bhanuprakash Bodireddy
Set the DPDK pmd thread scheduling policy to SCHED_RR and static priority to highest priority value of the policy. This is to deal with pmd thread starvation case where another cpu hogging process can get scheduled/affinitized on to the same core the pmd thread is running there by significantly imp

[ovs-dev] [PATCH] ofproto-dpif-xlate: Use passed ctx in XLATE_REPORT_ERROR.

2016-08-15 Thread Jesse Gross
XLATE_REPORT_ERROR is a macro that takes struct xlate_ctx as an argument but also implicitly uses 'ctx' from the local function scope. This is works with current uses but it really should be using the argument. Signed-off-by: Jesse Gross --- ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Loftus, Ciara
> > Thanks for the patch, I tried it and it makes possible to restart vswitchd and > qemu. > I believe that now vhost_server_id and vhost_client_id are not constant for > the lifetime of the struct and must be protected with dev->mutex. > The following incremental on top of your patch does that an

[ovs-dev] [PATCH v5 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Ciara Loftus
Until now, vHost ports in OVS have only been able to operate in 'server' mode whereby OVS creates and manages the vHost socket and essentially acts as the vHost 'server'. With this commit a new mode, 'client' mode, is available. In this mode, OVS acts as the vHost 'client' and connects to the socke

[ovs-dev] [PATCH v5 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-15 Thread Ciara Loftus
This commit removes the 'dpdkvhostcuse' port type from the userspace datapath. vhost-cuse ports are quickly becoming obsolete as the vhost-user port type begins to support a greater feature-set thanks to the addition of things like vhost-user multiqueue and potential upcoming features like vhost-us

[ovs-dev] [PATCH v5 2/3] netdev-dpdk: Consistent naming for vhost

2016-08-15 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty init functions for netdev dpdk classes. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ciara Loftus ---

[ovs-dev] Documents from Purple Office - IN00064493

2016-08-15 Thread Jen
Please find attached invoice/credit from Purple Office. Best regards, Purple Office ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell quoting inos-release.

2016-08-15 Thread Panu Matilainen
On 08/15/2016 03:40 AM, Ryan Moats wrote: Ben Pfaff wrote on 08/14/2016 07:38:08 PM: From: Ben Pfaff To: Ryan Moats/Omaha/IBM@IBMUS Cc: dev@openvswitch.org, Matthew Mulsow/Austin/IBM@IBMUS Date: 08/14/2016 07:38 PM Subject: Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell quoting inos-rel

[ovs-dev] [PATCH monitor_cond V13 2/2] ovn: implementation of conditional monitoring usage

2016-08-15 Thread Liran Schour
Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Performance evaluation: OVN is the main candidate for conditional monitoring usage.

Re: [ovs-dev] [PATCH monitor_cond V12 2/2] ovn: implementation of conditional monitoring usage

2016-08-15 Thread Liran Schour
Ben Pfaff wrote on 14/08/2016 07:51:05 AM: > On Tue, Aug 02, 2016 at 04:38:00PM +0300, Liran Schour wrote: > > Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group > > MAC_Binding tables. As a result ovn-controller will be notified only about > > records belongs to a datapath tha

[ovs-dev] [PATCH monitor_cond V13 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

2016-08-15 Thread Liran Schour
Use struct uuid * on [add|remove]_clause on columns which are references to tables. That prevents use-after-free errors. Signed-off-by: Liran Schour --- ovsdb/ovsdb-idlc.in | 62 ++--- 1 file changed, 54 insertions(+), 8 deletions(-) diff --git a/

[ovs-dev] Emailing - 9825670427868

2016-08-15 Thread Emma Critchley
Hi Vicky has asked me to forward you the finance documents (Please see attached) Many Thanks ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Order Confirmation-3317-2908484-20160815-376865

2016-08-15 Thread orderconfirmation
_ This communication and any files transmitted with it contain information which is confidential and which may also be privileged. It is for the exclusive use of the intended recipient(s). If you are not the intended recipient(s), pl

  1   2   >