On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou <az...@ovn.org> wrote:

>
>
> On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant <russ...@ovn.org> wrote:
>
>>
>>
>> On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou <az...@ovn.org> wrote:
>>
>>> Automatically launch backup server for OVN SB database that replicates
>>> all transactions of the active server. This can be handy for
>>> experimenting with the newly added replication feature.
>>>
>>> Signed-off-by: Andy Zhou <az...@ovn.org>
>>>
>>
>> Sure, seems fine to me.  You could also add some notes to OVN-Tutorial.md
>> about how to poke at the backup replica.
>>
>
> How about the following incremental? I'd like to fold it in before pushing
> diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md
> index a1fff0b..be9805c 100644
> --- a/tutorial/OVN-Tutorial.md
> +++ b/tutorial/OVN-Tutorial.md
> @@ -25,12 +25,17 @@ environment:
>    1. Creates the `OVN_Northbound` and `OVN_Southbound` databases as
> described in
>       [ovn-nb(5)] and [ovn-sb(5)].
>
> -  2. Creates the `hardware_vtep` database as described in [vtep(5)].
> +  2. Creates a backup server for `OVN_Southbond` database. Sandbox launch
> +     screen provides the instructions on accessing the backup database.
> +     However access to the backup server is not required to go through the
> +     tutorial.
>
> -  3. Runs the [ovn-northd(8)], [ovn-controller(8)], and
> [ovn-controller-vtep(8)]
> +  3. Creates the `hardware_vtep` database as described in [vtep(5)].
> +
> +  4. Runs the [ovn-northd(8)], [ovn-controller(8)], and
> [ovn-controller-vtep(8)]
>       daemons.
>
> -  4. Makes OVN and VTEP utilities available for use in the environment,
> +  5. Makes OVN and VTEP utilities available for use in the environment,
>       including [vtep-ctl(8)], [ovn-nbctl(8)], and [ovn-sbctl(8)].
>
>  Note that each of these demos assumes you start with a fresh sandbox
>

This incremental looks good.

Any reason not to add a backup for northbound, as well?


>> Acked-by: Russell Bryant <russ...@ovn.org>
>>
> Thanks for the review.
>
>
No problem.

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to