Re: [ovs-dev] [PATCH V7 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

2016-08-09 Thread Ilya Maximets
Hi, Daniele. Maybe I'm not the very right person to review such things, but I'm actually used this patch since it appeared in your github and it looks good to me. Also, I wanted to remove this non-working implementation of 'netdev_dpdk_set_mtu' for a long time. Acked-by: Ilya Maximets On 09.08.2

Re: [ovs-dev] [PATCH V7 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

2016-08-09 Thread Ilya Maximets
On 09.08.2016 19:01, Mark Kavanagh wrote: > From: Daniele Di Proietto > > Every provider silently drops the const attribute when converting the > parameter to the appropriate subclass. Might as well drop the const > attribute from the parameter, since this is a "set" function. > > Signed-off-by

Re: [ovs-dev] [PATCH v1] ovn: Extend Address_Set to Macros to support define port name sets

2016-08-09 Thread Zong Kai Li
On Thu, Aug 4, 2016 at 7:46 PM, Russell Bryant wrote: > > > On Wed, Aug 3, 2016 at 6:31 PM, Ben Pfaff wrote: >> >> On Wed, Aug 03, 2016 at 11:14:20PM +0800, Zong Kai LI wrote: >> > This patch aims to extend Address_Set to Macros, make it more common to >> > accept variable set, not only address.

[ovs-dev] [PATCH v1] ovn: rename Address_Set to Set to reflect a more broad purpose

2016-08-09 Thread Zong Kai LI
This patch renames table Address_Set to Set, Address_Set.addresses to Set.members to reflect a more broad purpose, that we can define other types of sets than address set. Per discussion around [1] and [2], this patch only does rename work on table Address_Set, and consider put future purpose on u

[ovs-dev] [CudaMailTagged] 国家海运,什么样的货都可以接,价格优惠,时效稳定

2016-08-09 Thread Bright
深圳民海国际承接散货拼箱,整柜出口,可接受敏感货物,电池,化工品,化妆品等。 深圳市民海国际物流有限公司总部位于深圳,业务分布于香港、中国内地、东南亚以及全球极具活力和潜力的新兴市场,在国际物流界有着广泛影响。公司与多家世 界著名的运输供应商建立了长期而深厚的业务关系:国际海运主要代理OOCL、APL、EVERGREEN、YANGMING、WHL的东南亚/中东/印巴航线, COSCO、MISC、PIL、ANL 、MAERSK、OOCL的欧洲/地中海航线, COSCO、NYK、EVERGREEN、MSC、CMA-CGM、CSAV、SAFMARINE的拉美航线, SAFMARINE、

Re: [ovs-dev] [v2] ovs-vsctl: simply vsctl_parent_process_info()

2016-08-09 Thread William Tu
Thanks for making this code much more clean. I've tested it and no problem. Acked-by: William Tu On Tue, Aug 9, 2016 at 12:50 PM, Andy Zhou wrote: > Use ds_get_line() instead of hand rolling it. Rearrange the logic > to removes some duplication. > > Signed-off-by: Andy Zhou > > --- > v1->v2:

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-09 Thread Daniele Di Proietto
2016-08-08 7:18 GMT-07:00 Loftus, Ciara : > > > > The patch mostly looks good to me, thanks. > > I'm not 100% sure about the interface. Can we make the flag interface > > specific? > > I'm not 100% sure about making the flag interface specific :) Do you think > there's a use case for both client

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Avoid reconfiguration on reconnection of same vhost device.

2016-08-09 Thread Daniele Di Proietto
2016-08-08 4:19 GMT-07:00 Ilya Maximets : > Binding/unbinding of virtio driver inside VM leads to reconfiguration > of PMD threads. This behaviour may be abused by executing bind/unbind > in an infinite loop to break normal networking on all ports attached > to the same instance of Open vSwitch. >

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Aug 9, 2016 8:28 PM, "Ryan Moats" wrote: > > Numan Siddique wrote on 08/09/2016 09:39:21 AM: > > > From: Numan Siddique > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 08/09/2016 09:39 AM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > > after (re)conn

Re: [ovs-dev] [PATCH] netdev-dpdk: add DPDK pdump capability

2016-08-09 Thread Daniele Di Proietto
This is interesting, thanks for working on this. The patch looks pretty simple, most of the magic happens in DPDK, so I will comment only on the OvS side of things. Why is 'other_config:dpdk-pdump' required? Can't we always enable the feature? I tried running with it and I didn't notice any slo

[ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

2016-08-09 Thread Andy Zhou
Automatically launch backup server for OVN SB database that replicates all transactions of the active server. This can be handy for experimenting with the newly added replication feature. Signed-off-by: Andy Zhou --- tutorial/ovs-sandbox | 15 +++ 1 file changed, 15 insertions(+) di

[ovs-dev] Returned mail: see transcript for details

2016-08-09 Thread Automatic Email Delivery Software
The original message was received at Wed, 10 Aug 2016 07:00:44 +0800 from [97.17.115.44] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-09 Thread Sairam Venugopal
Hi Alin, I took a preliminary look at the patch and have added some review comments. I was mainly concerned about the use of switchContext->internalPortId when we no longer have switchContext->internalVport and we can have multiple internal ports. Thanks, Sairam On 8/2/16, 12:47 PM, "Alin Ser

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix dead initialization reported by clang.

2016-08-09 Thread Daniele Di Proietto
Applied to master, thanks 2016-08-07 14:06 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > Clang reports that value stored to 'tok' during initialization is never > read. > > Signed-off-by: Bhanuprakash Bodireddy > --- > lib/netdev-dpdk.c | 2 +- > 1 file changed, 1 inse

Re: [ovs-dev] [PATCH] INSTALL.DPDK: Update documentation for DPDK 16.07 support

2016-08-09 Thread Daniele Di Proietto
Applied to master, thanks 2016-08-08 0:55 GMT-07:00 Loftus, Ciara : > > > > Replace 'dpdk_nic_bind.py' references with 'dpdk-devbind.py'. The script > > name is changed in DPDK 16.07 as the script can be used also on crypto > > devices along with NICs. > > > > Update the command for setting packe

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-09 Thread Daniele Di Proietto
2016-08-09 10:20 GMT-07:00 Ian Stokes : > When egress policer is set as a QoS type for a port, an error may occur > during > setup if incorrect parameters are used for the rte_meter. If this occurs > the egress policer construct and set functions should free any allocated > memory relevant to the

Re: [ovs-dev] [PATCH] INSTALL.DPDK-ADVANCED: Add vhost multiqueue loopback testcase.

2016-08-09 Thread Daniele Di Proietto
Applied to master, thanks 2016-07-28 5:48 GMT-07:00 Bhanuprakash Bodireddy < bhanuprakash.bodire...@intel.com>: > Add steps for loopback test using vhost-user configured with multiqueue > doing packet forwarding in kernel. > > Signed-off-by: Bhanuprakash Bodireddy > --- > INSTALL.DPDK-ADVANCED.

Re: [ovs-dev] [PATCH] Revert "pvector: Expose non-concurrent priority vector."

2016-08-09 Thread Daniele Di Proietto
Simple revert, looks good to me, thanks Acked-by: Daniele Di Proietto 2016-08-09 13:59 GMT-07:00 Jarno Rajahalme : > This reverts commit 8bdfe1313894047d44349fa4cf4402970865950f. > > I failed to see that lib/dpif-netdev.c actually needs the concurrency > provided by pvector prior to this chang

Re: [ovs-dev] [PATCH RFC v2 3/3] ovn: add SLAAC support for IPv6

2016-08-09 Thread Dustin Lundquist
On Mon, Aug 1, 2016 at 7:16 PM, Zong Kai LI wrote: > This patch tries to implement Router Advertisement (RA) responder for SLAAC > on ovn-northd side. > > It tries to build lflows per each Logical Router Port, who have IPv6 > networks > and set their 'slaac' column to true. > > The lflows will lo

Re: [ovs-dev] [PATCH v3] dpif-netdev: dpcls per in_port with sorted subtables

2016-08-09 Thread Jan Scheurich
From your second mail I figure I should base on your revert patch and post a v5 instead where cpvector is replaced by the old pvector again. What is the best procedure for this? I guess I should wait until the revert patch is merged. But that might delay the review and reduce chances of making

[ovs-dev] [PATCH] Revert "pvector: Expose non-concurrent priority vector."

2016-08-09 Thread Jarno Rajahalme
This reverts commit 8bdfe1313894047d44349fa4cf4402970865950f. I failed to see that lib/dpif-netdev.c actually needs the concurrency provided by pvector prior to this change. More specifically, when a subtable is removed, concurrent lookups may skip over another subtable swapped in to the place of

Re: [ovs-dev] [PATCH RFC v2 2/3] ovn: add SLAAC support for IPv6

2016-08-09 Thread Dustin Lundquist
On Mon, Aug 1, 2016 at 7:19 PM, Zong Kai LI wrote: > This patch tries to implement Router Advertisement (RA) responder for SLAAC > on ovn-controller side. > > It parses lflows which have: > - match: inport == LRP_NAME && ip6.dst == ff02::2 && nd_rs >(nd_rs: icmp6.type == 133 && icmp6.code ==

Re: [ovs-dev] [PATCH V14] Function tracer to trace all functioncalls

2016-08-09 Thread Ryan Moats
"dev" wrote on 08/08/2016 11:41:21 PM: > > > > There is a python file [generate_ft_report.py] with the patch, > > that may be used to convert this trace output to a human readable > > format with symbol names instead of address and their execution > > times. This tool uses addr2line that expects

Re: [ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

2016-08-09 Thread Jarno Rajahalme
> On Aug 8, 2016, at 3:10 PM, Jan Scheurich wrote: > > Hi Jarno, > > While trying to rebase my "dpcls per in_port" patch to your updated > pvector/cpvector implementation, I have stumbled over a threading issue in > your patch. > > I believe that dpcls_destroy_subtable(), which may be invoke

Re: [ovs-dev] [PATCH v3] dpif-netdev: dpcls per in_port with sorted subtables

2016-08-09 Thread Jarno Rajahalme
> On Aug 9, 2016, at 7:08 AM, Jan Scheurich wrote: > > - Adapted to renamed cpvector API > Reverted dplcs to using cpvector due to threading issue during flow removal Would you be kind and make this a separate patch, with a more detailed commit message. Thanks, Jarno

[ovs-dev] [v2] ovs-vsctl: simply vsctl_parent_process_info()

2016-08-09 Thread Andy Zhou
Use ds_get_line() instead of hand rolling it. Rearrange the logic to removes some duplication. Signed-off-by: Andy Zhou --- v1->v2: rebase to current master. --- utilities/ovs-vsctl.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/utilities/ovs-vsctl.c b/

Re: [ovs-dev] [PATCH 2/2] datapath: backport: net: vxlan: lwt: Use source ip address during route lookup.

2016-08-09 Thread pravin shelar
On Tue, Aug 9, 2016 at 10:51 AM, Jesse Gross wrote: > On Mon, Aug 8, 2016 at 2:54 PM, Pravin B Shelar wrote: >> Upstream commit: >> commit 272d96a5ab10662691b4ec90c4a66fdbf30ea7ba >> Author: pravin shelar >> Date: Fri Aug 5 17:45:36 2016 -0700 >> >> net: vxlan: lwt: Use source

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-08-09 Thread Jesse Gross
On Tue, Aug 9, 2016 at 7:52 AM, Simon Horman wrote: > Hi Jesse, > > On Wed, Jul 13, 2016 at 07:35:59AM -0700, Jesse Gross wrote: >> On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson >> wrote: >> > I wanted to mention though, currently the type 2 metadata (MD2) isnt a top >> > priority for us.

Re: [ovs-dev] [PATCH RFC v2 1/3] ovn: add SLAAC support for IPv6

2016-08-09 Thread Dustin Lundquist
On Mon, Aug 1, 2016 at 7:16 PM, Zong Kai LI wrote: > This patch introduces methods to compose a Router Advertisement (RA) > packet, > introduces flags for RA, renames ovs_nd_opt to ovs_nd_lla_opt to specify > it's > Source/Target Link-layer Address option. > > Signed-off-by: Zong Kai LI > --- >

Re: [ovs-dev] netdev-dpdk: Fix deadlock in destroy_device().

2016-08-09 Thread Daniele Di Proietto
On 08/08/2016 01:02, "Kavanagh, Mark B" wrote: >> >>Minor comment inline. >> >>Acked-by: Ilya Maximets >> > >Other than the comment mentioned by Ilya, this LGTM also - thanks again for >resolving, Daniele. > >Acked-by: mark.b.kavan...@intel.com Thanks for the reviews, I applied this to ma

Re: [ovs-dev] [PATCH 2/2] datapath: backport: net: vxlan: lwt: Use source ip address during route lookup.

2016-08-09 Thread Jesse Gross
On Mon, Aug 8, 2016 at 2:54 PM, Pravin B Shelar wrote: > Upstream commit: > commit 272d96a5ab10662691b4ec90c4a66fdbf30ea7ba > Author: pravin shelar > Date: Fri Aug 5 17:45:36 2016 -0700 > > net: vxlan: lwt: Use source ip address during route lookup. > > LWT user can specify

Re: [ovs-dev] [PATCH 1/2] datapath: backport: net: vxlan: lwt: Fix vxlan local traffic.

2016-08-09 Thread Jesse Gross
On Mon, Aug 8, 2016 at 2:54 PM, Pravin B Shelar wrote: > Upstream commit: > commit bbec7802c6948c8626b71a4fe31283cb4691c358 > Author: pravin shelar > Date: Fri Aug 5 17:45:37 2016 -0700 > > net: vxlan: lwt: Fix vxlan local traffic. > > vxlan driver has bypass for local vxlan

Re: [ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-09 Thread Stokes, Ian
From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Friday, August 05, 2016 2:15 AM To: Stokes, Ian Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug. Thanks for the patch, comments inline 2016-08-02 9:37 GMT-07:00 Ian Stok

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-09 Thread Ian Stokes
When egress policer is set as a QoS type for a port, an error may occur during setup if incorrect parameters are used for the rte_meter. If this occurs the egress policer construct and set functions should free any allocated memory relevant to the policer and set the QoS configuration pointer to nu

Re: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

2016-08-09 Thread Darrell Ball
On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour wrote: > "dev" wrote on 03/08/2016 09:09:48 AM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 03/08/2016 09:10 AM > > Subject: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering. > > Sent b

Re: [ovs-dev] [PATCH V7 7/7] netdev-dpdk: add support for jumbo frames

2016-08-09 Thread Daniele Di Proietto
Thanks for all the series and the reviews, I will push this when the dependencies (patch 2 and patch 6) are reviewed. Daniele 2016-08-09 9:01 GMT-07:00 Mark Kavanagh : > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of

Re: [ovs-dev] [PATCH V7 1/7] ofproto: Consider datapath_type when looking for internal ports.

2016-08-09 Thread Daniele Di Proietto
On 09/08/2016 09:08, "Thadeu Lima de Souza Cascardo" wrote: >On Tue, Aug 09, 2016 at 05:01:14PM +0100, Mark Kavanagh wrote: >> From: Daniele Di Proietto >> >> Interfaces with type "internal" end up having a netdev with type "tap" >> in the dpif-netdev datapath, so a strcmp will fail to mat

Re: [ovs-dev] Documents Requested

2016-08-09 Thread Owen
Dear dev, Please find attached documents as requested. Best Regards, Owen ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V7 1/7] ofproto: Consider datapath_type when looking for internal ports.

2016-08-09 Thread Thadeu Lima de Souza Cascardo
On Tue, Aug 09, 2016 at 05:01:14PM +0100, Mark Kavanagh wrote: > From: Daniele Di Proietto > > Interfaces with type "internal" end up having a netdev with type "tap" > in the dpif-netdev datapath, so a strcmp will fail to match internal > interfaces. > > We can translate the types with ofproto_p

Re: [ovs-dev] [PATCH V6 7/7] netdev-dpdk: add support for jumbo frames

2016-08-09 Thread Kavanagh, Mark B
> >On 09.08.2016 18:02, Mark Kavanagh wrote: >> Add support for Jumbo Frames to DPDK-enabled port types, >> using single-segment-mbufs. >> >> Using this approach, the amount of memory allocated to each mbuf >> to store frame data is increased to a value greater than 1518B >> (typical Ethernet maxim

[ovs-dev] [PATCH V7 7/7] netdev-dpdk: add support for jumbo frames

2016-08-09 Thread Mark Kavanagh
Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated to each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space available in the mbuf me

[ovs-dev] [PATCH V7 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 2 +-

[ovs-dev] [PATCH V7 5/7] tests: Add a new MTU test.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Also, netdev-dummy needs to call netdev_change_seq_changed() in set_mtu(). Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 5 - tests/ofproto-dpif.at | 30 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V7 3/7] netdev: Pass 'netdev_class' to ->run() and ->wait().

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto This will allow run() and wait() methods to be shared between different classes and still perform class-specific work. Signed-off-by: Daniele Di Proietto --- lib/netdev-bsd.c | 6 +++--- lib/netdev-dummy.c| 4 ++-- lib/netdev-linux.c| 6 +++--- lib/net

[ovs-dev] [PATCH V7 4/7] netdev-dummy: Add dummy-internal class.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto "internal" netdevs are treated specially in OVS (e.g. for MTU), but the dummy datapath remaps both "system" and "internal" devices to the same "dummy" netdev class, so there's no way to discern those in tests. This commit adds a new "dummy-internal" netdev type, which w

[ovs-dev] [PATCH V7 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto The 'mtu_request' column can be used to set the MTU of a specific interface. This column is useful because it will allow changing the MTU of DPDK devices (implemented in a future commit), which are not accessible outside the ovs-vswitchd process, but it can be used for

[ovs-dev] [PATCH V7 1/7] ofproto: Consider datapath_type when looking for internal ports.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Interfaces with type "internal" end up having a netdev with type "tap" in the dpif-netdev datapath, so a strcmp will fail to match internal interfaces. We can translate the types with ofproto_port_open_type() before calling strcmp to fix this. This fixes a minor issue

Re: [ovs-dev] the host will be soft lookup when some illeagal packets attack host

2016-08-09 Thread pravin shelar
On Mon, Aug 8, 2016 at 8:32 PM, Zhangkun (K) wrote: > diff --git a/datapath/linux/compat/flow_dissector.c > b/datapath/linux/compat/flow_dissector.c > index 3f42dba..4c5d023 100644 > --- a/datapath/linux/compat/flow_dissector.c > +++ b/datapath/linux/compat/flow_dissector.c > @@ -77,7 +77,7 @@ ag

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-09 Thread pravin shelar
On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman wrote: > On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote: >> On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman >> wrote: >> > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: >> >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman >

[ovs-dev] FW: Documents Requested

2016-08-09 Thread Elvis
Dear dev, Please find attached documents as requested. Best Regards, Elvis ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V6 7/7] netdev-dpdk: add support for jumbo frames

2016-08-09 Thread Ilya Maximets
On 09.08.2016 18:02, Mark Kavanagh wrote: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of memory allocated to each mbuf > to store frame data is increased to a value greater than 1518B > (typical Ethernet maximum frame

[ovs-dev] [PATCH] openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-09 Thread Martynas Pumputis
The creation of a tunnel vport (geneve, gre, vxlan) brings up a corresponding netdev, a multi-step operation which can fail. For example, changing a vxlan vport's netdev state to 'up' binds the vport's socket to a UDP port - if the binding fails (e.g. due to the port being in use), the error is cu

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Ryan Moats
Numan Siddique wrote on 08/09/2016 09:39:21 AM: > From: Numan Siddique > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 08/09/2016 09:39 AM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > after (re)connection to switch > > On Tue, Aug 9, 2016 at 7:15 PM, Ryan Moat

[ovs-dev] [PATCH V6 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 2 +-

[ovs-dev] [PATCH V6 7/7] netdev-dpdk: add support for jumbo frames

2016-08-09 Thread Mark Kavanagh
Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated to each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space available in the mbuf me

[ovs-dev] [PATCH V6 1/7] ofproto: Consider datapath_type when looking for internal ports.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Interfaces with type "internal" end up having a netdev with type "tap" in the dpif-netdev datapath, so a strcmp will fail to match internal interfaces. We can translate the types with ofproto_port_open_type() before calling strcmp to fix this. This fixes a minor issue

[ovs-dev] [PATCH V6 5/7] tests: Add a new MTU test.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Also, netdev-dummy needs to call netdev_change_seq_changed() in set_mtu(). Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 5 - tests/ofproto-dpif.at | 30 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V6 4/7] netdev-dummy: Add dummy-internal class.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto "internal" netdevs are treated specially in OVS (e.g. for MTU), but the dummy datapath remaps both "system" and "internal" devices to the same "dummy" netdev class, so there's no way to discern those in tests. This commit adds a new "dummy-internal" netdev type, which w

[ovs-dev] [PATCH V6 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto The 'mtu_request' column can be used to set the MTU of a specific interface. This column is useful because it will allow changing the MTU of DPDK devices (implemented in a future commit), which are not accessible outside the ovs-vswitchd process, but it can be used for

[ovs-dev] [PATCH V6 3/7] netdev: Pass 'netdev_class' to ->run() and ->wait().

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto This will allow run() and wait() methods to be shared between different classes and still perform class-specific work. Signed-off-by: Daniele Di Proietto --- lib/netdev-bsd.c | 6 +++--- lib/netdev-dummy.c| 4 ++-- lib/netdev-linux.c| 6 +++--- lib/net

Re: [ovs-dev] [PATCH v2] dpif-netdev: dpcls per in_port with sorted subtables

2016-08-09 Thread Jan Scheurich
I just submitted a v3 version of the patch. No need to review this one. Jan > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jan Scheurich > Sent: Friday, 15 July, 2016 18:35 > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2] dpif-netdev: dpcls per

Re: [ovs-dev] [PATCH V5 7/7] netdev-dpdk: add support for Jumbo Frames

2016-08-09 Thread Kavanagh, Mark B
>Few minor comments inline. Thanks Ilya - responses inline. > >On 09.08.2016 15:03, Mark Kavanagh wrote: >> Add support for Jumbo Frames to DPDK-enabled port types, >> using single-segment-mbufs. >> >> Using this approach, the amount of memory allocated to each mbuf >> to store frame data is incr

Re: [ovs-dev] [PATCH v3] dpif-netdev: dpcls per in_port with sorted subtables

2016-08-09 Thread Jan Scheurich
This change improves the performance of the DPDK netdev datapath in real-world NFV scenarios by 30% or more. Given that the patch has been reviewed and conceptually agreed upon earlier (e.g. http://openvswitch.org/pipermail/dev/2016-July/074455.html) it would be great if it could still make it

Re: [ovs-dev] [RFC PATCH v2 1/5] Add NSH fields for Openvswitch flow key

2016-08-09 Thread Simon Horman
On Wed, Jul 13, 2016 at 01:36:14AM +0800, Johnson Li wrote: > Openvswitch could use the fields of Network Serivce Header(NSH) > as key to steer traffic to the Virtual Network Functions(VNF). > The key will contain fields for NSH base header, service path > header and context header for MD type 1. F

Re: [ovs-dev] [RFC PATCH v2 06/13] Parse NSH header in function flow_extract in user space

2016-08-09 Thread Simon Horman
On Wed, Jul 13, 2016 at 01:27:53AM +0800, Johnson Li wrote: > Signed-off-by: Johnson Li > > diff --git a/lib/flow.c b/lib/flow.c > index a4c1215..cdeccfc 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -439,6 +439,46 @@ invalid: > arp_buf[1] = eth_addr_zero; > } > > +static int > +parse

Re: [ovs-dev] [RFC PATCH v2 04/13] Add APIs to set NSH keys for match fields

2016-08-09 Thread Simon Horman
On Wed, Jul 13, 2016 at 01:27:19AM +0800, Johnson Li wrote: > Signed-off-by: Johnson Li > > diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h > index c955753..4c79da3 100644 > --- a/include/openvswitch/match.h > +++ b/include/openvswitch/match.h > @@ -40,6 +40,18 @@ struct ma

Re: [ovs-dev] [RFC PATCH v2 3/5] parse NSH key in key_extract of openvswitch

2016-08-09 Thread Simon Horman
On Wed, Jul 13, 2016 at 01:36:30AM +0800, Johnson Li wrote: > Parse the Network Service Header to fullfill the fields in the > struct sw_flow_key. > > Signed-off-by: Johnson Li > > diff --git a/datapath/flow.c b/datapath/flow.c > index fd09cec..debac6f 100644 > --- a/datapath/flow.c > +++ b/data

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-08-09 Thread Simon Horman
Hi Jesse, On Wed, Jul 13, 2016 at 07:35:59AM -0700, Jesse Gross wrote: > On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson > wrote: > > I wanted to mention though, currently the type 2 metadata (MD2) isnt a top > > priority for us. It looks like its already been investigated how to use some >

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Tue, Aug 9, 2016 at 7:15 PM, Ryan Moats wrote: > "dev" wrote on 08/09/2016 07:19:27 AM: > > > From: Numan Siddique > > To: ovs dev > > Date: 08/09/2016 07:19 AM > > Subject: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > > after (re)connection to switch > > Sent by: "dev" > > >

Re: [ovs-dev] [PATCH V5 7/7] netdev-dpdk: add support for Jumbo Frames

2016-08-09 Thread Ilya Maximets
Few minor comments inline. On 09.08.2016 15:03, Mark Kavanagh wrote: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of memory allocated to each mbuf > to store frame data is increased to a value greater than 1518B > (ty

[ovs-dev] Documents Requested

2016-08-09 Thread Garth
Dear dev, Please find attached documents as requested. Best Regards, Garth ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v3] dpif-netdev: dpcls per in_port with sorted subtables

2016-08-09 Thread Jan Scheurich
The user-space datapath (dpif-netdev) consists of a first level "exact match cache" (EMC) matching on 5-tuples and the normal megaflow classifier. With many parallel packet flows (e.g. TCP connections) the EMC becomes inefficient and the OVS forwarding performance is determined by the megaflow clas

[ovs-dev] Documents Requested

2016-08-09 Thread Jeannie
Dear dev, Please find attached documents as requested. Best Regards, Jeannie ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Ryan Moats
"dev" wrote on 08/09/2016 07:19:27 AM: > From: Numan Siddique > To: ovs dev > Date: 08/09/2016 07:19 AM > Subject: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > after (re)connection to switch > Sent by: "dev" > > When ovn-controller reconnects to the ovs-vswitchd, it deletes all th

Re: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility.

2016-08-09 Thread Ryan Moats
Ben Pfaff wrote on 08/08/2016 11:56:22 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/08/2016 11:57 PM > Subject: Re: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility. > > On Mon, Aug 08, 2016 at 09:33:54PM -0500, Ryan Moats wrote: > > "dev" wrote o

[ovs-dev] FW: Documents Requested

2016-08-09 Thread Cedric
Dear dev, Please find attached documents as requested. Best Regards, Cedric ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovs-discuss] OVS DPDK VFIO error

2016-08-09 Thread Panu Matilainen
On 08/09/2016 03:14 PM, Kapil Adhikesavalu wrote: Hi Bhanu Prakash, I already check the BIOS, VT-d is enabled by default. From the dmesg, how can i find if VT-d is enabled, i see "IOMMU enabled", i don't understand the rest. [root@localhost ~]# dmesg | grep -e DMAR -e IOMMU [0.00] ACPI:

[ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
When ovn-controller reconnects to the ovs-vswitchd, it deletes all the OF flows in the switch. It doesn't install the flows again, leaving the datapath broken unless ovn-controller is restarted or ovn-northd updates the SB DB. The reason for this is - lflow_reset_processing() is not called after

Re: [ovs-dev] [ovs-discuss] OVS DPDK VFIO error

2016-08-09 Thread Kapil Adhikesavalu
Hi Bhanu Prakash, I already check the BIOS, VT-d is enabled by default. From the dmesg, how can i find if VT-d is enabled, i see "IOMMU enabled", i don't understand the rest. [root@localhost ~]# dmesg | grep -e DMAR -e IOMMU [0.00] ACPI: DMAR 0xBDDAD200 000558 (v01 HP ProLiant

Re: [ovs-dev] [ovs-discuss] OVS DPDK VFIO error

2016-08-09 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Kapil >Adhikesavalu >Sent: Tuesday, August 9, 2016 10:46 AM >To: dev@openvswitch.org; disc...@openvswitch.org >Subject: [ovs-discuss] OVS DPDK VFIO error > >Hi, > >On a Intel xeon E5-2697 chip with iomm

[ovs-dev] [PATCH V5 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 2 +-

[ovs-dev] [PATCH V5 4/7] netdev-dummy: Add dummy-internal class.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto "internal" netdevs are treated specially in OVS (e.g. for MTU), but the dummy datapath remaps both "system" and "internal" devices to the same "dummy" netdev class, so there's no way to discern those in tests. This commit adds a new "dummy-internal" netdev type, which w

[ovs-dev] [PATCH V5 7/7] netdev-dpdk: add support for Jumbo Frames

2016-08-09 Thread Mark Kavanagh
Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated to each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space available in the mbuf me

[ovs-dev] [PATCH V5 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto The 'mtu_request' column can be used to set the MTU of a specific interface. This column is useful because it will allow changing the MTU of DPDK devices (implemented in a future commit), which are not accessible outside the ovs-vswitchd process, but it can be used for

[ovs-dev] [PATCH V5 3/7] netdev: Pass 'netdev_class' to ->run() and ->wait().

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto This will allow run() and wait() methods to be shared between different classes and still perform class-specific work. Signed-off-by: Daniele Di Proietto --- lib/netdev-bsd.c | 6 +++--- lib/netdev-dummy.c| 4 ++-- lib/netdev-linux.c| 6 +++--- lib/net

[ovs-dev] [PATCH V5 5/7] tests: Add a new MTU test.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Also, netdev-dummy needs to call netdev_change_seq_changed() in set_mtu(). Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 5 - tests/ofproto-dpif.at | 30 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V5 1/7] ofproto: Consider datapath_type when looking for internal ports.

2016-08-09 Thread Mark Kavanagh
From: Daniele Di Proietto Interfaces with type "internal" end up having a netdev with type "tap" in the dpif-netdev datapath, so a strcmp will fail to match internal interfaces. We can translate the types with ofproto_port_open_type() before calling strcmp to fix this. This fixes a minor issue

Re: [ovs-dev] [PATCH V3 7/7] netdev-dpdk: add support for Jumbo Frames

2016-08-09 Thread Kavanagh, Mark B
>On 08.08.2016 18:50, Mark Kavanagh wrote: >> Add support for Jumbo Frames to DPDK-enabled port types, >> using single-segment-mbufs. >> >> Using this approach, the amount of memory allocated to each mbuf >> to store frame data is increased to a value greater than 1518B >> (typical Ethernet maximu

[ovs-dev] Delivery reports about your e-mail

2016-08-09 Thread Mail Delivery Subsystem
The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Documents Requested

2016-08-09 Thread Bridgette
Dear dev, Please find attached documents as requested. Best Regards, Bridgette ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] FW: Documents Requested

2016-08-09 Thread Bradford
Dear dev, Please find attached documents as requested. Best Regards, Bradford ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] FW: Documents Requested

2016-08-09 Thread Robt
Dear dev, Please find attached documents as requested. Best Regards, Robt ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Documents Requested

2016-08-09 Thread Rosalind
Dear dev, Please find attached documents as requested. Best Regards, Rosalind ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Documents Requested

2016-08-09 Thread Blair
Dear dev, Please find attached documents as requested. Best Regards, Blair ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] OVS DPDK VFIO error

2016-08-09 Thread Kapil Adhikesavalu
Hi, On a Intel xeon E5-2697 chip with iommu turned on with Intel NIC 82599, i am getting the following error while doing the NIC binding using VFIO. kernel: 4.23 fedora 23, i haven't tried the latest kernel yet. E5-2697 supports IOMMU VT-d, does VFIO NIC binding steps, modprobe vfio-pci sudo /u

Re: [ovs-dev] [PATCH V4 7/7] netdev-dpdk: add support for Jumbo Frames

2016-08-09 Thread Ilya Maximets
On 08.08.2016 18:50, Mark Kavanagh wrote: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of memory allocated to each mbuf > to store frame data is increased to a value greater than 1518B > (typical Ethernet maximum frame

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

2016-08-09 Thread Christian Svensson
On Mon, Aug 8, 2016 at 11:59 PM, Ben Pfaff wrote: > > Including the PID allows multiple daemons of a single type to run. While technically true, in practice I would argue this doesn't hold and is indeed one of the reason I made this change. The documented way to connect to a daemon is "ovs-appct