"dev" <dev-boun...@openvswitch.org> wrote on 08/09/2016 07:19:27 AM:
> From: Numan Siddique <nusid...@redhat.com> > To: ovs dev <dev@openvswitch.org> > Date: 08/09/2016 07:19 AM > Subject: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > after (re)connection to switch > Sent by: "dev" <dev-boun...@openvswitch.org> > > When ovn-controller reconnects to the ovs-vswitchd, it deletes all the > OF flows in the switch. It doesn't install the flows again, leaving > the datapath broken unless ovn-controller is restarted or ovn-northd > updates the SB DB. > > The reason for this is > - lflow_reset_processing() is not called after the reconnection > - the hmap "installed_flows" is not cleared, because of which > ofctrl_put skips adding the flows to the switch. > > This patch fixes the issue and also adds a test case to test > this scenario. > > Signed-off-by: Numan Siddique <nusid...@redhat.com> > --- I'm going to pick a nit on this one - is the behavior you are aiming for delete and re-add or just recalculate and leave alone? I ask because if it is "delete and re-add" aren't you still disrupting the datapath even if only momentarily? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
