The lrouter drop the traffic to it's own port IPs unless the IPs are
configured for SNAT. Now these flows are still built.
Signed-off-by: Dongjun
---
ovn/northd/ovn-northd.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
mode change 100644 => 100755 ovn/northd/ovn-north
Signed-off-by: Dongjun
---
tests/system-ovn.at | 106 +++-
1 file changed, 105 insertions(+), 1 deletion(-)
mode change 100644 => 100755 tests/system-ovn.at
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
old mode 100644
new mode 100755
ind
Fixed a minor bug that would print out a confusing warning about core mask,
"ovs_numa|WARN|Invalid cpu mask: x", when dpdl-lcore-mask has 0x prefix, e.g.
0x123, which is the convention used in INSTALL.DPDK.md.
Signed-off-by: Wei Shen
---
lib/ovs-numa.c | 5 +
1 file changed, 5 insertions(+)
I guess, you pushed some development version of this patch set.
There is strange commit there:
commit 6c54734ed27bc22975d7035a6bd5f32a412335a0
Author: Daniele Di Proietto
Date: Wed Jul 27 18:32:15 2016 -0700
XXX Improve comment.
Best regards, Ilya Maximets.
_
Thanks for the reply. The INSTALL.DPDK.md has those “0x” prefix used as example
212 * dpdk-lcore-mask
213 Specifies the CPU cores on which dpdk lcore threads should be spawned
and
214 expects hex string (eg '0x123').
so I think either we make those documents compliant or make the
Thanks for the reviews, I pushed this to master except for the system tests
part.
On 26/07/2016 17:58, "Daniele Di Proietto" wrote:
>This series aims to implement the ct() action for the dpif-netdev datapath.
>The bulk of the code is in the new conntrack module: it contains some packet
>parsi
On 27/07/2016 21:13, "Joe Stringer" wrote:
>On 27 July 2016 at 19:01, Daniele Di Proietto wrote:
>>
>>
>>
>>
>>
>> On 27/07/2016 17:14, "Joe Stringer" wrote:
>>
>>>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
This commit adds a thread that periodically removes expired connect
On Wed, Jul 27, 2016 at 04:02:11PM +0800, Zong Kai LI wrote:
> This patch introduces(from north to south):
> - OVN NB DB:
> * mtu(integer) column for Logical_Switch, used by Router Advertisement
>(RA) message MTU option.
> * slaac(bool) column for Logical_Router_Port to specify the IPv6 netwo
On Wed, Jul 27, 2016 at 04:23:07AM +, Ryan Moats wrote:
> [1] indicates that with incremental processing of logical flows
> desired conntrack groups are not being persisted. This patch
> adds this capability, with the side effect of adding a ds_copy
> method that this capability leverages.
>
On 27 July 2016 at 19:01, Daniele Di Proietto wrote:
>
>
>
>
>
> On 27/07/2016 17:14, "Joe Stringer" wrote:
>
>>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>>> This commit adds a thread that periodically removes expired connections.
>>>
>>> The expiration time of a connection can be exp
> On Jul 28, 2016, at 5:03 AM, Ben Pfaff wrote:
>
> On Mon, Jul 25, 2016 at 09:23:19AM -0700, nickcooper-zhangtonghao wrote:
>> If the logical router ports without 'peer' or the port named peer
>> is not created, it is unnecessary to insert the ports into the
>> southbound Port_Binding table.
>>
Good, it is unnecessary to check again.
> On Jul 28, 2016, at 2:13 AM, William Tu wrote:
>
> Hi zhangtonghao,
>
> Thanks for the patch!
> I think it's safe to call free(ptr) when ptr == NULL. The free() will
> be no operation.
>
> Regards,
> William
>
> On Tue, Jul 26, 2016 at 9:18 PM, nickco
> On Jul 28, 2016, at 5:01 AM, Ben Pfaff wrote:
>
> On Mon, Jul 25, 2016 at 09:19:00AM -0700, nickcooper-zhangtonghao wrote:
>> Deletion of a logical router port, which may be an other
>> router peer, result in a WARN, because the "ports" variable
>> still contains the logical port deleted. This
Ben Pfaff wrote on 07/27/2016 03:53:56 PM:
> From: Ben Pfaff
> To: Guru Shetty
> Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev
> Date: 07/27/2016 03:54 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected
> duplicate flow warnings
>
> On Tue, Jul 26, 2016 at 01:54:29PM -0700, Guru
On 27/07/2016 17:14, "Joe Stringer" wrote:
>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>> This commit adds a thread that periodically removes expired connections.
>>
>> The expiration time of a connection can be expressed by:
>>
>> expiration = now + timeout
>>
>> For each possibl
- Improve performance by scanning only changed port binding entries
when determining whether to mark the logical switch port up or
down
---
v4->v5:
- rebase
v3->v4:
- Add an initialization function to scan all entries in Port_binding table
when ovn-northd restarts or fails over
Signed-off-by:
Thanks for the patch.
I agree, I'd be nice to document this in INSTALL.DPDK-ADVANCED.md
We should also document the new fields in vswitchd/vswitch.xml.
Probably it's better to use "true" and "false" rather that "on" and "off",
for consistency with other configuration options and so that we can u
On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
> This commit adds a thread that periodically removes expired connections.
>
> The expiration time of a connection can be expressed by:
>
> expiration = now + timeout
>
> For each possible 'timeout' value (there aren't many) we keep a list.
> Wh
"dev" wrote on 07/27/2016 05:53:17 PM:
> From: Ben Pfaff
> To: Hui Kang
> Cc: dev@openvswitch.org
> Date: 07/27/2016 05:53 PM
> Subject: Re: [ovs-dev] [PATCH, v4] Scanning only changed entries in the
ovnsb
> Sent by: "dev"
>
> On Tue, Jul 26, 2016 at 10:25:07PM -0400, Hui Kang wrote:
> > - I
Russell Bryant wrote on 07/27/2016 04:13:34 PM:
> From: Russell Bryant
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 07/27/2016 04:14 PM
> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: Restore all_lports
> for update_ct_zone
>
> On Wed, Jul 27, 2016 at 8:42 AM, Ryan Moats wrote:
Ben Pfaff wrote on 07/27/2016 03:27:22 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 07/27/2016 03:27 PM
> Subject: Re: [ovs-dev] [PATCH] ovn: Add ovn-controller-vtep debian
package
>
> On Sat, Jul 23, 2016 at 10:38:34AM -0500, Ryan Moats wrote:
> > H
Ben Pfaff wrote on 07/27/2016 04:14:07 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 07/27/2016 04:14 PM
> Subject: Re: [ovs-dev] [PATCH ovn-controller] Physical: persist tunnels
>
> On Mon, Jul 25, 2016 at 04:28:52PM +, Ryan Moats wrote:
> > Whil
On 27 July 2016 at 14:50, Ben Pfaff wrote:
> On Tue, Jul 26, 2016 at 12:34:16PM -0700, Joe Stringer wrote:
>> python-openvswitch uses the python "six" library, add a dependency for
>> this to the debian package.
>>
>> VMware-BZ: #1700259
>> Reported-by: Devang Doshi
>> Signed-off-by: Joe Stringer
On Wed, Jul 27, 2016 at 01:48:47PM -0700, Ben Pfaff wrote:
> On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > When the route table is reset, the addresses list may be out of date, as we
> > race
> > for the many netlink socket notifications.
> >
> > A quick fix f
On Tue, Jul 26, 2016 at 08:24:57PM -0700, William Tu wrote:
> Testcase 1857: ovsdb-monitor.at:538 monitor-cond-change reports the
> following definitely memory leak:
> ovsdb_schema_create (ovsdb.c:34)
> ovsdb_schema_from_json (ovsdb.c:196)
> fetch_schema (ovsdb-client.c:385)
> do_mo
On Tue, Jul 26, 2016 at 12:34:16PM -0700, Joe Stringer wrote:
> python-openvswitch uses the python "six" library, add a dependency for
> this to the debian package.
>
> VMware-BZ: #1700259
> Reported-by: Devang Doshi
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
On Tue, Jul 26, 2016 at 08:12:36PM -0700, William Tu wrote:
> Valgrind testcase 1967: simple idl, conditional, modify as delete due
> to condition - C reports the following leak:
> json_array_create_empty (json.c:185)
> json_parser_push_array (json.c:1234)
> json_parser_input (json.c:13
On Tue, Jul 26, 2016 at 10:25:07PM -0400, Hui Kang wrote:
> - Improve performance by scanning only changed port binding entries
> when determining whether to mark the logical switch port up or
> down
>
> v3->v4:
> - Add an initialization function to scan all entries in Port_binding table
> when
Looks good to me, applied to master, thanks!
2016-07-27 8:06 GMT-07:00 Thadeu Lima de Souza Cascardo :
> Fix some uses of type on netdev_open.
>
> We established that there are two types: the database type and the netdev
> type.
> And that ofproto and dpif layers use the netdev type and return it
On Tue, Jul 26, 2016 at 11:28:14PM +0530, Numan Siddique wrote:
> When python IDL calls the "notify" function after processing the "update2"
> message from ovsdb-server, it is suppose to send the old values of the
> updated columns as the last parameter. But the recent commit "897c8064"
> sends the
On Wed, Jul 27, 2016 at 10:16:17PM +0100, Bhanuprakash Bodireddy wrote:
> Add contents section to FAQ and enable internal links in doc for pretty
> printing on GitHub.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
> v1->v2
> * Rebase.
> * Change link handling to titles.
Much less ugly. Thanks
On Wed, Jul 27, 2016 at 02:15:54AM -0700, Chandra S Vejendla wrote:
> In cases where a DNAT IP is moved to a new router or the SNAT IP is reused
> with a new mac address, the NAT IPs become unreachable because the external
> switches/routers have stale ARP entries. This commit
> aims to fix the pro
Thanks for the patch.
We never accepted the 0x prefix for pmd-cpu-mask, but I guess there's no
harm in doing it and it might make user's life easier.
We always use braces, even for single statement, please read CodingStyle.md
https://github.com/openvswitch/ovs/blob/master/CodingStyle.md#statemen
On Wed, Jul 27, 2016 at 1:44 AM, Babu Shanmugam wrote:
>
>
> On Wednesday 27 July 2016 06:43 AM, Russell Bryant wrote:
>
> On Tue, Jul 26, 2016 at 6:46 AM, wrote:
>
>> From: Babu Shanmugam
>>
>> Commit 263064a (Convert binding_run to incremental processing.) removed
>> the usage
>> of all_lport
On Mon, Jul 25, 2016 at 03:04:32PM -0700, Aaron Rosen wrote:
> This patch is done to enable in tree building of the ovn-utils python
> wrapper. This is similar to what was done in:
> ee89ea7b477bb4fd05137de03b2e8443807ed9f4
>
> Signed-off-by: Aaron Rosen
Applied, thanks!
>-Original Message-
>From: Ben Pfaff [mailto:b...@ovn.org]
>Sent: Wednesday, July 27, 2016 8:59 PM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org
>Subject: Re: [PATCH] FAQ: Add contents section and enable internal links.
>
>On Wed, Jul 27, 2016 at 08:48:12PM +0100, Bhanuprakash Bodi
On Wed, Jul 27, 2016 at 01:51:00PM -0700, Jesse Gross wrote:
> On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto
> wrote:
> > On 27/07/2016 13:12, "Joe Stringer" wrote:
> >
> >>On 26 July 2016 at 17:58, Daniele Di Proietto
> >>wrote:
> >>> The userspace connection tracker doesn't support ALG
Add contents section to FAQ and enable internal links in doc for pretty
printing on GitHub.
Signed-off-by: Bhanuprakash Bodireddy
---
v1->v2
* Rebase.
* Change link handling to titles.
FAQ.md | 56 +++-
1 file changed, 27 insertions(+), 29 del
On Tue, Jul 26, 2016 at 5:07 PM, Kyle Mestery wrote:
> On Tue, Jul 26, 2016 at 3:49 PM, Russell Bryant wrote:
> > When L3 gateway support was added, it introduced a port type called
> > "gateway" and a corresponding option called "gateway-chassis". Since
> > that time, we also have an L2 gatewa
On Wed, Jul 27, 2016 at 1:40 PM, Kyle Mestery wrote:
> While reading this document, the title stood out to me as not
> accurate. The title indicates it will discuss how to use
> Open vSwitch with Docker, but in reality, it's about using
> Open Virtual Networking with Docker.
>
> This change updat
On Mon, Jul 25, 2016 at 04:28:52PM +, Ryan Moats wrote:
> While commit ab39371d68842b7e4000cc5d8718e6fc04e92795
> (ovn-controller: Handle physical changes correctly) addressed
> unit test failures, it did so at the cost of performance: [1]
> notes that ovn-controller cpu usage is now pegged at
On Wed, Jul 27, 2016 at 8:42 AM, Ryan Moats wrote:
> As [1] indicates, commit 263064a (Convert binding_run
> to incremental processing.) incorrectly localized
> all_lports to the binding module, leaving an empty
> set for update_ct_zone to work with. This patch
> restores all_lports processing t
Thanks for the patch, the implementation looks good to me too.
During testing I kept noticing that it's way too easy to make OVS
completely unresponsive. As you point out in the documentation by having
dpdk-lcore-mask the same as pmd-cpu-mask, OVS cannot even be killed (a kill
-9 is required). I
On Wed, Jul 27, 2016 at 8:34 AM, Ryan Moats wrote:
> "dev" wrote on 07/27/2016 12:44:38 AM:
>
> > From: Babu Shanmugam
> > To: Russell Bryant
> > Cc: ovs dev
> > Date: 07/27/2016 12:45 AM
> > Subject: Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone
> > operates always on empty set
> > Se
On Mon, Jul 25, 2016 at 09:23:19AM -0700, nickcooper-zhangtonghao wrote:
> If the logical router ports without 'peer' or the port named peer
> is not created, it is unnecessary to insert the ports into the
> southbound Port_Binding table.
>
> Similarly, if logical switch ports of type 'router' don
On Mon, Jul 25, 2016 at 09:19:00AM -0700, nickcooper-zhangtonghao wrote:
> Deletion of a logical router port, which may be an other
> router peer, result in a WARN, because the "ports" variable
> still contains the logical port deleted. This port exists
> but should not have been initialized fully.
On Tue, Jul 26, 2016 at 01:54:29PM -0700, Guru Shetty wrote:
> On 24 July 2016 at 10:07, Ryan Moats wrote:
>
> > In the physical processing of ovn-controller, there are two
> > sets of OF flows that are still fully recalculated every cycle:
> >
> > Flows that aren't associated with any logical
On Wed, Jul 27, 2016 at 12:48 PM, Andy Zhou wrote:
>
>
> On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff wrote:
>
>> On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote:
>> > Release the memory of reply message of the initial "monitor" request.
>> >
>> > Reported-at: http://openvswitch.org/pip
On 26 July 2016 at 14:10, Flavio Leitner wrote:
> On Tue, Jul 26, 2016 at 12:57:07PM -0700, Joe Stringer wrote:
>> On 25 July 2016 at 18:16, Flavio Leitner wrote:
>> > Updates SELinux to allow ovs-vsctl to get parent process
>> > information and log that to the database:
>> >
>> > record 241: 201
On Mon, Jul 25, 2016 at 11:00:29AM +0300, Liran Schour wrote:
> Destroy shash on destroy of session's condition structure.
> Reported here: http://openvswitch.org/pipermail/dev/2016-July/075968.html
>
> Signed-off-by: Liran Schour
Applied, thanks!
___
On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto
wrote:
> On 27/07/2016 13:12, "Joe Stringer" wrote:
>
>>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>>> The userspace connection tracker doesn't support ALGs, frag reassembly
>>> or NAT yet, so skip those tests.
>>>
>>> Also, connecti
On Sun, Jul 24, 2016 at 01:07:26PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Though this should not happen when we have another address on the device that
> is
> IPv4 mapped, we should prevent adding a routing entry to IPv4 with an IPv6
> source address.
>
> This entry has been observed when
On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote:
> When the route table is reset, the addresses list may be out of date, as we
> race
> for the many netlink socket notifications.
>
> A quick fix for this is flushing the addresses list, before dumping the routes
> and
I'm planning to leave this series to Daniele, since he already seems to
be handling the main discussion.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Justin, are you the best person to review this (when you're back from
vacation)?
Thanks,
Ben.
On Sun, Jul 24, 2016 at 03:01:00PM +0300, itamaro wrote:
> From: itamaro
>
> This patch adds support for handeling a per-tunnel tunnel key in the
> ovs-vtep and vtep-ctl to support the usage of neutro
On 27/07/2016 13:12, "Joe Stringer" wrote:
>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>> The userspace connection tracker doesn't support ALGs, frag reassembly
>> or NAT yet, so skip those tests.
>>
>> Also, connection tracking state input from a local port is not possible
>> in
On Tue, Jul 26, 2016 at 06:28:30PM -0700, William Tu wrote:
> Valgrind testcase 1804 ovsdb-server.at:1023 insert rows, update rows by value
> reports the following leak.
> json_from_string (json.c:1025)
> execute_update (replication.c:614), similarily at execute_delete()
> process_table
On Sat, Jul 23, 2016 at 01:18:01PM -0700, Darrell Ball wrote:
> This patch enables source node replication in OVN for receive from Vxlan
> tunnels. OVN only supports source node replication mode.
>
> OVN only supports source_node replication and previously vtep interaction,
> which used service n
On Sat, Jul 23, 2016 at 10:38:34AM -0500, Ryan Moats wrote:
> Having a separate debian package for deploying
> the ovn-controller-vtep binary enables the ability
> to assign specific nodes the role of communicating
> with VTEP enabled TORs.
>
> Change-Id: Ia36aea7d89bd011a57918820b2a9f6e3469b3e04
On Tue, Jul 26, 2016 at 6:28 PM, William Tu wrote:
> Valgrind testcase 1804 ovsdb-server.at:1023 insert rows, update rows by
> value
> reports the following leak.
> json_from_string (json.c:1025)
> execute_update (replication.c:614), similarily at execute_delete()
> process_table_upda
On Mon, Jul 25, 2016 at 02:03:51PM -0400, Aaron Conole wrote:
> This commit allows the ovs-ctl command to spawn daemons without the
> internal process monitor. This is useful when integrating with,
> ex. systemd, which provides its own monitoring facilities.
>
> Signed-off-by: Aaron Conole
> Rev
On Wed, Jul 20, 2016 at 08:02:03PM +0530, bscha...@redhat.com wrote:
> ovn-northd processes the list of Port_Bindings and hashes the list of
> queues per chassis. When it finds a port with qos_parameters and without
> a queue_id, it allocates a free queue for the chassis that this port belongs.
> T
On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
> The userspace connection tracker doesn't support ALGs, frag reassembly
> or NAT yet, so skip those tests.
>
> Also, connection tracking state input from a local port is not possible
> in userspace.
>
> The userspace datapath pads all frames wi
This tests that the newly introduced pmd-rxq-affinity option works as
intended, at least for a single port.
Signed-off-by: Daniele Di Proietto
---
tests/pmd.at | 53 +
1 file changed, 53 insertions(+)
diff --git a/tests/pmd.at b/tests/pmd.at
i
On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant wrote:
>
>
> On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou wrote:
>
>>
>>
>> On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote:
>>
>>>
>>>
>>> On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote:
>>>
On Tue, Jul 26, 2016 at 5:37 AM,
I don't think dynamic_txqs should be atomic, since we change it when the pmd
threads are stopped.
Also, in port_create() we should check for 'netdev_n_txq(netdev) < n_cores + 1'
after we reconfigure the device.
Other than that this looks good to me, so I applied the following incremental
and p
ofputil_parse_key_value() to parse the affinity seems like a good idea, thanks!
I got a compiler warning on an unused variable. I fixed that and applied the
series to master.
Thanks,
Daniele
On 27/07/2016 07:44, "Ilya Maximets" wrote:
>New 'other_config:pmd-rxq-affinity' field for Interf
On Wed, Jul 27, 2016 at 08:48:12PM +0100, Bhanuprakash Bodireddy wrote:
> Add contents section to FAQ and enable internal links in doc for pretty
> printing on GitHub.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
> Reviewers can review the rendered form here
> https://github.com/bbodired/ovs/
On Wed, Jul 20, 2016 at 01:19:37AM -0700, nickcooper-zhangtonghao wrote:
> Hi Ryan,
> Thank you for your advice. The controller will drop the icmp4 packet whose
> eth.src or eth.dst is
> broadcast/multicast address and the type of icmp4 is “destination
> unreachable”. That may reduce
> the broad
Add contents section to FAQ and enable internal links in doc for pretty
printing on GitHub.
Signed-off-by: Bhanuprakash Bodireddy
---
Reviewers can review the rendered form here
https://github.com/bbodired/ovs/blob/master/FAQ.md
FAQ.md | 52 +++-
On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff wrote:
> On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote:
> > Release the memory of reply message of the initial "monitor" request.
> >
> > Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html
> > Signed-off-by: Andy Zhou
>
On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote:
> Release the memory of reply message of the initial "monitor" request.
>
> Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html
> Signed-off-by: Andy Zhou
> ---
> ovsdb/replication.c | 4
> 1 file changed, 4 inse
On Thu, Jul 21, 2016 at 3:55 AM, Chandran, Sugesh
wrote:
> Hi Mark & Jesse
>
> Thank you for looking into the the proposal,
> Please find my answers inline below.
>
> Regards
> _Sugesh
>
>> -Original Message-
>> From: Gray, Mark D
>> Sent: Wednesday, July 20, 2016 7:17 PM
>> To: Jesse Gros
On Wed, Jul 27, 2016 at 07:31:09PM +0100, Bhanuprakash Bodireddy wrote:
> Signed-off-by: Bhanuprakash Bodireddy
I applied all of these, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Jul 26, 2016 at 5:37 PM, William Tu wrote:
> Hi Andy,
>
> Thanks for fixing the memory leak! I've tested it and it solved the
> issue. btw, I think we don't have to assign "NULL" to static variable,
> C99 standard assume all static variable initializes to 0.
>
Right, I will drop the NULL
On Tue, Jul 19, 2016 at 10:58:08AM -0700, Ben Pfaff wrote:
> This document has two different kinds of text:
>
>- The first sections of the document, "Release Strategy" and "Release
> Numbering", describe what we've already been doing for most of the
> history of Open vSwitch. If the
On Thu, Jul 21, 2016 at 3:40 PM, Jan Scheurich
wrote:
> 1. The pending question whether to model NSH headers as packet header match
> fields, metadata fields, or both applies in particular to the MD2 TLVs.
>
> We have three main OpenFlow use cases for the MD2 TLVs:
> a) Match on an MD2 TLV of an
Some time ago this morning, I accidentally pushed several patches that
were still under review to master. I've force-pushed a correction to
the branch. My apologies--I hope that this does not screw up anyone's
development process in a bad way.
Sorry,
Ben.
___
On Mon, Jul 18, 2016 at 10:21:09PM -0700, Amitabha Biswas wrote:
> NB and SB dbs are handled by separate ovsdb-server processes. The
> ovsdb-server processes manage dbs based on the schemas for OVN NorthBound
> and SouthBound. These schemas do not have any Manager Options similar
> to the Open_vSwi
On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote:
> Flow key handleing changes:
> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN
> headers.
> - Add dpif multi-VLAN capability probing. If datapath supports multi-VLAN,
> increase the maximum depth of nested OVS_K
Signed-off-by: Bhanuprakash Bodireddy
---
INSTALL.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/INSTALL.md b/INSTALL.md
index 47126a3..591f924 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -779,6 +779,7 @@ Please report problems to b...@openvswitch.org.
[INSTALL.RHEL.md]:INSTALL.RHEL.md
Signed-off-by: Bhanuprakash Bodireddy
---
INSTALL.RHEL.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/INSTALL.RHEL.md b/INSTALL.RHEL.md
index 82f3efd..3c3f1a7 100644
--- a/INSTALL.RHEL.md
+++ b/INSTALL.RHEL.md
@@ -167,4 +167,5 @@ Reporting Bugs
Please report problems to b...@openvswitch.
Built-in CRC32 intrinsics can be used for efficient hash computation on
processors with SSE4.2 support.
Signed-off-by: Bhanuprakash Bodireddy
---
INSTALL.md | 15 +++
1 file changed, 15 insertions(+)
diff --git a/INSTALL.md b/INSTALL.md
index 591f924..6fbf9ea 100644
--- a/INSTALL.md
"dev" wrote on 07/26/2016 02:37:30 PM:
> From: "Liran Schour"
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 07/26/2016 02:38 PM
> Subject: Re: [ovs-dev] [ovs-dev,ovn-controller] Physical: persist tunnels
> Sent by: "dev"
>
> "dev" wrote on 26/07/2016 12:02:37 AM:
>
> > F
Added an IPv4 and MAC addresses management system to ovn-northd. When a logical
switch's other_config:subnet field is set, logical ports attached to that
switch that have the keyword "dynamic" in their addresses column will
automatically be allocated a globally unique MAC address/unused IPv4 addres
On Sun, Jul 3, 2016 at 11:16 AM, Ben Pfaff wrote:
> On Wed, Jun 29, 2016 at 01:53:24PM -0700, Nimay Desai wrote:
> > Added an IPv4 and MAC addresses management system to ovn-northd. When a
> logical
> > switch's options:subnet field is set, logical ports attached to that
> switch
> > that do not
On Wed, Jul 27, 2016 at 12:18:37PM +0800, nickcooper-zhangtonghao wrote:
> If the ‘ovsdb_condition_from_json’ return the error, cnd->clauses will be
> set NULL, so ‘ovsdb_condition_destroy’ should check the 'cnd->clauses’ before
> free it.
Please read CodingStyle.md:
Functions that destroy an
Hi zhangtonghao,
Thanks for the patch!
I think it's safe to call free(ptr) when ptr == NULL. The free() will
be no operation.
Regards,
William
On Tue, Jul 26, 2016 at 9:18 PM, nickcooper-zhangtonghao
wrote:
> Hi William,
> I reviewed your patch codes and found other bugs.
>
> If the ‘ovsdb_cond
"dev" wrote on 07/27/2016 12:40:23 PM:
> From: Kyle Mestery
> To: dev@openvswitch.org
> Date: 07/27/2016 12:40 PM
> Subject: [ovs-dev] [PATCH] doc: Update INSTALL.Docker.md to reflect
> it's focus on OVN
> Sent by: "dev"
>
> While reading this document, the title stood out to me as not
> accura
While reading this document, the title stood out to me as not
accurate. The title indicates it will discuss how to use
Open vSwitch with Docker, but in reality, it's about using
Open Virtual Networking with Docker.
This change updates the title, as well as the opening paragraphs
to more accurately
Ben Pfaff wrote on 07/27/2016 12:30:25 PM:
> From: Ben Pfaff
> To: Hui Kang/Watson/IBM@IBMUS
> Cc: Hui Kang , dev@openvswitch.org
> Date: 07/27/2016 12:30 PM
> Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the
ovnsb
>
> On Tue, Jul 26, 2016 at 03:44:57PM -0400, Hui Kang wr
On Tue, Jul 26, 2016 at 03:44:57PM -0400, Hui Kang wrote:
>
>
> "dev" wrote on 07/26/2016 02:20:27 PM:
>
> > From: Ben Pfaff
> > To: Hui Kang
> > Cc: dev@openvswitch.org
> > Date: 07/26/2016 02:20 PM
> > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the
> ovnsb
> > Sent b
On Wed, Jul 27, 2016 at 05:15:43PM +0100, Bhanuprakash Bodireddy wrote:
> Signed-off-by: Bhanuprakash Bodireddy
This probably makes better sense in INSTALL.md.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jul 27, 2016 at 09:13:50PM +0530, Deepanshu Saxena1/CHN/TCS wrote:
> Thanks for the review comments. I am working on the review comments.
>
> As per earlier discussion on meter implementation [1] the approach is to use
> tc capabilities for kernel implementation. Using qdisc and filters
Signed-off-by: Bhanuprakash Bodireddy
---
FAQ.md | 16
1 file changed, 16 insertions(+)
diff --git a/FAQ.md b/FAQ.md
index 35e1cac..6218feb 100644
--- a/FAQ.md
+++ b/FAQ.md
@@ -688,6 +688,22 @@ A: The OVS kernel datapath may have been updated to a
newer version than
recomme
On Wed, Jul 27, 2016 at 01:07:29PM +0530, Numan Siddique wrote:
> On Wed, Jul 27, 2016 at 11:13 AM, Ben Pfaff wrote:
>
> > The most important change here is to delete misspelled "the".
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > ovn/utilities/ovn-nbctl.c | 4 ++--
> > 1 file changed, 2 inserti
Thanks for the review comments. I am working on the review comments.
As per earlier discussion on meter implementation [1] the approach is to use tc
capabilities for kernel implementation. Using qdisc and filters
I implemented meter as rate limiter.
I understood your point that my code is app
tunnel_check_status_change__ calls netdev_open with type system. Using NULL
instead will default to system in case the device is not opened yet, and allow a
different type in case it's already opened.
Any type should be fine, as netdev_get_carrier will work with any of them.
Signed-off-by: Thadeu
Instead of using the internal type, use the port_open_type when creating the
local port. That makes sure that whenever dpif_port_query is used, the netdev
open_type is returned instead of the "internal" type.
For other ports, that is already the case, as the netdev type is used when
creating the d
When a device is already opened, netdev_open should verify that the types match,
or else return an error.
Otherwise, users might expect to open a device with a certain type and get a
handle belonging to a different type.
This also prevents certain conflicting configurations that would have a port
1 - 100 of 134 matches
Mail list logo
