Re: [ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

2016-07-19 Thread Justin Pettit
> On Jul 19, 2016, at 11:39 PM, Ben Pfaff wrote: > > On Tue, Jul 19, 2016 at 11:04:20PM -0700, Justin Pettit wrote: >> Reported-by: Ben Pfaff >> Signed-off-by: Justin Pettit > > Might add a Fixes: header. Done. > Acked-by: Ben Pfaff Thanks for spotting the problem and the quick review.

[ovs-dev] proposed OVS release schedule (was: [PATCH] release-process.md: Document OVS release process and propose a schedule.)

2016-07-19 Thread Ben Pfaff
Perhaps the title buried the lead. My main goal for this patch is to propose a new regular release schedule for OVS. Any comments? Thanks, Ben. On Tue, Jul 19, 2016 at 10:58:08AM -0700, Ben Pfaff wrote: > This document has two different kinds of text: > >- The first sections of the docume

Re: [ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 11:04:20PM -0700, Justin Pettit wrote: > Reported-by: Ben Pfaff > Signed-off-by: Justin Pettit Might add a Fixes: header. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

2016-07-19 Thread Justin Pettit
Reported-by: Ben Pfaff Signed-off-by: Justin Pettit --- lib/packets.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/packets.h b/lib/packets.h index 8f11e2c..5fd1e51 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -987,8 +987,9 @@ in6_is_lla(struct in6_addr *addr)

Re: [ovs-dev] [ovn-ipv6 20/26] packets: Add in6_is_lla() function.

2016-07-19 Thread Justin Pettit
> On Jul 19, 2016, at 10:49 PM, Ben Pfaff wrote: > > On Tue, Jul 19, 2016 at 10:16:12PM -0700, Justin Pettit wrote: >> >> diff --git a/lib/packets.h b/lib/packets.h >> index 02028c9..8f11e2c 100644 >> --- a/lib/packets.h >> +++ b/lib/packets.h >> @@ -980,10 +980,16 @@ in6_generate_lla(struct et

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-19 Thread Mickey Spiegel
Comments inline as -"dev" wrote: - To: Ben Pfaff From: Liran Schour Sent by: "dev" Date: 07/19/2016 01:45AM Cc: dev@openvswitch.org Subject: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage Conditional monitor of: Port_Binding, Logical_Flow

Re: [ovs-dev] [ovn-ipv6 24/26] [RFC] ovn-northd: Implement basic IPv6 routing.

2016-07-19 Thread Justin Pettit
> On Jul 13, 2016, at 1:10 PM, Ben Pfaff wrote: > > On Mon, Jul 11, 2016 at 11:56:54PM -0700, Justin Pettit wrote: >> Future commits will add support for dynamic IPv6/MAC bindings. >> >> TODO: >>- ovn-northd man page needs updated flows. >>- Add unit tests. > > I hope it's OK if I defe

Re: [ovs-dev] [ovn-ipv6 20/26] packets: Add in6_is_lla() function.

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 10:16:12PM -0700, Justin Pettit wrote: > > > On Jul 13, 2016, at 12:57 PM, Ben Pfaff wrote: > > > > On Mon, Jul 11, 2016 at 11:56:50PM -0700, Justin Pettit wrote: > >> This will have a caller in a future commit. > >> > >> Signed-off-by: Justin Pettit > > > >> +static i

Re: [ovs-dev] [networking-ovn] Re: Issue when using ovn with Openstack

2016-07-19 Thread Chen Li
Just Tested with another multi-node setup with older code (code download in last week), and everything works. Here are the last changes for workable ovs/neutron/networking-ovn: ovs: commit 3041e1fc963886c3e19f1b848df20c6f9d96b289 Author: William Tu Date: Fri Jul 1 09:45:52 2016 -0700 sys

[ovs-dev] MAIL SYSTEM ERROR - RETURNED MAIL

2016-07-19 Thread MAILER-DAEMON
Your message was not delivered due to the following reason(s): Your message was not delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

Re: [ovs-dev] [networking-ovn] Re: Issue when using ovn with Openstack

2016-07-19 Thread Chen Li
Thanks for adding the openstack-dev. Yes, I'm running with devstack, and using the master branch of everything. I just updated every thing several hours ago to make sure this is not an issue already been fixed. The last change in neutron: commit 122a971656671f92927d44ddd3725cca74b4e0bb Merge: 82

Re: [ovs-dev] [ovn-ipv6 20/26] packets: Add in6_is_lla() function.

2016-07-19 Thread Justin Pettit
> On Jul 13, 2016, at 12:57 PM, Ben Pfaff wrote: > > On Mon, Jul 11, 2016 at 11:56:50PM -0700, Justin Pettit wrote: >> This will have a caller in a future commit. >> >> Signed-off-by: Justin Pettit > >> +static inline bool >> +in6_is_lla(struct in6_addr *addr) >> +{ >> +return addr->s6_ad

[ovs-dev] [networking-ovn] Re: Issue when using ovn with Openstack

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/19/2016 10:44:27 PM: > From: Chen Li > To: dev@openvswitch.org > Date: 07/19/2016 10:44 PM > Subject: [ovs-dev] Issue when using ovn with Openstack > Sent by: "dev" > > Hi list, > > I have an all-in-one devstack environment with ovn enabled. > I create a neutron network. > Cr

[ovs-dev] Issue when using ovn with Openstack

2016-07-19 Thread Chen Li
Hi list, I have an all-in-one devstack environment with ovn enabled. I create a neutron network. Create a port A from the network with secgroup A Create a vm from the network with secgroup B. Secgroup B has both ICMP and tcp 22 enabled. Then I try to ping the VM from the dhcp namespace, since th

Re: [ovs-dev] [PATCH 3/3] ovn-northd: Ensure that flows are added to correct types of datapaths.

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 09:07:13AM -0700, Ben Pfaff wrote: > A DP_TYPE_SWITCH_* flow should only be added to a logical switch datapath, > and a DP_TYPE_ROUTER_* flow should only be added to a logical router > datapath, but the code previously did not verify this and it caused a > problem in practic

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote: > FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix > STREAM socket. The current code will assume it means a sun_path larger than 0. > > That breaks some tests like the one below which don't

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 07:28:05PM -0500, Ryan Moats wrote: > "dev" wrote on 07/19/2016 07:26:01 PM: > > > From: Ryan Moats/Omaha/IBM@IBMUS > > To: Ben Pfaff > > Cc: dev@openvswitch.org > > Date: 07/19/2016 07:26 PM > > Subject: Re: [ovs-dev] [PATCH 2/2] ovn-controller: Add incremental > > proce

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-19 Thread Yang, Yi Y
Jan, although NSH isn't tunnel, but we still need to do some matches after pop_nsh, this is similar to vxlan tunnel, we still can match vxlan tunnel metadata after the patch is de-capsulated, such as TUN_ID and TUN_DST. So my point is maybe we need both header fields and metadata fields. -O

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/08/2016 07:04:06 PM: > From: Nirapada Ghosh/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Date: 07/08/2016 07:04 PM > Subject: [ovs-dev] [PATCH V13] Function tracer to trace all function calls > Sent by: "dev" > > From: Nirapada Ghosh > > In some circumstances, we might need

Re: [ovs-dev] [RFC PATCH v2 12/13] Commit push_eth/pop_eth flow action to data plane

2016-07-19 Thread Yang, Yi Y
Hi, Jan How do you know we trigger recirculate after pop_eth? pop_nsh also needs to do so, is there any existing example for reference? -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jan Scheurich Sent: Tuesday, July 19, 2016 3:46 PM To: Li, Johnson ; dev@

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/19/2016 07:26:01 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 07/19/2016 07:26 PM > Subject: Re: [ovs-dev] [PATCH 2/2] ovn-controller: Add incremental > processing to lflow_run and physical_run > Sent by: "dev" > > Ben Pfaff wrote o

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 07:07:35 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff , Ryan Moats/Omaha/IBM@IBMUS > Date: 07/19/2016 07:07 PM > Subject: [PATCH 2/2] ovn-controller: Add incremental processing to > lflow_run and physical_run > > From: Ryan Moats > > This code ch

Re: [ovs-dev] [PATCH 1/2] ofctrl: Refine treatment of duplicate flows in ofctrl_add_flow().

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/19/2016 07:07:34 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/19/2016 07:07 PM > Subject: [ovs-dev] [PATCH 1/2] ofctrl: Refine treatment of duplicate > flows in ofctrl_add_flow(). > Sent by: "dev" > > It's better to use the newer actions, in c

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 07:08:04 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs-dev > Date: 07/19/2016 07:08 PM > Subject: Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add > incremental processing to lflow_run and physical_run > > On Tue, Jul 19, 2016 at 04:55:49PM

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 04:55:49PM -0500, Ryan Moats wrote: > > > > On Tue, Jul 19, 2016 at 02:57:43PM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 07/19/2016 02:54:36 PM: > > > > > > > From: Ben Pfaff > > > To: Ryan Moats/Omaha/IBM at IBMUS> > > > Cc: dev at openvswitch.org > > > Date: 07

[ovs-dev] [PATCH 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
From: Ryan Moats This code changes to allow incremental processing of the logical flow and physical binding tables whenver possible. Note: flows created by physical_run for multicast_groups are *NOT* handled incrementally due to to be solved issues with GWs and local routers. Signed-off-by: Rya

[ovs-dev] [PATCH 1/2] ofctrl: Refine treatment of duplicate flows in ofctrl_add_flow().

2016-07-19 Thread Ben Pfaff
It's better to use the newer actions, in cases where the actions for duplicate flows differ, because on balance they are more likely to be correct. Signed-off-by: Ben Pfaff --- ovn/controller/ofctrl.c | 48 +++- 1 file changed, 43 insertions(+), 5 dele

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-19 Thread Simon Horman
On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: > On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman > wrote: > > [CC Jiri Benc for portion regarding GRE] > > > > Hi Pravin, > > > > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: > >> On Wed, Jul 13, 2016 at 12:31 AM, Simo

Re: [ovs-dev] [ovn-ipv6 17/26] packets: Introduce xor and is_zero functions on IPv6 addresses.

2016-07-19 Thread Justin Pettit
> On Jul 19, 2016, at 4:52 PM, Ben Pfaff wrote: > >> But what if we do the whole thing this way? >> >> #ifdef s6_addr32 >> #define s6_addrX s6_addr32 >> #define IPV6_FOR_EACH(VAR) for (int VAR = 0; VAR < 4; VAR++) >> #else >> #define s6_addrX s6_addr >> #define IPV6_FOR_EACH(VAR) for (int VAR =

Re: [ovs-dev] [ovn-ipv6 17/26] packets: Introduce xor and is_zero functions on IPv6 addresses.

2016-07-19 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 12:48:28PM -0700, Ben Pfaff wrote: > On Mon, Jul 11, 2016 at 11:56:47PM -0700, Justin Pettit wrote: > > These will have callers later. > > > > Signed-off-by: Justin Pettit > > > lib/packets.c | 38 ++ > > lib/packets.h | 3 +++ > > 2

Re: [ovs-dev] [PATCH] ovn: Add datapth of gateway port tolocal_datapaths

2016-07-19 Thread Mickey Spiegel
-"dev" wrote: - >To: dev@openvswitch.org >From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS >Sent by: "dev" >Date: 07/18/2016 05:50AM >Subject: [ovs-dev] [PATCH] ovn: Add datapth of gateway port to local_datapaths > >When a l3 gateway port is created on a chassis, the corresponding >datap

Re: [ovs-dev] [PATCH 4/4] ovsdb: Add unixctl commands for OVSDB replication

2016-07-19 Thread Andy Zhou
On Fri, Jun 24, 2016 at 4:44 PM, Ben Pfaff wrote: > From: Mario Cabrera > > Set and get the server to replicate from: > > ovsdb-server/set-remote-ovsdb-server {server} > ovsdb-server/get-remote-ovsdb-server > > Set and get the replicated table blacklist: > > ovsdb-server/

Re: [ovs-dev] [PATCH v2] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-19 Thread Jan Scheurich
Hi Antonio, Thanks for the review. I will fix all the editorials in v3. A few more answers inline. Thanks, Jan > -Original Message- > From: Fischetti, Antonio [mailto:antonio.fische...@intel.com] > Sent: Tuesday, 19 July, 2016 17:23 > > Hi Jan, > I added some comments prefixed with [Anton

[ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
> On Tue, Jul 19, 2016 at 02:57:43PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 07/19/2016 02:54:36 PM: > > > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM at IBMUS> > > Cc: dev at openvswitch.org > > Date: 07/19/2016 02:54 PM > > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add i

Re: [ovs-dev] [PATCH 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-19 Thread Ansis Atteka
On 14 July 2016 at 02:22, Jarno Rajahalme wrote: > > > On Jul 13, 2016, at 9:01 PM, Ansis Atteka wrote: > > > > There are two issues that this patch fixes: > > 1. it was impossible to set skb mark at all through > > NXM_NX_PKT_MARK register for tunnel packets; AND > > 2. ipsec_xxx tunnels woul

[ovs-dev] [PATCHv2 2/2] tunneling: get skb marking to work properly with tunnels

2016-07-19 Thread Ansis Atteka
There are two issues that this patch fixes: 1. it was impossible to set skb mark at all through NXM_NX_PKT_MARK register for tunnel packets; AND 2. ipsec_xxx tunnels would not be marked with the default IPsec mark (broken by d23df9a87 "lib/odp: Use masked set actions."). This patch also a

[ovs-dev] [PATCHv2 1/2] IPsec: refactor out some code in OVS_MONITOR_IPSEC_START macro

2016-07-19 Thread Ansis Atteka
This OVS_MONITOR_IPSEC_START macro will be helpful in the next patch where it will be used also from tests/tunnel.at file to test that skb marking happens correctly. Otherwise, without ovs-monitor-ipsec running the ovs-vswitchd would refuse to configure ipsec_XXX tunnels. Signed-off-by: Ansis Att

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-19 Thread Jan Scheurich
No problem, Jesse. As this is mainly about the northbound OpenFlow interface for NSH, is there anybody else would want to chime in? Thanks, Jan > -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Tuesday, 19 July, 2016 18:39 > To: Jan Scheurich > Cc: dev@openvswit

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 02:57:43PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/19/2016 02:54:36 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 02:54 PM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > > pro

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Russell Bryant
On Tue, Jul 19, 2016 at 3:45 PM, Ben Pfaff wrote: > On Tue, Jul 19, 2016 at 10:06:09AM -0400, Russell Bryant wrote: > > On Mon, Jul 18, 2016 at 2:30 PM, Ben Pfaff wrote: > > > > > Until now, there has been no reliable for the CMS (or ovn-nbctl, or > > > anything else) to detect when changes made

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

2016-07-19 Thread Justin Pettit
> On Jul 13, 2016, at 3:19 AM, Zong Kai Li wrote: > > Hi, Justin. I tried your patches one by one. P1~P5 are OK. > But something wrong seems happened to P6. > In my OpenStack integrated environment, after using P6, I cannot ping > VM dhcp netns. And later when I dump ovs flows, I found there is

Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Justin Pettit
> On Jul 19, 2016, at 11:36 AM, Hui Kang wrote: > > These variables indicate ports in nb switches or routers. > > Signed-off-by: Hui Kang > > -- > v2->v3: > - rebase agains master branch > v1->v2: > - modify commit message > --- Thanks for the patch. Just a few things first, though:

[ovs-dev] [PATCH] stream-unix: only use path-based socket names

2016-07-19 Thread Thadeu Lima de Souza Cascardo
FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix STREAM socket. The current code will assume it means a sun_path larger than 0. That breaks some tests like the one below which don't expect to find "unix::" on the logs. As a Linux abstract address would not have a more

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 02:54:36 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 02:54 PM > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > processing to lflow_run and physical_run > > On Tue, Jul 19, 2016 at 02:18:11PM

[ovs-dev] [PATCH 2/3] system-traffic: Remove unnecessary priorities.

2016-07-19 Thread Joe Stringer
Signed-off-by: Joe Stringer --- tests/system-traffic.at | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index bd2cea11bff0..14a75b68fe7e 100644 --- a/tests/system-traffic.at +++ b/tests/syst

[ovs-dev] [PATCH 3/3] system-traffic: Fix up FTP tests.

2016-07-19 Thread Joe Stringer
Prior to commit b87a5aacefe2 ("datapath: Fix cached ct with helper."), we were relying on automatic helpers to ensure that FTP connections were tracked correctly, regardless of the flows that existed in the datapath. Now, we can drop the automatic helpers in the root namespace and still have relate

[ovs-dev] [PATCH 1/3] system-traffic: Update tests in flat tables.

2016-07-19 Thread Joe Stringer
A few of the earlier tests were written with all flows in a single flat table. While this is a possible way to write your flows to use connection tracking, it's easier to understand if the processing proceeds forward from one table to the next. Update these tests. Signed-off-by: Joe Stringer Acke

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 02:18:11PM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 07/19/2016 01:39:43 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 01:41 PM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental >

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 10:06:09AM -0400, Russell Bryant wrote: > On Mon, Jul 18, 2016 at 2:30 PM, Ben Pfaff wrote: > > > Until now, there has been no reliable for the CMS (or ovn-nbctl, or > > anything else) to detect when changes made to the northbound configuration > > have been passed through

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 01:39:43 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 01:41 PM > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > processing to lflow_run and physical_run > > On Tue, Jul 19, 2016 at 08:10:05

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-19 Thread Cathy Zhang
Hi Russell, Please see inline. Thanks, Cathy From: Russell Bryant [mailto:russ...@ovn.org] Sent: Tuesday, July 19, 2016 6:51 AM To: Cathy Zhang Cc: Farhad Sunavala; dev@openvswitch.org; Russell Bryant; Kyle Mestery Subject: Re: [ovs-dev] SFC-Summary: MultiTenant Even putting the multi-tenant co

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Ben Pfaff
On Mon, Jul 18, 2016 at 10:29:34PM -0500, Ryan Moats wrote: > "dev" wrote on 07/18/2016 01:30:10 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/18/2016 01:30 PM > > Subject: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to > > detect when the OVN syste

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 08:10:05AM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 12:57 AM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental >

[ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Hui Kang
These variables indicate ports in nb switches or routers. Signed-off-by: Hui Kang -- v2->v3: - rebase agains master branch v1->v2: - modify commit message --- ovn/northd/ovn-northd.c | 184 1 file changed, 92 insertions(+), 92 deletions(-) diff

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

2016-07-19 Thread Joe Stringer
On 24 June 2016 at 19:06, Ben Pfaff wrote: > On Wed, Jun 22, 2016 at 11:30:16AM -0700, Guru Shetty wrote: >> On 17 June 2016 at 12:42, Joe Stringer wrote: >> >> > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") >> > shifted a file between debian packages, but didn't update the

Re: [ovs-dev] ovs+dpdk hang? (was: Re: c)

2016-07-19 Thread Charlie Li
"One question - I see in another post that you modified the igb_uio driver; is that the case here also?" For Ubuntu 16.04, I did not modify the igb_uio driver because it has kernel 4.4.0. It seems that only kernel 4.5 and above needs this workaround. Thanks, Charlie On Mon, Jul 18, 2016 at 4:15

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Tuesday, July 19, 2016 10:20:37 AM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one > passive connection > > Lance Richardson wrote on 07/19/2016 09:07:41

[ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-19 Thread Ben Pfaff
This document has two different kinds of text: - The first sections of the document, "Release Strategy" and "Release Numbering", describe what we've already been doing for most of the history of Open vSwitch. If there is anything surprising in them, then it's because our process

Re: [ovs-dev] [RFC] datapath-windows: Allow validation ports processing

2016-07-19 Thread Nithin Raju
Alin, Do you intend to add them to the vport hash tables? What is the use of doing this? Also, will it not create a collision in the hash table? When the vport gets added from userspace, we should make sure that we don¹t use the validation port as a valid port. -- Nithin -Original Message---

Re: [ovs-dev] [PATCH 0/3] ovn-northd router peering fixes

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/19/2016 11:07:10 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/19/2016 11:07 AM > Subject: [ovs-dev] [PATCH 0/3] ovn-northd router peering fixes > Sent by: "dev" > > v1->v2: > - Patch 1 now warns for attempting to peer router ports to switch por

Re: [ovs-dev] [ovs-discuss] ovs+dpdk hang?

2016-07-19 Thread Aaron Conole
Apologies for the top post, I believe I might be reproducing this or a similar failure, intermittently. See http://openvswitch.org/pipermail/dev/2016-July/075673.html Thanks, Aaron "Kavanagh, Mark B" writes: >> >>>Hi Mark, >>> >>>I observed the same issue using Ubuntu 16.04 server > with 4.4.0

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-19 Thread Jesse Gross
On Tue, Jul 19, 2016 at 5:48 PM, Jan Scheurich wrote: > I hate to be pestering but I believe the answer to the question below will > have significant impact on the design of the NSH patch as well as the way SDN > controllers can use NSH. So could the OVS maintainers please have a look and > pro

[ovs-dev] [BUG] netdev-dpdk deadlock in dpdk_watchdog

2016-07-19 Thread Aaron Conole
I haven't fully had a chance to investigate this, but it seems there's a possible deadlock with the dpdk netdev - specifically vhostuser class. I've seen it intermittently with 2.4, 2.5, and now master. It's quite rare to reproduce. Below is a sample stack trace. In it, notice that thread 12 (dp

[ovs-dev] Documents from work

2016-07-19 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 10:16:54AM -0400, Hui Kang wrote: > These variables indicate ports in nb switches or routers. > > Signed-off-by: Hui Kang > > -- > v1->v2: > - modify commit message This doesn't seem to apply against current master. ___ dev mai

Re: [ovs-dev] [PATCH] ovn.at: A "peer" is only for interconnected routers.

2016-07-19 Thread Ryan Moats
"dev" wrote on 07/19/2016 11:08:10 AM: > From: Ben Pfaff > To: Guru Shetty > Cc: ovs dev > Date: 07/19/2016 11:08 AM > Subject: Re: [ovs-dev] [PATCH] ovn.at: A "peer" is only for > interconnected routers. > Sent by: "dev" > > On Tue, Jul 19, 2016 at 08:44:23AM -0700, Ben Pfaff wrote: > > On M

Re: [ovs-dev] [PATCH] ovn.at: A "peer" is only for interconnected routers.

2016-07-19 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 08:44:23AM -0700, Ben Pfaff wrote: > On Mon, Jul 18, 2016 at 01:57:53PM -0700, Guru Shetty wrote: > I posted these as proper patches in case anyone has a comment: > https://patchwork.ozlabs.org/patch/650263/ > https://patchwork.ozlabs.org/patch/650264/ > > I

[ovs-dev] [PATCH 3/3] ovn-northd: Ensure that flows are added to correct types of datapaths.

2016-07-19 Thread Ben Pfaff
A DP_TYPE_SWITCH_* flow should only be added to a logical switch datapath, and a DP_TYPE_ROUTER_* flow should only be added to a logical router datapath, but the code previously did not verify this and it caused a problem in practice. Suggested-by: Guru Shetty Suggested-at: http://openvswitch.org

[ovs-dev] [PATCH 2/3] ovn-northd: Avoid redundant lookup of logical router port peer.

2016-07-19 Thread Ben Pfaff
An ovn_port keeps track of its peer in its 'peer' member, but the code updated by this commit instead did a redundant lookup of the peer. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ovn/northd/ovn-northd.c b

[ovs-dev] [PATCH 1/3] ovn-northd: Only peer router ports to other router ports.

2016-07-19 Thread Ben Pfaff
A router port's "peer", if set, must point to another router port, but the code as written also accepted switch ports. This caused problems when switch ports were actually specified. Reported-by: Gurucharan Shetty Reported-at: http://openvswitch.org/pipermail/dev/2016-July/075524.html Signed-off

[ovs-dev] [PATCH 0/3] ovn-northd router peering fixes

2016-07-19 Thread Ben Pfaff
v1->v2: - Patch 1 now warns for attempting to peer router ports to switch ports. - Patch 2 is new. - Patch 3 is unchanged. Ben Pfaff (3): ovn-northd: Only peer router ports to other router ports. ovn-northd: Avoid redundant lookup of logical router port peer. ovn-northd: Ensure that fl

Re: [ovs-dev] [PATCH] ovn-northd: Warn when the peer of a router port is a switch port.

2016-07-19 Thread Ben Pfaff
On Mon, Jul 18, 2016 at 01:39:56AM -0700, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty Hmm. I think that the existing code here is a little strange and can be fixed up in a better way. Let me post a second version of my series from a few minutes ago. > --- > ovn/northd/ovn-nort

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-19 Thread Jan Scheurich
I hate to be pestering but I believe the answer to the question below will have significant impact on the design of the NSH patch as well as the way SDN controllers can use NSH. So could the OVS maintainers please have a look and provide feedback? Thanks a lot, Jan > -Original Message-

[ovs-dev] Documents from work

2016-07-19 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn.at: A "peer" is only for interconnected routers.

2016-07-19 Thread Ben Pfaff
On Mon, Jul 18, 2016 at 01:57:53PM -0700, Guru Shetty wrote: > On 18 July 2016 at 13:11, Ben Pfaff wrote: > > > On Mon, Jul 18, 2016 at 11:34:54AM -0700, Guru Shetty wrote: > > > On 18 July 2016 at 10:35, Ben Pfaff wrote: > > > > > > > On Mon, Jul 18, 2016 at 12:00:30AM -0700, Gurucharan Shetty

[ovs-dev] [PATCH 2/2] ovn-northd: Ensure that flows are added to correct types of datapaths.

2016-07-19 Thread Ben Pfaff
A DP_TYPE_SWITCH_* flow should only be added to a logical switch datapath, and a DP_TYPE_ROUTER_* flow should only be added to a logical router datapath, but the code previously did not verify this and it caused a problem in practice. Suggested-by: Guru Shetty Suggested-at: http://openvswitch.org

[ovs-dev] [PATCH 1/2] ovn-northd: Only peer router ports to other router ports.

2016-07-19 Thread Ben Pfaff
A router port's "peer", if set, must point to another router port, but the code as written also accepted switch ports. This caused problems when switch ports were actually specified. Reported-by: Gurucharan Shetty Reported-at: http://openvswitch.org/pipermail/dev/2016-July/075524.html Signed-off

Re: [ovs-dev] [PATCH 7/8] datapath: Add support for kernel 4.6

2016-07-19 Thread pravin shelar
On Mon, Jul 18, 2016 at 11:51 AM, Jesse Gross wrote: > On Mon, Jul 18, 2016 at 4:24 AM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/linux/if_ether.h >> b/datapath/linux/compat/include/linux/if_ether.h >> index b2cb56d..ac0f1ed 100644 >> --- a/datapath/linux/compat/includ

Re: [ovs-dev] [PATCH v2] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-19 Thread Fischetti, Antonio
Hi Jan, I added some comments prefixed with [Antonio F]. Thanks, Antonio > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jan > Scheurich > Sent: Friday, July 15, 2016 5:35 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2] dpif-netdev: dpcls pe

[ovs-dev] Documents from work

2016-07-19 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-19 Thread Kyle Mestery
On Tue, Jul 19, 2016 at 12:21 AM, Amitabha Biswas wrote: > NB and SB dbs are handled by separate ovsdb-server processes. The > ovsdb-server processes manage dbs based on the schemas for OVN NorthBound > and SouthBound. These schemas do not have any Manager Options similar > to the Open_vSwitch sch

Re: [ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test case error cause

2016-07-19 Thread Russell Bryant
On Mon, Jul 18, 2016 at 11:38 PM, Ryan Moats wrote: > "dev" wrote on 07/07/2016 04:30:01 PM: > > > From: Lance Richardson > > To: dev@openvswitch.org > > Date: 07/07/2016 04:30 PM > > Subject: [ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test > > case error cause > > Sent by: "dev" > >

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-19 Thread Ryan Moats
Lance Richardson wrote on 07/19/2016 09:07:41 AM: > From: Lance Richardson > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 09:07 AM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more > than one passive connection > > - Original Message - > >

[ovs-dev] [PATCH v2] [OVN-northd] Rename nbs/nbr port names to nbsp/nbrp

2016-07-19 Thread Hui Kang
These variables indicate ports in nb switches or routers. Signed-off-by: Hui Kang -- v1->v2: - modify commit message --- ovn/northd/ovn-northd.c | 196 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Monday, July 18, 2016 11:36:27 PM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one > passive connection > > "dev" wrote on 07/18/2016 11:29:28 AM: > > >

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Russell Bryant
On Mon, Jul 18, 2016 at 2:30 PM, Ben Pfaff wrote: > Until now, there has been no reliable for the CMS (or ovn-nbctl, or > anything else) to detect when changes made to the northbound configuration > have been passed through to the southbound database or to the hypervisors. > This commit adds this

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Set pmd thread priority

2016-07-19 Thread Kavanagh, Mark B
> Hi Bhanu, Thanks for the patch - some comments inline. Cheers, Mark >Set the DPDK pmd thread scheduling policy to SCHED_RR and static >priority to highest priority value of the policy. This is to deal with >pmd thread starvation case where another cpu hogging process can get >scheduled/affini

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-19 Thread Russell Bryant
Even putting the multi-tenant considerations aside, I think sub-ports (tagging or encapsulation) are valuable as a mechanism to differentiate between different chains (traffic matched with different classifiers). I agree that it's also complex that it requires coordination with the VNF - both with

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" , "Daniele Di Proietto" > > Sent: Friday, July 15, 2016 2:06:36 PM > Subject: Re: [ovs-dev] Question about ovs-vtep implementation > > On Fri, Jul 15, 2016 at 11:00 AM, Lance Richardson > wrote: > >

Re: [ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

2016-07-19 Thread Russell Bryant
On Fri, Jul 15, 2016 at 1:11 PM, Ryan Moats wrote: > Russell Bryant wrote on 07/15/2016 11:38:14 AM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant > > Date: 07/15/2016 11:38 AM > > Subject: [PATCH] ovn-northd.8.xml: Remove outdated fl

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 12:57 AM > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > processing to lflow_run and physical_run > > On Mon, Jul 18, 2016 at 04:21:17

Re: [ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-19 Thread Russell Bryant
On Tue, Jul 19, 2016 at 1:24 AM, Numan Siddique wrote: > On Mon, Jul 18, 2016 at 11:40 PM, Ben Pfaff wrote: > > > On Fri, Jul 15, 2016 at 08:33:59PM +0530, Numan Siddique wrote: > > > To support 128-bits in ct_label, the value of the ct_label is expected > > > as a hex string in the 'ct_commit'

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Numan Siddique
On Tue, Jul 19, 2016 at 5:40 PM, Ryan Moats wrote: > Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 12:57 AM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > > processing

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 12:57 AM > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > processing to lflow_run and physical_run > > On Mon, Jul 18, 2016 at 04:21:17PM

[ovs-dev] Jack

2016-07-19 Thread an_sung05
2016-07-19 SHENZHEN AN-SUNG INTERNATIONAL LOGISTICS CO.,LTD. 深圳市安诚国际货运代理有限公司 地址:深圳市宝安区西乡街道金海路12号汇潮科技大厦607 Add:ROOM 607,HUICHAO TECHNOLOGY BUILDING,NO.12 JINHAI ROAD, XIXIANG STREET,BAO'AN DISTRICT,SHENZHEN,CHINA 周先生 Jack Tel: 0755-81114899 QQ:2209924272 Cell phone:86-15817310819 Email:an_s

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-19 Thread Loftus, Ciara
> > The idea looks very good to me, thanks for working on it. > Very high level comments: Hi Daniele thanks for looking at this. > > Do we need to be limited to pci devices?  Perhaps we can accept the same > string as rte_eth_dev_attach(). Can you elaborate? For physical devs the string is alway

[ovs-dev] Business Analysis

2016-07-19 Thread Kory Monroe
I attached the detailed business analysis (updated} --- Warm regards, Kory Monroe HERENCIA RESOURCES Phone: +1 (949) 931-67-66 Fax: +1 (949) 931-67-15 ID: 9515a896b807bf1d53d112dc51a89cc86e895710df2d ___ dev mailing list dev@openvswitch.org http://ope

[ovs-dev] Business Analysis

2016-07-19 Thread Patrice Wallace
I attached the detailed business analysis (updated} --- Yours faithfully, Patrice Wallace PXP VIETNAM FUND Phone: +1 (500) 684-29-08 Fax: +1 (500) 684-29-59 ID: 306891d3595c58ca24165bf952dd95559fae000d4008 ___ dev mailing list dev@openvswitch.org http

Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-19 Thread Loftus, Ciara
> > Hi Ciara, > > On 07/12/2016 11:11 AM, Ciara Loftus wrote: > > This RFC patch provides initial support for DPDK 16.07-rc2 (release > > candidate 2) which was tagged July 12th. I plan to submit a full patch > > once the 16.07 release is final, hopefully later this month. This RFC > > patch can

[ovs-dev] [PATCH] [PATCH v1] ovs python: add set type for from_python

2016-07-19 Thread Zong Kai LI
In method from_python, when parameter 'value' is in list type or tuple type, it will process per each element in 'value'. And indeed, it just needs a iterable sequence here, no matter it's a list or tuple. So set type should be considered too, it's also a basic, common iterable sequence type from p

  1   2   >