Re: [ovs-dev] [PATCH] [PATCH v1] ovn: align lrp 'network' to lsp 'addresses'

2016-06-23 Thread Zong Kai LI
On Fri, Jun 24, 2016 at 4:43 AM, Justin Pettit wrote: > > > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c > > index 17713ec..5851fca 100644 > > --- a/ovn/northd/ovn-northd.c > > +++ b/ovn/northd/ovn-northd.c > > @@ -612,11 +612,12 @@ join_logical_ports(struct northd_context *ctx,

Re: [ovs-dev] [PATCH v3 3/3] DSCP marking on packets egressing VIF interface

2016-06-23 Thread Ben Pfaff
On Mon, Jun 13, 2016 at 02:00:21PM +0530, bscha...@redhat.com wrote: > ovn-northd sets 'ip.dscp' to the DSCP value > > Signed-off-by: Babu Shanmugam The documentation says: Value should be in the range of 0 to 64. in a couple of places. I think that 64 is not a valid value so, usually,

Re: [ovs-dev] [PATCH v3 2/3] Check and allocate free qdisc queue id for ports with qos parameters

2016-06-23 Thread Ben Pfaff
On Mon, Jun 13, 2016 at 02:00:20PM +0530, bscha...@redhat.com wrote: > ovn-northd processes the list of Port_Bindings and hashes the list of > queues per chassis. When it finds a port with qos_parameters and without > a queue_id, it allocates a free queue for the chassis that this port belongs. > T

[ovs-dev] [PATCH v19 7/7] Add incremental processing to lflow_run and physical_run

2016-06-23 Thread Ryan Moats
This code changes to allow incremental processing of the logical flow and physical binding tables whenver possible. Note: flows created by physical_run for multicast_groups are *NOT* handled incrementally due to to be solved issues with GWs and local routers. Signed-off-by: Ryan Moats --- ovn/c

[ovs-dev] [PATCH v19 5/7] Refactor multicast group processing in physical.c

2016-06-23 Thread Ryan Moats
Extract block from SBREC_MULTICAST_GROUP_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. The is_true parameter is added for a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/physical.c | 233 --

[ovs-dev] [PATCH v19 6/7] Refactor neighbor flows in lflow.c

2016-06-23 Thread Ryan Moats
Extract block within SBREC_MAC_BINDING_FOR_EACH loop within add_neighbor_flows to helper method so it can be reused when doing incremental processing. This is_new parameter is added for use in a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 68 +

[ovs-dev] [PATCH v19 4/7] Refactor port binding processing in physical.c

2016-06-23 Thread Ryan Moats
iExtract block from SBREC_PORT_BINDING_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. Side effects: - localvif_to_oport and tunnels are now static file scoped. - the is_new parameter is added for use in a later patch set. Signed-off

[ovs-dev] [PATCH v19 3/7] Refactor lflow.c

2016-06-23 Thread Ryan Moats
Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH loop in add_logical_flow so that this can be reused when incremental processing is added. The is_new parameter is added for use in a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 310 +++-

[ovs-dev] [PATCH v19 2/7] Change tracking structures to use struct uuids

2016-06-23 Thread Ryan Moats
In encaps.c, binding.c, and lport.c incremental processing is aided by tracking entries by their ovsdb row uuids. The original patch sets used pointers, which might lead to errors if the ovsdb row uuid memory is released. So, use actual structures to hold the values instead. Signed-off-by: Ryan M

[ovs-dev] [PATCH v19 1/7] Persist ovn flow tables

2016-06-23 Thread Ryan Moats
Ensure that ovn flow tables are persisted so that changes to them chan be applied incrementally - this is a prereq for making lflow_run and physical_run incremental. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 26 ++-- ovn/controller/lflow.h | 3 +- ovn/controller

[ovs-dev] [PATCH v19 0/7] Add incremental processing

2016-06-23 Thread Ryan Moats
This patch set has the residual changes that didn't merge from v18. v18->v19: Addressed review comments on ovn flow tables patch. As needed rebases of other patches. Ryan Moats (7): Persist ovn flow tables Change tracking structures to use struct uuids Refactor lflow.c Refactor port b

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 03:50:44AM +, Wenyu Zhang wrote: > On 6/24/16, 10:54 AM, "Wenyu Zhang" wrote: > >On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > >>The documentation doesn't say what a "virtual observation ID" is. This > >>is not a standard term, so users can't be expected to know. Please

Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 10:58:03 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 10:58 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl > helpers to make logic more readable. > > On Thu, Jun 23, 2016 at 10:48:31PM -05

Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 10:48:31PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 06/23/2016 10:33:53 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 06/23/2016 10:34 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl > > hel

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Wenyu Zhang
Hi Ben, I add new comments inline . May you take a look? On 6/24/16, 10:54 AM, "Wenyu Zhang" wrote: >Thanks for your inputs. > >I added some comments inline, may you help take a look? > >On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > >>On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: >>

Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 10:33:53 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 10:34 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl > helpers to make logic more readable. > > On Thu, Jun 23, 2016 at 08:01:52PM -05

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 02:54:23AM +, Wenyu Zhang wrote: > On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > > >On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: > >> In virtual network, users want more info about the virtual point to > >>observe the traffic. > >> It should be a string to

Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 08:01:52PM -0500, Ryan Moats wrote: > "dev" wrote on 06/23/2016 07:00:51 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 06/23/2016 07:01 PM > > Subject: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers > > to make logic more

Re: [ovs-dev] [PATCH v2 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-23 Thread Numan Siddique
On Fri, Jun 24, 2016 at 3:57 AM, Ben Pfaff wrote: > On Wed, Jun 15, 2016 at 02:47:35PM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcp_opts' to support native > > DHCP in OVN. > > Applied to master, thanks! > ​Thanks Ben for the review and applying to the master. ​ _

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Wenyu Zhang
Thanks for your inputs. I added some comments inline, may you help take a look? On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: >On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: >> In virtual network, users want more info about the virtual point to >>observe the traffic. >> It should be a s

Re: [ovs-dev] [PATCH v2 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-23 Thread Numan Siddique
On Fri, Jun 24, 2016 at 4:13 AM, Ben Pfaff wrote: > On Wed, Jun 15, 2016 at 02:48:27PM +0530, Numan Siddique wrote: > > OVN implements a native DHCP support which caters to the common > > use case of providing an IP address to a booting instance by > > providing stateless replies to DHCP requests

[ovs-dev] [PATCH] rhel: Fix RHEL package build breakage

2016-06-23 Thread Ansis Atteka
This patch fixes following error: error: Installed (but unpackaged) file(s) found: /usr/bin/ovs-tcpdump /usr/share/man/man8/ovs-tcpdump.8.gz Signed-off-by: Ansis Atteka --- rhel/openvswitch.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rhel/openvswitch.spec.in b/rhel/openv

Re: [ovs-dev] [Bug Report] Cisco Switch will randomlygeterr-disabled when inter-connected with Open vSwitch

2016-06-23 Thread 渔舟
Sorry, I messed up the mail body, just resend it again. OVS generates a dp flow to drop the loopback packet by defaut,shown as below, recirc_id(0),in_port(3),eth(src=b0:00:b4:67:17:9b,dst=b0:00:b4:67:17:9b),eth_type(0x9000), packets:5, bytes:300, used:0.476s, actions:drop port(3) is the port w

Re: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ryan Moats
"dev" wrote on 06/23/2016 07:00:51 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 06/23/2016 07:01 PM > Subject: [ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers > to make logic more readable. > Sent by: "dev" > > Also there were lots of 'continue's sprinkle

Re: [ovs-dev] [ovs-dev,v18,5/9] Refactor lflow.c

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 06:13:10 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 06:13 PM > Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c > > On Thu, Jun 23, 2016 at 04:45:06PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 06/23/2016

Re: [ovs-dev] [PATCHv11 2/2] ofp-actions: Add truncate action.

2016-06-23 Thread William Tu
Thanks, I will update and resubmit. On Thu, Jun 23, 2016 at 3:28 PM, pravin shelar wrote: > On Wed, Jun 22, 2016 at 10:02 PM, William Tu wrote: >> The patch adds a new action to support packet truncation. The new action >> is formatted as 'output(port=n,max_len=m)', as output to port n, with >>

[ovs-dev] [PATCH] ovn-controller: Use new ovsdb-idl helpers to make logic more readable.

2016-06-23 Thread Ben Pfaff
Also there were lots of 'continue's sprinkled around that didn't seem to be needed given some simple code rearrangement. Signed-off-by: Ben Pfaff --- ovn/controller/binding.c | 11 --- ovn/controller/encaps.c | 19 +-- ovn/controller/lport.c | 18 ++ ov

Re: [ovs-dev] [PATCH v3 1/3] New qos type linux-noop

2016-06-23 Thread Ben Pfaff
On Mon, Jun 13, 2016 at 02:00:19PM +0530, bscha...@redhat.com wrote: > Linux ``No operation'' qos type is used to inform the vswitch that the > traffic control for the port is managed externally. Any configuration values > set for this type will have no effect. > > This patch provides a solution s

Re: [ovs-dev] [PATCH] ovsdb: Strong references cascade fix

2016-06-23 Thread Ben Pfaff
On Fri, Jun 10, 2016 at 04:35:09PM +, Rodriguez Betancourt, Esteban wrote: > Improves the performance of OVSDB avoiding the chain > reaction produced when modifing rows with a strong > reference and the pointed rows have more strong > references. > > The approach taken was using the change bit

Re: [ovs-dev] [PATCH 1/1] rpm: Update rhel/automake.mk to build via mock

2016-06-23 Thread Flavio Leitner
On Tue, Jun 07, 2016 at 04:23:14PM -0400, Leif Madsen wrote: > Provides changes to the automake.mk file in the rhel/ directory to utilize > mock > instead of rpmbuild for the rpm-fedora build target. The usage of mock > provides > an isolated environment for building packages, and makes things re

Re: [ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-06-23 Thread Ben Pfaff
On Fri, Jun 10, 2016 at 01:54:42AM -0500, Terry Wilson wrote: > There is no particularly good reason to use our own Python JSON > serialization implementation when serialization can be done faster > with Python's built-in JSON library. > > A few tests were changed due to Python's default JSON libr

Re: [ovs-dev] [ovs-dev,v18,5/9] Refactor lflow.c

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 04:45:06PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 06/23/2016 04:40:01 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 06/23/2016 04:40 PM > > Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c > > > > On Wed, Jun 08,

Re: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-23 Thread Ben Pfaff
On Fri, Jun 10, 2016 at 12:17:57PM -0400, Lance Richardson wrote: > Commit f9b11f2a09b4 introduced a loop to wait for process exit > in OVS_APP_EXIT_AND_WAIT after the "exit" command has been sent. > Unfortunately, this does not work for cases where a unixctl socket > has to be used to send the "ex

Re: [ovs-dev] [PATCH v4] lib: Use a more accurate value for CPU count (sched_getaffinity).

2016-06-23 Thread Ben Pfaff
On Thu, Jun 09, 2016 at 11:52:49AM +0200, Quentin Monnet wrote: > From: David Marchand > > Relying on /proc/cpuinfo to count the number of available cores is not > the best option: > > - The code is x86-specific. > - If the process is started with a different CPU affinity, then it will > wrong

Re: [ovs-dev] [ovs-dev, 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-23 Thread Ben Pfaff
On Wed, Jun 15, 2016 at 09:00:26AM +0530, Numan Siddique wrote: > > > > > > This patch set appears to have multiple collisions when I try > > to apply it - should it be rebased? > > > > > ​ > ​I will fix the conflicts and submit the patch. Thanks. ___ de

Re: [ovs-dev] [PATCH 0/4] OVN DHCP support proposal

2016-06-23 Thread Ben Pfaff
On Thu, Jun 09, 2016 at 10:09:33PM +0530, Numan Siddique wrote: > On Thu, Jun 9, 2016 at 11:07 AM, Ben Pfaff wrote: > > > Patches 1 and 2 are new. > > > > Patch 3 is based on https://patchwork.ozlabs.org/patch/631320/, with: > > - Minor style fixes. > > - Change syntax of put_dhcp_opts(), fro

Re: [ovs-dev] [PATCH v2 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-23 Thread Ben Pfaff
On Wed, Jun 15, 2016 at 02:48:27PM +0530, Numan Siddique wrote: > OVN implements a native DHCP support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCP requests based on statically > configured address mappings. To do th

Re: [ovs-dev] [PATCHv11 2/2] ofp-actions: Add truncate action.

2016-06-23 Thread pravin shelar
On Wed, Jun 22, 2016 at 10:02 PM, William Tu wrote: > The patch adds a new action to support packet truncation. The new action > is formatted as 'output(port=n,max_len=m)', as output to port n, with > packet size being MIN(original_size, m). > > One use case is to enable port mirroring to send sm

Re: [ovs-dev] [PATCH v2 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-23 Thread Ben Pfaff
On Wed, Jun 15, 2016 at 02:47:35PM +0530, Numan Siddique wrote: > This patch adds a new OVN action 'put_dhcp_opts' to support native > DHCP in OVN. Applied to master, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [PATCH 2/4] expr: Refactor parsing of assignments and exchanges.

2016-06-23 Thread Ben Pfaff
On Tue, Jun 14, 2016 at 09:36:10AM -0500, Ryan Moats wrote: > "dev" wrote on 06/09/2016 12:37:58 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Subject: [ovs-dev] [PATCH 2/4] expr: Refactor parsing of assignments and > exchanges. > > Sent by: "dev" > > [snip] > >

Re: [ovs-dev] [PATCH 1/4] expr: Shorten declarations of expr_context.

2016-06-23 Thread Ben Pfaff
On Tue, Jun 14, 2016 at 09:17:28AM -0500, Ryan Moats wrote: > "dev" wrote on 06/09/2016 12:37:58 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 06/09/2016 12:58 AM > > Subject: [ovs-dev] [PATCH 1/4] expr: Shorten declarations of > expr_context. > > Sent by: "d

Re: [ovs-dev] [ovs-dev,v18,4/9] Persist ovn flow tables.

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 04:45:40PM -0500, Ryan Moats wrote: > > struct ovn_flow contains a struct uuid *. I don't understand how the > > function can guarantee that the pointer remains valid. It seems like > > the prudent thing to do would be to contain a struct uuid instead. > > (I've noticed th

Re: [ovs-dev] [PATCH v2 0/3] ovs-tcpdump: A utility for convenient port mirroring

2016-06-23 Thread Ben Pfaff
I'm not trying to make review a barter system here, although review is always appreciated. I'm just slow, right now especially because of travel. On Thu, Jun 23, 2016 at 02:30:02PM -0400, Aaron Conole wrote: > Ping. I'll gladly trade some review time for this :-D Just point me to > the patches.

Re: [ovs-dev] [PATCH v2 3/3] debian: Add the tcpdump utility to the debian package

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 05:49:57PM -0400, Aaron Conole wrote: > Add ovs-tcpdump to the debian build. > > Signed-off-by: Aaron Conole Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 2/3] fedora: Add pcap, tcpdump and tcpundump utilities to test

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 05:49:56PM -0400, Aaron Conole wrote: > The openvswitch-test package is setup for enabling / performing tests > for openvswitch setups. Adding these utilities would enable a richer > set of debugging utilities for performing diagnostics. > > Signed-off-by: Aaron Conole A

Re: [ovs-dev] [PATCH v2 1/3] ovs-tcpdump: Add a tcpdump wrapper utility

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 05:49:55PM -0400, Aaron Conole wrote: > Currently, there is some documentation which describes setting up and > using port mirrors for bridges. This documentation is helpful to setup > a packet capture for specific ports. > > However, a utility to do such packet capture wou

Re: [ovs-dev] [patch_v2] ovn: Fix receive from vxlan in ovn-controller.

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 02:30:33PM -0700, Darrell Ball wrote: > OVN only supports source_node replication and previously vtep interaction, > which used service node replication by default for multicast/broadcast/unknown > unicast traffic worked by happenstance. Because of limited vxlan > encapsula

Re: [ovs-dev] [PATCH] netlink-notifier: change message to a less scary one

2016-06-23 Thread Ben Pfaff
On Fri, Jun 17, 2016 at 04:33:23PM -0300, Thadeu Lima de Souza Cascardo wrote: > "received bad netlink message" may be interpreted as a corrupt netlink > message. > However, the parse functions may return failure when the message contains > unexpected attributes or misses non optional attributes.

Re: [ovs-dev] [PATCH 2/2] test: Add more pmd tests.

2016-06-23 Thread Ben Pfaff
On Tue, Jun 07, 2016 at 02:08:45PM -0700, Daniele Di Proietto wrote: > These tests stress the pmd thread and multiqueue handling in > dpif-netdev. > > Signed-off-by: Daniele Di Proietto I barely skimmed these tests. I did run them, and they passed for me. Let me know if you want more detailed

[ovs-dev] [PATCH v2] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-06-23 Thread Nimay Desai
Added an IPv4 and MAC addresses management system to ovn-northd. When a logical switch's options:subnet field is set, logical ports attached to that switch that do not have a MAC/IPv4 address will automatically be allocated a globally unique MAC address/unused IPv4 address within the provided subne

Re: [ovs-dev] [PATCH 1/2] netdev-dummy: Allow configuring the numa_id for testing purposes.

2016-06-23 Thread Ben Pfaff
On Tue, Jun 07, 2016 at 02:08:44PM -0700, Daniele Di Proietto wrote: > This commit introduces an (undocumented) option for dummy Interfaces to > specify a dummy numa_id, to which the device belongs. It will be used > to test the pmd threads in dpif-netdev. > > Signed-off-by: Daniele Di Proietto

[ovs-dev] beneficial offer

2016-06-23 Thread dev
Hello! We are looking for employees working remotely. My name is Rubin, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best regards!

Re: [ovs-dev] [PATCH 1/1] rpm: Update rhel/automake.mk to build via mock

2016-06-23 Thread Ben Pfaff
Russell or Flavio, would you mind reviewing this? It seems like a plausible patch to me but I am no judge of RPMs. On Tue, Jun 07, 2016 at 04:23:14PM -0400, Leif Madsen wrote: > Provides changes to the automake.mk file in the rhel/ directory to utilize > mock > instead of rpmbuild for the rpm-fe

Re: [ovs-dev] [ovs-dev,v18,4/9] Persist ovn flow tables.

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 04:33:19 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 04:33 PM > Subject: Re: [ovs-dev,v18,4/9] Persist ovn flow tables. > > On Wed, Jun 08, 2016 at 08:02:29PM -0500, Ryan Moats wrote: > > From: "RYAN D. MOATS

Re: [ovs-dev] [ovs-dev,v18,5/9] Refactor lflow.c

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 04:40:01 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 04:40 PM > Subject: Re: [ovs-dev,v18,5/9] Refactor lflow.c > > On Wed, Jun 08, 2016 at 08:02:58PM -0500, Ryan Moats wrote: > > From: "RYAN D. MOATS" > > > >

Re: [ovs-dev] [ovs-dev,v18,5/9] Refactor lflow.c

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 08:02:58PM -0500, Ryan Moats wrote: > From: "RYAN D. MOATS" > > Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH > loop in add_logical_flow so that this can be reused when > incremental processing is added. > > Signed-off-by: RYAN D. MOATS Patches 5-8 seem OK t

Re: [ovs-dev] [ovs-dev,v18,4/9] Persist ovn flow tables.

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 08:02:29PM -0500, Ryan Moats wrote: > From: "RYAN D. MOATS" > > Ensure that ovn flow tables are persisted so that changes to > them chan be applied incrementally - this is a prereq for > making lflow_run and physical_run incremental. > > Signed-off-by: Ryan Moats Thanks

Re: [ovs-dev] [ovs-dev, v18, 3/9] Persist lport_index and mcgroup_index structures

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 04:05:49 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 04:06 PM > Subject: Re: [ovs-dev,v18,3/9] Persist lport_index and mcgroup_indexstructures > > On Wed, Jun 08, 2016 at 08:01:39PM -0500, Ryan Moats wrote: > >

Re: [ovs-dev] [ovs-dev, v18, 3/9] Persist lport_index and mcgroup_index structures

2016-06-23 Thread Ben Pfaff
On Wed, Jun 08, 2016 at 08:01:39PM -0500, Ryan Moats wrote: > From: "RYAN D. MOATS" > > This is preparatory to making physical_run and lflow_run process > incrementally as changes to the data in these structures control > that processing. > > Signed-off-by: RYAN D. MOATS Thanks for the patch.

Re: [ovs-dev] [ovs-dev, v18, 1/9] Change encaps_run to work incrementally

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 03:26:51 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 03:27 PM > Subject: Re: [ovs-dev,v18,1/9] Change encaps_run to work incrementally > > On Tue, Jun 07, 2016 at 01:52:50PM -0500, Ryan Moats wrote: > > As a

Re: [ovs-dev] [ovs-dev, v18, 2/9] Convert binding_run to incremental processing.

2016-06-23 Thread Ryan Moats
Ben Pfaff wrote on 06/23/2016 03:41:28 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 06/23/2016 03:41 PM > Subject: Re: [ovs-dev,v18,2/9] Convert binding_run to incremental processing. > > On Tue, Jun 07, 2016 at 01:52:51PM -0500, Ryan Moats wrote: > >

Re: [ovs-dev] [PATCH] [PATCH v1] ovn: align lrp 'network' to lsp 'addresses'

2016-06-23 Thread Justin Pettit
> On Jun 22, 2016, at 10:28 AM, Zong Kai LI wrote: > > This patch renames Logical_Router_Port 'network' column to 'networks' > and aligns it to Logical_Switch_Port 'addresses' column for peer port > in Logical_Switch_Port which type is 'router'. > > Currently, a lsp port whos type is 'router',

Re: [ovs-dev] [PATCH 9/9] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_GET cmd in Datapath.c

2016-06-23 Thread Sairam Venugopal
Hi Paul, Thanks for the review and comments. I will incorporate them in v2. Regarding the current patch - I do have a NETLINK_FAMILY defined: /* Netlink Ct family. */ NETLINK_CMD nlCtFamilyCmdOps[] = { { .cmd = IPCTNL_MSG_CT_DELETE, .handler = OvsCtDeleteCmdHandle

Re: [ovs-dev] [ovs-dev, v18, 2/9] Convert binding_run to incremental processing.

2016-06-23 Thread Ben Pfaff
On Tue, Jun 07, 2016 at 01:52:51PM -0500, Ryan Moats wrote: > From: "RYAN D. MOATS" > > Ensure that the entire port binding table is processed > when chassis are added/removed or when get_local_iface_ids > finds new ports on the local vswitch. > > Side effects: > - Persist local_datapaths and

Re: [ovs-dev] [ovs-dev, v18, 1/9] Change encaps_run to work incrementally

2016-06-23 Thread Ben Pfaff
On Tue, Jun 07, 2016 at 01:52:50PM -0500, Ryan Moats wrote: > As a side effect, tunnel context is persisted. > > Signed-off-by: Ryan Moats Thanks for the patch. I folded in the following changes and applied this to master. Most of my changes are style or comments, but there is a memory leak fi

Re: [ovs-dev] [PATCH V5] datapath-windows: Handle possible NULL pointer dereference in STT

2016-06-23 Thread Sairam Venugopal
Thanks for the changes. This looks good! Re-acking just in case it¹s required. Acked-by: Sairam Venugopal On 6/23/16, 2:16 AM, "Paul Boca" wrote: >Check if OvsAllocatememoryWithTag succeeded or not. >In case of failure propagate cleanup and return. > >Signed-off-by: Paul-Daniel Boca >Acked-

Re: [ovs-dev] [PATCH 8/9] datapath-windows: Conntrack - Handle memory allocation failure

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 8/9] datapath-windows: Conntrack - Handle > memory allocation failu

Re: [ovs-dev] [PATCH 9/9] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_GET cmd in Datapath.c

2016-06-23 Thread Paul Boca
Hi Sai! Please see my comments inline. Besides that it looks good to me. Thanks, Paul > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 9/9] da

Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for dump-conntrack in datapath

2016-06-23 Thread Paul Boca
Hi Sai! One small nit inline. Thanks, Paul Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 7/9] datapath-windows

Re: [ovs-dev] [PATCH 6/9] datapath-windows: Add new NlFillOvsMsgForNfGenMsg method in Netlink.c

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 6/9] datapath-windows: Add new > NlFillOvsMsgForNfGenMsg method in

Re: [ovs-dev] [PATCH 5/9] Windows: Add conntrack-flush support in userspace

2016-06-23 Thread Paul Boca
Hi Sai! A small nit inline. Otherwise it looks fine to me. Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 5/9] W

Re: [ovs-dev] [PATCH 4/9] datapath-windows: Add support for Conntrack IPCTNL_MSG_CT_DELETE cmd in Datapath.c

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 4/9] datapath-windows: Add support for > Conntrack IPCTNL_MSG_CT_DE

Re: [ovs-dev] [PATCH 2/9] datapath-windows: Add support for Netfilter netlink message

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/9] datapath-windows: Add support for Netfilter > netlink message

Re: [ovs-dev] [PATCH 3/9] datapath-windows: Add support for flushing conntrack entries

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 3/9] datapath-windows: Add support for flushing > conntrack entries

Re: [ovs-dev] [PATCH 1/9] Windows: Add netfilter-conntrack header files to Include folder

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Tuesday, June 21, 2016 4:23 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 1/9] Windows: Add netfilter-conntrack header files > to Include fol

Re: [ovs-dev] [PATCH] datapath-windows: Rename local variable in Vport.c

2016-06-23 Thread Guru Shetty
On 22 June 2016 at 13:50, Sairam Venugopal wrote: > Declaration of 'event' hides previous local declaration. Rename this to > evt. The other variable wasn't being used. > > Signed-off-by: Sairam Venugopal > Applied, thanks! > --- > datapath-windows/ovsext/Vport.c | 14 +++--- > 1 file

Re: [ovs-dev] [PATCH v3] ovn-northd: no logical router icmp response for directed broadcasts

2016-06-23 Thread Justin Pettit
Thanks, Flavio. I pushed this patch. I made a couple of small tweaks: - I updated the Reported-by link to the beginning of the thread that mentions the different options. - I removed a paragraph from the ovn-northd man page that talked about handling pings to 255.255.255.255.

Re: [ovs-dev] [PATCH] doc: Fix an error in FAQ.

2016-06-23 Thread Ben Pfaff
I think it is clearer with the "not". I don't know what it means without that word. On Mon, Jun 06, 2016 at 11:00:55PM -0700, Han Zhou wrote: > Sorry, I think I just realized that the "not" here is optional in English. > But it did take me sometime to figure out :( > > Han > > On Mon, Jun 6, 20

Re: [ovs-dev] [PATCH] doc: Fix an error in FAQ.

2016-06-23 Thread Ben Pfaff
On Mon, Jun 06, 2016 at 10:56:50PM -0700, Han Zhou wrote: > Signed-off-by: Han Zhou Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v5] ovn: Add software l2 gateway.

2016-06-23 Thread Russell Bryant
This patch implements one approach to using ovn-controller to implement a software l2 gateway between logical and physical networks. A new logical port type called "l2gateway" is introduced here. It is very close to how localnet ports work, with the following exception: - A localnet port makes O

Re: [ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests

2016-06-23 Thread Ben Pfaff
On Mon, Jun 06, 2016 at 01:51:16PM -0700, Andy Zhou wrote: > Add more ovsdb lock tests. > > Signed-off-by: Andy Zhou This test checks c1-output twice, I suspect that the second check should be for c2-output: > +# > +# Two sessions create two locks. Both sessions should able get their own > +# l

Re: [ovs-dev] [add ovsdb lock tests 2/3] ovsdb: Add ovsdb-client options for testing lock

2016-06-23 Thread Ben Pfaff
On Mon, Jun 06, 2016 at 01:51:15PM -0700, Andy Zhou wrote: > RFC 7047 lock operation has been fully implemented in ovsdb-server > for a while, but it is not well covered in unit testing. This > patch adds options for the ovsdb-client tool to issue lock operations. > The next patch will make use tho

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add address_set() support for ACLs.

2016-06-23 Thread Flaviof
On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russell Bryant > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses. > >outport == "lp1" && ip4.src

[ovs-dev] [PATCH v3] dpif-netdev: Remove PMD latency on seq_mutex

2016-06-23 Thread Flavio Leitner
The PMD thread needs to keep processing RX queues in order to achieve maximum throughput. It also needs to sweep emc cache and quiesce which use seq_mutex. That mutex can eventually block the PMD thread causing latency spikes and affecting the throughput. Since there is no requirement for running

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

2016-06-23 Thread Ben Pfaff
On Mon, Jun 06, 2016 at 01:51:14PM -0700, Andy Zhou wrote: > Signed-off-by: Andy Zhou > --- > This patch should be backported. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 0/3] ovs-tcpdump: A utility for convenient port mirroring

2016-06-23 Thread Aaron Conole
Ping. I'll gladly trade some review time for this :-D Just point me to the patches. Aaron Conole writes: > Open vSwitch ships with a mirroring facility. However, this facility can > sometimes be cumbersome to setup. To make this easier for end users, this > patch series introduces a utility

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a stri

[ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

2016-06-23 Thread Hui Kang
Hi, In our scalability test for OVN, we observed an in-scalable behaviour of the ovn-northd process: the time binding a logical port increases as # of large port increasing, regardless of whether logical ports belong to the same logical switch. The most suspicious function in causing this issue is

[ovs-dev] no OVN meeting for June 30

2016-06-23 Thread Ben Pfaff
A number of the usual attendees for the OVN meeting will be traveling or otherwise expect to have little to report for next week, so we expect to skip the June 30 meeting. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH] datapath-windows: Rename local variable in Vport.c

2016-06-23 Thread Paul Boca
Acked-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Wednesday, June 22, 2016 11:51 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Rename local variable in > Vport.c > > Decla

Re: [ovs-dev] OVN testsuite failure on Travis

2016-06-23 Thread Ben Pfaff
On Sun, May 08, 2016 at 10:54:52AM -0700, Ben Pfaff wrote: > On Sun, May 08, 2016 at 12:43:28PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 05/08/2016 11:31:18 AM: > > > The most common races I see in the OVN tests would be addressed by the > > > idea I proposed here: > > > http://open

Re: [ovs-dev] SFC summary?

2016-06-23 Thread Ben Pfaff
Thank you very much for the summary! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 1/2] Add address set support.

2016-06-23 Thread Flaviof
On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russel Bryant > > Update the OVN expression parser to support address sets. Previously, > you could have a set of IP or MAC addresses in this form: > > {addr1, addr2, ..., addrN} > > This patch adds support for a bit of indirection where we ca

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add address_set() support for ACLs.

2016-06-23 Thread Flaviof
On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russell Bryant > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses. > >outport == "lp1" && ip4.src

Re: [ovs-dev] [Bug Report] Cisco Switch will randomly geterr-disabled when inter-connected with Open vSwitch

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 07:37:12PM +0800, 渔舟 wrote: > I also encounter the same problem as Liang Dong did. > http://thread.gmane.org/gmane.linux.network.openvswitch.general/11704 Then I can give you the same response. It's really hard to debug problems that are intermittent and require specific

Re: [ovs-dev] Getting error while configuring OVS 2.5.90(unstable release) with DPDK 16.4

2016-06-23 Thread Joe Stringer
On 23 June 2016 at 05:47, Thiyagu Subramanyam wrote: > Hi All, > > I am trying to use Openvswitch in user space using DPDK. So that i need > to install DPDK first in user space and then to configure OVS with DPDK > which i installed in user space. I am following the INSTALL DPDK.md > document,

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-06-23 Thread Ben Pfaff
On Thu, Jun 23, 2016 at 12:01:11PM +, André Mantas wrote: > Hi again. > > I've sent an email with the patch using git send-email, I hope it reaches > the mailing list. Here is the git send-email output: It reached the mailing list successfully. ___

Re: [ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests

2016-06-23 Thread Ryan Moats
"dev" wrote on 06/06/2016 03:51:16 PM: > From: Andy Zhou > To: d...@openvswitch.com > Date: 06/06/2016 03:52 PM > Subject: [ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests > Sent by: "dev" > > Add more ovsdb lock tests. > > Signed-off-by: Andy Zhou > --- I would have preferred

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

2016-06-23 Thread Ryan Moats
"dev" wrote on 06/06/2016 03:51:14 PM: > From: Andy Zhou > To: d...@openvswitch.com > Date: 06/06/2016 03:51 PM > Subject: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb- > client --help output format > Sent by: "dev" > > Signed-off-by: Andy Zhou > --- This looks like a really simp

[ovs-dev] [CudaMailTagged] Re: [ovs-dev, v2]: ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-06-23 Thread Ryan Moats
> This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to OVS > for all OpenFlow versions that support groups (OF11 and higher). The new > ADD_OR_MOD creates a group that does not yet exist (like ADD) and modifies > an existing group (like MODIFY). > > Rational: In OpenFlow 1.x th

  1   2   >