[ovs-dev] The crisis has finished! Work with us!

2016-06-17 Thread dev
Hello! We are looking for employees working remotely. My name is Hollie, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best regards! __

[ovs-dev] Celebrity Lifestyle Plan To Keep Yourself Healthy

2016-06-17 Thread dev
Have you been dreaming of a beautiful body, but had no results with diets, workouts and supplements? Our incredible solution with a breakthrough formula will deliver you the results you've been so eager to achive. Click Here! Powerful weight loss product that amplifies methabolism, stimulates

[ovs-dev] [PATCH v3 18/18] datapath: Fix cached ct with helper.

2016-06-17 Thread Jarno Rajahalme
From: Joe Stringer Upstream commit: commit 16ec3d4fbb967bd0e1c8d9dce9ef70e915a86615 Author: Joe Stringer Date: Wed May 11 10:29:26 2016 -0700 openvswitch: Fix cached ct with helper. When using conntrack helpers from OVS, a common configuration is to perform a lookup w

[ovs-dev] [PATCH v3 17/18] datapath: __nf_ct_l{3, 4}proto_find() always return a valid pointer

2016-06-17 Thread Jarno Rajahalme
From: Pablo Neira Ayuso Upstream commit: commit 3b78155b1b3688dbe910fecdc3e003f431b46630 Author: Pablo Neira Ayuso Date: Tue May 3 11:13:29 2016 +0200 openvswitch: __nf_ct_l{3,4}proto_find() always return a valid pointer If the protocol is not natively supported, this ass

[ovs-dev] [PATCH v3 15/18] datapath: call only into reachable nf-nat code

2016-06-17 Thread Jarno Rajahalme
From: Arnd Bergmann Upstream commit: commit 99b7248e2ad57ca93ada10c6598affb267ffc99a Author: Arnd Bergmann Date: Fri Mar 18 14:33:45 2016 +0100 openvswitch: call only into reachable nf-nat code The openvswitch code has gained support for calling into the nf-nat-ipv4/i

[ovs-dev] [PATCH v3 16/18] datapath: change nf_connlabels_get bit arg to 'highest used'

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit adff6c6560ec2bb71840c943ee12668080f5 Author: Florian Westphal Date: Tue Apr 12 18:14:25 2016 +0200 netfilter: connlabels: change nf_connlabels_get bit arg to 'highest used' nf_connlabel_set() takes the bit number that we would like to set. nf

[ovs-dev] [PATCH v3 14/18] datapath: Fix checking for new expected connections.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 5745b0be05a0f8ccbc92a36b69f3a6bc58e91954 Author: Jarno Rajahalme Date: Mon Mar 21 11:15:19 2016 -0700 openvswitch: Fix checking for new expected connections. OVS should call into CT NAT for packets of new expected connections only when the conntr

[ovs-dev] [PATCH v3 06/18] datapath: Update the CT state key only after nf_conntrack_in().

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 394e910e909b174270b8231fd51942eb2f541fb9 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:19 2016 -0800 openvswitch: Update the CT state key only after nf_conntrack_in(). Only a successful nf_conntrack_in() call can effect a connection state change

[ovs-dev] [PATCH v3 08/18] datapath: Handle NF_REPEAT in conntrack action.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 5b6b929376a621e2bd3367f5de563d7123506597 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:21 2016 -0800 openvswitch: Handle NF_REPEAT in conntrack action. Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN pack

[ovs-dev] [PATCH v3 12/18] datapath: conntrack NF_NAT_RANGE_PROTO_RANDOM_FULLY compat code.

2016-06-17 Thread Jarno Rajahalme
Linux kernel 3.13 and older do not have NF_NAT_RANGE_PROTO_RANDOM_FULLY (unless backported by the distribution). Silently fall back to NF_NAT_RANGE_PROTO_RANDOM to maintain OVS API compatibility. Signed-off-by: Jarno Rajahalme --- datapath/conntrack.c | 12 +++- 1 file changed, 11 inser

[ovs-dev] [PATCH v3 13/18] datapath: Use proper buffer size in nla_memcpy

2016-06-17 Thread Jarno Rajahalme
From: Haishuang Yan Upstream commit: commit ac71b46efd2838c02ec193987c8f61c3ba33b495 Author: Haishuang Yan Date: Mon Mar 28 18:08:59 2016 +0800 openvswitch: Use proper buffer size in nla_memcpy For the input parameter count, it's better to use the size of destination

[ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 264619055bd52bc2278af848472176642d759874 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:17 2016 -0800 netfilter: Allow calling into nat helper without skb_dst. NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem

[ovs-dev] [PATCH v3 09/18] datapath: Delay conntrack helper call for new connections.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 28b6e0c1ace45779c60e7cefe6d469b7ecb520b8 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:22 2016 -0800 openvswitch: Delay conntrack helper call for new connections. There is no need to help connections that are not confirmed, so we can delay helpi

[ovs-dev] [PATCH v3 07/18] datapath: Find existing conntrack entry after upcall.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 289f225349cb2a97448fd14599ab34b741f706f3 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:20 2016 -0800 openvswitch: Find existing conntrack entry after upcall. Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which

[ovs-dev] [PATCH v3 05/18] datapath: Add commentary to conntrack.c

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 9f13ded8d3c715147c4759f937cfb712c185ca13 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:18 2016 -0800 openvswitch: Add commentary to conntrack.c This makes the code easier to understand and the following patches more focused. Signed-off-by:

[ovs-dev] [PATCH v3 10/18] datapath: Interface with NAT.

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit 05752523e56502cd9975aec0a2ded465d51a71f3 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:23 2016 -0800 openvswitch: Interface with NAT. Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT w

[ovs-dev] [PATCH v3 00/18] datapath: NAT backports.

2016-06-17 Thread Jarno Rajahalme
This series adds the conntrack NAT integration upstreamed in Linux 4.6 to the OVS tree kernel module. Main code is the same as upstream net-next, backports are provided for Linux kernels 3.10 - 4.6. Code compiles on each Linux version on this range, except for Linux 4.4 - 4.6, which fail to compi

[ovs-dev] [PATCH v3 02/18] acinclude: Add OVS_FIND_PARAM_IFELSE.

2016-06-17 Thread Jarno Rajahalme
OVS_FIND_PARAM_IFELSE is more robust macro for checking function parameters, as it does not require the parameter to be on the same line as the function name like the OVS_GREP_IFELSE does. Use this to fix the check for struct conntrack_zone parameter, which is on a different line on Linux 4.3 and

[ovs-dev] [PATCH v3 04/18] datapath: Remove NF_CT_NEW_REPLY

2016-06-17 Thread Jarno Rajahalme
Upstream commit: commit bfa3f9d7f3b349acea8982d2248e33a0ed84c687 Author: Jarno Rajahalme Date: Thu Mar 10 10:54:16 2016 -0800 netfilter: Remove IP_CT_NEW_REPLY definition. Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows t

[ovs-dev] [PATCH v3 03/18] datapath: compat for NAT.

2016-06-17 Thread Jarno Rajahalme
Compat code required to make the NAT code in the following patch compile with Linux 3.10 - 4.6. Some compat code applies to the conntrack.c itself; these are added after the main NAT backport for conntrack.c later in the series. Signed-off-by: Jarno Rajahalme --- acinclude.m4

[ovs-dev] [PATCH v3 01/18] tests: Clear TCP state from conntrack dumps.

2016-06-17 Thread Jarno Rajahalme
When the TCP state is not important it is better ignore it. This makes test cases more robust w.r.t. kernel versions and timing. Signed-off-by: Jarno Rajahalme --- tests/system-common-macros.at | 2 +- tests/system-traffic.at | 142 +- 2 files cha

Re: [ovs-dev] [PATCH v2 03/16] datapath: compat for NAT.

2016-06-17 Thread Jarno Rajahalme
> On Jun 16, 2016, at 4:39 PM, Jesse Gross wrote: > > On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme wrote: >> diff --git a/datapath/linux/compat/include/linux/netfilter/nf_nat.h >> b/datapath/linux/compat/include/linux/netfilter/nf_nat.h >> new file mode 100644 >> index 000..210b9a7 >>

Re: [ovs-dev] [PATCH v2 00/16] datapath: NAT backports

2016-06-17 Thread Jarno Rajahalme
> On Jun 17, 2016, at 10:47 AM, Jesse Gross > wrote: > > On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme > wrote: >> This series adds the conntrack NAT integration upstreamed in Linux 4.6 >> to the OVS tree kernel module. Main code is the same as

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-17 Thread Nithin Raju
From: Yin Lin mailto:yinli...@gmail.com>> Date: Friday, June 17, 2016 at 5:10 PM To: "aserd...@cloudbasesolutions.com" mailto:aserd...@cloudbasesolutions.com>>, Nithin Raju mailto:nit...@vmware.com>> Cc: Yin Lin mailto:li...@vmware.com>>, "dev@openvswitch.

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-17 Thread Jesse Gross
On Fri, Jun 17, 2016 at 5:10 PM, Yin Lin wrote: > Thanks Alin and Nithin for the review and Jesse for the clarification. > > I've addressed all the comments except this one: > > "One general comment is that we are validating the tunnel options in the > hot path - basically for each packet when we

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: NUMA Aware vHost User

2016-06-17 Thread Daniele Di Proietto
Thanks for v2, applied to master. 2016-06-13 3:10 GMT-07:00 Ciara Loftus : > This commit allows for vHost User memory from QEMU, DPDK and OVS, as > well as the servicing PMD, to all come from the same socket. > > The socket id of a vhost-user port used to be set to that of the master > lcore. Now

[ovs-dev] [PATCH 1/2][PATCH v7] datapath-windows: Add Geneve support

2016-06-17 Thread Yin Lin
Signed-off-by: Yin Lin --- datapath-windows/automake.mk | 2 + datapath-windows/ovsext/Actions.c | 72 ++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 179 +++-- datapa

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

2016-06-17 Thread Yin Lin
Thanks Alin and Nithin for the review and Jesse for the clarification. I've addressed all the comments except this one: "One general comment is that we are validating the tunnel options in the hot path - basically for each packet when we execute the actions for the flow. Obvious solution for this

Re: [ovs-dev] [PATCH v4 09/17] dpif-netdev: Implement conntrack dump functions.

2016-06-17 Thread Daniele Di Proietto
Hi Sairam, You're right, that should be tcp_peer_to_protoinfo_flags(&conn->peer[1]) Thanks for pointing that out! Daniele On 16/06/2016 15:57, "Sairam Venugopal" wrote: >Hi Daniele, > >I was trying to add conntrack dump support based on this patch and found a >discrepancy in >conntrack-tcp.c

[ovs-dev] employees needed

2016-06-17 Thread dev
Hello! We are looking for employees working remotely. My name is Jill, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best regards!

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-17 Thread Jesse Gross
On Fri, Jun 17, 2016 at 6:46 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 16, 2016 at 03:53:12PM -0700, Jesse Gross wrote: >> On Thu, Jun 16, 2016 at 12:40 PM, Thadeu Lima de Souza Cascardo >> wrote: >> > The reason we have the first patch in the series is because we can't >> > identif

[ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

2016-06-17 Thread Andy Zhou
When calling ovs_thread_create() without calling fatal_signal_init() first, ovs_thread_create() some times asserts. This dependency is subtle and not very obvious. The root cause seems to be that, within ovs_thread_create(), the multi-threaded state is declared before all initializations are done.

[ovs-dev] [PATCH V10] Function tracer to trace all function calls

2016-06-17 Thread nghosh
From: Nirapada Ghosh In some circumstances, we might need to figure out where in code, the CPU time is being spent most, so as to pinpoint the bottleneck and thereby resolve it with proper changes. Using '-finstrument-functions' flag, that can be achieved, and this patch exactly does that. There

Re: [ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 13:16, Alin Serdean wrote: > Thanks for incorporating the comments: > Acked-by: Alin Gabriel Serdean > Applied, thanks guys! > > > -Mesaj original- > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > > Trimis: Friday, June 17, 2016 8:52 PM > >

Re: [ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Alin Serdean
Thanks for incorporating the comments: Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Friday, June 17, 2016 8:52 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v4] datapath-windows: use ip pr

[ovs-dev] [PATCH v5 2/2] ovn: Apply ACL changes to existing connections.

2016-06-17 Thread Russell Bryant
Prior to this commit, once a connection had been committed to the connection tracker, the connection would continue to be allowed, even if the policy defined in the ACL table changed. This patch changes the implementation so that existing connections are affected by policy changes. The implementa

[ovs-dev] [PATCH v5 0/2] ovn: Apply ACL changes to existing connections.

2016-06-17 Thread Russell Bryant
Prior to this commit, once a connection had been committed to the connection tracker, the connection would continue to be allowed, even if the policy defined in the ACL table changed. This patch changes the implementation so that existing connections are affected by policy changes. The implementa

[ovs-dev] [PATCH v5 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-06-17 Thread Russell Bryant
Update the "ct_commit;" logical flow action to optionally take one or two parameters, setting the value of "ct_mark" or "ct_label". Supported ct_commit syntax now includes: ct_commit; ct_commit(); ct_commit(ct_mark=1); ct_commit(ct_mark=1/1); ct_commit(ct_label=1); ct_commi

[ovs-dev] [PATCH v4] datapath-windows: Add GRE checksum

2016-06-17 Thread Alin Serdean
This patch introduces GRE checksum computation if the userspace requires it on Tx. On Rx we verify the GRE checksum if the checksum bit was specified and also inform the userspace about it. Also fix the GRE header length as specified by the GRE flags not the tunnel flags. Signed-off-by: Alin Gabr

[ovs-dev] The beautiful work in crisis!

2016-06-17 Thread dev
Hello! We are looking for employees working remotely. My name is Erika, am the personnel manager of a large International company. Most of the work you can do from home, that is, at a distance. Salary is $2500-$5000. If you are interested in this offer, please visit Our Site Best regards! ___

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

2016-06-17 Thread Joe Stringer
On 17 June 2016 at 12:42, Joe Stringer wrote: > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") > shifted a file between debian packages, but didn't update the > destination package annotations to indicate that it replaces a file > from earlier versions of the source package. >

[ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

2016-06-17 Thread Joe Stringer
Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") shifted a file between debian packages, but didn't update the destination package annotations to indicate that it replaces a file from earlier versions of the source package. As a result, if one installs openvswitch-switch-2.5* an

[ovs-dev] [PATCH V2 15/16] python tests: Ported Python daemon to Windows

2016-06-17 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

Re: [ovs-dev] [PATCH] netlink-notifier: change message to a less scary one

2016-06-17 Thread Aaron Conole
Thadeu Lima de Souza Cascardo writes: > "received bad netlink message" may be interpreted as a corrupt netlink > message. > However, the parse functions may return failure when the message contains > unexpected attributes or misses non optional attributes. Indicating the > message > contained "

[ovs-dev] [PATCH] netlink-notifier: change message to a less scary one

2016-06-17 Thread Thadeu Lima de Souza Cascardo
"received bad netlink message" may be interpreted as a corrupt netlink message. However, the parse functions may return failure when the message contains unexpected attributes or misses non optional attributes. Indicating the message contained "unexpected contents" will avoid some interpretation th

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
Hi Ben! I gave it a second run now with the latest commits and attached the log file. Thanks, Paul > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, June 17, 2016 9:20 PM > To: Paul Boca > Cc: Guru Shetty; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 00

Re: [ovs-dev] Stream Library in OVS

2016-06-17 Thread Shravan Ambati
Thanks Ben! -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Friday, June 17, 2016 11:29 AM To: Shravan Ambati Cc: dev@openvswitch.org Subject: Re: [ovs-dev] Stream Library in OVS On Fri, Jun 17, 2016 at 06:20:07PM +, Shravan Ambati wrote: > I was browsing through the

Re: [ovs-dev] Stream Library in OVS

2016-06-17 Thread Shravan Ambati
Thanks Cascardo! -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@redhat.com] Sent: Friday, June 17, 2016 11:33 AM To: Shravan Ambati Cc: dev@openvswitch.org Subject: Re: [ovs-dev] Stream Library in OVS On Fri, Jun 17, 2016 at 06:20:07PM +, Shravan Ambati wro

Re: [ovs-dev] Stream Library in OVS

2016-06-17 Thread Thadeu Lima de Souza Cascardo
On Fri, Jun 17, 2016 at 06:20:07PM +, Shravan Ambati wrote: > Hello > > I was browsing through the code in stream-unix.c and found that the > unix_stream_class does not register any methods except unix_open. Similar > behavior for punix_stream_class. > > I was wondering then how is data bei

Re: [ovs-dev] Stream Library in OVS

2016-06-17 Thread Ben Pfaff
On Fri, Jun 17, 2016 at 06:20:07PM +, Shravan Ambati wrote: > I was browsing through the code in stream-unix.c and found that the > unix_stream_class does not register any methods except > unix_open. Similar behavior for punix_stream_class. unix_open() returns a stream_fd.

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Ben Pfaff
Paul, feel free to pass along the testsuite.log from the failures on OpenSUSE. It's possible that we can spot the problem. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Stream Library in OVS

2016-06-17 Thread Shravan Ambati
Hello I was browsing through the code in stream-unix.c and found that the unix_stream_class does not register any methods except unix_open. Similar behavior for punix_stream_class. I was wondering then how is data being sent between unix stream sockets in OVS if there is not corresponding send

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
Hi, Yusheng, When running the datalog test_interactive program, I have some difficulty in generating the output of the incremental change. Could you help to check at which step I did something wrong? - Step 1: Create a rul

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, June 17, 2016 8:49 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows Also, we cannot add or enable tests on Windows that we know fails. Is it hard to get all the python uni

Re: [ovs-dev] [PATCHv7 2/2] ofp-actions: Add truncate action.

2016-06-17 Thread pravin shelar
On Tue, Jun 14, 2016 at 4:42 PM, William Tu wrote: > The patch adds a new action to support packet truncation. The new action > is formatted as 'output(port=n,max_len=m)', as output to port n, with > packet size being MIN(original_size, m). > > One use case is to enable port mirroring to send sma

[ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Nithin Raju
In Actions.c, based on the IP Protocol type and L4 port of the outer packet, we lookup the tunnel port. The function that made this happen took the tunnel type as an argument. Semantically, is is better to pass the IP protocol type and let the lookup code map IP protocol type to tunnel type. In th

Re: [ovs-dev] [PATCHv7 1/2] datapath:backport: openvswitch: Add packet truncation support.

2016-06-17 Thread pravin shelar
On Tue, Jun 14, 2016 at 4:42 PM, William Tu wrote: > Upstream commit: > commit f2a4d086ed4c588d32fe9b7aa67fead7280e7bf1 > Author: William Tu > Date: Fri Jun 10 11:49:33 2016 -0700 > > openvswitch: Add packet truncation support. > > The patch adds a new OVS action, OVS_ACTION

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
> > > > > Also, we cannot add or enable tests on Windows that we know fails. Is it > hard to get all the python unit tests working in one series? > > *[Paul Boca] I could disable those tests until they are fixed but wanted > to keep them failing and to fix them with a subsequent patch.* > > > Let

Re: [ovs-dev] [PATCH v2 00/16] datapath: NAT backports

2016-06-17 Thread Jesse Gross
On Tue, Jun 14, 2016 at 3:25 PM, Jarno Rajahalme wrote: > This series adds the conntrack NAT integration upstreamed in Linux 4.6 > to the OVS tree kernel module. Main code is the same as upstream > net-next, backports are provided for Linux kernels 3.10 - 4.6. Code > compiles on each Linux versi

Re: [ovs-dev] [PATCH v3] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Nithin Raju
>> >>+case IPPROTO_GRE: >[Alin Gabriel Serdean: ] break; >> +default: >[Alin Gabriel Serdean: ] return NULL; >> +break; >> +} >> +return vport; >> +} >> +} >> +return NULL; >> +} >We need to exact match the IP proto. In

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
> > *[Paul Boca] openSUSE 13.2 (x86_64)* > > *VERSION = 13.2* > > * CODENAME = Harlequin* > > * I will try also on Ubuntu to see if are ok.* > I haven't heard many people doing development on openSUSE for Open vSwitch. I would suggest installing Ubuntu 14.04 and then installing the following pac

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
Hi! From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, June 17, 2016 8:26 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows On 17 June 2016 at 10:07, Paul Boca mailto:pb...@cloudbasesolutions.com>> wrote: Hi! From: Guru She

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 10:07, Paul Boca wrote: > Hi! > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Friday, June 17, 2016 7:59 PM > *To:* Paul Boca > *Cc:* dev@openvswitch.org > *Subject:* Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on > Windows > > > > > > > > On 17 June 201

Re: [ovs-dev] [PATCH] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Alin Serdean
> > [Nithin]: The code is simpler this way. No? I can add a comment to clarify and > an ASSERT as well. BTW, we already make assumptions in the code w.r.t the > L4 port number for GRE ports. Pls. have a look at the following code: [Alin Gabriel Serdean: ] The problem is not we make an assumption o

Re: [ovs-dev] [PATCH v3] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Alin Serdean
Maybe I was a bit unclear in my previous comment. See inlined comment. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, June 15, 2016 1:11 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v3] datapath-windows: use ip

Re: [ovs-dev] [PATCH v7] ipfix: support tunnel information for Flow IPFIX

2016-06-17 Thread Ben Pfaff
On Tue, Jun 14, 2016 at 04:53:34PM +0800, Benli Ye wrote: > Add support to export tunnel information for flow-based IPFIX. Thanks, applied to master. I changed a couple of VLOG_ERR calls to VLOG_WARN because the problems they reported were not severe enough to warrant VLOG_ERR. I also added an i

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
Hi! From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, June 17, 2016 7:59 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows On 17 June 2016 at 09:06, Paul Boca mailto:pb...@cloudbasesolutions.com>> wrote: This series of patc

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 09:06, Paul Boca wrote: > This series of patches ports the python damons to Windows and > fixes the tests to work on Windows. > There are still some python tests that fail on Windows, from which > some are failing on Linux too. > Are you saying that after applying this patch s

[ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. Paul-Daniel Boca

[ovs-dev] [PATCH 16/16] at tests: Allow Python tests to be run on Windows

2016-06-17 Thread Paul Boca
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca --- tests/atlocal.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index f174061..410199f 100644 ---

[ovs-dev] [PATCH 13/16] python tests: Fixed abs_file_name function for Windows

2016-06-17 Thread Paul Boca
On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca --- python/ovs/util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/util.py b/python/ovs/util.py index cb0574b..edcfe81 100644 --- a/python/ovs/util.py +++ b/python/

[ovs-dev] [PATCH 15/16] python tests: Ported Python daemon to Windows

2016-06-17 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

[ovs-dev] [PATCH 14/16] python tests: Ported UNIX sockets to Windows

2016-06-17 Thread Paul Boca
AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error

[ovs-dev] [PATCH 11/16] python tests: Skip python tests on Windows where POSIX pid is used

2016-06-17 Thread Paul Boca
There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected. Als

[ovs-dev] [PATCH 08/16] python tests: Skip IPsec test on Windows

2016-06-17 Thread Paul Boca
IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Signed-off-by: Paul-Daniel Boca --- tests/ovs-monitor-ipsec.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovs-monitor-ipsec.at b/tests/ovs-monitor-ipsec.at index 7f13444..89eab71 1006

[ovs-dev] [PATCH 12/16] python tests: Fixed OSError not iterable on Windows

2016-06-17 Thread Paul Boca
On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca --- python/ovs/poller.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/ovs/poller.py b/python/ovs/poller.py index 20be801..a0fb2a7 100644 -

[ovs-dev] [PATCH 09/16] python tests: Don't check if the PID file gets deleted

2016-06-17 Thread Paul Boca
On Windows the PID file doesn't gets deleted on process exit. Signed-off-by: Paul-Daniel Boca --- tests/daemon-py.at | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/daemon-py.at b/tests/daemon-py.at index e59c11d..7578622 100644 --- a/tests/daemon-py.at +++ b/te

[ovs-dev] [PATCH 10/16] python tests: Skip TCP6 idl tests on Windows

2016-06-17 Thread Paul Boca
TCP6 sockets are not supported in python on Windows. Signed-off-by: Paul-Daniel Boca --- tests/ovsdb-idl.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index 057d09f..c23086c 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -109,6 +109,7

[ovs-dev] [PATCH 05/16] python tests: Fixed ctl file name for Windows

2016-06-17 Thread Paul Boca
On Windows the CTL file doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca --- python/ovs/unixctl/__init__.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/python/ovs/unixctl/__init__.py b/python/ovs/unixctl/__init__.py index d3d3556..6bbcbaa

[ovs-dev] [PATCH 04/16] python tests: Register signal handlers only on supported types on Windows

2016-06-17 Thread Paul Boca
SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca --- python/ovs/fatal_signal.py | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/python/ovs/fatal_signal.py b/python/ovs/fatal_signal.py index 7308039..5b90559 100644 --- a/python/

[ovs-dev] [PATCH 07/16] python tests: Added fcntl module for Windows

2016-06-17 Thread Paul Boca
This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca --- python/automake.mk | 1 + python/ovs/fcntl_win.py | 36 +++

[ovs-dev] [PATCH 06/16] python tests: Fixed unixctl python tests for Windows

2016-06-17 Thread Paul Boca
For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca --- tests/unixctl-py.at | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/unixctl-py.at b/tests/unixctl-py.at index cbcd802..2031897 100644 --- a/tests/unixctl-py.at +++ b/

[ovs-dev] [PATCH 03/16] python tests: Implemented signal.alarm for Windows

2016-06-17 Thread Paul Boca
signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca --- tests/appctl.py | 26 +- tests/test-ovsdb.py | 26

[ovs-dev] [PATCH 02/16] windows: Added lockf function and lock PID file

2016-06-17 Thread Paul Boca
If the PID file isn't locked then appctl.py detects it as stale and bails out without doing anything. Because of this lots of Python tests fail. Signed-off-by: Paul-Daniel Boca --- lib/daemon-windows.c | 44 1 file changed, 44 insertions(+) diff --gi

[ovs-dev] [PATCH 01/16] tests: Fixed PMD tests on Windows

2016-06-17 Thread Paul Boca
CHECK_CPU_DISCOVERED check the log file now, not the stderr. On Windows the ovs-vswitchd output is logged only in log file, not to stderr. Tested both on Windows and Linux Signed-off-by: Paul-Daniel Boca --- tests/pmd.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tes

[ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. Paul-Daniel Boca

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
Hui Kang/Watson/IBM wrote on 06/17/2016 11:04:21 AM: > From: Hui Kang/Watson/IBM > To: Yusheng Wang > Cc: Ryan Moats/Omaha/IBM@IBMUS, "dev@openvswitch.org" > Date: 06/17/2016 11:04 AM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > > "dev" wrote on 06/16/2016 10:58:58

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
"dev" wrote on 06/16/2016 10:58:58 PM: > From: Yusheng Wang > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 06/16/2016 10:59 PM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > Sent by: "dev" > > > I agree with all your comments but the last one. T

Re: [ovs-dev] [PATCH v6] datapath-windows: Add support for UDP and ICMP to Conntrack Module

2016-06-17 Thread Alin Serdean
> -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, June 16, 2016 8:54 PM > Către: Sairam Venugopal ; dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v6] datapath-windows: Add support for UDP > and ICMP to Conntrack Mod

Re: [ovs-dev] [PATCH] datapath-windows: comment cleanup and indentation

2016-06-17 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Thursday, June 16, 2016 8:17 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: comment cleanup and > indentation > > Signed-of

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Hui Kang
Yusheng Wang wrote on 06/17/2016 04:30:02 AM: > From: Yusheng Wang > To: Hui Kang/Watson/IBM@IBMUS > Cc: "dev@openvswitch.org" > Date: 06/17/2016 04:40 AM > Subject: Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > > > The idea is to write ovn-northd in nlog program. In order to do

Re: [ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

2016-06-17 Thread Thadeu Lima de Souza Cascardo
On Thu, Jun 16, 2016 at 03:53:12PM -0700, Jesse Gross wrote: > On Thu, Jun 16, 2016 at 12:40 PM, Thadeu Lima de Souza Cascardo > wrote: > > On Wed, Jun 08, 2016 at 03:21:58PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> This series adds support for the creation of tunnels using the rtnetl

[ovs-dev] Celebrity Lifestyle Plan To Keep Yourself Healthy

2016-06-17 Thread dev
Have you been dreaming of a beautiful body, but had no results with diets, workouts and supplements? Our incredible solution with a breakthrough formula will deliver you the results you've been so eager to achive. Click Here! Powerful weight loss product that amplifies methabolism, stimulate

[ovs-dev] QoS Shaping implementation in OVS-DPDK

2016-06-17 Thread gayathri.manepalli
Hi Team, We are done with QoS shaping implementation in OVS-DPDK(2.4.0) by making use of DPDK scheduler library. We have conducted some basic tests for QoS shaping and compared DPDK vs OVS-DPDK with IMIX traffic. Please find the below test results conducted with bi directional traffic , I will

Re: [ovs-dev] [PATCH] OVN: initial patch of datalog engine

2016-06-17 Thread Yusheng Wang
The idea is to write ovn-northd in nlog program. In order to do that, we need a hook to ovs-db, which is the next step I am going to do. Generally, a subset of ovs-db tables will be input tables to the nlog engine and the engine's output table will also be written to ovs-db. If we think about o