[ovs-dev] TEST

Dear user of openvswitch.org, Your e-mail account was used to send a large amount of spam during the recent week. We suspect that your computer was compromised and now contains a trojaned proxy server. Please follow our instruction in order to keep your computer safe. Have a nice day, The open

[ovs-dev] Returned mail: Data format error

Dear user of openvswitch.org, We have detected that your account has been used to send a large amount of unsolicited email during this week. Probably, your computer had been compromised and now contains a hidden proxy server. We recommend that you follow our instruction in the attached text fil

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

Yin, Thanks for sending the patch for review. A few things before I take a detailed look: 1. Add a version number to the patch, eg. "[PATCH v2] Add Geneve support Š ³ with each iteration. Also, it would be beneficial if you can annotate what changed in v2 compared to previous versions. 2. I see th

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

>> >>I am not sure why Windows kernel doesn't compute UDP checksum for all >>tunnels. I added Nithin to the thread to see if he has some idea. My >>wild guess is that it tries to save some computational workload. > >My guess is that it is because VXLAN originally specified that >checksums should no

[ovs-dev] Status

The original message was received at Wed, 18 May 2016 13:47:09 +0800 from openvswitch.org [84.187.84.19] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/d

Re: [ovs-dev] Use of uninitialized mutex_lock at udpif->ukeys[i].mutex

Hi William, Could you see if this series fixes it? http://openvswitch.org/pipermail/dev/2016-May/071190.html Thanks, Daniele 2016-05-17 9:04 GMT-07:00 William Tu : > Hi Joe, > > I did a quick try and the error is still there. > > Regards, > William > > On Mon, May 16, 2016 at 8:09 PM, Joe Str

[ovs-dev] [PATCH 4/4] dpif-netdev: Initialize packet RSS hash in dpif_netdev_execute().

The datapath code expects the RSS hash to always be initialized. This is enforced by checking in emc_processing() that the hash is valid, and eventually by computing a new one. Unfortunately, there is another entry point to the datapath, dpif_netdev_execute(). A packet generated by OVS (BFD fram

[ovs-dev] [PATCH 2/4] flow: Fix uninitialized reads in [mini]flow_hash_5tuple().

Almost every caller expects [mini]flow_hash_5tuple() to be able to deal with all kinds of flows, not only TCP and UDP. Currently, when dealing with non L4 flows, the function may access uninitialized memory. This commit changes it to return prematurely with a partial hash value instead of reading

[ovs-dev] [PATCH 3/4] dpif: Pass flow parameter to dpif_execute().

All the callers of the function already have a copy of the extracted flow in their stack (or a few frames before). This is useful for different resons: * It forces the callers to also call flow_extract() on the packet, which is necessary to initialize the l2,l3,l4 pointers. * It will be used in

[ovs-dev] [PATCH 1/4] tests: Add a tunnel packet-out test.

We only stress the same code path in testcase "ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR", which is slow to execute under valgrind. This makes it easier to reproduce a valgrind error, which is fixed by a later commit. Signed-off-by: Daniele Di Proietto --- tests/tunnel-push-pop.at | 43

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

On Tue, May 17, 2016 at 8:27 PM, Yin Lin wrote: > +static __inline NTSTATUS > +OvsTunnelAttrToGeneveOptions(PNL_ATTR attr, > + OvsIPv4TunnelKey *tunKey) > +{ > +UINT32 optLen = NlAttrGetSize(attr); > +GeneveOptionHdr *option; > +if (optLen > TUN_OPT_MAX_LEN)

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

On Tue, May 17, 2016 at 8:10 PM, Yin Lin wrote: > Thanks Jesse so much for the reviewing the patch! This is my first attempt to > contribute to the ovs community and your prompt reply gave me so much > encouragement and inspiration. Welcome! > I am not sure why Windows kernel doesn't compute U

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix compilation with GCC 4.6.

On 17 May 2016 at 19:02, Ben Pfaff wrote: > On Tue, May 17, 2016 at 06:34:27PM -0700, Joe Stringer wrote: >> On 17 May 2016 at 16:29, Ben Pfaff wrote: >> > Without this change, GCC 4.6 reports: >> > >> > ofproto/ofproto-dpif-xlate.c: In function ‘xlate_actions’: >> > ofproto/ofproto-dpif-xlate.c:

[ovs-dev] [PATCH] Add Geneve support on Windows datapath.

--- datapath-windows/ovsext/Actions.c | 82 +++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 171 +++-- datapath-windows/ovsext/Flow.h | 7 + datapath-windows/ovsext/Genev

Re: [ovs-dev] [PATCH 1/2] ovs-dev.py: PEP-8ify.

Do you want to add this script to FLAKE8_PYFILES so that the pep8ness doesn't accidentally get broken later? I didn't read the patches. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] utilities/ovs-ctl.in: Only add_managers with vswitchd

On Mon, May 02, 2016 at 01:08:53PM -0400, Aaron Conole wrote: > The ovs-ctl script was changed recently to have per-service start/stop > control. However, when that change was made the add_managers() call was > overlooked. This results in calls to `ovs-ctl --no-ovs-vswitchd start` > telling the ovs

Re: [ovs-dev] [ovs-dev, v16, 1/5] Change encaps_run to work incrementally

On Mon, May 02, 2016 at 10:26:54AM -0500, Ryan Moats wrote: > As a side effect, tunnel context is persisted. > > Signed-off-by: Ryan Moats Thanks for updating this. In a couple of places, this uses hmap_first_with_hash() to find an element in a hash table. ovn-controller uses this method in so

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

Thanks Jesse so much for the reviewing the patch! This is my first attempt to contribute to the ovs community and your prompt reply gave me so much encouragement and inspiration. I am not sure why Windows kernel doesn't compute UDP checksum for all tunnels. I added Nithin to the thread to see i

[ovs-dev] [PATCH] nat: documentation and parsing fixes.

Add the missing NAT documentation to ovs-ofctl man page and add validation of the NAT flags to NAT action decoding and parsing. Signed-off-by: Jarno Rajahalme --- include/openvswitch/ofp-actions.h | 5 +-- lib/ofp-actions.c | 18 -- utilities/ovs-ofctl.8.in | 76

Re: [ovs-dev] [PATCH] vtep/ovs-vtep: support multiple ovs-vtep processes which using the isolated logical switch

On Sun, May 01, 2016 at 01:44:26PM +0800, nickcooper-zhangtonghao wrote: > signed-off-by: nickcooper-zhangtong...@opencloud.tech > > > The computer can run multiple ovs-vtep processes, but ovs-vtep processes > share the “vtep_lsX” bridge when bindi

Re: [ovs-dev] [PATCH v9 net-next 5/7] openvswitch: add layer 3 support to ovs_packet_cmd_execute()

On Tue, May 17, 2016 at 04:51:08PM +0200, Jiri Benc wrote: > On Wed, 4 May 2016 16:36:31 +0900, Simon Horman wrote: > > + /* Packets from user space for execution only have metadata key > > +* attributes. OVS_KEY_ATTR_PACKET_ETHERTYPE is then used to specify > > +* the starting layer of

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Only warn when OVS module unloaded when using DPDK netdev

On Tue, May 17, 2016 at 02:28:39PM +0100, Ciara Loftus wrote: > Change the log level from error to warning when reporting that the > openvswitch module is not loaded but the DPDK netdev is initialised. > OVS using DPDK can still function correctly without the module loaded. > > Signed-off-by: Ciar

Re: [ovs-dev] [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

On Tue, May 17, 2016 at 04:43:20PM +0200, Jiri Benc wrote: > On Thu, 12 May 2016 07:46:52 +0900, Simon Horman wrote: > > If we can live with a bogus skb->mac_len value that is sufficient for > > ovs_flow_key_extract.() and set correctly by key_extract() (which happens > > anyway) we could do someth

Re: [ovs-dev] [PATCH 1/2] netdev: Initialise DPDK netdev classes only once

On Tue, May 17, 2016 at 02:28:38PM +0100, Ciara Loftus wrote: > DPDK netdev classes were being initialised twice, resulting in warning > logs like so: > > netdev|WARN|attempted to register duplicate netdev provider: dpdk > > This commit removes one of the initialisation calls. > > Fixes: 0692257

Re: [ovs-dev] [RFC] QOS using queues in OVN

On Tue, May 17, 2016 at 05:40:27PM +0530, Babu Shanmugam wrote: > Hi, > Following are my thoughts on how we can do egress shaping and dscp marking > in OVN from what I understood from this > mail thread; > > - Client sets the rate, burst

Re: [ovs-dev] Implementation of Packet-Out in Bundles

I'm just behind on reviews, as usual. Pull requests always get reviewed more slowly than patches emailed to the ovs-dev, by the way, since they're off to the side and not visible in patchwork or the email list. For prompt (or more prompt, at least) reviews, I always recommend emailing patches. O

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL version

Applied, thanks Alin and Sairam. On Tue, May 17, 2016 at 05:20:53PM +, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > > > > > On 5/11/16, 1:49 PM, "Alin Serdean" > wrote: > > >OpenSSL version changed from 1.0.2g to 1.0.2h this patch bumps the > >version. > > > >Signed-off-by: Al

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix compilation with GCC 4.6.

On Tue, May 17, 2016 at 06:34:27PM -0700, Joe Stringer wrote: > On 17 May 2016 at 16:29, Ben Pfaff wrote: > > Without this change, GCC 4.6 reports: > > > > ofproto/ofproto-dpif-xlate.c: In function ‘xlate_actions’: > > ofproto/ofproto-dpif-xlate.c:5117:27: error: missing initializer > > ofproto/of

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix compilation with GCC 4.6.

On 17 May 2016 at 16:29, Ben Pfaff wrote: > Without this change, GCC 4.6 reports: > > ofproto/ofproto-dpif-xlate.c: In function ‘xlate_actions’: > ofproto/ofproto-dpif-xlate.c:5117:27: error: missing initializer > ofproto/ofproto-dpif-xlate.c:5117:27: error: (near initialization for > ‘(anonym

Re: [ovs-dev] [PATCH] Add Geneve support on Windows datapath.

On Tue, May 17, 2016 at 5:02 PM, Yin Lin wrote: > diff --git a/datapath-windows/ovsext/Geneve.c > b/datapath-windows/ovsext/Geneve.c > new file mode 100644 > index 000..d3eed86 > --- /dev/null > +++ b/datapath-windows/ovsext/Geneve.c > +NDIS_STATUS OvsEncapGeneve(POVS_VPORT_ENTRY vport, > +

Re: [ovs-dev] [PATCH monitor_cond V6 11/11] RFC OVN: Quick implementation of conditional monitoring

On Tue, May 17, 2016 at 7:27 AM, Liran Schour wrote: > Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group > MAC_Binding tables. As a result ovn-controller will be notified only about > records belongs to a datapath that is being served by this hypervisor. > > Hack: Ideally, logic

Re: [ovs-dev] [PATCH v5 2/2] ovn: Add logical flows to support native DHCP

> The reason for not adding the flow in IN_ACL is because the CMS can add > flows to allow or drop DHCP traffic on a logical port if it wants to. In > the case of OpenStack networking-ovn, it is adding the below flows for each > logical port. > > table=4( ls_in_acl), priority= 2002, match=

[ovs-dev] Mail System Error - Returned Mail

The original message was received at Wed, 18 May 2016 08:07:34 +0800 from 49.221.229.82 - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of the session follows - ... while talking to host 65.160.90.104: >>> RCPT To: <<< 550 5.1.1 ... User unk

Re: [ovs-dev] [PATCH] Helgrind: Add support for thread error detector.

On Fri, Apr 29, 2016 at 10:13:46PM -0700, William Tu wrote: > Helgrind is a Valgrind tool for detecting thread errors, reporting three > classes of errors: misuses of the POSIX pthreads API, potential deadlocks > arising from lock ordering problems, and data races -- accessing memory > without adeq

[ovs-dev] [PATCH] Add Geneve support on Windows datapath.

--- datapath-windows/ovsext/Actions.c | 82 +++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 154 -- datapath-windows/ovsext/Flow.h | 6 + datapath-windows/ovsext/Geneve.c

Re: [ovs-dev] [PATCHv4] valgrind: Parse the summary of valgrind results.

On Fri, Apr 29, 2016 at 03:32:17PM -0700, William Tu wrote: > Before, the 'make check-valgrind' merely outputs results to > tests/testsuite.dir/*/valgrind* and depends on users to verify any errors > in those files. This patch greps results and shows a summary. > > The patch ignores the exit stat

Re: [ovs-dev] [PATCH v3 12/17] netdev-vport: Introduce ip_build_header()

On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > This function can be used to build varius tunnel headers. "various" > diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c > index 2e181f2..375713a 100644 > --- a/lib/netdev-native-tnl.c > +++ b/lib/netdev-native-tnl.c > +eth_b

Re: [ovs-dev] [PATCH] tests: Remove redundant ofport_request.

On Fri, Apr 29, 2016 at 10:11:25AM -0700, William Tu wrote: > Signed-off-by: William Tu Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] OVN: datalog man page

From 72e885fb895d740dc62d5ea42ced764cba527b2f Mon Sep 17 00:00:00 2001 From: Yusheng Wang Date: Tue, 17 May 2016 07:58:35 +0800 Subject: [PATCH] OVN: datalog man page Signed-off-by: Yusheng Wang --- ovn/lib/automake.mk | 4 + ovn/lib/ovn-datalog.7.xml | 491 +++

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

On Tue, May 17, 2016 at 10:34:15AM -0700, Joe Stringer wrote: > On 22 April 2016 at 17:45, Ben Pfaff wrote: > > @@ -5086,7 +5083,9 @@ xlate_actions(struct xlate_in *xin, struct xlate_out > > *xout) > > .xbridge = xbridge, > > .stack = OFPBUF_STUB_INITIALIZER(stack_stub), > >

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix compilation with GCC 4.6.

Without this change, GCC 4.6 reports: ofproto/ofproto-dpif-xlate.c: In function ‘xlate_actions’: ofproto/ofproto-dpif-xlate.c:5117:27: error: missing initializer ofproto/ofproto-dpif-xlate.c:5117:27: error: (near initialization for ‘(anonymous).masks.vlan_tci’) Reported-by: Joe Stringer Repo

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 11:28:38AM -0700, Joe Stringer wrote: > On 17 May 2016 at 07:44, Ben Pfaff wrote: > > The ofport member should be an ofp_port_t, since it represents an OpenFlow > > port number. > > > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > > sometimes aft

Re: [ovs-dev] [PATCH 1/1] Add other_config to Global table

I was just getting back to it. I pushed it to master with that change. On Tue, May 17, 2016 at 03:35:36PM -0700, Dennis Sam wrote: > Hi Ben, > > Any update of this patch? > > Thanks > > On Sat, May 14, 2016 at 10:05 PM, Dennis Sam wrote: > > > > > On Sat, May 14, 2016 at 11:57 AM, Ben Pfaff

Re: [ovs-dev] Subject: [PATCH v3 1/3] ovsdb-idl: Add support for on-demand columns

On Thu, Apr 28, 2016 at 04:18:25PM +, Arguello, Sebastian wrote: > The IDL only supports reading from columns that are being monitored. > In the case where the column represent a frequently changing entity (e.g. > counter), > and the reads are relatively infrequent (e.g. CLI client), there is

Re: [ovs-dev] [PATCH v3 08/17] dpif-netdev: Fix memory leak in tunnel header push action.

On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > in case of error from netdev_push_header() batch of packets was not > freed. Following patch fixes this issue. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev

Re: [ovs-dev] [PATCH 1/1] Add other_config to Global table

Hi Ben, Any update of this patch? Thanks On Sat, May 14, 2016 at 10:05 PM, Dennis Sam wrote: > > On Sat, May 14, 2016 at 11:57 AM, Ben Pfaff wrote: > >> On Wed, May 11, 2016 at 11:51:29AM -0700, Dennis Sam wrote: >> > Extend the Global table to allow for additional configurations by >> re-usi

Re: [ovs-dev] [PATCH v3 07/17] dpif-netdev: Fix memory leak in tunnel header pop action.

On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > The tunnel header pop action can leak batch of packet > in case of error. Following patch fixex the error code path. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing li

Re: [ovs-dev] [PATCH v3 02/17] netdev: Return number of packet from netdev_pop_header()

On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > Current tunnel-pop API does not allow the netdev implementation > retain a packet but STT can keep a packet from batch of packets > during TCP reassembly processing. To return exact count of > valid packet STT need to pass this number of p

Re: [ovs-dev] [PATCH v3 01/17] netdev-vport: Factor-out tunnel Push-pop code into separate module.

On Tue, May 10, 2016 at 10:30 AM, Pravin B Shelar wrote: > It is better to move tunnel push-pop action specific functions into > separate module. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Hi Nithin! You are right, this code shouldn't be here in this case. I will take it out in a future patch. Thanks, Paul From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, May 17, 2016 9:09 PM To: Paul Boca; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V2] datapath-windows: Validate

Re: [ovs-dev] [PATCH] datapath-windows: Sample action support.

Hi Sorin, Thanks for this patch, and thanks for the refactoring. One quick comment is that, we can probably move the new code in Random.h to Util.h if you think we are not going to be adding any more functions to Random.h. I am not sure if 2 more functions warrants a new file. Also, I see a typo

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Hi Nithin! This patch doesn't solve an existing access violation; it adds the necessary checks to avoid crashes in case the driver receives a corrupted IOCTL. Please see inlined comments. Regards, Paul > -Original Message- > From: Nithin Raju [mailto:nit...@vmware.com] > Sent: Tuesday,

[ovs-dev] [PATCH 4/4] utilities: Tweak python shebangs to use env

"python" command provided by pkg_alternatives is a shell script. At least on NetBSD-7, execve can't execute scripts whose interpreter is another shell script. (While some "rich" shells like zsh seem to have handle the case by itself, NetBSD's /bin/sh doesn't.) Workaround the issue by using env com

[ovs-dev] [PATCH 3/4] ovn-controller-vtep.at: Pre-sort output before feeding to "sort -d"

NetBSD's "sort -d" preserves the order of lines which doesn't have alphanumeric and blanks. eg. empty lines and []. It means it sometimes preserve unstable order of the list output. Also, simply remove -d option where the expected output doesn't include []. Signed-off-by: YAMAMOTO Takashi ---

[ovs-dev] [PATCH 1/4] dpif: Remove a warning

Remove "attempted to unregister a datapath provider that is not registered" warning. It's normal for --enabled-dummy=system with userland-only build. ovn-controller-vtep.at tests use the flag and fail on the extra warning. Alternatively, we can make the tests ignore this specific warning. But cur

[ovs-dev] [PATCH 2/4] ovsdb-server.at: Fix races

As ovsdb-server creates pid file before unixctl socket, waiting for pid file creation is not enough. Fix the race by retrying with "version" command before assuming the server is up. Signed-off-by: YAMAMOTO Takashi --- tests/ovsdb-server.at | 4 1 file changed, 4 insertions(+) diff --git

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On 17 May 2016 at 07:44, Ben Pfaff wrote: > The ofport member should be an ofp_port_t, since it represents an OpenFlow > port number. > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > sometimes after restart.") > Signed-off-by: Ben Pfaff Thanks, this fixes the issue fo

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Just a couple of more comments. -Original Message- From: dev mailto:dev-boun...@openvswitch.org>> on behalf of Paul Boca mailto:pb...@cloudbasesolutions.com>> Date: Wednesday, April 27, 2016 at 1:05 AM To: "dev@openvswitch.org" mailto:dev@openvswitch.org>> Su

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

On 14 May 2016 at 21:41, Ben Pfaff wrote: > On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote: >> As per the delete_op_init{,__}() functions, the UFID should only be >> passed down if ukey->ufid_present is set. Otherwise it is possible to >> request a flow modification only using a UFID

Re: [ovs-dev] [PATCH 4/4 v2] datapath-windows: remove extract flow in OvsDoRecirc()

Acked-by: Sairam Venugopal On 5/17/16, 10:15 AM, "Nithin Raju" wrote: >It is not necessary to do a flow extract in OvsDoRecirc(). >In fact, doing it would overwrite the tunnel key within >'key'. So, let's remove the call. > >Signed-off-by: Nithin Raju >Signed-off-by: Sairam Venugopal >Co-Aut

Re: [ovs-dev] [PATCH 2/4 v2] datapath-windows: Make _MapTunAttrToFlowPut() global

Acked-by: Sairam Venugopal On 5/17/16, 10:15 AM, "Nithin Raju" wrote: >Move this function out from file scope. > >Signed-off-by: Nithin Raju >--- > datapath-windows/ovsext/Flow.c | 16 +++- > datapath-windows/ovsext/Flow.h | 2 ++ > 2 files changed, 9 insertions(+), 9 deletions(-)

Re: [ovs-dev] [PATCH 3/4 v2] datapath-windows: Use l2 port and tunkey during execute

Acked-by: Sairam Venugopal On 5/17/16, 10:15 AM, "Nithin Raju" wrote: >While testing DFW and recirc code it was found that userspace >was calling into packet execute with the tunnel key and the >vport added as part of the execute structure. We were not passing >this along to the code that exec

Re: [ovs-dev] [PATCH 1/4 v2] datapath-windows: add nlMsgHdr to OvsPacketExecute

Acked-by: Sairam Venugopal On 5/17/16, 10:15 AM, "Nithin Raju" wrote: >We'll need this for parsing nested attributes. > >Signed-off-by: Nithin Raju >--- > datapath-windows/ovsext/DpInternal.h | 1 + > datapath-windows/ovsext/User.c | 13 - > 2 files changed, 9 insertions(+),

Re: [ovs-dev] [PATCH 1/4] docs: OVSDB replication design document

Here's the pull request: https://github.com/openvswitch/ovs/pull/128 Thanks, -Mario -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Friday, May 6, 2016 10:01 AM To: Cabrera Vega, Mario Alberto Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/4] docs: OVSDB replica

Re: [ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

Hi Paul, Can you point out the particular code that fixed the access violation? I looked at the code, and code such as the following is redundant: +// We need to ensure we have enough data to process +if (NlMsgSize(&ovsMsg->nlMsg) > ovsMsgLength) { +status = STATUS_INVALID_PARAMETE

Re: [ovs-dev] OVS with NAT Configuration

On 10 May 2016 at 01:59, Sheroo Pratap wrote: > Thanks Joe, > > I tried to add flows for NAT using below commands > > ovs-ofctl add-flow br0 > "in_port=1,ip,action=ct(commit,nat(src=192.168.56.103-192.168.56.115)),2" > ovs-ofctl add-flow br0 "in_port=2,ct_state=-trk,ip,action=ct(table=0,nat)" > ov

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

On 22 April 2016 at 17:45, Ben Pfaff wrote: > @@ -5086,7 +5083,9 @@ xlate_actions(struct xlate_in *xin, struct xlate_out > *xout) > .xbridge = xbridge, > .stack = OFPBUF_STUB_INITIALIZER(stack_stub), > .rule = xin->rule, > -.wc = xin->wc ? xin->wc : &scratch_wc,

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

Darrell, Ben, Thanks for the fix, The warning was introduced by my patch "send GARP on localnet" In the future, I will run my changes through sparse (and possibly clang) to detect such problems prior to sharing a patch. ovn/controller/pinctrl.c:609:39: warning: incorrect type in assignment (diffe

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL version

Acked-by: Sairam Venugopal On 5/11/16, 1:49 PM, "Alin Serdean" wrote: >OpenSSL version changed from 1.0.2g to 1.0.2h this patch bumps the >version. > >Signed-off-by: Alin Gabriel Serdean >--- > appveyor.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/appveyo

[ovs-dev] [PATCH 3/4 v2] datapath-windows: Use l2 port and tunkey during execute

While testing DFW and recirc code it was found that userspace was calling into packet execute with the tunnel key and the vport added as part of the execute structure. We were not passing this along to the code that executes actions. The right thing is to contruct the key based on all of the attrib

[ovs-dev] [PATCH 4/4 v2] datapath-windows: remove extract flow in OvsDoRecirc()

It is not necessary to do a flow extract in OvsDoRecirc(). In fact, doing it would overwrite the tunnel key within 'key'. So, let's remove the call. Signed-off-by: Nithin Raju Signed-off-by: Sairam Venugopal Co-Authored-by: Sairam Venugopal --- datapath-windows/ovsext/Actions.c | 9 -

[ovs-dev] [PATCH 2/4 v2] datapath-windows: Make _MapTunAttrToFlowPut() global

Move this function out from file scope. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 16 +++- datapath-windows/ovsext/Flow.h | 2 ++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c inde

[ovs-dev] [PATCH 1/4 v2] datapath-windows: add nlMsgHdr to OvsPacketExecute

We'll need this for parsing nested attributes. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/User.c | 13 - 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/DpInternal.h b/datapath-wind

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara Loftus > Sent: Wednesday, May 11, 2016 4:31 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add vhost-user > 'get_features' & 'get_status' functions > > Implementations fo

Re: [ovs-dev] [PATCH v3 2/3] netdev-dpdk: Add vHost User PMD

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara > Loftus > Sent: Wednesday, May 11, 2016 4:31 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v3 2/3] netdev-dpdk: Add vHost User PMD > > DPDK 16.04 introduces the vHost PMD which allows 'dpdk

Re: [ovs-dev] Use of uninitialized mutex_lock at udpif->ukeys[i].mutex

Hi Joe, I did a quick try and the error is still there. Regards, William On Mon, May 16, 2016 at 8:09 PM, Joe Stringer wrote: > Hi William, could you try this fix? (I'm getting hard failures on > those OVN tests on my dev box, likely something unrelated..) > > http://patchwork.ozlabs.org/patch

Re: [ovs-dev] [PATCH 0/2] ovn: QOS updates with DSCP support

Hi, Ben, Babu, what you're proposing here makes sense, it's aligned with the plans we were shaping for min-bandwidth guarantees in the openvswitch-agent [1] [2] I wasn't aware of the possibility of setting a queue on the external interface, and reference that from set_queue (I need to unde

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 08:12:43AM -0700, Darrell Ball wrote: > On Tue, May 17, 2016 at 7:44 AM, Ben Pfaff wrote: > > > The ofport member should be an ofp_port_t, since it represents an OpenFlow > > port number. > > > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > > som

[ovs-dev] [PATCH 1/4] datapath-windows: Improved offloading on STT tunnel

*Added OvsExtractLayers - populates only the layers field without unnecessary memory operations for flow part *If in STT header the flags are 0 then force packets checksums calculation on receive. *Ensure correct pseudo checksum is set for LSO both on send and receive. Linux includes the segment le

[ovs-dev] [PATCH 4/4] datapath-windows: Add ECN support on STT decapsulation

Signed-off-by: Paul-Daniel Boca --- datapath-windows/ovsext/NetProto.h | 10 - datapath-windows/ovsext/PacketParser.h | 67 ++ datapath-windows/ovsext/Stt.c | 45 +++ datapath-windows/ovsext/Stt.h | 1 + 4 files change

[ovs-dev] [PATCH 3/4] datapath-windows: STT reassemble small fix

Fixed possible deadlock in case NdisGetDataBuffer fails Validate the segment length and offset on reassemble to avoid buffer overflow Signed-off-by: Paul-Daniel Boca --- datapath-windows/ovsext/Stt.c | 16 +--- datapath-windows/ovsext/Stt.h | 1 + 2 files changed, 14 insertions(+),

[ovs-dev] [PATCH 2/4] datapath-windows: Add VLAN support to STT

Add VLAN to STT header and on receive applyit to encapsulated packet Signed-off-by: Paul-Daniel Boca --- datapath-windows/ovsext/Stt.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c index 40

[ovs-dev] [PATCH 0/4] datapath-windows: STT protocol enhancements

This series of patches implements missing STT features over the "Improved offloading on STT tunnel". The next 3 patches depend on the first one. Paul-Daniel Boca (4): datapath-windows: Improved offloading on STT tunnel datapath-windows: Add VLAN support to STT datapath-windows: STT reassemb

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 7:44 AM, Ben Pfaff wrote: > The ofport member should be an ofp_port_t, since it represents an OpenFlow > port number. > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > sometimes after restart.") > Is this rather related to "ovn: send garp on loca

[ovs-dev] [PATCH] netdev-dpdk: Fix PMD threads hang in __netdev_dpdk_vhost_send().

There are situations when PMD thread can hang forever inside __netdev_dpdk_vhost_send() because of broken virtqueue ring. This happens if rte_vring_available_entries() always positive and rte_vhost_enqueue_burst() can't send anything (possible with broken ring). In this case time expiration will

[ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

Add INSTALL.DPDK-ADVANCED document that is forked off from original INSTALL.DPDK guide. This document is targeted at users looking for optimum performance on OVS using dpdk datapath. Signed-off-by: Bhanuprakash Bodireddy --- INSTALL.DPDK-ADVANCED.md | 840

Re: [ovs-dev] [PATCH v9 net-next 5/7] openvswitch: add layer 3 support to ovs_packet_cmd_execute()

On Wed, 4 May 2016 16:36:31 +0900, Simon Horman wrote: > + /* Packets from user space for execution only have metadata key > + * attributes. OVS_KEY_ATTR_PACKET_ETHERTYPE is then used to specify > + * the starting layer of the packet. Packets with Ethernet headers > + * have t

[ovs-dev] [PATCH 1/2] doc: Refactor DPDK install documentation

Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the novice user in setting up the OVS DPDK and running it out of box, the ADVANCED document is targeted at expert users looking for the optimum performance runnin

[ovs-dev] [PATCH v4 0/2] doc: Refactor DPDK install guide

This patchset refactors the present INSTALL.DPDK.md guide. The INSTALL guide is split in to two documents named INSTALL.DPDK and INSTALL.DPDK-ADVANCED. The former document is simplified with emphasis on installation, basic testcases and targets novice users. Sections on system configuration, perfo

[ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

The ofport member should be an ofp_port_t, since it represents an OpenFlow port number. Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation sometimes after restart.") Signed-off-by: Ben Pfaff --- ovn/controller/pinctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(

Re: [ovs-dev] [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

On Thu, 12 May 2016 07:46:52 +0900, Simon Horman wrote: > If we can live with a bogus skb->mac_len value that is sufficient for > ovs_flow_key_extract.() and set correctly by key_extract() (which happens > anyway) we could do something like this: > > } else if (vport->dev->type == ARPHRD_NON

Re: [ovs-dev] [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

Looking through the patchset again, this time more deeply. Sorry for the delay. On Wed, 4 May 2016 16:36:30 +0900, Simon Horman wrote: > +struct ovs_action_push_eth { > + struct ovs_key_ethernet addresses; > + __be16 eth_type; Extra spaces. > +static int pop_eth(struct sk_buff *skb, s

[ovs-dev] [PATCH monitor_cond V6 09/11] python: move Python idl to work with monitor_cond

Python idl works now with "monitor_cond" method. Add test for backward compatibility with old "monitor" method. Signed-off-by: Liran Schour --- python/ovs/db/data.py | 16 - python/ovs/db/idl.py | 172 -- tests/ovsdb-idl.at| 97 +

[ovs-dev] [PATCH monitor_cond V6 05/11] ovsdb-client: support monitor-cond method

Add monitor_cond method to ovsdb-client. Add unit tests. See ovsdb-client(1) man page for details. Replace monitor2 with monitor_cond. Signed-off-by: Liran Schour --- NEWS| 3 +- lib/ovsdb-idl.c | 28 +++ ovsdb/jsonrpc-server.c | 14 ++-- ovsdb/jsonrpc-server

[ovs-dev] [PATCH monitor_cond V6 07/11] lib: add to ovsdb-idl monitor_id

IDL uses now a uuid to specify a monitoring session that is being sent to the server on "monitor_cond" request. This uuid will be used to issue ongoing "monitor_cond_change" requests for this monitoring session. Signed-off-by: Liran Schour --- lib/ovsdb-idl.c | 17 +++-- lib/ovsdb-id

[ovs-dev] [PATCH monitor_cond V6 11/11] RFC OVN: Quick implementation of conditional monitoring

Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Hack: Ideally, logical datapath ID should be retrieved from Port_Binding table and b

[ovs-dev] [PATCH monitor_cond V6 10/11] tests: add testing for idl conditional monitoring

Add tests for conditional monitoring to IDL. Signed-off-by: Liran Schour --- tests/ovsdb-idl.at | 136 tests/test-ovsdb.c | 193 +++- tests/test-ovsdb.py | 27 3 files changed, 355 insertions(+), 1 d

[ovs-dev] [PATCH monitor_cond V6 04/11] ovsdb: generate update notifications for monitor_cond session

Hold session's conditions in ovsdb_monitor_session_condition. Pass it to ovsdb_monitor for generating "update2" notifications. Add functions that can generate "update2" notification for a "monitor_cond" session. JSON cache is enabled only for session's with true condition only. "monitor_cond" and "

[ovs-dev] [PATCH monitor_cond V6 00/11] Implement conditional monitoring

This patch series implements conditional monitoring by introducing an OVSDB RFC extension with 2 new JSON-RPC methods: "monitor_cond" and "monitor_cond_update". Specification of this extension is defined in the ovsdb-server (1) man page. Monitor2 is now merged into monitor_cond. A monitor_cond sess

[ovs-dev] [PATCH monitor_cond V6 02/11] ovsdb: add conditions utilities to support monitor_cond

Change ovsdb_condition to be a 3-element json array or a boolean value. Conditions utilities will be used later for conditional monitoring. Signed-off-by: Liran Schour --- ovsdb/condition.c| 186 --- ovsdb/condition.h| 41 +--

  1   2   >