Re: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

2016-04-21 Thread Paul Boca
Thanks for review! You're right Nithin, there's no reason to extend to 32 bytes. I've searched about why Microsoft added that size to MAC address and found in NDIS_FILTER_ATTACH_PARAMETERS that there is a field MacAddressLength specific to the type media, but for NdisMedium802_3 it is indeed 6

Re: [ovs-dev] [PATCH] datapath-windows: Add paranthesis to fix error C2275

2016-04-21 Thread Nithin Raju
Acked-by: Nithin Raju -Original Message- From: dev on behalf of Sairam Venugopal Date: Thursday, April 21, 2016 at 10:44 PM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH] datapath-windows: Add paranthesis to fix error C2275 >Add braces around the if condition to prevent Visual

[ovs-dev] [PATCH] datapath-windows: Add paranthesis to fix error C2275

2016-04-21 Thread Sairam Venugopal
Add braces around the if condition to prevent Visual Studio from giving the "error C2275: illegal use of this type as an expresion". This happens when a variable is declared after a block. This error occurs on certain versions of compilers. Signed-off-by: Sairam Venugopal --- datapath-windows/ov

[ovs-dev] [PATCH] packets: use flow protocol when recalculating ipv6 checksums

2016-04-21 Thread Simon Horman
When using masked actions the ipv6_proto field of an action to set IPv6 fields may be zero rather than the prevailing protocol which will result in skipping checksum recalculation. This patch resolves the problem by relying on the protocol in the flow key rather than that in the set field action.

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-21 Thread Takashi YAMAMOTO
i don't have any problem with Xiao's approach. just wanted to make sure alternatives considered. wrt implementation, Xiao, can you rebase it? On Fri, Apr 22, 2016 at 3:39 AM, Ben Pfaff wrote: > Yamamoto-san, I could really use your opinion here: do you think that > this should be done different

Re: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

2016-04-21 Thread Nithin Raju
Why do we need ethernet address to be macAddress to be 32 bytes? We should just make sure that when we copy, we use sizeof () and in this case, it is sizeof (vport->macAddress). -- Nithin -Original Message- From: dev on behalf of Paul Boca Date: Monday, April 18, 2016 at 12:52 AM To: "

[ovs-dev] [PATCH] datapath: Fix datapath build on Centos 6.5 (2.6.31-431) kernels

2016-04-21 Thread Wanlong Gao
The build was failing with following error: CC [M] /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.o /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.c: In function ‘ovs_vport_get_stats’: /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.c:328: error: im

Re: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam

2016-04-21 Thread Sorin Vinturis
Good catch! Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca Sent: Monday, 18 April, 2016 10:52 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Fixed buffer overflow in OvsInitVportWithNicParam nicPar

[ovs-dev] [PATCH v2 13/15] native tunnel: Add support for STT

2016-04-21 Thread Pravin B Shelar
This patch used userpsace tunneling mechanism for implementing STT tunneling protocol. For details about STT you can refer the draft: https://tools.ietf.org/html/draft-davie-stt-07 Signed-off-by: Pravin B Shelar --- lib/automake.mk | 2 + lib/netdev-native-stt.c | 700 +

[ovs-dev] [PATCH v2 12/15] tnl-ports: Handle STT ports.

2016-04-21 Thread Pravin B Shelar
STT uses TCP port so we need to filter traffic on basis of TCP port numbers. Signed-off-by: Pravin B Shelar --- lib/tnl-ports.c | 82 +--- lib/tnl-ports.h | 4 +-- ofproto/tunnel.c | 8 -- 3 files changed, 62 insertions(+), 32 deletions

[ovs-dev] [PATCH v2 11/15] tunnel: Add IP ECN related functions.

2016-04-21 Thread Pravin B Shelar
Set and get functions for IP explicit congestion notification flag. These function would be used by STT reassembly code. Signed-off-by: Pravin B Shelar --- lib/packets.c| 21 + lib/packets.h| 7 +++ ofproto/tunnel.c | 6 +++--- 3 files changed, 31 insertions(+),

[ovs-dev] [PATCH v2 15/15] netdev: Add support for GENEVE/VXLAN tunnel segmentation

2016-04-21 Thread Pravin B Shelar
This patch adds support to segment large UDP based tunnel packet. With this patch large packet generated by STT can be forwarded over to GENEVE/VXLAN port. Signed-off-by: Pravin B Shelar --- lib/dp-packet-lso.c | 32 +++- lib/dp-packet-lso.h | 1 + lib/netdev

[ovs-dev] [PATCH v2 14/15] netdev: Add support for GRE segmentation

2016-04-21 Thread Pravin B Shelar
This patch adds support to segment large GRE packet. This does means that there are two sets of headers for given packet. To get offset of inner packet outer_hlen member is added to dp-packet. Signed-off-by: Pravin B Shelar --- lib/dp-packet-lso.c | 74 +++

[ovs-dev] [PATCH v2 09/15] netdev: Add Large packet segmentation support.

2016-04-21 Thread Pravin B Shelar
STT can generate large packets. Following patch adds support to handle packet which are larger than device MTU size. To support such packets following members are added dp-packet structure. type: type of packet, e.g tcp, tcpv6, geneve, etc. mss: maximum segment size. netdev can set the flags in net

[ovs-dev] [PATCH v2 08/15] dpif-netdev: Refactor userspace action

2016-04-21 Thread Pravin B Shelar
Large segment support need to use this refactored function to send individual segments. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH v2 01/15] netdev-vport: Factor-out tunnel Push-pop code into separate module.

2016-04-21 Thread Pravin B Shelar
It is better to move tunnel push-pop action specific functions into separate module. Signed-off-by: Pravin B Shelar --- lib/automake.mk| 3 + lib/netdev-native-tnl.c| 641 +++ lib/netdev-native-tnl.h| 108 lib/netdev-provider

[ovs-dev] [PATCH v2 06/15] dpif-netdev: create batch object

2016-04-21 Thread Pravin B Shelar
DPDK datapath operate on batch of packets. To pass the batch of packets around we use packets array and count. Next patch needs to associate meta-data with each batch of packets. So Introducing a batch structure to make handling the metadata easier. Signed-off-by: Pravin B Shelar --- lib/dp-pac

[ovs-dev] [PATCH v2 05/15] dpif-netdev: rename packet_batch

2016-04-21 Thread Pravin B Shelar
Next patch introduces new structure named packet_batch. So I am renaming it to packet_batch_per_flow. This does not change any functionality. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --

[ovs-dev] [PATCH v2 10/15] netdev-vport: Introduce ip_build_header()

2016-04-21 Thread Pravin B Shelar
This function can be used to build varius tunnel headers. Signed-off-by: Pravin B Shelar --- lib/netdev-native-tnl.c | 35 +++ lib/netdev-native-tnl.h | 25 + 2 files changed, 28 insertions(+), 32 deletions(-) diff --git a/lib/netdev-nativ

[ovs-dev] [PATCH v2 07/15] dpif-netdev: Refactor fast path process function.

2016-04-21 Thread Pravin B Shelar
Once datapath support large packets, we need to segment packet before sending it to upcall. Refactoring this code make it bit cleaner. Signed-off-by: Pravin B Shelar --- lib/dpif-netdev.c | 128 +- 1 file changed, 70 insertions(+), 58 deletions

[ovs-dev] [PATCH v2 04/15] dp-packet: use packet reset function.

2016-04-21 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- lib/dp-packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 201fd14..4a8b5ab 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -516,7 +516,7 @@ dp_packet_reset_packet(struct dp_packet *b, int of

[ovs-dev] [PATCH v2 00/15] dpif-netdev: Large packet segmentation and STT.

2016-04-21 Thread Pravin B Shelar
Following patch series adds support for STT. STT can generate large packet by merging multiple stt segments. To handle packet larger than device MTU we need to segment these packet. We can just segment then packet in STT and send each packet up to the userspace datapath. But that generate lot more

[ovs-dev] [PATCH v2 02/15] netdev: Return number of packet from netdev_pop_header()

2016-04-21 Thread Pravin B Shelar
Current tunnel-pop API does not allow the netdev implementation retain a packet but STT can keep a packet from batch of packets during TCP reassembly processing. To return exact count of valid packet STT need to pass this number of packet parameter as a reference. Signed-off-by: Pravin B Shelar -

[ovs-dev] [PATCH v2 03/15] dp-packet: Add private data

2016-04-21 Thread Pravin B Shelar
This scratchpad can be used by any layer to keep private data. STT will use it for TCP reassembly state. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- lib/dp-packet.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 000

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Jesse Gross
On Thu, Apr 21, 2016 at 6:03 PM, Li, Johnson wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, April 22, 2016 12:44 AM >> To: Li, Johnson >> Cc: ovs dev >> Subject: Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space >> data path >> >>

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Li, Johnson
> -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Friday, April 22, 2016 12:44 AM > To: Li, Johnson > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space > data path > > On Wed, Apr 20, 2016 at 11:43 PM, Johnson.Li wrote: > > Fro

Re: [ovs-dev] [PATCH] FAQ: Add entry for OVS/DPDK version dependencies.

2016-04-21 Thread Daniele Di Proietto
Thanks for writing this up, applied to master! 2016-04-19 3:35 GMT-07:00 Kevin Traynor : > For a given release this is listed in the INSTALL.DPDK.md > but it gets asked quite a bit on the mailing list, so create > a table in the FAQ. > > Signed-off-by: Kevin Traynor > --- > FAQ.md | 13 ++

[ovs-dev] Returned mail: see transcript for details

2016-04-21 Thread john
The message was undeliverable due to the following reason: Your message could not be delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely th

Re: [ovs-dev] [PATCH 2/2] system-traffic: Add basic geneve tunnel sanity test.

2016-04-21 Thread Daniele Di Proietto
Thanks for adding this tests! Acked-by: Daniele Di Proietto On 20/04/2016 16:07, "Joe Stringer" wrote: >Signed-off-by: Joe Stringer >--- > tests/system-common-macros.at | 4 > tests/system-traffic.at | 41 >+ > 2 files changed, 45 insertions(

Re: [ovs-dev] [PATCH 1/2] system-traffic: Add basic gre tunnel sanity test.

2016-04-21 Thread Daniele Di Proietto
Acked-by: Daniele Di Proietto On 21/04/2016 13:29, "Joe Stringer" wrote: >On 20 April 2016 at 16:07, Joe Stringer wrote: >> Signed-off-by: Joe Stringer >> --- > > >> +dnl Set up tunnel endpoints on OVS outside the namespace and with a >>native >> +dnl linux device inside the namespace. >> +A

Re: [ovs-dev] [PATCH] ovn: Fix link in tutorial

2016-04-21 Thread Russell Bryant
On Mon, Apr 18, 2016 at 1:25 AM, Jamie Lennox wrote: > Correct the link to the ovn-northd man page in the OVN tutorial. > > Signed-off-by: Jamie Lennox > Thanks for the patch! I applied this to master. Since this was your first patch to OVS, I also added your name to the AUTHORS file. Thanks

Re: [ovs-dev] [PATCH] system-traffic: Fix IPv6 frag vxlan check.

2016-04-21 Thread Daniele Di Proietto
Thanks for fixing this Acked-by: Daniele Di Proietto On 21/04/2016 14:10, "Joe Stringer" wrote: >This was missed before somehow, which would cause the test to fail >(rather than being skipped) if iproute2 didn't support setting the >vxlan dstport on the kernel tunnel device. > >Signed-off-by:

Re: [ovs-dev] [PATCH] datapath-windows: remove OvsAllocateForwardingContextForNBL

2016-04-21 Thread Ben Pfaff
On Fri, Apr 15, 2016 at 07:05:07AM -0700, Nithin Raju wrote: > dead code. > > Signed-off-by: Nithin Raju Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC] ovn: Add support for DSCP marking

2016-04-21 Thread Ben Pfaff
On Fri, Apr 15, 2016 at 04:30:41PM +0530, bscha...@redhat.com wrote: > From: Babu Shanmugam > > Added an additional option 'dscp_code' for VMI Logica_Ports in addition to the > ingress_policing_rate and burst in the OVN Northbound database. > > Also in the controller, replaced the earlier approa

Re: [ovs-dev] [PATCH] datapath-windows: Add ICMP types in NetProto.h

2016-04-21 Thread Ben Pfaff
On Thu, Apr 14, 2016 at 01:22:40PM -0700, Sairam Venugopal wrote: > Update NetProto.h to include ICMP and ICMPv6 types. Update ICMP header to > keep it consistent with KVM. Add UDP and ICMP min length definitions. > > Signed-off-by: Sairam Venugopal Applied, thanks! _

Re: [ovs-dev] [PATCH] datapath-windows: Refactor Conntrack Module in Hyper-V

2016-04-21 Thread Ben Pfaff
On Thu, Apr 14, 2016 at 12:07:11PM -0700, Sairam Venugopal wrote: > Minor refactors around naming and reusability in lieu of adding support for > other > protocols for tracking connections. > > Signed-off-by: Sairam Venugopal Applied, thanks! ___ dev

Re: [ovs-dev] [ovs-dev,v15,1/6] More updates to ovn test output

2016-04-21 Thread Ben Pfaff
On Thu, Apr 14, 2016 at 08:27:05AM -0500, Ryan Moats wrote: > From: RYAN D. MOATS > > Adding more detail that helps find what went wrong. > > Signed-off-by: RYAN D. MOATS Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.or

Re: [ovs-dev] Introduce OVSDB readme markdown

2016-04-21 Thread Ben Pfaff
On Thu, Apr 21, 2016 at 06:20:19PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 04/21/2016 01:49:15 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 04/21/2016 01:49 PM > > Subject: Re: [ovs-dev] Introduce OVSDB readme markdown > > > > On Wed, A

[ovs-dev] [PATCH] Add change tracking documentation

2016-04-21 Thread Ryan Moats
From: RYAN D. MOATS Change tracking is a bit different from what someone with "classic" database experience might expect, so let's add the knowledged gained from the experience of making change tracking work for incremental processing. Signed-off-by: RYAN D. MOATS --- lib/ovsdb-idl.h | 10 ++

Re: [ovs-dev] Introduce OVSDB readme markdown

2016-04-21 Thread Ryan Moats
Ben Pfaff wrote on 04/21/2016 01:49:15 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 04/21/2016 01:49 PM > Subject: Re: [ovs-dev] Introduce OVSDB readme markdown > > On Wed, Apr 13, 2016 at 12:00:01PM -0500, Ryan Moats wrote: > > From: RYAN D. MOATS >

Re: [ovs-dev] [PATCH v8 07/16] hmap: Add HMAP_FOR_EACH_POP.

2016-04-21 Thread Daniele Di Proietto
On 21/04/2016 14:54, "Ben Pfaff" wrote: >On Thu, Apr 21, 2016 at 09:41:03PM +, Daniele Di Proietto wrote: >> >> >> On 21/04/2016 11:28, "Ben Pfaff" wrote: >> >> >On Tue, Apr 19, 2016 at 03:28:39PM -0700, Daniele Di Proietto wrote: >> >> Makes popping each member of the hmap a bit easier

Re: [ovs-dev] [PATCH v8 07/16] hmap: Add HMAP_FOR_EACH_POP.

2016-04-21 Thread Ben Pfaff
On Thu, Apr 21, 2016 at 09:41:03PM +, Daniele Di Proietto wrote: > > > On 21/04/2016 11:28, "Ben Pfaff" wrote: > > >On Tue, Apr 19, 2016 at 03:28:39PM -0700, Daniele Di Proietto wrote: > >> Makes popping each member of the hmap a bit easier. > >> > >> Signed-off-by: Daniele Di Proietto >

Re: [ovs-dev] [PATCH] netdev-linux: Fix ingress policing burst rate configuration via tc

2016-04-21 Thread Ben Pfaff
On Thu, Apr 14, 2016 at 11:51:44AM +0200, Miguel Angel Ajo wrote: > The tc_police structure was filled with a value calculated in bits > instead of bytes while bytes were expected. This led the setting > of an x8 higher burst value. > > Documentation and defaults have been corrected accordingly to

Re: [ovs-dev] [PATCH V4] ovn-controller: reload configured SB probe timer

2016-04-21 Thread Ben Pfaff
On Thu, Apr 14, 2016 at 12:24:03AM -0700, ngh...@us.ibm.com wrote: > There are four sessions established from ovn-controller to the following: > OVN Southbound — JSONRPC based > Local ovsdb — JSONRPC based > Local vswitchd — openflow based from ofctrl > Local vswitchd — openflow based from pinctrl

Re: [ovs-dev] [PATCH 4/4] classifier: Avoid inserting duplicates to cmaps.

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 07:06:46PM -0700, Jarno Rajahalme wrote: > Staged lookup indices assumed that cmap is efficient fealing with > duplicates. Duplicates are implemented as linked lists, however, > causing removal of rules to become (O^2) and highly cache-inefficient > with large number of dup

Re: [ovs-dev] [PATCH v8 07/16] hmap: Add HMAP_FOR_EACH_POP.

2016-04-21 Thread Daniele Di Proietto
On 21/04/2016 11:28, "Ben Pfaff" wrote: >On Tue, Apr 19, 2016 at 03:28:39PM -0700, Daniele Di Proietto wrote: >> Makes popping each member of the hmap a bit easier. >> >> Signed-off-by: Daniele Di Proietto > >It's unfortunately quite expensive, though: O(n**2) in the number of >buckets in the

[ovs-dev] [PATCH] system-traffic: Fix IPv6 frag vxlan check.

2016-04-21 Thread Joe Stringer
This was missed before somehow, which would cause the test to fail (rather than being skipped) if iproute2 didn't support setting the vxlan dstport on the kernel tunnel device. Signed-off-by: Joe Stringer --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[ovs-dev] [PATCH 2/5] compat: nf_defrag_ipv6: avoid/free clone operations.

2016-04-21 Thread Joe Stringer
Upstream commit: netfilter: ipv6: nf_defrag: avoid/free clone operations commit 6aafeef03b9d9ecf ("netfilter: push reasm skb through instead of original frag skbs") changed ipv6 defrag to not use the original skbs anymore. So rather than keeping the original skbs around just t

[ovs-dev] [PATCH 1/5] compat: ipv6: Pass struct net into nf_ct_frag6_gather.

2016-04-21 Thread Joe Stringer
Upstream commit: ipv6: Pass struct net into nf_ct_frag6_gather The function nf_ct_frag6_gather is called on both the input and the output paths of the networking stack. In particular ipv6_defrag which calls nf_ct_frag6_gather is called from both the the PRE_ROUTING chain on in

[ovs-dev] [PATCH 3/5] compat: nf_defrag_ipv6: avoid nf_iterate recursion.

2016-04-21 Thread Joe Stringer
Upstream commit: netfilter: ipv6: avoid nf_iterate recursion The previous patch changed nf_ct_frag6_gather() to morph reassembled skb with the previous one. This means that the return value is always NULL or the skb argument. So change it to an err value. Instead of invok

[ovs-dev] [PATCH 5/5] datapath: Orphan skbs before IPv6 defrag

2016-04-21 Thread Joe Stringer
Upstream commit: openvswitch: Orphan skbs before IPv6 defrag This is the IPv6 counterpart to commit 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()"). Prior to commit 029f7f3b8701 ("netfilter: ipv6: nf_defrag: avoid/free clone operations"), ipv6 fragments sent

[ovs-dev] [PATCH 4/5] compat: nf_defrag_ipv6: fix NULL deref panic.

2016-04-21 Thread Joe Stringer
Upstream commit: netfilter: ipv6: nf_defrag: fix NULL deref panic Valdis reports NULL deref in nf_ct_frag6_gather. Problem is bogus use of skb_queue_walk() -- we miss first skb in the list since we start with head->next instead of head. In case the element we're looking for wa

[ovs-dev] [PATCH 0/5] Backport nf_defrag_ipv6 changes.

2016-04-21 Thread Joe Stringer
This short series addresses some of the netfilter/defrag-related changes recently upstream and backports the equivalent fixes to our compat code. The last two patches address bugs introduced from the second patch, I've left them as separate patches here to mirror the upstream commits. Tested using

Re: [ovs-dev] [PATCH 3/4] classifier: Remove rare optimization case.

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 07:06:45PM -0700, Jarno Rajahalme wrote: > This optimization applied when a staged lookup index would narrow down > to a single rule, which happens sometimes is simple test cases, but > presumably less often in more populated flow tables. The result of > this optimization a

Re: [ovs-dev] [PATCH 2/4] classifier: Remove logging.

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 07:06:44PM -0700, Jarno Rajahalme wrote: > The only vlog line was a left over from debugging. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH 1/2] system-traffic: Add basic gre tunnel sanity test.

2016-04-21 Thread Joe Stringer
On 20 April 2016 at 16:07, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > +dnl Set up tunnel endpoints on OVS outside the namespace and with a native > +dnl linux device inside the namespace. > +ADD_OVS_TUNNEL([gre], [br0], [at_gre0], [172.31.1.1], [10.1.1.100/24]) > +ADD_NATIVE_TUNN

Re: [ovs-dev] [PATCH net] openvswitch: use flow protocol when recalculating ipv6 checksums

2016-04-21 Thread David Miller
From: Simon Horman Date: Thu, 21 Apr 2016 11:49:15 +1000 > When using masked actions the ipv6_proto field of an action > to set IPv6 fields may be zero rather than the prevailing protocol > which will result in skipping checksum recalculation. > > This patch resolves the problem by relying on th

Re: [ovs-dev] [PATCH 1/4] classifier: Remove redundant index.

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 07:06:43PM -0700, Jarno Rajahalme wrote: > The test for figuring out if the last index had the same fields as the > actual rules map as broken, resulting into keeping an unnecessary > index around. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff __

Re: [ovs-dev] Introduce OVSDB readme markdown

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 12:00:01PM -0500, Ryan Moats wrote: > From: RYAN D. MOATS > > Provide a point to start collecting documentation on OVSDB > and seed it with experiences from making use of change > tracking. > > Signed-off-by: RYAN D. MOATS Needs to be added to EXTRA_DIST, otherwise it b

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

2016-04-21 Thread Ben Pfaff
Yamamoto-san, I could really use your opinion here: do you think that this should be done differently? If you do, then I will not accept it. But if you do not feel strongly about it, then I'll start properly reviewing it. Thanks, Ben. On Mon, Apr 18, 2016 at 07:05:52PM +0800, Xiao Liang wrote:

Re: [ovs-dev] [PATCH RFC] dpif-netdev: ACL+dpcls for Wildcard matching.

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 10:45:09AM +0100, antonio.fische...@intel.com wrote: > The purpose of this implementation is to improve the performance > of wildcard matching in user-space. > This RFC patch shows the basic functionality, some aspects were not > covered yet. > > I would like to get some fe

Re: [ovs-dev] [PATCH V2, 3/3] datapath-windows: Removed always true condition in VXLAN

2016-04-21 Thread Ben Pfaff
On Mon, Apr 18, 2016 at 08:34:43AM +, Paul Boca wrote: > Instance ID flag must be set to 1 in case of valid VXLAN id > > Signed-off-by: Paul-Daniel Boca > Acked-by: Sorin Vinturis Applied, thanks! ___ dev mailing list dev@openvswitch.org http://op

Re: [ovs-dev] [PATCH V3, 2/3] datapath-windows: Removed double initialization on local variables

2016-04-21 Thread Ben Pfaff
On Mon, Apr 18, 2016 at 09:46:07AM +, Paul Boca wrote: > Signed-off-by: Paul-Daniel Boca > Acked-by: Sorin Vinturis > --- > v3: fixed a minor compilation issue. Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

Re: [ovs-dev] [PATCH V2, 1/3] datapath-windows: Avoid using uninitialized gOvsExtDriverHandle

2016-04-21 Thread Ben Pfaff
On Mon, Apr 18, 2016 at 08:33:56AM +, Paul Boca wrote: > Ensure gOvsExtDriverHandle is not used if initialization fails > Added PAGED_CODE() where needed > > Signed-off-by: Paul-Daniel Boca > Acked-by: Sorin Vinturis Applied, thanks! ___ dev maili

Re: [ovs-dev] [PATCH v8 07/16] hmap: Add HMAP_FOR_EACH_POP.

2016-04-21 Thread Ben Pfaff
On Tue, Apr 19, 2016 at 03:28:39PM -0700, Daniele Di Proietto wrote: > Makes popping each member of the hmap a bit easier. > > Signed-off-by: Daniele Di Proietto It's unfortunately quite expensive, though: O(n**2) in the number of buckets in the hmap, as opposed to O(n) for HMAP_FOR_EACH_SAFE. _

Re: [ovs-dev] [PATCH v3] debian : upstream_version fix

2016-04-21 Thread Ben Pfaff
On Tue, Apr 05, 2016 at 07:56:35AM +, Zoltán Balogh wrote: > From: > > The Debian Policy Manual > (https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version) > says that the upstream_version may contain only alphanumerics and the > characters . + - : ~ (full stop, plus, h

Re: [ovs-dev] [PATCH] tunneling: Fix for concomitant IPv4 and IPv6 tunnels

2016-04-21 Thread Ben Pfaff
On Fri, Apr 01, 2016 at 10:06:05AM -0300, Thadeu Lima de Souza Cascardo wrote: > When using an IPv6 tunnel on the same bridge as an IPv4 tunnel, the flow > received from the IPv6 tunnel would have an IPv4 address added to it, causing > problems when trying to put or execute the action on Linux data

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif: Rename "recurse" to "indentation".

2016-04-21 Thread Ben Pfaff
On Wed, Apr 13, 2016 at 09:45:09PM -0700, Ben Pfaff wrote: > The "recurse" member of struct xlate_in and struct xlate_ctx is used for > two purposes: to determine the amount of indentation in "ofproto/trace" > output and to limit the depth of recursion. An upcoming commit will > separate these tas

Re: [ovs-dev] [ovs-dev, 1/2] ofproto-dpif: Rename "recurse" to "indentation".

2016-04-21 Thread Ben Pfaff
On Thu, Apr 21, 2016 at 09:02:46AM -0500, Ryan Moats wrote: > > > --- Original Message --- > > The "recurse" member of struct xlate_in and struct xlate_ctx is used for > > two purposes: to determine the amount of indentation in "ofproto/trace" > > output and to limit the depth of recursion. An up

[ovs-dev] [PATCH v2 2/2] ofproto-dpif: Do not count resubmit to later tables against limit.

2016-04-21 Thread Ben Pfaff
Open vSwitch must ensure that flow translation takes a finite amount of time. Until now it has implemented this by limiting the depth of recursion. The initial limit, in version 1.0.1, was no recursion at all, and then over the years it has increased to 8 levels, then 16, then 32, and 64 for the

[ovs-dev] [PATCH v2 0/2] more flexible limits for resubmits

2016-04-21 Thread Ben Pfaff
v1->v2: - Fix bad patch split between patch 1 and patch 2 (thanks Ryan). Ben Pfaff (2): ofproto-dpif: Rename "recurse" to "indentation". ofproto-dpif: Do not count resubmit to later tables against limit. lib/ofp-actions.c| 19 -- ofproto/ofproto-dpif-xlate.c | 82

[ovs-dev] [PATCH v2 1/2] ofproto-dpif: Rename "recurse" to "indentation".

2016-04-21 Thread Ben Pfaff
The "recurse" member of struct xlate_in and struct xlate_ctx is used for two purposes: to determine the amount of indentation in "ofproto/trace" output and to limit the depth of recursion. An upcoming commit will separate these tasks, and so in preparation this commit renames "recurse" to "indenta

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-21 Thread Jesse Gross
On Thu, Apr 21, 2016 at 9:43 AM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Apr 20, 2016 at 11:38:31AM -0700, Jesse Gross wrote: >> One minor comment that I noticed on the patch itself - I don't know if >> the port mapping functions are handling IPsec variants of tunnels >> correctly in all si

Re: [ovs-dev] [dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 04:04:03PM +0200, Christian Ehrhardt wrote: > Thanks Ilya, > yeah we usually wait for the point releases as they undergo some extra testing > and verification. > .1 shouldn't be too much into the future I guess. > Thanks a lot for identifying. > > That said, I'd still go on

Re: [ovs-dev] [dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Yuanhan Liu
On Thu, Apr 21, 2016 at 02:01:26PM +0300, Ilya Maximets wrote: > Hi, Christian. > You're, likely, using tar archive with openvswitch from openvswitch.org. > It doesn't contain many bug fixes from git/branch-2.5 unfortunately. > > The problem that you are facing has been solved in branch-2.5 by >

Re: [ovs-dev] [PATCH v3] Add VxLAN-GBP support for user space data path

2016-04-21 Thread Jesse Gross
On Wed, Apr 20, 2016 at 11:43 PM, Johnson.Li wrote: > From: Johnson Li > > In user space, only standard VxLAN was support. This patch will > add the VxLAN-GBP support for the user space data path. > > How to use: > 1> Create VxLAN port with GBP extension > $ovs-vsctl add-port br-int vxlan0 -- s

Re: [ovs-dev] [PATCH] ovn-northd: Add support for static_routes.

2016-04-21 Thread Guru Shetty
On 20 April 2016 at 18:38, steve.ruan wrote: > From: Guru Shetty > Run the following command (with your name added) for your next respin: git commit --amend --author="Author Name " > > static routes are useful when connecting multiple > routers with each other. > > Signed-off-by: steve.ruan

Re: [ovs-dev] [RFC PATCH] create vxlan device using rtnetlink interface

2016-04-21 Thread Thadeu Lima de Souza Cascardo
On Wed, Apr 20, 2016 at 11:38:31AM -0700, Jesse Gross wrote: > Thanks for that analysis. I agree with you that this looks safe. I'm > glad - there are fewer corner cases than I was expecting. > > One minor comment that I noticed on the patch itself - I don't know if > the port mapping functions ar

Re: [ovs-dev] [PATCH] ovn-northd: Add support for static_routes.

2016-04-21 Thread Mickey Spiegel
For the case where the static route specifies the output_port (logical router port), this patch is not as efficient and streamlined as it could be. With this patch, in ovn/ovn-nb.ovsschema, the output_port is defined as a string that consists of a uuid: +"Logical_Router_Static_Route": {

[ovs-dev] [PATCH] netdev-dpdk: Set pmd thread priority

2016-04-21 Thread Bhanuprakash Bodireddy
Set the DPDK pmd thread scheduling policy to SCHED_RR and static priority to highest priority value of the policy. This is to deal with pmd thread starvation case where another cpu hogging process can get scheduled/affinitized to the same core where pmd is running there by significantly impacting t

Re: [ovs-dev] [ovs-dev,RFC] ovn: Add support for DSCP marking

2016-04-21 Thread Ryan Moats
> --- Original Message --- > Added an additional option 'dscp_code' for VMI Logica_Ports in addition to the > ingress_policing_rate and burst in the OVN Northbound database. > > Also in the controller, replaced the earlier approach of setting the rate and > burst parameters in the Interface table

[ovs-dev] netdev-linux: Fix ingress policing burst rate configuration via tc

2016-04-21 Thread Ryan Moats
> --- Original Message --- > The tc_police structure was filled with a value calculated in bits > instead of bytes while bytes were expected. This led the setting > of an x8 higher burst value. > > Documentation and defaults have been corrected accordingly to minimize > nuisances on users sticking

Re: [ovs-dev] [dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Christian Ehrhardt
Thanks Ilya, yeah we usually wait for the point releases as they undergo some extra testing and verification. .1 shouldn't be too much into the future I guess. Thanks a lot for identifying. That said, I'd still go on with Yuanhan to finalize the dpdk side leak fix we identified, so we eventually g

Re: [ovs-dev] [ovs-dev, 1/2] ofproto-dpif: Rename "recurse" to "indentation".

2016-04-21 Thread Ryan Moats
> --- Original Message --- > The "recurse" member of struct xlate_in and struct xlate_ctx is used for > two purposes: to determine the amount of indentation in "ofproto/trace" > output and to limit the depth of recursion. An upcoming commit will > separate these tasks, and so in preparation this

[ovs-dev] 答复: 答复: Reply: ovs + dpdk vhost-user match flows but cannot execute actions

2016-04-21 Thread lifuqiong
Hi Volkan, Thank you. Promiscuous mode: enabled. port info detail: testpmd> show port info 0 * Infos for port 0 * MAC address: A0:36:9F:09:36:C0 Connect to socket: 0 memory allocation on the socket: 0 Link status: up Link speed: 100

[ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-04-21 Thread Ciara Loftus
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports. The commit integrates this functionality into OVS, and refactors some of the existing vhost code such that it is vhost-cuse specific. Similarly, there is now

[ovs-dev] Delivery failed

2016-04-21 Thread Returned mail
„„!œ,´`]À¨Bôf 1{GƗxÞ>•&ˆØ ? Mñy¾›7ûa3ï'²Ò÷²ÍðV¦ÀÀ²> 5KIsžÅ^S Ë%ËÚ¤’ÄÉn 풍xSÉ;°íwŽ&Í­%ê %¯š!’]YY؊lˆz#ñc²ÊòØßՆÊôћŽøþso‡Ð"hó lƒ…ÕAõ¬ <ü9ƒ½ì ^ ]?g\à5ÝgSÈﮒn…ý¢®çåÕןgâ¦é'þ´UY’9‰Ú¢Ž V7:­;!ëúØÔÀ(5Âe£Mˆ‘ö±:BàäÊ.îdYžt'‡${väá?mw¢Ñk¶éHðÙV£Z#8•bõø)(/wÛtJIÍÓg°Æ}HuH¥Ì­T”ÊÊ?ãÀË6ƋaTfI£ù¶~F|oÍZ/$c

Re: [ovs-dev] 答复: Reply: ovs + dpdk vhost-user match flows but cannot execute actions

2016-04-21 Thread Ali Volkan Atli
Hi please check "promiscuous mode" by using the show command as follows: testpmd> show port info 0 - Volkan From: dev [dev-boun...@openvswitch.org] on behalf of lifuqiong [lifuqi...@cncloudsec.com] Sent: Thursday, April 21, 2016 11:26 AM To: 'Mauricio V

Re: [ovs-dev] [dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Ilya Maximets
Hi, Christian. You're, likely, using tar archive with openvswitch from openvswitch.org. It doesn't contain many bug fixes from git/branch-2.5 unfortunately. The problem that you are facing has been solved in branch-2.5 by commit d9df7b9206831631ddbd90f9cbeef1b4fc5a8e89 Author: Ilya Maximets Date

Re: [ovs-dev] 答复: Reply: ovs + dpdk vhost-user match flows but cannot execute actions

2016-04-21 Thread Mauricio Vásquez
Unfortunately I am not able to give you a more precise help in this case. As this problem is not directly related to OvS, I recommend you to write to the DPDK mailing list, hopefully someone will help you. Best Regards, Mauricio Vasquez, On Thu, Apr 21, 2016 at 10:26 AM, lifuqiong wrote: > Hi

[ovs-dev] 答复: Reply: ovs + dpdk vhost-user match flows but cannot execute actions

2016-04-21 Thread lifuqiong
Hi Mauricio Vasquez: When I executed “stop” cmd as follows , is there something wrong? Thank you. testpmd> stop Telling cores to stop... Waiting for lcores to finish... -- Forward statistics for port 0 -- RX-packets: 0

[ovs-dev] Reply: ovs + dpdk vhost-user match flows but cannot execute actions

2016-04-21 Thread lifuqiong
Hi Mauricio Vasquez: Thank you for advice. I connect dpdk NIC to outside PC directly , but things still do not work. While using test_pmd to test my NIC, When executing : testpmd> start After a while, port stats show there are a