On Fri, Apr 15, 2016 at 04:30:41PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam <bscha...@redhat.com>
>
> Added an additional option 'dscp_code' for VMI Logica_Ports in addition to the
> ingress_policing_rate and burst in the OVN Northbound database.
>
> Also in the controller, replaced the earlier approach of setting the rate and
> burst parameters in the Interface table with Port tables's qos parameter
> (using the default queue). In this patch, 'linux-htb' is used as a
> fixed Qos type.
>
> Signed-off-by: Babu Shanmugam <bscha...@redhat.com>
I think that this should be two patches, one for DSCP, one for the QoS
changes.
There are some style issues, such as lack of {} around single statements.
The DSCP feature seems fine to me.
Converting policing into shaping changes the semantics. If these are
superior semantics (which does seem likely) then that's fine but it
needs documentation and rationale.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
