Re: [ovs-dev] [PATCH v2] vtep: Introduce other_config column in some vtep schema tables.

2016-03-19 Thread Ben Pfaff
On Thu, Mar 17, 2016 at 09:00:50AM -0700, Saurabh Shrivastava wrote: > Having an other_config column is a simple way to pass more information than > the > schema allows. > > Signed-off-by: Saurabh Shrivastava Applied to master, thanks! ___ dev mailing

Re: [ovs-dev] [o[dev] [PATCH v5 4/5] ovn: Implement basic ARP support for L3 logical routers.

2016-03-19 Thread Ben Pfaff
Please read ovn-northd(8), specifically the section "Ingress Table 3: ARP Resolution". As you can see there, neither static nor dynamic MAC bindings directly output to a port. Rather, both cases simply initialize eth.dst to the destination MAC and continue to the next table. On Wed, Mar 16, 2016

Re: [ovs-dev] [PATCH v6 2/6] datapath-windows: Added recirculation support.

2016-03-19 Thread Nithin Raju
-Original Message- From: dev on behalf of Sorin Vinturis Date: Friday, March 18, 2016 at 7:58 AM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH v6 2/6] datapath-windows: Added recirculation support. >Recirculation support for the OVS extension. > >Tested using PING and iperf wi

[ovs-dev] [PATCH 4/6] Update sbctl man page for physical endpts and binding to logical ports

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/utilities/ovn-sbctl.8.in | 48 1 file changed, 48 insertions(+) diff --git a/ovn/utilities/ovn-sbctl.8.in b/ovn/utilities/ovn-sbctl.8.in index e4e4431..67c78ee 100644 --- a/ovn/utilities/ovn-sbctl.8.in +++ b/ovn/uti

Re: [ovs-dev] Discontiguous bit mask in Megaflow

2016-03-19 Thread Peng He
Hi, Ben, You're correct. I think the principle is to cache as few bits as possible. In fact to differentiate two prefixes, you just need 1 more bits in positions [16,24]. We are currently doing some research to accelerate the performance of OVS. Since the prefix mask is not contiguous

Re: [ovs-dev] [PATCH 6/6] Update localnet ovn test to use physical endpoints

2016-03-19 Thread Darrell Ball
Adding ovs dev On 3/15/16, 4:28 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > tests/ovn.at | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/tests/ovn.at b/tests/ovn.at >index 689e544..dac36c8 100644 >--- a/tests/ovn.at >+++ b/tests/ovn.at >@@ -840,12 +840,15 @@ for

Re: [ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Ryan Moats
Guru Shetty wrote on 03/17/2016 09:56:08 AM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 03/17/2016 09:56 AM > Subject: Re: [ovs-dev] Update on OVN east-west loadbalancing. > > > I gave this patch series a test drive this morning, but I'm seeing a > failure on >

Re: [ovs-dev] [PATCH v3 11/11] netdev-dpdk: Use ->reconfigure() call to change rx/tx queues.

2016-03-19 Thread Ilya Maximets
On 16.03.2016 01:30, Daniele Di Proietto wrote: > This introduces in dpif-netdev and netdev-dpdk the first use for the > newly introduce reconfigure netdev call. > > When a request to change the number of queues comes, netdev-dpdk will > remember this and notify the upper layer via > netdev_reques

Re: [ovs-dev] [PATCH 0/6] OVN: Support Physical Endpoints and their logical binding

2016-03-19 Thread Darrell Ball
I sent a clean series Ignore these previous duplicates that I forwarded On 3/16/16, 1:00 PM, "Darrell Ball" wrote: >Adding ovs dev > > > >On 3/15/16, 4:28 PM, "Darrell Ball" wrote: > >>The following patch series supports physical endpoints and their binding to >>logical ports. >>Physical

[ovs-dev] [PATCH v6 4/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attribute

2016-03-19 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal --- datapath-windows/ovsext/Actions.c| 32 datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 13 + 3 files changed, 46 insertions(+) diff --git a/datapath-

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-19 Thread Ben Pfaff
Your action structures are wrong because they are not based on the OpenFlow experimenter action format. Please refer to the OpenFlow specification for details. On Wed, Mar 16, 2016 at 06:06:30PM +0530, Ajmer Singh wrote: > Hi Ben, > > I have started adding OFPAT_ENCAP_GTP action in ofp-actions.c

Re: [ovs-dev] [PATCH 00/10] PMD Testsuite.

2016-03-19 Thread Ilya Maximets
Hi, Daniele. On 17.03.2016 03:53, Daniele Di Proietto wrote: > Hi Ilya, > > thanks for the series, I think it's going to ease development of > dpif-netdev a lot. > > I have been thinking about doing the same for a while and I've also > sketched out some code, which is very similar to this :-) (I

Re: [ovs-dev] [PATCH] python: Allow specifying the iterations in Idl.run

2016-03-19 Thread Jason Kölker
I would like to request that, if accepted, this also be applied to branch-2.5. Happy Hacking! 7-11 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] python: Allow specifying the iterations in Idl.run

2016-03-19 Thread Jason Kölker
Callers to Idl.run() should be able to specify the number of iterations to run in one call. Instrumentation revealed that a call to Idl.run() with a can block up to a few seconds, with most of the time being spent parsing messages. Since parsing is a CPU only task eventlet and friends are unable t

Re: [ovs-dev] [PATCH v3 02/11] dpif-netdev: Keep count of elements in port->rxq[].

2016-03-19 Thread Daniele Di Proietto
On 16/03/2016 07:13, "Ilya Maximets" wrote: >IMHO, it's confusing to have so many similar variables in all >structures. >Without this patch we already have: > >netdev->n_rxq >netdev_dpdk->requested_n_rxq >netdev_dpdk->real_n_rxq I understand your concern, and in general I agree, but in this cas

[ovs-dev] [PATCH v6 6/6] datapath-windows: Updated FAQ regarding Hyper-V recirculation.

2016-03-19 Thread Sorin Vinturis
Updated FAQ document to reflect recirculation support for Hyper-V. Signed-off-by: Sorin Vinturis Acked-by: Sairam Venugopal --- FAQ.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FAQ.md b/FAQ.md index 0ebf1d5..a7f70e5 100644 --- a/FAQ.md +++ b/FAQ.md @@ -227,7 +227,7 @@

Re: [ovs-dev] [PATCH] list.h: Define OVS_LIST_POISON statically

2016-03-19 Thread Nithin Raju
I am fine with the suggestion and the patch you sent. Thanks Ben. -Original Message- From: Ben Pfaff Date: Friday, March 18, 2016 at 1:47 PM To: Nithin Raju Cc: "dev@openvswitch.org" , Yin Lin Subject: Re: [ovs-dev] [PATCH] list.h: Define OVS_LIST_POISON statically >On Fri, Mar 18, 201

Re: [ovs-dev] ofp-actions: Fix use-after-free with ofpact_finish().

2016-03-19 Thread Ryan Moats
Original Message > ofpact_finish() may now reallocate the buffer it is passed, but not all > callers updated their local pointers to the current action in the > buffer. This could potentially lead to several use-after-free bugs. > > Update ofpact_finish() to return the new pointer to the

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 3/9] ovsdb: Spawn threads to handle jsonrpc sessions

2016-03-19 Thread Ryan Moats
- Original Message > Add the basic infrastructure to create and destroy threads that > will be used to handle jsonrpc sessions. > > This patch implements a simple logic to create thread on demand. > Using number of sessions a server services as an rough measure of > system load, A jsonr

Re: [ovs-dev] What looks like a bug in OVSDB change seqno tracking

2016-03-19 Thread Ryan Moats
Ben Pfaff wrote on 03/14/2016 11:11:29 AM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 03/14/2016 11:11 AM > Subject: Re: [ovs-dev] What looks like a bug in OVSDB change seqno tracking > > On Tue, Mar 08, 2016 at 11:01:21PM -0600, Ryan Moats wrote: > > >

Re: [ovs-dev] [PATCH] lib/util.c: Optimise bitwise_rscan.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 08:55:35PM -0700, Han Zhou wrote: > bitwise_rscan() is found to be hot spot in ovn-controller during OVN > scalability tests. It is triggered by lflow_run() when processing > lflow updates from SB ovsdb. The perf result shows: > > + 34.21% ovn-controller ovn-controller

Re: [ovs-dev] [ovs-dev, v2, 09/23] Break tun-metadata.h into private and public parts

2016-03-19 Thread Ryan Moats
> From: Ben Warren > > Public (struct definitions and some prototypes) go in > include/openvswitch > > Signed-off-by: Ben Warren > --- > include/openvswitch/automake.mk| 1 + > include/openvswitch/tun-metadata.h | 101 +++ ++ > lib/tun-metadata.h

Re: [ovs-dev] [RFC 8/8] ovn-controller: Handle logical flows of loadbalancers.

2016-03-19 Thread Ben Pfaff
On Tue, Mar 15, 2016 at 02:14:42PM -0700, Guru Shetty wrote: > On 15 March 2016 at 11:32, Ben Pfaff wrote: > > > On Sun, Feb 28, 2016 at 10:33:24PM -0800, Gurucharan Shetty wrote: > > > Signed-off-by: Gurucharan Shetty > > > > > Thank you for looking through the series. I agree with all your c

[ovs-dev] [PATCH v6 0/6] datapath-windows: Recirculation support

2016-03-19 Thread Sorin Vinturis
This patch series adds support for recirculation to the OVS extension. Sorin Vinturis (6): [PATCH v6 1/6] datapath-windows: Percpu allocation support function [PATCH v6 2/6] datapath-windows: Added recirculation support. [PATCH v6 3/6] datapath-windows: Allow recirculation feature probe. [

[ovs-dev] [PATCH v1] bridge: Dump configurable QoS types.

2016-03-19 Thread Ian Stokes
This commit adds a new command 'qos/show-types' for use with appctl. This allows a user to query the types of QoS which are configurable via Open vSwitch on a given interface. Signed-off-by: Ian Stokes --- vswitchd/bridge.c | 46 vswitchd/o

Re: [ovs-dev] [PATCH v2 0/3] ovn: Apply ACL changes to existing connections.

2016-03-19 Thread Russell Bryant
On Wed, Mar 9, 2016 at 1:51 PM, Russell Bryant wrote: > Prior to this commit, once a connection had been committed to the > connection tracker, the connection would continue to be allowed, even > if the policy defined in the ACL table changed. This patch changes > the implementation so that exis

[ovs-dev] [PATCH] vtep: Introduce other_config column in some vtep schema tables

2016-03-19 Thread Saurabh Shrivastava
Having an other_config column is a simple way to pass more information than the schema allows. Signed-off-by: Saurabh Shrivastava --- vtep/vtep.ovsschema | 16 ++-- vtep/vtep.xml | 50 ++ 2 files changed, 64 insertions(+), 2 delet

Re: [ovs-dev] [PATCH 1/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 4:45 PM, Ben Pfaff wrote: > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > index 0082bed..c1fdd1a 100755 > --- a/utilities/ovs-ctl.in > +++ b/utilities/ovs-ctl.in > -save_ofports_if_required () { > -# Save OpenFlow port numbers if we are upgrading from a pre

Re: [ovs-dev] [PATCH v3 10/11] netdev: Add reconfigure request mechanism.

2016-03-19 Thread Ilya Maximets
On 16.03.2016 01:30, Daniele Di Proietto wrote: > A netdev provider, especially a PMD provider (like netdev DPDK) might > not be able to change some of its parameters (such as MTU, or number of > queues) without stopping everything and restarting. > > This commit introduces a mechanism that allows

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

2016-03-19 Thread Andy Zhou
On Wed, Mar 16, 2016 at 10:38 AM, Ryan Moats wrote: > > Original Message > > Currently ovsdb_jsonrpc_session are grouped together in a linked > > list within 'ovsdb_jsonrpc_remote'. This makes sense since most > > session operations applies to sessions within a remote. > > > > However,

[ovs-dev] [PATCH v4 11/12] netdev: Add reconfigure request mechanism.

2016-03-19 Thread Daniele Di Proietto
A netdev provider, especially a PMD provider (like netdev DPDK) might not be able to change some of its parameters (such as MTU, or number of queues) without stopping everything and restarting. This commit introduces a mechanism that allows a netdev provider to request a restart (netdev_request_re

[ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

2016-03-19 Thread Bhanuprakash Bodireddy
Add INSTALL.DPDK-ADVANCED document that is forked off from original INSTALL.DPDK guide. This document is targeted at users looking for optimum performance on OVS using dpdk datapath. Signed-off-by: Bhanuprakash Bodireddy --- INSTALL.DPDK-ADVANCED.md | 650 +++

[ovs-dev] [PATCH v4 07/12] ofproto-dpif: Call dpif_poll_threads_set() before dpif_run()

2016-03-19 Thread Daniele Di Proietto
An upcoming commit will make dpif_poll_threads_set() record the requested configuration and dpif_run() apply it, so it makes sense to change the order. Signed-off-by: Daniele Di Proietto --- ofproto/ofproto-dpif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/of

Re: [ovs-dev] [ovs-dev, v2, 04/23] Move contents of lib/list.h to include/openvswitch directory

2016-03-19 Thread Ryan Moats
Original Message > From: Ben Warren > > Most of the list code is properly namespaced, so is OK to move to the > global export directory. Some "lib/util.h" code had to move to the > other directory as well, but I've tried to make that as small as > possible > > Signed-off-by: Ben Warren

[ovs-dev] [PATCH 3/6] Support physical endpts and binding to logical ports in sbctl

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/utilities/ovn-sbctl.c | 295 +- 1 file changed, 291 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 0f402cd..382128b 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b

[ovs-dev] [patch] openvswitch: using a bit shift as a mask

2016-03-19 Thread Dan Carpenter
The original condition is never true. We want to test if BIT(0) is set but the code is ANDing with zero. Fixes: 05752523e565 ('openvswitch: Interface with NAT.') Signed-off-by: Dan Carpenter diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index dc5eb29..29c82d6 100644 ---

Re: [ovs-dev] [PATCH 00/10] PMD Testsuite.

2016-03-19 Thread Daniele Di Proietto
Hi Ilya, thanks for the series, I think it's going to ease development of dpif-netdev a lot. I have been thinking about doing the same for a while and I've also sketched out some code, which is very similar to this :-) (I've merged the first patch). The interesting thing about this tests for me

Re: [ovs-dev] Deletion of Indirect Groups on Ovs2.5

2016-03-19 Thread Jarno Rajahalme
OpenFlow 1.5 spec says: “The group type need not be specified for the delete request.” Jarno > On Mar 17, 2016, at 7:40 PM, Simon Horman wrote: > > On Wed, Mar 16, 2016 at 05:48:23PM +, Shuva Jyoti Kar wrote: >> Hello, >> >> I am trying deletion of an indirect group on ovs2.5 . Now when

Re: [ovs-dev] [PATCH v2 04/23] Move contents of lib/list.h to include/openvswitch directory

2016-03-19 Thread Ben Warren
Thanks! I'll resolve and re-post. Sent from my iPhone > On Mar 19, 2016, at 9:51 AM, Ben Pfaff wrote: > >> On Thu, Mar 03, 2016 at 10:20:44AM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> Most of the list code is properly namespaced, so is OK to move to the >> global export

Re: [ovs-dev] [ovs-dev,v2,05/23] Remove lib/list.h completely

2016-03-19 Thread Ryan Moats
Original Message > From: Ben Warren > > All code is now in include/openvswitch/list.h > > Signed-off-by: Ben Warren > --- > lib/automake.mk | 1 - > lib/bfd.c | 2 +- > lib/dp-packet.h | 2 +- > lib/dpif-netdev.c | 2 +- >

Re: [ovs-dev] [PATCH 2/4] Update OVN SB documentation to use physical endpoints table and mention possible deprecation of vtep logical port options which would require other changes for HW VTEP side a

2016-03-19 Thread Ben Pfaff
Hi Darrell. The commit message should begin with a brief summary, no more than about 75 columns wide, and that should be the entire first paragraph of the commit message. When it's longer than that, the subject of the email message becomes too wide. I think that the commit message needs to be mo

[ovs-dev] [PATCH v2] ovn: Update the test case for localnet port.

2016-03-19 Thread Han Zhou
Localnet port is now able to connect vif ports on different HVs. Change the test case accordingly. Signed-off-by: Han Zhou --- Notes: v1->v2: Update according to Russell's comment: add test for connectivity between 2 lswitches on same physical network tests/ovn.at | 67

Re: [ovs-dev] [PATCH v6 1/6] datapath-windows: Percpu allocation support function

2016-03-19 Thread Nithin Raju
Alternately, you could just do combination of KeQueryActiveProcessorCountEx(ALL_PROCESSOR_GROUPS) and make this code future proof. You’ll have to update the code in 2/6 patch also to use GetCurrentProcessorNumberEx(). -- Nitin -Original Message- From: dev on behalf of Nithin Raju Da

Re: [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller

2016-03-19 Thread Russell Bryant
On Wed, Mar 16, 2016 at 12:11 AM, Numan Siddique wrote: > On 03/16/2016 11:55 AM, Russell Bryant wrote: > > This is a fairly minor thing, but I'm wondering if the syntax of dhcp_offer > { ... }; should be dhcp_offer(...); instead. > > Logical flows currently support: > > next(); > arp { a

[ovs-dev] [PATCH 08/14] Create SW gateway physical bridges and patch ports

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/controller/patch.c | 134 - 1 file changed, 132 insertions(+), 2 deletions(-) diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c index 753ce3e..168513d 100644 --- a/ovn/controller/patch.c +++ b/ovn/cont

[ovs-dev] [RFC] lib/netdev-dpdk: add hotplug support

2016-03-19 Thread Mauricio Vasquez B
In order to use dpdk ports in ovs they have to be bound to a DPDK compatible driver before ovs is started. This patch adds the possibility to hotplug (or hot-unplug) a device after ovs has been started. The implementation adds two appctl commands: netdev-dpdk/attach and netdev-dpdk/detach. After

[ovs-dev] [PATCH v4 12/12] netdev-dpdk: Use ->reconfigure() call to change rx/tx queues.

2016-03-19 Thread Daniele Di Proietto
This introduces in dpif-netdev and netdev-dpdk the first use for the newly introduce reconfigure netdev call. When a request to change the number of queues comes, netdev-dpdk will remember this and notify the upper layer via netdev_request_reconfigure(). The datapath, instead of periodically call

[ovs-dev] [PATCH v4 04/12] dpif-netdev: Do not keep refcount for ports.

2016-03-19 Thread Daniele Di Proietto
Only the main thread will delete ports after pausing every other thread. There's no need to keep count. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 50 ++ 1 file changed, 14 insertions(+), 36 deletions(-) diff --git a/lib/dpif-netd

Re: [ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Samuel Gauthier
2016-03-17 0:23 GMT+01:00 Jesse Gross : > On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier > wrote: >> This patchset adds a netlink api to refresh an existing flow in >> openvswitch. >> >> When a packet is sent in the openvswitch kernel datapath and no >> flow is found, the packet is sent to the o

Re: [ovs-dev] [PATCH 2/6] Add physical endpts and binding to logical ports to SB schema doc

2016-03-19 Thread Darrell Ball
Adding ovs dev On 3/15/16, 4:28 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > ovn/ovn-sb.xml | 68 ++ > 1 file changed, 68 insertions(+) > >diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml >index d62f1e4..fce7123 100644 >---

Re: [ovs-dev] [PATCH v5 4/5] ovn: Implement basic ARP support for L3 logical routers

2016-03-19 Thread Liran Schour
> diff --git a/ovn/ovn-sb.ovsschema b/ovn/ovn-sb.ovsschema > index a9a91e5..ead733b 100644 > --- a/ovn/ovn-sb.ovsschema > +++ b/ovn/ovn-sb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Southbound", > -"version": "1.0.0", > -"cksum": "1392129391 5060", > +"version": "1.1.0", > +

[ovs-dev] [PATCH] NEWS: Add 2.5.0 release date.

2016-03-19 Thread Russell Bryant
OVS 2.5.0 was released. The date was updated in branch-2.5, but not master. Signed-off-by: Russell Bryant --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e612f76..a2da8b6 100644 --- a/NEWS +++ b/NEWS @@ -40,7 +40,7 @@ Post-v2.5.0 - Datapath Lin

Re: [ovs-dev] [PATCH v3 2/7] ovs-ofctl: declare / set up colors for command output

2016-03-19 Thread Ben Pfaff
On Wed, Mar 02, 2016 at 03:56:17PM +0100, Quentin Monnet wrote: > OVS_COLORS environment variable is parsed to extract user-defined > preferences regarding colors (this is used to set up a color theme, not > to replace the `--color` option for activating color output). > > The string should be of

[ovs-dev] [PATCH 11/14] Support physical endpoint based binding for SW gateway logical ports

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- ovn/controller/binding.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index d3ca9c9..d947329 100644 --- a/ovn/controller/binding.c +++ b/ovn/controller/binding.c @@ -181,7 +

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Joe Stringer
On 17 March 2016 at 01:47, Arnd Bergmann wrote: > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > > net/built-in.o: In function `__ovs_c

[ovs-dev] [PATCH v4 01/12] netdev-dpdk: Consistent variable naming.

2016-03-19 Thread Daniele Di Proietto
In different functions we use different variable names ('netdev_', 'netdev', 'dev', 'vhost_dev', ...) for the same objects. This commit changes the code to comply with the following convention: 'struct netdev':'netdev' 'struct netdev_dpdk':'dev' 'struct virtio_net':'virtio_dev' 'struct netdev_rxq

Re: [ovs-dev] [ovsdb-server multithreading RFC 8/9] ovsdb: Add ovsdb-server/list-threads command.

2016-03-19 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 12:13:27AM -0800, Andy Zhou wrote: > Signed-off-by: Andy Zhou Seems fine to me, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [linux-next:master 8604/12950] net/openvswitch/vport-internal_dev.c:141:6: sparse: symbol 'internal_set_rx_headroom' was not declared. Should it be static?

2016-03-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5e3497cca281616e7930b74a0076b7324dcc2057 commit: 3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 [8604/12950] ovs: propagate per dp max headroom to all vports reproduce: # apt-get install sparse gi

Re: [ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier wrote: > This patchset adds a netlink api to refresh an existing flow in > openvswitch. > > When a packet is sent in the openvswitch kernel datapath and no > flow is found, the packet is sent to the ovs-vswitchd daemon, > which will process the pack

Re: [ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

2016-03-19 Thread Andy Zhou
On Wed, Mar 16, 2016 at 4:00 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: > On 2016-03-15 11:16, Andy Zhou wrote: > >> On Mon, Mar 14, 2016 at 12:11 PM, Ramu Ramamurthy < >> srama...@linux.vnet.ibm.com> wrote: >> >> When a logical switch (localnet) has lots of ports on a hypervisor, >

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-19 Thread Ajmer Singh
Hi Ben, I have started adding OFPAT_ENCAP_GTP action in ofp-actions.c file as following: taking reference of already added action "OFPAT_ENQUEUE". I have prepared the structure of Action, also written encode and decode for this new action. but not able to understand how its *parse_ENCAP_GTP* and *

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

2016-03-19 Thread Ryan Moats
Original Message > Currently ovsdb_jsonrpc_session are grouped together in a linked > list within 'ovsdb_jsonrpc_remote'. This makes sense since most > session operations applies to sessions within a remote. > > However, in order to scale up ovsdb-server with multi-threading, it is > mo

[ovs-dev] [ovs-dev, v4, 2/3] check-system-userspace: Waiting for port's availability before creation.

2016-03-19 Thread Ryan Moats
Original Message > Fixes failure of test due to not yet fully destroyed ports from > previous test if ovs-vswitchd was killed. > > Example: > > netdev_linux|WARN|br0: creating tap device failed: Device or resource busy > bridge|WARN|could not open network device br0 (Device or resource b

[ovs-dev] Discontiguous bit mask in Megaflow

2016-03-19 Thread Peng He
Hi, I send this email once, no people replied. I am trying to refresh this email for a reply. This discontiguous bit mask issue arises in the following case: I installed two rules, ovs-ofctl add-flow br0 in_port=1,dl_type=0x0800,nw_src=10.2.10.0/24,nw_proto=6,tcp_dst=0x0050,priority=1,acti

Re: [ovs-dev] [PATCH 1/4] Update OVN SB to use physical endpoints table

2016-03-19 Thread Darrell Ball
On 3/18/16, 11:06 AM, "dev on behalf of Ben Pfaff" wrote: >On Tue, Mar 01, 2016 at 10:39:16AM -0800, Darrell Ball wrote: >> Signed-off-by: Darrell Ball > >This patch isn't self-contained because it causes a build failure: > > GEN ovn/ovn-sb.5 >../ovsdb/ovsdb-doc: undocumented

[ovs-dev] [PATCH 0/9] OVN: Support SW gateway in ovn-controller

2016-03-19 Thread Darrell Ball
The following patch series implements the SW Gateway infrastructure. The SW gateway runs in the context of ovn-controller as other HVs. The gateway node uses a single bridge (call it br-int) that is actively controlled by OVN. This bridge also houses the tunnels connecting other HVs. Additional p

[ovs-dev] [PATCH] acinclude: Autodetect DPDK location when configuring OVS

2016-03-19 Thread Bhanuprakash Bodireddy
When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if the DPDK is installed in standard location i.e /usr/src. This patch fixes the problem by searching for DPDK libraries in standard location and configures OVS sources f

[ovs-dev] [PATCH v4 05/12] dpif-netdev: Remove useless dpif-dummy/delete-port appctl.

2016-03-19 Thread Daniele Di Proietto
It is only used in the testsuite and it can be replaced by a dpctl command. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 33 - tests/bridge.at | 4 ++-- 2 files changed, 2 insertions(+), 35 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-n

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

2016-03-19 Thread Ryan Moats
Andy Zhou wrote on 03/16/2016 01:20:48 PM: > From: Andy Zhou > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 03/16/2016 01:31 PM > Subject: Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, > 1/9] ovsdb: Do not group sessions by remote. > > On Wed, Mar 16, 2016 at 10:38 AM, Rya

[ovs-dev] [PATCH v4 08/12] dpif-netdev: Change pmd thread configuration in dpif_netdev_run().

2016-03-19 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 140 ++-- lib/dpif-provider.h | 3 +- 2 files changed, 83 insertions(+), 60 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 3e07ddf..0268b9b 100644 --- a/lib/dpif-

Re: [ovs-dev] [PATCH 2/2] ovs-ctl: Remove code for upgrading from Open vSwitch 1.6 and earlier.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 05:06:16PM -0700, Jesse Gross wrote: > On Wed, Mar 16, 2016 at 4:45 PM, Ben Pfaff wrote: > > OVS 1.7 was released in July 2012, so by the time current OVS is released, > > it will be almost four years old. I think that this is long enough to > > remove special upgrade code

[ovs-dev] [PATCH] lib/util.c: Optimise bitwise_rscan.

2016-03-19 Thread Han Zhou
bitwise_rscan() is found to be hot spot in ovn-controller during OVN scalability tests. It is triggered by lflow_run() when processing lflow updates from SB ovsdb. The perf result shows: + 34.21% ovn-controller ovn-controller [.] bitwise_rscan + 16.08% ovn-controller libc-2.15.so

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-19 Thread Ben Pfaff
On Fri, Mar 18, 2016 at 11:29:39AM +0530, Ajmer Singh wrote: > Thanks Ben! I will update the name as per your comment. > > can you please answer 2nd part of the question? I have to write > encode,decode,parse and format functions for this new action. I have > updated decode and encode as per previ

Re: [ovs-dev] [PATCH v10 1/1] Separating OVN NB and SB database processes

2016-03-19 Thread Russell Bryant
On Mon, Mar 7, 2016 at 8:15 AM, Ryan Moats wrote: > From: RYAN D. MOATS > > OVN NB & SB DB's should be run in separate ovsdb-server processes > and should run with ovn-ctl start_northd / stop_northd. This patch > includes changes to unit tests, tutorial and debian scripts to remain > self-consi

Re: [ovs-dev] [ovs-dev, v2, 01/23] Move ofp-parse.h to include/openvswitch directory

2016-03-19 Thread Ryan Moats
- Original Message - > From: Ben Warren > > Signed-off-by: Ben Warren > --- > include/openvswitch/automake.mk | 1 + > include/openvswitch/ofp-parse.h | 106 ++ ++ > lib/automake.mk | 1 - > lib/dpctl.c | 2 +-

[ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Arnd Bergmann
The openvswitch code has gained support for calling into the nf-nat-ipv4/ipv6 modules, however those can be loadable modules in a configuration in which openvswitch is built-in, leading to link errors: net/built-in.o: In function `__ovs_ct_lookup': :(.text+0x2cc2c8): undefined reference to `nf_nat

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Joe Stringer
On 17 March 2016 at 02:56, Arnd Bergmann wrote: > On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote: >> Not related with this patch, just a side note/recommendation. >> >> I understand this code just got into tree, and that this needs a bit >> work/iterations but this thing above is ugly

Re: [ovs-dev] [PATCH 4/4] Update flow generation for localnet and future software gateway to source physical endpoint encapsulation from the OVN SB physical endpoint table

2016-03-19 Thread Darrell Ball
On 3/18/16, 11:21 AM, "dev on behalf of Ben Pfaff" wrote: >On Tue, Mar 01, 2016 at 10:39:19AM -0800, Darrell Ball wrote: >> Signed-off-by: Darrell Ball > >I get a consistent test failure with this patch applied: > >2003: ovn -- 2 HVs, 4 lports/HV, localnet ports FAILED (ovn.at:931)

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Add support for on-demand columns

2016-03-19 Thread Ben Pfaff
On Tue, Mar 01, 2016 at 05:42:19PM +, Arguello, Sebastian wrote: > The IDL only supports reading from columns that are being monitored. > In the case where the column represent a frequently changing entity (e.g. > counter), > and the reads are relatively infrequent (e.g. CLI client), there is

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-19 Thread Ajmer Singh
Hi Ben, This new "ENCAP_GTP" action structure will be used as a payload in below action experimenter header structure. also the new structure is a multiple of 8 Bytes as per openflow specification. An Experimenter action uses the following structure and fields: /* Action header for OFPAT_EXPERIME

[ovs-dev] [PATCH 0/6] OVN: Support Physical Endpoints and their logical binding

2016-03-19 Thread Darrell Ball
The following patch series supports physical endpoints and their binding to logical ports. Physical endpoints are defined here as endpoints at the border of a physical network. This presently applies to localnet and gateways. For localnet physical endpoints, chassis name and chassis port can be

[ovs-dev] [ovs-dev, v2, 10/23] Misc cleanup with "util.h" header files

2016-03-19 Thread Ryan Moats
Original Message > From: Ben Warren > > Removed from redundant #includes and moved some macros to different file > scope > > Signed-off-by: Ben Warren > --- > include/openvswitch/compiler.h | 3 +++ > include/openvswitch/util.h | 46 - > l

[ovs-dev] [PATCH v4 03/12] dpif-netdev: Keep count of elements in port->rxq[].

2016-03-19 Thread Daniele Di Proietto
This will ease deleting a port with no open rxqs. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 9c30dad..a2281b8 100644 --- a/lib/dpif-netdev.c ++

Re: [ovs-dev] [PATCH] datapath-windows: Change reported time for flows

2016-03-19 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, 15 March, 2016 21:42 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Change reported time for flows Currently the datapath reports the

Re: [ovs-dev] [PATCH 4/4] Update flow generation for localnet and future software gateway to source physical endpoint encapsulation from the OVN SB physical endpoint table

2016-03-19 Thread Ben Pfaff
On Tue, Mar 01, 2016 at 10:39:19AM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball I get a consistent test failure with this patch applied: 2003: ovn -- 2 HVs, 4 lports/HV, localnet ports FAILED (ovn.at:931) I'm appending the full test log. I applied these patches on top of comm

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Add on-demand columns generated functions

2016-03-19 Thread Ben Pfaff
On Tue, Mar 01, 2016 at 05:42:27PM +, Arguello, Sebastian wrote: > To ease the usage of the on-demand columns, wrappers that allow the > developers to work with ovsrecs instead of ovsdb_idl_rows were added. > > For each table, a new set of functions to request the on-demand data > from the ser

Re: [ovs-dev] [PATCH v2 06/23] Move lib/dynamic-string.h to include/openvswitch directory

2016-03-19 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 10:20:46AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > Signed-off-by: Ben Warren Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 04/23] Move contents of lib/list.h to include/openvswitch directory

2016-03-19 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 10:20:44AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > Most of the list code is properly namespaced, so is OK to move to the > global export directory. Some "lib/util.h" code had to move to the > other directory as well, but I've tried to make that as sma

Re: [ovs-dev] [PATCH v2 05/23] Remove lib/list.h completely

2016-03-19 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 10:20:45AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > All code is now in include/openvswitch/list.h > > Signed-off-by: Ben Warren Makes perfect sense once patch 4 is in, thanks. ___ dev mailing list dev@openv

Re: [ovs-dev] [PATCH v3 11/11] netdev-dpdk: Use ->reconfigure() call to change rx/tx queues.

2016-03-19 Thread Daniele Di Proietto
Thanks for your detailed comments, replies inline. I'll send v4 in a minute. On 16/03/2016 06:12, "Ilya Maximets" wrote: >On 16.03.2016 01:30, Daniele Di Proietto wrote: >> This introduces in dpif-netdev and netdev-dpdk the first use for the >> newly introduce reconfigure netdev call. >> >> Wh

[ovs-dev] [RFC PATCH] tunneling: Improving vxlan performance using DPDK flow director feature.

2016-03-19 Thread Sugesh Chandran
Optimizing vxlan tunneling performance in userspace datapath using flow director feature in Fortville NIC DPDK ports. OVS uses metadata reported by NIC to improve the flow lookup performance on VxLAN packets. Signed-off-by: Sugesh Chandran --- lib/automake.mk | 2 + lib/dpdk-i40e-ofld.c

[ovs-dev] [PATCH 14/14] Add a test for software gateway using ovn-controller

2016-03-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/ovn.at | 133 +++ 1 file changed, 133 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index dac36c8..7ad8330 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1121,6 +1121,139 @@ for daemon in ovs

Re: [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller

2016-03-19 Thread Ben Pfaff
On Thu, Mar 17, 2016 at 12:04:19PM +0530, Numan Siddique wrote: > On 03/16/2016 10:44 PM, Russell Bryant wrote: > > It could also be this: > > > > dhcp_offer(offer_ip=10.0.0.3, netmask=255.255.255.0, mtu=1300, > > dns={8.8.8.8, 7.7.7.7}); > > Thanks. This seems better to me. Yes, I agree. I pref

[ovs-dev] [PATCH] rhel: Don't package ovs-testcontroller with ovn.

2016-03-19 Thread Russell Bryant
This was a mistake. ovs-testcontroller was duplicated in the ovn package. It's already in the main openvswitch package, where it belongs. Signed-off-by: Russell Bryant --- rhel/openvswitch-fedora.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/

Re: [ovs-dev] [PATCH v6 2/6] datapath-windows: Added recirculation support.

2016-03-19 Thread Nithin Raju
Pls. disregard this. I hit the ‘send’ too soon. Will send out the full list of comments. -Original Message- From: Nithin Raju Date: Friday, March 18, 2016 at 12:43 PM To: Sorin Vinturis , "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH v6 2/6] datapath-windows: Added recirculation su

Re: [ovs-dev] [PATCH 4/6] Update sbctl man page for physical endpts and binding to logical ports

2016-03-19 Thread Darrell Ball
Adding ovs dev On 3/15/16, 4:28 PM, "Darrell Ball" wrote: >Signed-off-by: Darrell Ball >--- > ovn/utilities/ovn-sbctl.8.in | 48 > 1 file changed, 48 insertions(+) > >diff --git a/ovn/utilities/ovn-sbctl.8.in b/ovn/utilities/ovn-sbctl.8.in >index

Re: [ovs-dev] [PATCH v2 03/23] Move lib/ofp-errors.h to include/openvswitch directory

2016-03-19 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 10:20:43AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > Signed-off-by: Ben Warren Applied, thanks! > -ERROR_HEADER should point to lib/ofp-errors.h. > +ERROR_HEADER should point to include/openvswitch/ofp-errors.h. > VENDOR_HEADER should point to includ

Re: [ovs-dev] Deletion of Indirect Groups on Ovs2.5

2016-03-19 Thread Simon Horman
On Wed, Mar 16, 2016 at 05:48:23PM +, Shuva Jyoti Kar wrote: > Hello, > > I am trying deletion of an indirect group on ovs2.5 . Now when I try to > delete the group using the group-id and group-type without the buckets the > group-deletion fails with an error OFPGMFC_INVALID_GROUP > > The O

Re: [ovs-dev] [PATCH v3 1/7] ovs-ofctl: add option for color output to dump-flows command

2016-03-19 Thread Ben Pfaff
On Wed, Mar 02, 2016 at 03:56:16PM +0100, Quentin Monnet wrote: > Add an option to ovs-ofctl utility so as to obtain colorized output in > tty, for easier reading. Currently, only the dump-flows command supports > colors. > > A new `--color` option has been added to ovs-ofctl so as to indicate > w

Re: [ovs-dev] [PATCH] lib/util.c: Optimise bitwise_rscan.

2016-03-19 Thread Ben Pfaff
On Wed, Mar 16, 2016 at 10:38:46PM -0700, Han Zhou wrote: > On Wed, Mar 16, 2016 at 10:03 PM, Ben Pfaff wrote: > > > On Wed, Mar 16, 2016 at 08:55:35PM -0700, Han Zhou wrote: > > > bitwise_rscan() is found to be hot spot in ovn-controller during OVN > > > scalability tests. It is triggered by lfl

  1   2   3   >