On Mon, Mar 7, 2016 at 8:15 AM, Ryan Moats <rmo...@us.ibm.com> wrote:
> From: RYAN D. MOATS <rmo...@us.ibm.com>
>
> OVN NB & SB DB's should be run in separate ovsdb-server processes
> and should run with ovn-ctl start_northd / stop_northd. This patch
> includes changes to unit tests, tutorial and debian scripts to remain
> self-consistent.
>
> Signed-off-by: RYAN D. MOATS <rmo...@us.ibm.com>
> Signed-off-by: Michael Arnaldi <arnaldimichael at gmail.com>
>
I apologize for being so slow to review this.
Unfortunately it no longer applies cleanly. Can you rebase it?
> + if daemon_is_running ovn-northd; then
> + log_success_msg "OVN Northbound is already running"
>
This should probably say "ovn-northd is already running".
>
> @@ -134,10 +210,13 @@ startup scripts. System administrators should not
> normally invoke it directly.
>
> Commands:
> start_northd start ovn-northd
> + start_ovsdb start ovn related ovsdb-server processes
> start_controller start ovn-controller
> stop_northd stop ovn-northd
> + stop_ovsdb stop ovn related ovsdb-server processes
> stop_controller stop ovn-controller
> restart_northd restart ovn-northd
> + restart_ovsdb restart ovn related ovsdb-server processes
> restart_controller restart ovn-controller
>
> Options:
> @@ -145,6 +224,11 @@ Options:
> --ovn-northd-wrapper=WRAPPER run with a wrapper like valgrind for
> debugging
> --ovn-controller-priority=NICE set ovn-northd's niceness (default:
> $OVN_CONTROLLER_PRIORITY)
> --ovn-controller-wrapper=WRAPPER run with a wrapper like valgrind for
> debugging
> + --ovn-manage-ovsdb=no manage ovsdb separately from
> start_northd and stop_northd
>
I find this a little bit confusing. I would expect the help text to
explain what happens when I enable something.
An alternative could be
--ovn-manage-ovsdb=yes|no Whether or not the OVN databases should be
automatically started and stopped along with ovn-northd. The default is
"yes". If this is set to "no", the "start_ovsdb" and "stop_ovsdb" commands
must be used to start and stop the OVN databases.
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index c0b6981..bdad368 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
> @@ -142,7 +142,7 @@ nbctl_default_db(void)
> if (!def) {
> def = getenv("OVN_NB_DB");
> if (!def) {
> - def = ctl_default_db();
> + def = xasprintf("unix:%s/ovnnb_db.sock", ovs_rundir());
>
These defaults are in multiple places (ovn-nbctl, ovn-sbctl, and
ovn-northd). It would be nice to have it come from a common place in
ovn/lib/. That could be a cleanup later, too.
--
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
