[ovs-dev] Mail System Error - Returned Mail

2016-01-07 Thread Post Office
$„^ÑQO/ò>ž´('­ð;a¾Ù×…ïÆ‘¼ lü­1¾`ÑùˆGª  /è3.‰Oª0KžÉåõÈõµ¯êÐ2‹)ÏÝõN1·°mS#zRŽÑ6¥Î'W×&À'0¿TYq҉ Z}z½ÍUasa#ñ^ZCg¤pS_jëͽ ϖH¤¡äñNG÷p·1˜í´0†îP\à ñÙGjû³.cjÏBÖ3hf`k*OL¡˜bG"k諞ï,>TŒ9e¡nwÁ›Ö?˜*pŒ$úõí<÷Ÿ”D³IiA: ËËSR¥'³ÖŒÚ)’æ§eéÈO¨Ï›kÝiì^?Œ5mL“¤bÓHQE49†˜qšuiœ¨¾Ç~¢™)‚¹µ¹³pD"¥ÞRÍÔýxF‰õá¤OMùMÌWí,a¼´U7¬Õ

[ovs-dev] [PATCH] python: Fix the TypeError exception seen when idl.Idl parses lock reply

2016-01-07 Thread Numan Siddique
File "/usr/lib/python2.7/site-packages/ovs/db/idl.py", line 334, in __parse_lock_notify self.__update_has_lock(self, new_has_lock) TypeError: __update_has_lock() takes exactly 2 arguments (3 given) Signed-off-by: Numan Siddique --- python/ovs/db/idl.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread David Miller
From: David Wragg Date: Thu, 07 Jan 2016 23:42:52 + > I'm willing to follow up on Jesse's request to look into the other > tunnel types too, but at the moment I'm wondering what the chances are > that the resulting submission would get accepted. I'm ok with these fixes if you look into Jesse

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Document revalidator cycle.

2016-01-07 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 7, 2016, at 4:16 PM, Joe Stringer wrote: > > Add a series of comments to make it more clear what's happening for > individual ukeys being handled during revalidator dump/sweep cycle. > > Signed-off-by: Joe Stringer > --- > ofproto/ofproto-dpif-upcall.c | 43

[ovs-dev] [PATCH] ofproto-dpif-upcall: Document revalidator cycle.

2016-01-07 Thread Joe Stringer
Add a series of comments to make it more clear what's happening for individual ukeys being handled during revalidator dump/sweep cycle. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 43 +-- 1 file changed, 37 insertions(+), 6 deletions(-)

Re: [ovs-dev] [PATCH 2/4] ovs-vsctl: fix memory leak reported by valgrind

2016-01-07 Thread William Tu
Hi, Please ignore this one [PATCH 2/4], I found it might not be correct and breaks testcase 1619: database commands -- wait-until must wait (make check-valgrind pass, but make check fails) Regards, William On Wed, Jan 6, 2016 at 10:49 AM, William Tu wrote: > test case 1: appctl-bashcomp - basi

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Joe Stringer
On 7 January 2016 at 13:53, Jarno Rajahalme wrote: > While correct, I would find this easier to follow (as an incremental on top > of this patch): > > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c > index d611131..390acbf 100644 > --- a/ofproto/ofproto-dpif-upcall.c >

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Don't delete modified ukeys.

2016-01-07 Thread Joe Stringer
On 7 January 2016 at 13:49, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, I applied this to master and branch-2.5. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] stream-ssl.c: fix memory leak reported by valgrind

2016-01-07 Thread William Tu
test case 1628: peer ca cert ASN1_item_dup do_ca_cert_bootstrap (stream-ssl.c:413) ssl_connect (stream-ssl.c:468) scs_connecting (stream.c:297) stream_connect (stream.c:320) Fix by removing the X509_dup(). Signed-off-by: William Tu --- lib/stream-ssl.c | 6 -- 1 file chan

[ovs-dev] [PATCH 1/2] ovsdb-client: fix memory leak reported by valgrind

2016-01-07 Thread William Tu
test case 1427: ovsdb-server combines updates on backlogged connections. ovsdb_column_set_add (column.c:233) add_column (ovsdb-client.c:730) parse_monitor_columns (ovsdb-client.c:787) add_monitored_table (ovsdb-client.c:872) do_monitor__ (ovsdb-client.c:945) Reported-by: Willia

[ovs-dev] [PATCH 2/2] ovsdb-client: fix memory leak reported by valgrind

2016-01-07 Thread William Tu
testc ase 1427: ovsdb-server combines updates on backlogged connections. valgrind reports two leaks: unixctl_server_create (unixctl.c:250) do_monitor__ (ovsdb-client.c:918) and json_create (json.c:1406) json_integer_create (json.c:262) json_clone (json.c:413) do_monitor__ (o

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread David Wragg
David Miller writes: >> Considering non-openvswitch scenarios, when using vxlan netdevs >> directly, a vxlan netdev locked to an underlying device supporting jumbo >> frames can use a larger MTU. It's only vxlan netdevs without an >> underlying device that have the limit of 1500 imposed. But why

Re: [ovs-dev] possible memory leak at add_monitored_table()

2016-01-07 Thread William Tu
Hi Andy, This patch solves the leak. I will combine with the rest and send out a patch! Thank you. Regards, William On Thu, Jan 7, 2016 at 2:01 PM, Andy Zhou wrote: > Hi, William, > > I have posted a patch at > https://patchwork.ozlabs.org/patch/564472/ > > Would you please review and tes

Re: [ovs-dev] possible memory leak at add_monitored_table()

2016-01-07 Thread Andy Zhou
Hi, William, I have posted a patch at https://patchwork.ozlabs.org/patch/564472/ Would you please review and test the changes? Thanks! --andy On Thu, Jan 7, 2016 at 11:48 AM, William Tu wrote: > Hi, > > I'm running valgrind on testcase 1427: ovsdb-server combines updates on > backlogged

[ovs-dev] [PATCH] ovsdb-client: fix monitored table memory leak

2016-01-07 Thread Andy Zhou
Properly free memory used monitored_tables to reduce valgrind noises. Reported-by: William Tu Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064161.html Signed-off-by: Andy Zhou --- ovsdb/ovsdb-client.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ovsdb/o

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Jarno Rajahalme
While correct, I would find this easier to follow (as an incremental on top of this patch): diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index d611131..390acbf 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -2240,9 +2240,8 @@ revali

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Don't delete modified ukeys.

2016-01-07 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 7, 2016, at 11:47 AM, Joe Stringer wrote: > > If revalidation returns the result UKEY_DELETE, then both the ukey and > its corresponding flow should be deleted. However, if revalidation > returns UKEY_MODIFY, the ukey itself should be modified in-place and > s

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread David Miller
From: David Wragg Date: Wed, 06 Jan 2016 23:25:56 + > Considering non-openvswitch scenarios, when using vxlan netdevs > directly, a vxlan netdev locked to an underlying device supporting jumbo > frames can use a larger MTU. It's only vxlan netdevs without an > underlying device that have the

[ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Joe Stringer
Flows which are deleted during the revalidator "dump" phase have their corresponding dump seq updated, which leads to such ukeys being handled by the "UKEY_KEEP" logic in revalidator_sweep__() here: } else if (!seq_mismatch) { result = UKEY_KEEP; } In practice, this has allowed th

[ovs-dev] possible memory leak at add_monitored_table()

2016-01-07 Thread William Tu
Hi, I'm running valgrind on testcase 1427: ovsdb-server combines updates on backlogged connections. valgrind reports the following two leaks and I haven't been able to fix it. Can anyone give me some hints about how to fix it? Thank you. ==104840== 896 bytes in 5 blocks are definitely lost in lo

Re: [ovs-dev] Performance Issue when using netdev-dpdk and multiple PMD threads

2016-01-07 Thread Mauricio Vásquez
Hi to All, I performed some testing using physical NICs and an external traffic generator. The issue was not present in that case. Could it be due to that when using physical NICs the data rate is slower than when the traffic is generated locally? What else should I check? Thank you, On 31 De

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/07/16 at 06:50pm, Hannes Frederic Sowa wrote: > On 07.01.2016 18:21, Thomas Graf wrote: > >On 01/07/16 at 08:35am, Jesse Gross wrote: > >>On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote: > >>>A simple start could be to add a new return code for > MTU drops in > >>>the dev_queue_xmit() path

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Hannes Frederic Sowa
On 07.01.2016 18:21, Thomas Graf wrote: On 01/07/16 at 08:35am, Jesse Gross wrote: On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote: A simple start could be to add a new return code for > MTU drops in the dev_queue_xmit() path and check for NET_XMIT_DROP_MTU in ovs_vport_send() and emit prope

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/07/16 at 08:35am, Jesse Gross wrote: > On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote: > > A simple start could be to add a new return code for > MTU drops in > > the dev_queue_xmit() path and check for NET_XMIT_DROP_MTU in > > ovs_vport_send() and emit proper ICMPs. > > That could be in

Re: [ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-07 Thread Daniele Venturino
Maybe we could destroy the hmap with the mutex still locked. Anyway, looks good to me. Acked-by: Daniele Venturino mailto:daniele.ventur...@m3s.it>> > Il giorno 05 gen 2016, alle ore 22:38, William Tu ha > scritto: > > test case: 1650 RSTP Single bridge, call stacks >hmap_insert_at (hmap.h

Re: [ovs-dev] About OpenvSwitch

2016-01-07 Thread Fischetti, Antonio
Hi Chandrakant, You may want to have a look at the OVS/utilities/ or OVS/vswitchd/ folders. For ex. OVS/utilities/ovs-vsctl.c contains the implementation of commands like 'ovs-vsctl add-br ...' See 'vsctl_commands[]' structure, it lists the required format, the params check and the execution of th

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 04:46pm, Jesse Gross wrote: > On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa > > I don't see any other way as to make MTUs part of the flow if we want to > > have correct ip_local_error notifications. And those must also work across > > VMs, so openvswitch in quasi brouting mod

Re: [ovs-dev] [PATCH net 2/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 01:33pm, David Wragg wrote: > Prior to 4.3, vxlan vports could transmit vxlan packets of any size, > constrained only by the ability to transmit the resulting UDP packets. > 4.3 introduced vxlan netdevs corresponding to vxlan vports. These > netdevs have an MTU, which limits the siz

[ovs-dev] How to setup IVSHM in OVS-DPDK

2016-01-07 Thread Furong
Hello everybody: I am trying to use IVSHM to exchange packets between VMs. On OVS side, I know the IVSHM channel is built upon the ring devices from DPDK. However, I do not know how to setup qemu to share this ring device's memory to VMs. Could somebody give a short tutorial? Thanks!! __

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Convert initialization from cmdline to db

2016-01-07 Thread Panu Matilainen
On 01/04/2016 11:46 PM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packag

[ovs-dev] About OpenvSwitch

2016-01-07 Thread Chandrakant Raundal
Respected Sir/Ma'am, This is Chandrakant from PICT,Pune. I am final year student of Computer Engineering and currently working on a project "NFS Backup using networking in SDN Environment." We are using openvswitch 2.0.2 and pox controller version 0.2.0. I am familiar with following commands of ov

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK v2.2.0.

2016-01-07 Thread Weglicki, MichalX
Hello, Is it possible to merge this patch? It is just documentation update about dpdk2.2. Br, Michal. -Original Message- From: Weglicki, MichalX Sent: Wednesday, December 23, 2015 10:20 AM To: dev@openvswitch.org Cc: Weglicki, MichalX Subject: [PATCH] Update relevant artifacts to