Maybe we could destroy the hmap with the mutex still locked. Anyway, looks good to me.
Acked-by: Daniele Venturino <daniele.ventur...@m3s.it <mailto:daniele.ventur...@m3s.it>> > Il giorno 05 gen 2016, alle ore 22:38, William Tu <u9012...@gmail.com> ha > scritto: > > test case: 1650 RSTP Single bridge, call stacks > hmap_insert_at (hmap.h:235) > rstp_port_set_port_number__ (rstp.c:744) > rstp_add_port (rstp.c:1164) > new_bridge (test-rstp.c:123) > test_rstp_main (test-rstp.c:514) > ovstest_wrapper_test_rstp_main__ (test-rstp.c:714) > ovs_cmdl_run_command (command-line.c:121) > main (ovstest.c:132) > fix it by adding hmap_destroy() at rstp_unref() > > Signed-off-by: William Tu <u9012...@gmail.com> > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> > Co-authored-by: Daniele Di Proietto <diproiet...@vmware.com> > --- > lib/rstp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/rstp.c b/lib/rstp.c > index 9fdf810..f24ca01 100644 > --- a/lib/rstp.c > +++ b/lib/rstp.c > @@ -186,6 +186,7 @@ rstp_unref(struct rstp *rstp) > > list_remove(&rstp->node); > ovs_mutex_unlock(&rstp_mutex); > + hmap_destroy(&rstp->ports); > free(rstp->name); > free(rstp); > } > -- > 2.5.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
