The existing wording was very specific to the actual operation being
performed. While this is nice for users, it becomes difficult to maintain
as more and more operations are added. This commit makes the wording less
specific, because a third operation will start using this function in an
upcomin
This is sufficient support that an L3 logical router can now transmit
packets to VMs (and other destinations) without having to know the
IP-to-MAC binding in advance. The details are carefully documented in all
of the appropriate places.
There are several important caveats that need to be fixed b
It seems easier to understand if all of the tests for a given action
are grouped together.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 89 ++--
1 file changed, 50 insertions(+), 39 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
inde
An simap is convenient but it isn't very flexible. If the client wants to
keep extra data with each node then it has to build a second parallel data
structure. A callback function is kind of a pain for the clients from the
point of view of having to write it and deal with auxiliary data, etc., bu
This was more or less implemented inside lflow.c until now, but some
upcoming code that shouldn't be in that file needs to use it too.
This also adds a second index on lports, so that lports can be looked up
based on the logical datapath tunnel key and the logical port tunnel key.
An upcoming comm
This will make it easier to add and change parameters, as done in an
upcoming commit.
Signed-off-by: Ben Pfaff
---
ovn/controller/lflow.c | 15 +--
ovn/lib/actions.c | 109 -
ovn/lib/actions.h | 51 ++-
tests/tes
An upcoming commit will use this as a building block in adding ARP support
to the OVN L3 logical router implementation.
Signed-off-by: Ben Pfaff
---
ovn/lib/actions.c | 33 +
ovn/ovn-sb.xml| 21 +
tests/ovn.at | 3 +++
3 files changed
This is useful for generating an ARP request from the OpenFlow flow table,
which in turn is useful for implementing a router. An upcoming commit
will use this feature to implement ARP request generationg in the OVN L3
logical router.
Signed-off-by: Ben Pfaff
---
NEWS
This will acquire new users in upcoming commits.
Signed-off-by: Ben Pfaff
---
ovn/lib/actions.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
index 693b1c1..581dbae 100644
--- a/ovn/lib/actions.c
+++ b/ovn/lib/
This will have another user in an upcoming commit.
Signed-off-by: Ben Pfaff
---
ovn/lib/actions.c | 70 +++
1 file changed, 39 insertions(+), 31 deletions(-)
diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
index 581dbae..6bc452a 100644
---
This saves some code and improves clarity, in my opinion.
Some of these changes just change an inet_pton() call into a similar
ip_parse() or ipv6_parse() call. In those cases the benefit is better
type safety, since inet_pton()'s output parameter is type "void *".
Signed-off-by: Ben Pfaff
---
An upcoming commit will introduce another user.
Signed-off-by: Ben Pfaff
---
lib/packets.h | 1 +
vswitchd/bridge.c | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/packets.h b/lib/packets.h
index edf140b..1e0417a 100644
--- a/lib/packets.h
+++ b/lib/packets.h
@@
These will be used in an upcoming patch to reduce duplicated code.
Signed-off-by: Ben Pfaff
---
lib/packets.c | 132 ++
lib/packets.h | 7
2 files changed, 102 insertions(+), 37 deletions(-)
diff --git a/lib/packets.c b/lib/packets.
Ben Pfaff (14):
sparse: Define INET_ADDRSTRLEN.
packets: New macro ETH_ADDR_STRLEN.
packets: Add new functions for IPv4 and IPv6 address parsing.
Use ip_parse() and ipv6_parse() and variants in more places.
Add OpenFlow support for new "arp" action.
actions: Factor out new helper functi
POSIX defines this but it was missing from the OVS header file definitions
for "sparse".
Signed-off-by: Ben Pfaff
---
include/sparse/netinet/in.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/sparse/netinet/in.h b/include/sparse/netinet/in.h
index 1223553..78e5981 100644
--- a/incl
Add a new function ovs_ct_find_existing() to find an existing
conntrack entry for which this packet was already applied to. This is
only to be called when there is evidence that the packet was already
tracked and committed, but we lost the ct reference due to an
userspace upcall.
ovs_ct_find_exis
Only a successful nf_conntrack_in() call can effect a connection state
change, so if suffices to update the key only after the
nf_conntrack_in() returns.
This change is needed for the later NAT patches.
Signed-off-by: Jarno Rajahalme
---
net/openvswitch/conntrack.c | 9 ++---
1 file changed
NAT checksum recalculation code assumes existence of skb_dst, which
becomes a problem for a later patch in the series ("openvswitch:
Interface with NAT."). Simplify this by removing the check on
skb_dst, as the checksum will be dealt with later in the stack.
Suggested-by: Pravin Shelar
Signed-of
Define a new inline function to map conntrack status to enum
ip_conntrack_info. This removes the need to otherwise duplicate this
code in a later patch ("openvswitch: Find existing conntrack entry
after upcall.").
Signed-off-by: Jarno Rajahalme
---
include/net/netfilter/nf_conntrack.h | 15
This series adds NAT support to openvswitch kernel module. A few
changes are needed to the netfilter code to facilitate this (patches
1-3/8). Patches 4-7 make the openvswitch kernel module ready for the
patch 8 that adds the NAT support by calling into netfilter NAT code
from the openvswitch conn
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does
not make sense. This allows the definition of IP_CT_NUMBER to be
simplified as well.
Signed-off-by: Jarno Rajahalme
---
include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +---
net/openvswitch/conntrack.c
Previously this was only done when connlabels were enabled in the kernel
config, even if the functions didn't exist. Fix the compile error.
Reported-by: Simon Horman
Signed-off-by: Joe Stringer
---
.../compat/include/net/netfilter/nf_conntrack_labels.h | 14 +++---
1 file changed, 1
If userspace executes ct(zone=1), and the connection tracker determines
that the packet is invalid, then the ct_zone flow key field is populated
with the default zone rather than the zone that was specified. Even
though connection tracking failed, this field should be updated with the
value that us
On 8 December 2015 at 14:34, Russell Bryant wrote:
> The OVN symbol table contained outdated mappings between connection
> states and the corresponding bit in the ct_state field. This patch
> updates the symbol table with the proper values as defined in
> lib/packets.h.
>
> Signed-off-by: Russell
The OVN symbol table contained outdated mappings between connection
states and the corresponding bit in the ct_state field. This patch
updates the symbol table with the proper values as defined in
lib/packets.h.
Signed-off-by: Russell Bryant
---
ovn/controller/lflow.c | 8
1 file chang
Dear Customer
Your invoice appears below. Please remit payment at your earliest convenience.
Thank you for your business - we appreciate it very much.
Sincerely,
Sharlene ConradCourier Service
___
dev mailing list
dev@openvswitch.org
http://openvswitch
On December 8, 2015 at 12:18:29 PM, Jarno Rajahalme (ja...@ovn.org) wrote:
On Dec 8, 2015, at 11:43 AM, Shashank Shanbhag
wrote:
Hi Jarno,
It looks great. We tested it internally to make sure.
I'm not in favor of exclusion lists, as it gets unwieldy if the number of
tables of interest is pret
> On Dec 8, 2015, at 11:41 AM, Ben Pfaff wrote:
>
> On Tue, Dec 08, 2015 at 11:39:23AM -0800, Jarno Rajahalme wrote:
>>
>>> On Dec 7, 2015, at 9:34 AM, Ben Pfaff wrote:
>>>
>>> On Fri, Dec 04, 2015 at 03:57:09PM -0800, Jarno Rajahalme wrote:
Having a coverage counter tracking the value o
> On Dec 8, 2015, at 11:43 AM, Shashank Shanbhag
> wrote:
>
> Hi Jarno,
>
> It looks great. We tested it internally to make sure.
> I'm not in favor of exclusion lists, as it gets unwieldy if the number of
> tables of interest is pretty small (which is the case in our application).
> Thanks
Hi Jarno,
It looks great. We tested it internally to make sure.
I'm not in favor of exclusion lists, as it gets unwieldy if the number of
tables of interest is pretty small (which is the case in our application).
Thanks for this.
Acked-by: Shashank Shanbhag
-
On Tue, Dec 08, 2015 at 11:39:23AM -0800, Jarno Rajahalme wrote:
>
> > On Dec 7, 2015, at 9:34 AM, Ben Pfaff wrote:
> >
> > On Fri, Dec 04, 2015 at 03:57:09PM -0800, Jarno Rajahalme wrote:
> >> Having a coverage counter tracking the value of the internal seq_next
> >> should help in debugging.
>
> On Dec 8, 2015, at 11:39 AM, Jarno Rajahalme wrote:
>
>
>> On Dec 7, 2015, at 9:34 AM, Ben Pfaff wrote:
>>
>> On Fri, Dec 04, 2015 at 03:57:09PM -0800, Jarno Rajahalme wrote:
>>> Having a coverage counter tracking the value of the internal seq_next
>>> should help in debugging.
>>>
>>> Sug
> On Dec 7, 2015, at 9:34 AM, Ben Pfaff wrote:
>
> On Fri, Dec 04, 2015 at 03:57:09PM -0800, Jarno Rajahalme wrote:
>> Having a coverage counter tracking the value of the internal seq_next
>> should help in debugging.
>>
>> Suggested-by: Justin Pettit
>> Signed-off-by: Jarno Rajahalme
>
> Ac
Acked-by: Sairam Venugopal
On 12/7/15, 3:13 PM, "Nithin Raju" wrote:
>Fixing a little buglet from commit: efee3309.
>
>Signed-by: Nithin Raju
>---
> datapath-windows/ovsext/NetProto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/NetProto.h
>b/
Requested-by: P R Dinesh
Requested-at: https://github.com/openvswitch/ovs/pull/94
Signed-off-by: Ben Pfaff
---
lib/vlog.c | 24 ++
python/ovs/vlog.py | 11 +++-
tests/vlog.at | 74 ++
3 files changed, 108 inserti
Signed-off-by: Ben Pfaff
---
tests/automake.mk| 2 +
tests/test-unixctl.c | 186 +++
tests/vlog.at| 131
3 files changed, 319 insertions(+)
create mode 100644 tests/test-unixctl.c
diff --git a/tes
Thanks Sairam and Nithin, I applied this to master.
On Tue, Dec 01, 2015 at 01:06:15AM +, Sairam Venugopal wrote:
> Thanks for the patch.
>
> Acked-by: Sairam Venugopal
>
>
>
> On 11/25/15, 12:32 PM, "Nithin Raju" wrote:
>
> >On Hyper-V, we currently don't validate a flow to see if data
On 7 December 2015 at 13:00, Daniele Di Proietto
wrote:
> This is an easy way to keep track of the features supported by the
> different datapaths.
>
> Nithin helped filling the list for the Hyper-V port.
>
> CC: Nithin Raju
> Signed-off-by: Daniele Di Proietto
>
Thanks for doing this!
This s
On Mon, Dec 7, 2015 at 7:49 PM, Jesse Gross wrote:
> On Mon, Dec 7, 2015 at 6:23 PM, Pravin B Shelar wrote:
>> Few important bugfixes for OVS out of tree module.
>>
>> Pravin B Shelar (4):
>> datapath: Backport: openvswitch: fix hangup on vxlan/gre/geneve
>> device deletion
>> datapath: B
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Tuesday, December 8, 2015 4:50 PM
> To: Gray, Mark D
> Cc: Traynor, Kevin; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: Clarify DPDK arguments.
>
> On Tue, Dec 08, 2015 at 04:41:37PM +, Gray
Hi Uday,
On 8 December 2015 at 06:43, wrote:
We want to contribute the same to the openvswitch . Please , let me know
> whom to approach regarding reviews. All comments are appreciated.
Reviews are conducted on this mailinglist, you can send patches as per the
instructions in CONTRIBUTING.md.
> On Dec 8, 2015, at 8:51 AM, Nithin Raju wrote:
>
> Thanks for putting this together. Like we discussed offline, a lot of the
> hyper-v values are subject to change in the near future, but the matrix
> represents that state of the Hyper-V datapath as of today.
That's great to hear. When a fea
> On Dec 8, 2015, at 1:01 AM, Gray, Mark D wrote:
>
>> +Feature | Linux upstream | Linux OVS tree | Userspace |
>> Hyper-V |
>> +--|:--:|:--:|:-:|:-
>> +--|--:|
>> +Connection tracking | 4.3 |
On Mon, Dec 07, 2015 at 04:27:32PM -0800, Pravin Shelar wrote:
> On Mon, Dec 7, 2015 at 12:34 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Pravin B Shelar
Thanks, applied to master and branch-2.5.
___
dev mailing list
dev@openvswit
On Tue, Dec 08, 2015 at 04:41:37PM +, Gray, Mark D wrote:
> > -Original Message-
> > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Kevin
> > Traynor
> > Sent: Monday, December 7, 2015 5:58 PM
> > To: dev@openvswitch.org
> > Subject: [ovs-dev] [PATCH] INSTALL.DPDK.md: Clari
Thanks for putting this together. Like we discussed offline, a lot of the
hyper-v values are subject to change in the near future, but the matrix
represents that state of the Hyper-V datapath as of today.
Acked-by: Nithin Raju
-Original Message-
From: Daniele Di Proietto
Date: Monday,
Dear Customer
Your invoice appears below. Please remit payment at your earliest convenience.
Thank you for your business - we appreciate it very much.
Sincerely,
Liza Witt Courier Service
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Kevin
> Traynor
> Sent: Monday, December 7, 2015 5:58 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] INSTALL.DPDK.md: Clarify DPDK arguments.
>
> Add some information about the DPDK -c and -n pa
On 12/08/2015 01:06 AM, Wei Li wrote:
>
>
> 在 2015/12/7 23:30, Russell Bryant 写道:
>>
>> Can you update the man page, as well?
>>
> I would like to do this,but have a question
>
> There is a reference to /db-ctl-base.man/ in /ovn-sbctl.8.in/ implement
> by "/.so lib/db-ctl-base.man/"
>
> but ov
On 12/07/2015 06:46 PM, Ben Pfaff wrote:
> On Mon, Dec 07, 2015 at 01:13:27PM -0500, Russell Bryant wrote:
>> I'm looking at this again and I think it's worth keeping because the
>> output is a bit friendlier.
>>
>> How about supporting both "show LSWITCH" and "show LROUTER". The
>> implementation
Hi Team ,
We all know that ovs supports 4 types of port configuration .
1. Access
2. Trunk
3. Native-tagged
4. Native-untagged
Through access port configuration we can achieve 802.1q by adding normal
flow(Not Openflow) ,we all know that when ovs is configured with norm
On 12/04/2015 05:44 PM, Gray, Mark D wrote:
I welcome this initiative, one question below:
-Original Message-
From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Panu
Matilainen
Sent: Friday, December 4, 2015 10:54 AM
To: d...@dpdk.org; us...@dpdk.org; dev@openvswitch.or
Hi Nithin,
Thanks for your review. The mpls push and pop actions were tested by manually
changing the action type when one was received. I don't know how to trigger the
MPLS push/pop actions for properly testing this part.
The part of the patch regarding MPLS key extraction or NL buffer parsin
Good initiative Daniele. Comment below.
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Monday, December 7, 2015 9:01 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] FAQ: Add entry about different datapaths
> featur
54 matches
Mail list logo
