[ovs-dev] [PATCH] seq: Add a coverage counter for seq_change.

2015-12-04 Thread Jarno Rajahalme
Having a coverage counter tracking the value of the internal seq_next should help in debugging. Suggested-by: Justin Pettit Signed-off-by: Jarno Rajahalme --- lib/seq.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/seq.c b/lib/seq.c index 271e617..9c3257c 100644 --- a/lib/seq.

Re: [ovs-dev] [PATCH net-next v3 3/8] netfilter: Allow calling into nat helper without skb_dst.g

2015-12-04 Thread Pravin Shelar
On Tue, Dec 1, 2015 at 12:51 PM, Pablo Neira Ayuso wrote: > On Wed, Nov 25, 2015 at 04:08:16PM -0800, Jarno Rajahalme wrote: >> NAT checksum recalculation code assumes existence of skb_dst, which >> becomes a problem for a later patch in the series ("openvswitch: >> Interface with NAT."). Simplif

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Validate NAT action support.

2015-12-04 Thread Daniele Di Proietto
Thanks for the reviews, Jarno! On 04/12/2015 15:03, "Jarno Rajahalme" wrote: >Thanks Daniele! > >Acked-by: Jarno Rajahalme > >Pushed to master, > > Jarno > >> On Dec 3, 2015, at 10:35 AM, Daniele Di Proietto >> wrote: >> >> The NAT validation is similar (and based on) the existing conntrack >

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Validate NAT action support.

2015-12-04 Thread Jarno Rajahalme
Thanks Daniele! Acked-by: Jarno Rajahalme Pushed to master, Jarno > On Dec 3, 2015, at 10:35 AM, Daniele Di Proietto > wrote: > > The NAT validation is similar (and based on) the existing conntrack > validation: when a dpif backer is created, we try to install a flow with > the ct_state N

Re: [ovs-dev] [PATCH 1/2] odp-util: Consider NAT bits in conversions and format.

2015-12-04 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme Pushed to master, Jarno > On Dec 3, 2015, at 10:35 AM, Daniele Di Proietto > wrote: > > Signed-off-by: Daniele Di Proietto > --- > lib/odp-util.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/lib/odp-util.c b/lib/odp-util.c > index 32

Re: [ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-04 Thread Jarno Rajahalme
Thanks for the review. Agree that will need to consider fixing this in the kernel datapath. Pushed to master, Jarno > On Dec 2, 2015, at 6:33 PM, Daniele Di Proietto > wrote: > > That works for me, thanks Jarno. > > It would be nice for the module to be automatically loaded by the > OVS k

Re: [ovs-dev] Does OVS 2.4 support MPLS over VXLAN?

2015-12-04 Thread Pravin Shelar
On Fri, Dec 4, 2015 at 11:03 AM, Cathy Zhang wrote: > Hi, > > We have been using OVS 2.3 in our SFC development and testing and it supports > MPLS over VXLAN. Now when we switched to OVS 2.4, it seems MPLS over VXLAN > does not work. We are not sure if it is due to that OVS2.4 does not support

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-04 Thread Jarno Rajahalme
> On Dec 3, 2015, at 10:57 PM, Ben Pfaff wrote: > > On Thu, Dec 03, 2015 at 10:23:19PM -0800, Ben Pfaff wrote: >> On Thu, Dec 03, 2015 at 05:59:12PM -0800, Jarno Rajahalme wrote: >>> seq values are 64-bit, and storing them to a 32-bit variable causes >>> the stored value never to match actual se

Re: [ovs-dev] Newbie question: is there a make command to crate images anew after doing an incremental make

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 06:17:57PM +, Charlet, Ricky wrote: > In ops, if I have just done something like > `make ops-openvswitch-build`, is there another make target I can then > use to recreate the package images in the /images/ directory > (in particular, the onie-installer-* image) ?

[ovs-dev] Does OVS 2.4 support MPLS over VXLAN?

2015-12-04 Thread Cathy Zhang
Hi, We have been using OVS 2.3 in our SFC development and testing and it supports MPLS over VXLAN. Now when we switched to OVS 2.4, it seems MPLS over VXLAN does not work. We are not sure if it is due to that OVS2.4 does not support MPLS over VXLAN or it is due to our own code problem. Could

Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-04 Thread Aaron Conole
"Gray, Mark D" writes: >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron >> Conole >> Sent: Thursday, December 3, 2015 4:24 AM >> To: dev@openvswitch.org >> Cc: Flavio Leitner >> Subject: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect n

[ovs-dev] Newbie question: is there a make command to crate images anew after doing an incremental make

2015-12-04 Thread Charlet, Ricky
Howdy, In ops, if I have just done something like `make  ops-openvswitch-build`, is there another make target I can then use to recreate the package images in the /images/ directory (in particular, the onie-installer-* image) ? Ricky Charlet

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix manpage formatting typo.

2015-12-04 Thread Ben Pfaff
Thanks, applied to master. On Thu, Dec 03, 2015 at 11:01:30PM -0800, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Dec 3, 2015, at 11:00 PM, Ben Pfaff wrote: > > > > Only the names of the fields were supposed to be bold here, but omitting > > the "fR" from "\fR" made

Re: [ovs-dev] [PATCH v4] ovn: support ARP response for known IPs

2015-12-04 Thread Ben Pfaff
On Mon, Nov 30, 2015 at 11:42:46AM -0800, Han Zhou wrote: > For lswitch ports with known IPs, ARP is responded directly from > local ovn-controller to avoid flooding. > > Signed-off-by: Han Zhou Applied, thanks! ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH v3 1/5] netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 Thread Thadeu Lima de Souza Cascardo
On Fri, Dec 04, 2015 at 08:56:34AM -0800, Ben Pfaff wrote: > On Fri, Dec 04, 2015 at 12:37:55PM -0200, Thadeu Lima de Souza Cascardo wrote: > > On Tue, Dec 01, 2015 at 12:20:02PM -0800, Ben Pfaff wrote: > > > On Mon, Nov 30, 2015 at 04:53:02PM -0200, Thadeu Lima de Souza Cascardo > > > wrote: > >

Re: [ovs-dev] [PATCH v3 1/5] netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 12:37:55PM -0200, Thadeu Lima de Souza Cascardo wrote: > On Tue, Dec 01, 2015 at 12:20:02PM -0800, Ben Pfaff wrote: > > On Mon, Nov 30, 2015 at 04:53:02PM -0200, Thadeu Lima de Souza Cascardo > > wrote: > > > This includes VXLAN, GRE and Geneve. > > > > > > Signed-off-by:

Re: [ovs-dev] [PATCH v4 3/5] tnl-neigh-cache: remove tnl_arp_lookup

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 12:36:49PM -0200, Thadeu Lima de Souza Cascardo wrote: > tnl_arp_lookup is not used anymore. All users have been converted to > IPv4-mapped > addresses. New users need to use IPv4-mapped addresses and use > tnl_neigh_lookup. > > Signed-off-by: Thadeu Lima de Souza Cascard

Re: [ovs-dev] [PATCH v4 1/5] netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 12:36:47PM -0200, Thadeu Lima de Souza Cascardo wrote: > This includes VXLAN, GRE and Geneve. > > v2: > > Added tests for parsing and formatting at odp.at, as suggested by Ben Pfaff. > Fixed parsing problems found with those tests. > > Signed-off-by: Thadeu Lima de Souza

Re: [ovs-dev] [PATCH v4 2/5] ofproto-dpif-xlate: Support IPv6 when sending to tunnel

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 12:36:48PM -0200, Thadeu Lima de Souza Cascardo wrote: > When doing push/pop and building tunnel header, do IPv6 route lookups and send > Neighbor Solicitations if needed. > > v2: > > Implement compose_nd as suggested by Flavio Leitner. > Use ipv6_string_mapped for xlate_r

[ovs-dev] new warnings

2015-12-04 Thread Ben Pfaff
I'm getting the following new warnings since the big backports series. This is with GCC 4.9 and Linux 3.2: In file included from include/asm-generic/percpu.h:6:0, from /home/blp/nicira/test-vm-linux/arch/x86/include/asm/percpu.h:576, from /home/blp/nicira/test-v

Re: [ovs-dev] [PATCH] packets: Introduce in6_addr_mapped_ipv4() and use where appropriate.

2015-12-04 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 07:11:04PM -0200, Thadeu Lima de Souza Cascardo wrote: > On Thu, Dec 03, 2015 at 01:00:38PM -0800, Ben Pfaff wrote: > > This allows code to be written more naturally in some cases. > > > > Signed-off-by: Ben Pfaff > > --- > > lib/mcast-snooping.c | 9 +++-- >

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Traynor, Kevin
> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Friday, December 4, 2015 3:37 PM > To: Traynor, Kevin > Cc: dev@openvswitch.org; Flavio Leitner > Subject: Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to > db > > "Traynor, Kevin" writes:

Re: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-04 Thread Gray, Mark D
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron > Conole > Sent: Thursday, December 3, 2015 4:24 AM > To: dev@openvswitch.org > Cc: Flavio Leitner > Subject: [ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new > config > > A previous c

Re: [ovs-dev] [PATCH v2] ovs-router: fix compile error on FreeBSD

2015-12-04 Thread Ben Pfaff
On Fri, Dec 04, 2015 at 11:31:40PM +0800, Kevin Lo wrote: > FreeBSD needs to include netinet/in.h to define struct in6_addr. > > Signed-off-by: Kevin Lo Thanks, applied to master and branch-2.5. ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Aaron Conole
Zoltan Kiss writes: > On 03/12/15 04:23, Aaron Conole wrote: >> Existing DPDK integration is provided by use of command line options which >> must be split out and passed to librte in a special manner. However, this >> forces any configuration to be passed by way of a special DPDK flag, and >> int

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Zoltan Kiss
On 03/12/15 04:23, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packaging

Re: [ovs-dev] [PATCH v2] ovs-router: fix compile error on FreeBSD

2015-12-04 Thread Thadeu Lima de Souza Cascardo
On Fri, Dec 04, 2015 at 11:31:40PM +0800, Kevin Lo wrote: > FreeBSD needs to include netinet/in.h to define struct in6_addr. > > Signed-off-by: Kevin Lo > --- > > diff --git a/lib/ovs-router.h b/lib/ovs-router.h > index 315702c..c23d554 100644 > --- a/lib/ovs-router.h > +++ b/lib/ovs-router.h >

Re: [ovs-dev] [ovs-discuss] [announce] driverctl: utility for persistent alternative driver binding

2015-12-04 Thread Gray, Mark D
I welcome this initiative, one question below: > -Original Message- > From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Panu > Matilainen > Sent: Friday, December 4, 2015 10:54 AM > To: d...@dpdk.org; us...@dpdk.org; dev@openvswitch.org; > disc...@openvswitch.org > Subjec

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

2015-12-04 Thread Kevin Lo
On Thu, Dec 03, 2015 at 11:42:34PM -0800, Joe Stringer wrote: > > On 3 December 2015 at 22:11, Kevin Lo wrote: > > On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo > > wrote: > >> > >> On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote: > >> > On Wed, Dec 02, 2015 at

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Aaron Conole
"Traynor, Kevin" writes: >> -Original Message- <> >> +static int >> +get_dpdk_args(const struct ovsrec_open_vswitch *ovs_cfg, char ***argv) >> +{ >> +struct dpdk_options_map { >> +const char *ovs_configuration; >> +const char *dpdk_option; >> +bool default_enabl

[ovs-dev] [PATCH v2] ovs-router: fix compile error on FreeBSD

2015-12-04 Thread Kevin Lo
FreeBSD needs to include netinet/in.h to define struct in6_addr. Signed-off-by: Kevin Lo --- diff --git a/lib/ovs-router.h b/lib/ovs-router.h index 315702c..c23d554 100644 --- a/lib/ovs-router.h +++ b/lib/ovs-router.h @@ -17,6 +17,8 @@ #ifndef OVS_TNL_ROUTER_H #define OVS_TNL_ROUTER_H 1 +#in

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Aaron Conole
Panu Matilainen writes: > On 12/03/2015 06:23 AM, Aaron Conole wrote: >> Existing DPDK integration is provided by use of command line options which >> must be split out and passed to librte in a special manner. However, this >> forces any configuration to be passed by way of a special DPDK flag, a

[ovs-dev] hi

2015-12-04 Thread Conrad Dena
Hello. My name is Wendy and when I get home from school the first thing I do is get onmy computer and start chatting with people. My favorite is to lock my door,strip off my school clothes, and find friends who want to party online. I know I am popular online but what I really want is for someon

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Aaron Conole
Mauricio Vásquez writes: > Dear Aaron, > > The general idea looks good to me. > > Just some comments inline > > On 3 December 2015 at 05:23, Aaron Conole wrote: > << snipped >> >> +if(lookup) { >> +char **newargv = grow_argv(argv, ret, 2); >> + >> +if (!newargv) >

Re: [ovs-dev] [PATCH v3 1/5] netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 Thread Thadeu Lima de Souza Cascardo
On Tue, Dec 01, 2015 at 12:20:02PM -0800, Ben Pfaff wrote: > On Mon, Nov 30, 2015 at 04:53:02PM -0200, Thadeu Lima de Souza Cascardo wrote: > > This includes VXLAN, GRE and Geneve. > > > > Signed-off-by: Thadeu Lima de Souza Cascardo > > Would you mind adding some ipv6 test cases for tnl_push to

[ovs-dev] [PATCH v4 2/5] ofproto-dpif-xlate: Support IPv6 when sending to tunnel

2015-12-04 Thread Thadeu Lima de Souza Cascardo
When doing push/pop and building tunnel header, do IPv6 route lookups and send Neighbor Solicitations if needed. v2: Implement compose_nd as suggested by Flavio Leitner. Use ipv6_string_mapped for xlate_report. Do not use tnl_arp_lookup any more. Signed-off-by: Thadeu Lima de Souza Cascardo Cc:

[ovs-dev] [PATCH v4 3/5] tnl-neigh-cache: remove tnl_arp_lookup

2015-12-04 Thread Thadeu Lima de Souza Cascardo
tnl_arp_lookup is not used anymore. All users have been converted to IPv4-mapped addresses. New users need to use IPv4-mapped addresses and use tnl_neigh_lookup. Signed-off-by: Thadeu Lima de Souza Cascardo Acked-by: Ben Pfaff --- lib/tnl-neigh-cache.c | 19 --- lib/tnl-neigh-ca

[ovs-dev] [PATCH v4 1/5] netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 Thread Thadeu Lima de Souza Cascardo
This includes VXLAN, GRE and Geneve. v2: Added tests for parsing and formatting at odp.at, as suggested by Ben Pfaff. Fixed parsing problems found with those tests. Signed-off-by: Thadeu Lima de Souza Cascardo Cc: Ben Pfaff --- lib/netdev-vport.c | 230 --

[ovs-dev] [PATCH v4 4/5] Allow flow-based IPv6 tunnels to be configured with OpenFlow

2015-12-04 Thread Thadeu Lima de Souza Cascardo
With this patch, it is possible to set the IPv6 source and destination address in flow-based tunnels. $ ovs-ofctl add-flow br0 "in_port=LOCAL actions=set_field:2001:cafe::92->tun_ipv6_dst" Signed-off-by: Thadeu Lima de Souza Cascardo Signed-off-by: Jiri Benc Co-authored-by: Jiri Benc Acked-by

[ovs-dev] [PATCH v4 5/5] tests: Add tunnel-push-pop-ipv6 tests

2015-12-04 Thread Thadeu Lima de Souza Cascardo
Based on IPv4 tests, test tunnels over IPv6. In order to do that, add netdev-dummy/ip6addr command for dummy bridges, and get_in6 support for netdev-dummy as well. v2: Minor changes suggested by Ben Pfaff. Fixed tnl_push formatting for tests. Signed-off-by: Thadeu Lima de Souza Cascardo Acked-b

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-04 Thread Numan Siddique
On 12/04/2015 01:47 PM, Joe Stringer wrote: > On 3 December 2015 at 23:49, Numan Siddique wrote: >> On 12/04/2015 12:39 PM, Justin Pettit wrote: On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole > Sent: Thursday, December 3, 2015 4:24 AM > To: dev@openvswitch.org > Cc: Flavio Leitner > Subject: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db > > Existing DPDK integr

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Panu Matilainen
On 12/03/2015 06:23 AM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packag

[ovs-dev] hi

2015-12-04 Thread Weaver Lolita
Hello. My name is Wendy and when I get home from school the first thing I do is get onmy computer and start chatting with people. My favorite is to lock my door,strip off my school clothes, and find friends who want to party online. I know I am popular online but what I really want is for someon

[ovs-dev] [announce] driverctl: utility for persistent alternative driver binding

2015-12-04 Thread Panu Matilainen
Hi all, While this is not directly related to DPDK or OVS, it is potentially useful for users of both, so excuse me for cross-posting. Quoting from the project README (for the full text see http://laiskiainen.org/git/?p=driverctl.git;a=blob_plain;f=README) > driverctl is a tool for manipulati

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-04 Thread Joe Stringer
On 3 December 2015 at 23:49, Numan Siddique wrote: > On 12/04/2015 12:39 PM, Justin Pettit wrote: >>> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >>> >>> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >