Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Numan Siddique
On 12/04/2015 12:39 PM, Justin Pettit wrote: >> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >> >> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >>> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >>> would use a sequence to see if anything changed in NB d

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 22:11, Kevin Lo wrote: > On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo wrote: >> >> On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote: >> > On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote: >> > > On Wed, Dec 2, 2015 at 4:12 PM

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.5.0 (2.5.90).

2015-12-03 Thread Justin Pettit
> On Dec 3, 2015, at 11:34 PM, Joe Stringer wrote: > > On 3 December 2015 at 23:21, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Joe Stringer Thanks! I pushed the series and created a new "branch-2.5" branch. I'll push the revert of the NAT patch to the 2.5 in just

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.5.0 (2.5.90).

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 23:21, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] Prepare for 2.5.0.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 23:21, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 23:09, Justin Pettit wrote: > >> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: >> >> On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >>> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >>> would use a sequence to see if anything changed

[ovs-dev] [PATCH 1/2] Prepare for 2.5.0.

2015-12-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 42 ++ 3 files changed, 40 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index dd0295c..71b3d33 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -P

[ovs-dev] [PATCH 2/2] Prepare for post-2.5.0 (2.5.90).

2015-12-03 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 71b3d33..e1f3d33 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v2.5.0 +- + +

[ovs-dev] Delivery reports about your e-mail

2015-12-03 Thread MAILER-DAEMON
Dear user of openvswitch.org, We have detected that your email account has been used to send a huge amount of unsolicited e-mail messages during the recent week. Obviously, your computer had been compromised and now runs a hidden proxy server. Please follow the instructions in order to keep you

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Justin Pettit
> On Dec 3, 2015, at 10:55 PM, Ben Pfaff wrote: > > On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: >> Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we >> would use a sequence to see if anything changed in NB database to >> compute and notify the SB database

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix manpage formatting typo.

2015-12-03 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Dec 3, 2015, at 11:00 PM, Ben Pfaff wrote: > > Only the names of the fields were supposed to be bold here, but omitting > the "fR" from "\fR" made everything between the field names bold too, > which looked funny. > > Signed-off-by: Ben Pfaff > --- > ut

[ovs-dev] [PATCH] ovs-ofctl: Fix manpage formatting typo.

2015-12-03 Thread Ben Pfaff
Only the names of the fields were supposed to be bold here, but omitting the "fR" from "\fR" made everything between the field names bold too, which looked funny. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/o

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 10:23:19PM -0800, Ben Pfaff wrote: > On Thu, Dec 03, 2015 at 05:59:12PM -0800, Jarno Rajahalme wrote: > > seq values are 64-bit, and storing them to a 32-bit variable causes > > the stored value never to match actual seq value after the seq value > > gets big enough. > > >

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we > would use a sequence to see if anything changed in NB database to > compute and notify the SB database, and vice versa. This logic got > dropped with the refact

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 05:59:12PM -0800, Jarno Rajahalme wrote: > seq values are 64-bit, and storing them to a 32-bit variable causes > the stored value never to match actual seq value after the seq value > gets big enough. > > This is a likely cause of OVS main thread using 100% CPU in a system

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 06:39:46PM -0800, Jarno Rajahalme wrote: > Nevertheless, it is curious how the connectivity_seq would grow to > such a big value to trigger this bug. seq values are global (see how seq_next works in lib/seq.c) so it wouldn't have to be connectivity_seq related changes.

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

2015-12-03 Thread Kevin Lo
On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo wrote: > > On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote: > > On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote: > > > On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo wrote: > > > > On Wed, Dec 02, 2015 at

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-03 Thread Wei Li
I have created a pull request on git for adding db commands help and I want to change the output of "/ovn-nbctl show/" 1: "ovn-nbctl show" will print all switch and all router like this: lswitch 363cf780-c233-4cbd-a9b3-57bfad8dc907 (neutron-9822d5dd-017c-4c82-92d8-8b71f7d55255) lpo

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 18:39, Jarno Rajahalme wrote: > > On Dec 3, 2015, at 6:19 PM, Joe Stringer wrote: > > On 3 December 2015 at 17:59, Jarno Rajahalme wrote: > >> seq values are 64-bit, and storing them to a 32-bit variable causes >> the stored value never to match actual seq value after the

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Jarno Rajahalme
> On Dec 3, 2015, at 6:19 PM, Joe Stringer wrote: > > On 3 December 2015 at 17:59, Jarno Rajahalme > wrote: > seq values are 64-bit, and storing them to a 32-bit variable causes > the stored value never to match actual seq value after the seq value > gets big enough. > >

Re: [ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 17:59, Jarno Rajahalme wrote: > seq values are 64-bit, and storing them to a 32-bit variable causes > the stored value never to match actual seq value after the seq value > gets big enough. > > This is a likely cause of OVS main thread using 100% CPU in a system > using bond

[ovs-dev] [PATCH] bond: Use correct type for slave's change_seq.

2015-12-03 Thread Jarno Rajahalme
seq values are 64-bit, and storing them to a 32-bit variable causes the stored value never to match actual seq value after the seq value gets big enough. This is a likely cause of OVS main thread using 100% CPU in a system using bonds after some runtime. VMware-BZ: #1564993 Reported-by: Hiram Bay

Re: [ovs-dev] [PATCHv2 00/20] Conntrack datapath backport.

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 16:54, Pravin Shelar wrote: > On Wed, Dec 2, 2015 at 11:53 PM, Joe Stringer wrote: > > From: Joe Stringer > > > > This series backports the support for connection tracking introduced in > > Linux 4.3, allowing the kernel module in the tree to support this feature > > on ke

Re: [ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Thadeu Lima de Souza Cascardo
On Thu, Dec 03, 2015 at 05:11:49PM -0800, Joe Stringer wrote: > Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we > would use a sequence to see if anything changed in NB database to > compute and notify the SB database, and vice versa. This logic got > dropped with the refact

[ovs-dev] [PATCH] ovn-northd: Only run idl loop if something changed.

2015-12-03 Thread Joe Stringer
Before refactoring the main loop to reuse ovsdb_idl_loop_* functions, we would use a sequence to see if anything changed in NB database to compute and notify the SB database, and vice versa. This logic got dropped with the refactor, causing a testsuite failure in the ovn-sbctl test. Reintroduce the

Re: [ovs-dev] [PATCHv2 00/20] Conntrack datapath backport.

2015-12-03 Thread Pravin Shelar
On Wed, Dec 2, 2015 at 11:53 PM, Joe Stringer wrote: > From: Joe Stringer > > This series backports the support for connection tracking introduced in > Linux 4.3, allowing the kernel module in the tree to support this feature > on kernels 3.10 and newer. > > This series applies on top of the lwtu

Re: [ovs-dev] [PATCH v8] datapath: Add support for lwtunnel

2015-12-03 Thread Pravin Shelar
On Thu, Dec 3, 2015 at 4:12 PM, Jesse Gross wrote: > On Thu, Dec 3, 2015 at 4:05 PM, Joe Stringer wrote: >> On 3 December 2015 at 11:40, Pravin B Shelar wrote: >> >>> Following patch adds support for lwtunnel to OVS datapath. >>> With this change OVS datapath detect lwtunnel support and >>> make

Re: [ovs-dev] [PATCH v8] datapath: Add support for lwtunnel

2015-12-03 Thread Jesse Gross
On Thu, Dec 3, 2015 at 4:05 PM, Joe Stringer wrote: > On 3 December 2015 at 11:40, Pravin B Shelar wrote: > >> Following patch adds support for lwtunnel to OVS datapath. >> With this change OVS datapath detect lwtunnel support and >> make use of new APIs if available. On older kernel where the >>

Re: [ovs-dev] [PATCH v8] datapath: Add support for lwtunnel

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 11:40, Pravin B Shelar wrote: > Following patch adds support for lwtunnel to OVS datapath. > With this change OVS datapath detect lwtunnel support and > make use of new APIs if available. On older kernel where the > support is not there the backported tunnel modules are used

Re: [ovs-dev] [PATCH] packets: Introduce in6_addr_mapped_ipv4() and use where appropriate.

2015-12-03 Thread Thadeu Lima de Souza Cascardo
On Thu, Dec 03, 2015 at 01:00:38PM -0800, Ben Pfaff wrote: > This allows code to be written more naturally in some cases. > > Signed-off-by: Ben Pfaff > --- > lib/mcast-snooping.c | 9 +++-- > lib/ovs-router.c | 3 +-- > lib/packets.c| 14 ++

[ovs-dev] [PATCH] packets: Introduce in6_addr_mapped_ipv4() and use where appropriate.

2015-12-03 Thread Ben Pfaff
This allows code to be written more naturally in some cases. Signed-off-by: Ben Pfaff --- lib/mcast-snooping.c | 9 +++-- lib/ovs-router.c | 3 +-- lib/packets.c| 14 ++ lib/packets.h| 15 ++- lib/tnl-neigh-cache.c

Re: [ovs-dev] [PATCH v7] datapath: Add support for lwtunnel

2015-12-03 Thread Pravin Shelar
On Thu, Dec 3, 2015 at 10:29 AM, Joe Stringer wrote: > On 3 December 2015 at 08:10, Jesse Gross wrote: >> >> On Wed, Dec 2, 2015 at 11:34 PM, Joe Stringer wrote: >> > On 1 December 2015 at 19:04, Pravin B Shelar wrote: >> > >> >> Following patch adds support for lwtunnel to OVS datapath. >> >>

Re: [ovs-dev] [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-03 Thread David Miller
From: Paolo Abeni Date: Tue, 1 Dec 2015 18:33:36 +0100 > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in the

[ovs-dev] [PATCH 1/2] odp-util: Consider NAT bits in conversions and format.

2015-12-03 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto --- lib/odp-util.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/odp-util.c b/lib/odp-util.c index 32c813b..267451f 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -2576,6 +2576,10 @@ odp_ct_state_to_string(uint32_t flag)

[ovs-dev] [PATCH 2/2] ofproto-dpif: Validate NAT action support.

2015-12-03 Thread Daniele Di Proietto
The NAT validation is similar (and based on) the existing conntrack validation: when a dpif backer is created, we try to install a flow with the ct_state NAT bits set. If the flow setup fails we assume that the backer doesn't support NAT and we reject OpenFlow flows with a NAT action or a match on

Re: [ovs-dev] [PATCH v7] datapath: Add support for lwtunnel

2015-12-03 Thread Joe Stringer
On 3 December 2015 at 08:10, Jesse Gross wrote: > On Wed, Dec 2, 2015 at 11:34 PM, Joe Stringer wrote: > > On 1 December 2015 at 19:04, Pravin B Shelar wrote: > > > >> Following patch adds support for lwtunnel to OVS datapath. > >> With this change OVS datapath detect lwtunnel support and > >>

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Validate ct action support.

2015-12-03 Thread Joe Stringer
Thanks, I applied this series to master. On 2 December 2015 at 11:34, Jarno Rajahalme wrote: > LGTM, > > Acked-by: Jarno Rajahalme > > > On Dec 1, 2015, at 4:17 PM, Joe Stringer wrote: > > > > Disallow installing rules that execute ct() if conntrack is unsupported > > in the datapath. > > > >

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

2015-12-03 Thread Thadeu Lima de Souza Cascardo
On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote: > On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote: > > On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo wrote: > > > On Wed, Dec 02, 2015 at 03:47:57PM +0900, Takashi Yamamoto wrote: > > >> > > >> On Wed, Dec 2, 2015 at 3:21 PM, Ke

Re: [ovs-dev] [PATCH 1/1] ofproto: Wean off ofproto_class registration from ofproto initialization

2015-12-03 Thread Ben Pfaff
The commit message is inaccurate then. It's not about registering a custom ofproto_class, it's about suppressing registration of the standard one. On Wed, Dec 02, 2015 at 04:57:36AM +, Ansari, Shad wrote: > Ben, > > I have my own custome ofproto provider class (for a hardware dp) which is to

Re: [ovs-dev] [PATCH v2] ipfix: Skip BFD packets.

2015-12-03 Thread Ben Pfaff
On Thu, Dec 03, 2015 at 02:45:15AM +, Wenyu Zhang wrote: > > > On 12/2/15, 11:45 AM, "Ben Pfaff" wrote: > > >On Tue, Dec 01, 2015 at 06:43:49PM -0800, Wenyu Zhang wrote: > >> The patch is to skip BFD packets in ipfix. > >> Bidirectional Forwarding Detection (BFD) packets are for monitoring

Re: [ovs-dev] [PATCH v7] datapath: Add support for lwtunnel

2015-12-03 Thread Jesse Gross
On Wed, Dec 2, 2015 at 11:34 PM, Joe Stringer wrote: > On 1 December 2015 at 19:04, Pravin B Shelar wrote: > >> Following patch adds support for lwtunnel to OVS datapath. >> With this change OVS datapath detect lwtunnel support and >> make use of new APIs if available. On older kernel where the >

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-03 Thread Mauricio Vásquez
Dear Aaron, The general idea looks good to me. Just some comments inline On 3 December 2015 at 05:23, Aaron Conole wrote: > Existing DPDK integration is provided by use of command line options which > must be split out and passed to librte in a special manner. However, this > forces any confi

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-03 Thread Russell Bryant
On 12/03/2015 03:54 AM, Wei Li wrote: > ovn-nbctl -h > General commands: > show print overview of database contents > show LSWITCH print overview of database contents for LSWITCH > > How to show LROUTER? ovn-nbctl supports the same general database commands a

Re: [ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB support for windows datapath

2015-12-03 Thread Sorin Vinturis
Alin, I had some minor comments and added them inline. Other than that, looks good to me. Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Wednesday, 2 December, 2015 22:19 To: dev@openvswitch.org Subject: [ovs-dev

Re: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c

2015-12-03 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Wednesday, 2 December, 2015 19:51 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c Remove double include for Flow.h and sort th

Re: [ovs-dev] [PATCH 1/3] datapath-windows: Add sequence tunneling information define

2015-12-03 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Wednesday, 2 December, 2015 19:50 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/3] datapath-windows: Add sequence tunneling information define This patch adds

[ovs-dev] [PATCH] datapath-windows: Added recirculation support.

2015-12-03 Thread Sorin Vinturis
Recirculation support for the OVS extension. Signed-off-by: Sorin Vinturis Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/104 --- datapath-windows/ovsext/Actions.c | 202 +++--- datapath-windows/ovsext/Actions.h

[ovs-dev] Returned mail: Data format error

2015-12-03 Thread cconlin
Dear user dev@openvswitch.org, administration of openvswitch.org would like to let you know the following, We have received reports that your email account has been used to send a huge amount of junk e-mail during this week. We suspect that your computer had been infected by a recent virus and n

[ovs-dev] ovn-nbctl:What are router commands like?

2015-12-03 Thread Wei Li
ovn-nbctl -h General commands: show print overview of database contents show LSWITCH print overview of database contents for LSWITCH How to show LROUTER? Add a keywork like "ovn-nbctl show /router /LROUTER"? and "lport-add LSWITCH LPORT" has same problem, i

Re: [ovs-dev] [PATCH 09/23] compat: Backport IPv4 reassembly.

2015-12-03 Thread Joe Stringer
On 25 November 2015 at 09:36, Pravin Shelar wrote: > On Sun, Nov 8, 2015 at 1:29 AM, Joe Stringer wrote: >> Backport IPv4 reassembly from the upstream commit caaecdd3d3f8 ("inet: >> frags: remove INET_FRAG_EVICTED and use list_evictor for the test"). >> >> This is necessary because kernels prior