[ovs-dev] [PATCHv2 19/20] datapath: Scrub skb between namespaces

2015-12-02 Thread Joe Stringer
From: Joe Stringer If OVS receives a packet from another namespace, then the packet should be scrubbed. However, people have already begun to rely on the behaviour that skb->mark is preserved across namespaces, so retain this one field. This is mainly to address information leakage between names

[ovs-dev] [PATCH] Add Passive TCP connection to IDL

2015-12-02 Thread ofer . benyacov
Currently the IDL does not support passive TCP connection, i.e. when the OVSDB connects to its manager. This patch enables IDL to use an already-open session (the one which was previously used for retrieving the db schema). In addition, it enables IDL to go back to "listen mode" in case the conne

[ovs-dev] [PATCHv2 18/20] datapath: Backport conntrack fixes.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Backport the following fixes for conntrack from upstream. 9723e6abc70a openswitch: fix typo CONFIG_NF_CONNTRACK_LABEL 0d5cdef8d5dd openvswitch: Fix conntrack compilation without mark. 982b52700482 openvswitch: Fix mask generation for nested attributes. cc5706056baa openvswitch

[ovs-dev] [PATCHv2 17/20] datapath: Allow attaching helpers to ct action

2015-12-02 Thread Joe Stringer
From: Joe Stringer Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the CT action specifies a helper to be used for this connection. If no helper is specified, then helpers will be automatically applied as per the sysctl configuration o

[ovs-dev] [PATCHv2 16/20] datapath: Allow matching on conntrack label

2015-12-02 Thread Joe Stringer
From: Joe Stringer Allow matching and setting the ct_label field. As with ct_mark, this is populated by executing the CT action. The label field may be modified by specifying a label and mask nested under the CT action. It is stored as metadata attached to the connection. Label modification occur

[ovs-dev] [PATCHv2 12/20] datapath: Move MASKED* macros to datapath.h

2015-12-02 Thread Joe Stringer
From: Joe Stringer This will allow the ovs-conntrack code to reuse these macros. Upstream: be26b9a "openvswitch: Move MASKED* macros to datapath.h" Signed-off-by: Joe Stringer --- datapath/actions.c | 52 +--- datapath/datapath.h | 4 2 fi

[ovs-dev] [PATCHv2 13/20] datapath: Serialize acts with original netlink len

2015-12-02 Thread Joe Stringer
From: Joe Stringer Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializin

[ovs-dev] [PATCHv2 14/20] datapath: Add conntrack action

2015-12-02 Thread Joe Stringer
From: Joe Stringer Expose the kernel connection tracker via OVS. Userspace components can make use of the CT action to populate the connection state (ct_state) field for a flow. This state can be subsequently matched. Exposed connection states are OVS_CS_F_*: - NEW (0x01) - Beginning of a new co

[ovs-dev] [PATCHv2 20/20] FAQ: Document kernel feature support.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Some recent features have more stringent requirements for kernel versions than the FAQ describes. Add an entry to be more explicit on which features work with which versions of the upstream kernel. Signed-off-by: Joe Stringer --- FAQ.md | 23 +++ 1 file c

[ovs-dev] [PATCH] Add Passive TCP connection to IDL

2015-12-02 Thread ofer . benyacov
From: Ofer Ben Yacov --- python/ovs/db/idl.py | 18 +++--- python/ovs/jsonrpc.py | 19 +++ python/ovs/stream.py | 13 ++--- 3 files changed, 32 insertions(+), 18 deletions(-) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index c8990c7..4b492fe 10

[ovs-dev] [PATCHv2 06/20] compat: Backport dev_recursion_level().

2015-12-02 Thread Joe Stringer
From: Joe Stringer Signed-off-by: Joe Stringer --- acinclude.m4| 1 + datapath/linux/compat/include/linux/netdevice.h | 4 2 files changed, 5 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 090712e356df..51081262 100644 --- a/acinclude.

[ovs-dev] [PATCHv2 11/20] compat: Backport IPv6 reassembly.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Backport IPv6 fragment reassembly from upstream commits in the Linux 4.3 development tree. Signed-off-by: Joe Stringer --- v2: Fix compiler warning on RHEL7. --- datapath/compat.h | 28 +- datapath/linux/Modules.mk |

[ovs-dev] [PATCHv2 15/20] datapath: Allow matching on conntrack mark

2015-12-02 Thread Joe Stringer
From: Joe Stringer Allow matching and setting the ct_mark field. As with ct_state and ct_zone, these fields are populated when the CT action is executed. To write to this field, a value and mask can be specified as a nested attribute under the CT action. This data is stored with the conntrack ent

[ovs-dev] [PATCHv2 07/20] compat: Backport ip_skb_dst_mtu().

2015-12-02 Thread Joe Stringer
From: Joe Stringer From upstream f87c10a8aa1e ("ipv4: introduce ip_dst_mtu_maybe_forward and protect forwarding path against pmtu spoofing") Signed-off-by: Joe Stringer --- acinclude.m4 | 1 + datapath/linux/compat/include/net/ip.h | 39 ++

[ovs-dev] [PATCHv2 08/20] compat: Wrap IPv4 fragmentation.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Most kernels provide some form of ip fragmentation. However, until recently many of them would always send ICMP responses for over_MTU packets, even when operating in bridge mode. Backport the check to ensure this doesn't occur. Signed-off-by: Joe Stringer --- v2: Fix build o

[ovs-dev] [PATCHv2 09/20] compat: Backport IPv4 reassembly.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Backport IPv4 reassembly from the upstream commit caaecdd3d3f8 ("inet: frags: remove INET_FRAG_EVICTED and use list_evictor for the test"). This is necessary because kernels prior to upstream commit d6b915e29f4a ("ip_fragment: don't forward defragmented DF packet") would not a

[ovs-dev] [PATCHv2 10/20] compat: Backport IPv6 fragmentation.

2015-12-02 Thread Joe Stringer
From: Joe Stringer IPv6 fragmentation functionality is not exported by most kernels, so backport this code from the upstream 4.3 development tree. Signed-off-by: Joe Stringer --- v2: Fix build on newer RHEL kernels. --- acinclude.m4 | 1 + datapath/linux

[ovs-dev] [PATCHv2 02/20] compat: Backport nf_ct_tmpl_alloc().

2015-12-02 Thread Joe Stringer
From: Joe Stringer Loosely based upon Linux commit 0838aa7fcfcd "netfilter: fix netns dependencies with conntrack templates" and commit 5e8018fc6142 "netfilter: nf_conntrack: add efficient mark to zone mapping". Signed-off-by: Joe Stringer --- v2: Backport missing nf_ct_tmpl_free(). Fix war

[ovs-dev] [PATCHv2 04/20] compat: Backport 'dst' functions.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Signed-off-by: Joe Stringer --- acinclude.m4| 2 + datapath/linux/compat/include/net/dst.h | 78 + 2 files changed, 80 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index a3dd3eb99bbd..da1d39704c7b 100644

[ovs-dev] [PATCHv2 03/20] compat: Backport nf_connlabels_{get, put}().

2015-12-02 Thread Joe Stringer
From: Joe Stringer This is a partial backport of Linux commit 86ca02e77408 "netfilter: connlabels: Export setting connlabel length". Signed-off-by: Joe Stringer --- datapath/linux/Modules.mk | 1 + .../include/net/netfilter/nf_conntrack_labels.h| 41 ++

[ovs-dev] [PATCHv2 05/20] compat: Backport prandom_u32_max().

2015-12-02 Thread Joe Stringer
From: Joe Stringer Signed-off-by: Joe Stringer --- acinclude.m4 | 1 + datapath/linux/compat/include/linux/random.h | 7 +++ 2 files changed, 8 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index da1d39704c7b..090712e356df 100644 --- a/acinclude.m4

[ovs-dev] [PATCHv2 00/20] Conntrack datapath backport.

2015-12-02 Thread Joe Stringer
From: Joe Stringer This series backports the support for connection tracking introduced in Linux 4.3, allowing the kernel module in the tree to support this feature on kernels 3.10 and newer. This series applies on top of the lwtunnel backport series v7 from Pravin. For ease of review, I have ma

[ovs-dev] [PATCHv2 01/20] compat: Backport conntrack zones headers.

2015-12-02 Thread Joe Stringer
From: Joe Stringer Loosely based upon Linux commit 308ac9143ee2 "netfilter: nf_conntrack: push zone object into functions". Signed-off-by: Joe Stringer --- datapath/linux/Modules.mk | 3 + .../include/net/netfilter/nf_conntrack_expect.h| 21 + .../include/ne

Re: [ovs-dev] [PATCH v7] datapath: Add support for lwtunnel

2015-12-02 Thread Joe Stringer
On 1 December 2015 at 19:04, Pravin B Shelar wrote: > Following patch adds support for lwtunnel to OVS datapath. > With this change OVS datapath detect lwtunnel support and > make use of new APIs if available. On older kernel where the > support is not there the backported tunnel modules are used

[ovs-dev] [PATCH] netdev_dpdk: pci_dev pointer check.

2015-12-02 Thread mweglicx
This change prevents netdev_dpdk from accessing pointer which is not valid. Signed-off-by: Michal Weglicki --- lib/netdev-dpdk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4658416..2831a1b 100644 --- a/lib/netdev-dpdk.c

Re: [ovs-dev] [PATCH] python/ovs: Add passive TCP connection to IDL

2015-12-02 Thread Ofer Ben-Yacov
Thanks Russell. I did use Gmail while the instruction in the link you sent me says that gmail does not work for patches. I will resend using git send-mail command. Regards, Ofer. On Wed, Dec 2, 2015 at 6:50 PM, Russell Bryant wrote: > On 12/02/2015 09:49 AM, Ofer Ben-Yacov wrote: > > Currently

[ovs-dev] [PATCH v7] Implement OFPT_TABLE_STATUS Message.

2015-12-02 Thread saloni . jain12
From: Saloni Jain On change in a table state, the controller needs to be informed with the OFPT_TABLE_STATUS message. The message is sent with reason OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining space eventually crossing any one of the threshold. Signed-off-by: Saloni Ja

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

2015-12-02 Thread Flavio Fernandes
On Wed, Dec 2, 2015 at 11:03 PM, Takashi Yamamoto wrote: > hi, > > On Thu, Dec 3, 2015 at 3:26 AM, Flavio Fernandes > wrote: > > On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi > > > wrote: > > > >> These tests are racy as nothing prevents packet re-ordering. > >> Fix them by sorting outputs

[ovs-dev] [RFC 2/2] dpdk: Update INSTALL.DPDK.md to reflect new config

2015-12-02 Thread Aaron Conole
A previous change modified the way DPDK configuration would be accepted by the system. This updates the documentation to align with the new method of configuring DPDK. Signed-off-by: Aaron Conole --- INSTALL.DPDK.md | 52 ++-- 1 file changed, 38 in

[ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-02 Thread Aaron Conole
Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packaging solutions. This commit delays dpdk initia

[ovs-dev] [RFC 0/2] Convert DPDK configuration from command line to DB based

2015-12-02 Thread Aaron Conole
Currently, configuration of DPDK parameters is done via the command line through a --dpdk **OPTIONS** -- command line argument. This has a number of challenges, including: * It must be the first option passed to ovs-vswitchd * It breaks from the way most other things are configured in OVS * It does

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

2015-12-02 Thread Takashi Yamamoto
hi, On Thu, Dec 3, 2015 at 3:26 AM, Flavio Fernandes wrote: > On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi > wrote: > >> These tests are racy as nothing prevents packet re-ordering. >> Fix them by sorting outputs before comparing. >> >> Signed-off-by: YAMAMOTO Takashi >> > > Reviewed-by: F

Re: [ovs-dev] [PATCH v2] ipfix: Skip BFD packets.

2015-12-02 Thread Wenyu Zhang
On 12/2/15, 11:45 AM, "Ben Pfaff" wrote: >On Tue, Dec 01, 2015 at 06:43:49PM -0800, Wenyu Zhang wrote: >> The patch is to skip BFD packets in ipfix. >> Bidirectional Forwarding Detection (BFD) packets are for monitoring >> the tunnel link status and consumed by ovs itself, no need to sample >>

Re: [ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-02 Thread Daniele Di Proietto
That works for me, thanks Jarno. It would be nice for the module to be automatically loaded by the OVS kernel datapath when needed (I believe it happens with nf_conntrack_ftp), but I don't know if there's a way to do that. Anyway, this fixes a problem, so: Acked-by: Daniele Di Proietto On 02/1

[ovs-dev] Fwd: Re: [ovs] ovn-northd: The traffic form gateway port not need to be followed (#92)

2015-12-02 Thread Wei Li
Bryant is right topo: vm1(1.1.1.2/24)--lswitch--(1.1.1.1)lrouter(2.2.2.1)--lswitch--vm2(2.2.2.2/24) vm1 and vm2 is on2 different host, vm1 on host1 vm2 on host2 When ping from vm1 to vm2 , the result of ovs-dpctl dump-flows on host2: ingress: recirc_id(0),tunnel(tun_id=0x3,src=10.160.1.122,d

[ovs-dev] Your e-ticket #00494076

2015-12-02 Thread America Airlines
Dear customer, Your payment has been processed and your credit card has been charged. You can find your e-ticket in the attachment. Order details and e-ticket information: FLIGHT NUMBER : MZ128378 DATE & TIME : Dec 10 2015, 13:40 DEPARTING : Raleigh TOTAL PRICE : $ 360.00 Thank you for flying

Re: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c

2015-12-02 Thread Nithin Raju
Acked-by: Nithin Raju -Original Message- From: dev on behalf of Alin Serdean Date: Wednesday, December 2, 2015 at 9:50 AM To: "dev@openvswitch.org" Subject: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c >Remove double include for Flow.h and sort the includes alphabetically. >A

Re: [ovs-dev] [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-02 Thread Pravin Shelar
On Tue, Dec 1, 2015 at 9:33 AM, Paolo Abeni wrote: > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in the netde

[ovs-dev] [PATCH] tests: Check for NAT modules in system testsuite.

2015-12-02 Thread Jarno Rajahalme
FTP NAT system tests fail if the corresponding modules are not loaded. Add a probe for nf_nat_ftp module to make sure it is loaded before the tests. Reported-by: Daniele Di Proietto Signed-off-by: Jarno Rajahalme --- tests/system-kmod-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [ovs-dev] Good News

2015-12-02 Thread Robert A. Gorman
From: Robert A. Gorman Sent: Wednesday, December 02, 2015 5:11 PM To: Robert A. Gorman Subject: RE: Good News From: Robert A. Gorman Sent: Wednesday, December 02, 2015 5:06 PM To: Robert A. Gorman Subject: Good News 2m USD t

[ovs-dev] [PATCH] Update windows datapath build system

2015-12-02 Thread Alin Serdean
Currently when building the windows datapath from the command line we specify the type (Release or Debug), which will build both versions (Win 8 and Win 8.1) of that type. This made a strict requirement of WDK 8.1. This patch allows the user to specify a specific version and type of the datapath w

Re: [ovs-dev] [PATCH 3/3] datapath-windows: Add GRE TEB support for windows datapath

2015-12-02 Thread Sairam Venugopal
Thanks for the patch Alin. I had very minor comments that I have added inline. Looks good otherwise. Sairam On 12/2/15, 9:50 AM, "Alin Serdean" wrote: >This patch introduces the support for GRE TEB (trasparent ethernet >bridging) >for the windows datapath. > >The GRE support is based on >https:

[ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB support for windows datapath

2015-12-02 Thread Alin Serdean
This patch introduces the support for GRE TEB (trasparent ethernet bridging) for the windows datapath. The GRE support is based on http://tools.ietf.org/html/rfc2890 and supports only the GRE protocol type 6558 (trasparent ethernet bridging) like its linux counterpart. Util.h: define the GRE pool

[ovs-dev] [PATCH v3 09/12] ovstest: Add test-netlink-conntrack command.

2015-12-02 Thread Daniele Di Proietto
Add a new test module to help debug Linux kernel conntrack development unsing the netlink-conntrack module. The tool has three uses: * `ovstest test-netlink-conntrack dump [zone=zone]` shows a list of the connection table * `ovstest test-netlink-conntrack monitor` displays the updates on t

[ovs-dev] [PATCH v3 10/12] system-traffic: use `dpctl/*conntrack` instead of `conntrack` tool.

2015-12-02 Thread Daniele Di Proietto
Often in the tests we inspect the conntrack tables with the 'conntrack' command line utility. Since this may not always be available, and since these tests are supposed to run with the upcoming userspace connection tracker, it is better to use the newly implemented dpctl command. Due to the tcp s

[ovs-dev] [PATCH v3 06/12] dpctl: Add 'conntrack-dump' command.

2015-12-02 Thread Daniele Di Proietto
It can be used to inspect the connection tracking entries in the datapath. Signed-off-by: Daniele Di Proietto --- lib/dpctl.c | 45 + lib/dpctl.man | 24 2 files changed, 69 insertions(+) diff --git a/lib/dpctl.c b/lib/dpctl

[ovs-dev] [PATCH v3 08/12] dpctl: Add new 'flush-conntrack' command.

2015-12-02 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto --- lib/dpctl.c | 30 ++ lib/dpctl.man | 6 ++ 2 files changed, 36 insertions(+) diff --git a/lib/dpctl.c b/lib/dpctl.c index 2990026..73204e2 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1285,6 +1285,35 @@ dpctl_dump_conntr

[ovs-dev] [PATCH v3 04/12] ct-dpif: Add ct_dpif_flush().

2015-12-02 Thread Daniele Di Proietto
This function will flush the connection tracking tables of a specific datapath. It simply calls a function pointer in the dpif_class. No dpif currently implements the required interface. The next commits will provide an implementation in dpif-netlink. Signed-off-by: Daniele Di Proietto --- lib

[ovs-dev] [PATCH v3 12/12] system-kmod-macros: Do not require the 'conntrack' tool.

2015-12-02 Thread Daniele Di Proietto
We can use 'ovstest test-netlink-conntrack' instead. Now that it is not required anymore, we can remove the HAVE_CONNTRACK macro in the build system. Signed-off-by: Daniele Di Proietto --- tests/atlocal.in| 7 --- tests/system-kmod-macros.at | 5 ++--- 2 files changed, 2 inserti

[ovs-dev] [PATCH v3 03/12] ct-dpif: Add ct_dpif_dump_{start, next, done}().

2015-12-02 Thread Daniele Di Proietto
These function can be used to dump conntrack entries from a datapath. They simply call a function pointer in the dpif_class. No dpif currently implements the interface. The next commits will provide an implementation in dpif-netlink. Signed-off-by: Daniele Di Proietto --- lib/ct-dpif.c |

[ovs-dev] [PATCH v3 07/12] dpif-netlink: Implement ct_flush.

2015-12-02 Thread Daniele Di Proietto
This member function is used by the ct-dpif module to provide its services. It's implemented using the netlink-conntrack module. N.B. The Linux kernel datapaths share the connection tracker among them and with the rest of the system. Therefore the operations are not really dpif specific. Signed

[ovs-dev] [PATCH v3 11/12] system-traffic: Use 'dpctl/dump-conntrack' for NAT tests.

2015-12-02 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto CC: Jarno Rajahalme --- I've experienced some failures for the FTP NAT tests, so I wasn't able to fully test this patch. --- tests/system-traffic.at | 52 + 1 file changed, 27 insertions(+), 25 deletions(-) diff

[ovs-dev] [PATCH v3 02/12] netlink-conntrack: New module.

2015-12-02 Thread Daniele Di Proietto
This module uses the netlink interface provide by the Linux kernel connection tracker to provide some visibility into the conntrack tables. The module provides functions to: * Convert a netlink representation of a connection into a struct 'ct_dpif_entry'. * Dump all the connections. * Flush a

[ovs-dev] [PATCH v3 00/12] Conntrack debugging appctl/dpctl

2015-12-02 Thread Daniele Di Proietto
The goal of this series is to introduce two dpctl command to interact with the Linux kernel connection tracker. The same infrastructure will be used by the userspace connection tracker. First, it defines some structures and some formatting routines (ct-dpif). Then, it adds some code to transform

Re: [ovs-dev] [PATCH v2 01/11] ct-dpif: New module.

2015-12-02 Thread Daniele Di Proietto
Hi Joe, thanks for the comments, answers inline I'm about to send a v3 to the list. On 17/11/2015 14:26, "Joe Stringer" wrote: >On 5 November 2015 at 19:12, Daniele Di Proietto >wrote: >> This defines some structures (and their related formatting functions) to >> manipulate entries in connect

[ovs-dev] [PATCH v3 05/12] dpif-netlink: Implement ct_dump_{start, next, done}.

2015-12-02 Thread Daniele Di Proietto
These member functions are used by the ct-dpif module to provide its services. They're implemented using the netlink-conntrack module. N.B. The Linux kernel datapaths share the connection tracker among them and with the rest of the system. Therefore the operations are not really dpif specific.

[ovs-dev] [PATCH v3 01/12] ct-dpif: New module.

2015-12-02 Thread Daniele Di Proietto
This defines some structures (and their related formatting functions) to manipulate entries in connection tracking tables. It will be used by next commits. Based on original work by Jarno Rajahalme Signed-off-by: Jarno Rajahalme Signed-off-by: Daniele Di Proietto --- lib/automake.mk | 2 +

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Validate ct action support.

2015-12-02 Thread Jarno Rajahalme
LGTM, Acked-by: Jarno Rajahalme > On Dec 1, 2015, at 4:17 PM, Joe Stringer wrote: > > Disallow installing rules that execute ct() if conntrack is unsupported > in the datapath. > > Reported-by: Ravindra Kenchappa > Signed-off-by: Joe Stringer > --- > v3: Revert back to checking as part of r

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

2015-12-02 Thread Flavio Fernandes
On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi wrote: > These tests are racy as nothing prevents packet re-ordering. > Fix them by sorting outputs before comparing. > > Signed-off-by: YAMAMOTO Takashi > Reviewed-by: Flavio Fernandes ___ dev mailin

Re: [ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c

2015-12-02 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 12/2/15, 9:50 AM, "Alin Serdean" wrote: >Remove double include for Flow.h and sort the includes alphabetically. >Also remove tabs. > >Found by inspection. > >Signed-off-by: Alin Gabriel Serdean >--- > datapath-windows/ovsext/Stt.c | 44 >+-

Re: [ovs-dev] [PATCH 1/3] datapath-windows: Add sequence tunneling information define

2015-12-02 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 12/2/15, 9:50 AM, "Alin Serdean" wrote: >This patch adds the sequence tunneling information which will be needed >for >GRE tunneling. > >Signed-off-by: Alin Gabriel Serdean >--- > datapath-windows/ovsext/Flow.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git

Re: [ovs-dev] [PATCH] debian: Skip systemctl redirect.

2015-12-02 Thread Guru Shetty
On 1 December 2015 at 12:00, Ben Pfaff wrote: > On Tue, Dec 01, 2015 at 11:51:34AM -0800, Guru Shetty wrote: > > > > > > > > > Does this fix #1 or #2 or both? > > > > > It fixes #2. It will fix #1 too as long as upstream Ubuntu does not > change > > the sysv script that we provide. > > OK, I unde

[ovs-dev] [PATCH 2/3] datapath-windows: Cleanup Stt.c

2015-12-02 Thread Alin Serdean
Remove double include for Flow.h and sort the includes alphabetically. Also remove tabs. Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Stt.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/d

[ovs-dev] [PATCH 3/3] datapath-windows: Add GRE TEB support for windows datapath

2015-12-02 Thread Alin Serdean
This patch introduces the support for GRE TEB (trasparent ethernet bridging) for the windows datapath. The GRE support is based on http://tools.ietf.org/html/rfc2890 and supports only the GRE protocol type 6558 (trasparent ethernet bridging) like its linux counterpart. Util.h: define the GRE pool

[ovs-dev] [PATCH 1/3] datapath-windows: Add sequence tunneling information define

2015-12-02 Thread Alin Serdean
This patch adds the sequence tunneling information which will be needed for GRE tunneling. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Flow.h b/datapath-windows/ovsext/Flow.h index 74b9dfb..0d4

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-02 Thread Zoltan Kiss
I plan to, obviously as part of an ODP series. But I don't have a time set for that. Regards, Zoltan On 02/12/15 16:33, Ben Pfaff wrote: On Wed, Dec 02, 2015 at 03:40:33PM +, Zoltan Kiss wrote: On 01/12/15 18:04, Ben Pfaff wrote: On Tue, Dec 01, 2015 at 04:09:07PM +0200, Panu Matilain

Re: [ovs-dev] [PATCH RFC v2] ofproto: RFC extended statistics patch.

2015-12-02 Thread Ben Pfaff
Sounds good! On Wed, Dec 02, 2015 at 11:11:41AM +, Weglicki, MichalX wrote: > Hello, > > Thank you for the comments. > > "I'm confused by the tentative choice of vendor ID, because it doesn't > seem to be an Ethernet OUI for Intel." > [MW] To be honest I didn't put too much attention to VE

Re: [ovs-dev] [PATCH] python/ovs: Add passive TCP connection to IDL

2015-12-02 Thread Russell Bryant
On 12/02/2015 09:49 AM, Ofer Ben-Yacov wrote: > Currently the IDL does not support passive TCP connection, > i.e. when the OVSDB connects to its manager. > > This patch enables IDL to use an already-open session > (the one which was previously used for retrieving the db schema). > In addition, it

Re: [ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
On 12/02/2015 11:39 AM, Ben Pfaff wrote: > On Wed, Dec 02, 2015 at 11:37:11AM -0500, Russell Bryant wrote: >> Add OVN to NEWS as a post-2.4.0 feature. >> >> Signed-off-by: Russell Bryant > > I like "experimental" because I think we might still be making > non-backward-compatible schema changes. >

Re: [ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Justin Pettit
Thanks for writing it up. Acked-by: Justin Pettit --Justin > On Dec 2, 2015, at 8:37 AM, Russell Bryant wrote: > > Add OVN to NEWS as a post-2.4.0 feature. > > Signed-off-by: Russell Bryant > --- > NEWS | 4 > 1 file changed, 4 insertions(+) > > v1->v2: > - s/initial/experimental/ >

Re: [ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Ben Pfaff
On Wed, Dec 02, 2015 at 11:37:11AM -0500, Russell Bryant wrote: > Add OVN to NEWS as a post-2.4.0 feature. > > Signed-off-by: Russell Bryant I like "experimental" because I think we might still be making non-backward-compatible schema changes. Acked-by: Ben Pfaff __

[ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
Add OVN to NEWS as a post-2.4.0 feature. Signed-off-by: Russell Bryant --- NEWS | 4 1 file changed, 4 insertions(+) v1->v2: - s/initial/experimental/ diff --git a/NEWS b/NEWS index cae265f..dd0295c 100644 --- a/NEWS +++ b/NEWS @@ -31,6 +31,10 @@ Post-v2.4.0 - Add support for connect

Re: [ovs-dev] [PATCH] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
On 12/02/2015 11:21 AM, Justin Pettit wrote: > I think I would go with experimental, since I don't think it should be used > in production yet. I'm hopeful that the release after 2.5 will be one that > people can start using. OK, agreed. I'll do a v2 using "experimental". -- Russell Bryant _

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-02 Thread Ben Pfaff
On Wed, Dec 02, 2015 at 03:40:33PM +, Zoltan Kiss wrote: > > > On 01/12/15 18:04, Ben Pfaff wrote: > >On Tue, Dec 01, 2015 at 04:09:07PM +0200, Panu Matilainen wrote: > >>On 11/26/2015 07:56 PM, Traynor, Kevin wrote: > >>>Just wanted to post some summary notes on the recent OVS with DPDK Meet

Re: [ovs-dev] [PATCH] NEWS: Add OVN.

2015-12-02 Thread Justin Pettit
I think I would go with experimental, since I don't think it should be used in production yet. I'm hopeful that the release after 2.5 will be one that people can start using. --Justin > On Dec 2, 2015, at 7:19 AM, Russell Bryant wrote: > > Add OVN to NEWS as a post-2.4.0 feature. > > Signe

Re: [ovs-dev] [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-02 Thread Flavio Leitner
On Tue, Dec 01, 2015 at 06:33:36PM +0100, Paolo Abeni wrote: > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-02 Thread Zoltan Kiss
On 01/12/15 18:04, Ben Pfaff wrote: On Tue, Dec 01, 2015 at 04:09:07PM +0200, Panu Matilainen wrote: On 11/26/2015 07:56 PM, Traynor, Kevin wrote: Just wanted to post some summary notes on the recent OVS with DPDK Meetup we had after the OVS conference. Thanks to everyone for the often lively

[ovs-dev] [PATCH] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
Add OVN to NEWS as a post-2.4.0 feature. Signed-off-by: Russell Bryant --- NEWS | 4 1 file changed, 4 insertions(+) I considered s/initial/experimental/ in this NEWS entry, but I'm curious what others think is appropriate. Mainly I was thinking we might want to mark it as experimental wh

[ovs-dev] [PATCH] python/ovs: Add passive TCP connection to IDL

2015-12-02 Thread Ofer Ben-Yacov
Currently the IDL does not support passive TCP connection, i.e. when the OVSDB connects to its manager. This patch enables IDL to use an already-open session (the one which was previously used for retrieving the db schema). In addition, it enables IDL to go back to "listen mode" in case the connec

Re: [ovs-dev] [PATCH] ofp-util: Remove unneeded default case from ofputil_decode_group_mod().

2015-12-02 Thread Flavio Leitner
On Wed, Dec 02, 2015 at 02:11:16PM +0900, Simon Horman wrote: > On Tue, Dec 01, 2015 at 07:50:43PM -0800, Ben Pfaff wrote: > > On Wed, Dec 02, 2015 at 10:27:53AM +0900, Simon Horman wrote: > > > On Tue, Dec 01, 2015 at 10:39:04AM -0800, Ben Pfaff wrote: > > > > Code earlier in this function validat

Re: [ovs-dev] [PATCH RFC v2] ofproto: RFC extended statistics patch.

2015-12-02 Thread Weglicki, MichalX
Hello, Thank you for the comments. "I'm confused by the tentative choice of vendor ID, because it doesn't seem to be an Ethernet OUI for Intel." [MW] To be honest I didn't put too much attention to VENDOR_ID because my initial plan was to re-submit patch with all relevant RFC2819 counters whe

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-02 Thread Gray, Mark D
> > > > I agree, it should simplify the code a lot. Ciara reviewed it and did > > a quick integration to see if the api would work. The patch was > > churning quite a bit, so we decided to hold off doing any more work > > with it for the time being. > > Correct, the vHost PMD really cleans things