Otherwise logical router ARP replies won't work as implemented.
Signed-off-by: Ben Pfaff
---
ovn/TODO | 35 ---
ovn/lib/expr.c | 10 ++
ovn/ovn-sb.xml | 6 +-
3 files changed, 15 insertions(+), 36 deletions(-)
diff --git a/ovn/TODO b/ovn/TODO
i
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 77 ++--
1 file changed, 70 insertions(+), 7 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index c76b5dc..b149058 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -886,6 +886,11 @@ vif_to_h
Logical patch ports do not have a physical location and effectively reside
on every hypervisor. This is fine for unicast output to logical patch
ports. However, when a logical patch port is part of a logical multicast
group, lumping them together with the other "local" ports in a multicast
group
On Fri, Oct 16, 2015 at 05:20:09PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote:
> >
> > ---
> > ovn/TODO| 6 -
>
> From ovn/TODO:
>
> -=-=-=-=-=-=-=-=-
> ** IP to MAC binding
>
> Somehow it has to be possible for an L3 logical router to map f
This message was not delivered due to the following reason:
Your message was not delivered because the destination server was
not reachable within the allowed queue period. The amount of time
a message is queued before it is returned depends on local configura-
tion parameters.
Most likely there
On Fri, Oct 16, 2015 at 02:46:55PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote:
> >
> > +*** Allow output to ingress port
> > +
> > +Sometimes when a packet ingresses into a router, it has to egress the
> > +same port. One example is a "one-armed" router that h
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote:
>
> ---
> ovn/TODO| 6 -
From ovn/TODO:
-=-=-=-=-=-=-=-=-
** IP to MAC binding
Somehow it has to be possible for an L3 logical router to map from an
IP address to an Ethernet address. This can happen statically or
dynamically.
On Fri, Oct 9, 2015 at 3:11 PM, Pravin B Shelar wrote:
> Following patch adds support for lwtunnel to OVS datapath.
> With this change OVS datapath detect lwtunnel support and
> make use of new APIs if available. On older kernel where the
> support is not there the backported tunnel modules are us
On 16 October 2015 at 15:46, Pravin Shelar wrote:
> On Fri, Oct 16, 2015 at 3:31 PM, Joe Stringer wrote:
>> GCC4.4 gets confused by anonymous fields + flexible fields, complains:
>> lib/ofp-actions.h:510: error: flexible array member in otherwise empty
>> struct
>> lib/ofp-actions.h:512: error: b
On Fri, Oct 16, 2015 at 3:31 PM, Joe Stringer wrote:
> GCC4.4 gets confused by anonymous fields + flexible fields, complains:
> lib/ofp-actions.h:510: error: flexible array member in otherwise empty
> struct
> lib/ofp-actions.h:512: error: bit-field ‘build_assert_failed’ width not
> an integer con
On Fri, Oct 16, 2015 at 2:24 PM, Joe Stringer wrote:
> On 16 October 2015 at 13:46, Gurucharan Shetty wrote:
>> Signed-off-by: Gurucharan Shetty
>
> Acked-by: Joe Stringer
Thanks Joe. Pushed the series.
___
dev mailing list
dev@openvswitch.org
http://
GCC4.4 gets confused by anonymous fields + flexible fields, complains:
lib/ofp-actions.h:510: error: flexible array member in otherwise empty
struct
lib/ofp-actions.h:512: error: bit-field ‘build_assert_failed’ width not
an integer constant
lib/ofp-actions.h:514: error: bit-field ‘build_assert_fail
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote:
>
> +*** Allow output to ingress port
> +
> +Sometimes when a packet ingresses into a router, it has to egress the
> +same port. One example is a "one-armed" router that has multiple
> +routes on a single port (or in which a host is (mis)configured
On Thu, Oct 15, 2015 at 11:21 AM, Liran Schour wrote:
> OK. Andy, tell me when you post your changes so I will be able to base mine
> on top of yours.
>
I have got a version that seems to work. I plan to add more tests in
the next few days, then post them
for review.
In the mean time, I have pu
On 16 October 2015 at 13:46, Gurucharan Shetty wrote:
> Windows has INET6_ADDRSTRLEN defined as 65 whereas
> POSIX has it as 46. This difference causes a unit test
> failure as the test 'tunnel_push_pop' was looking at o/p
> format based on the length of INET6_ADDRSTRLEN.
>
> Signed-off-by: Guruch
On 16 October 2015 at 13:46, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Oct 15, 2015 at 11:49:13PM -0700, Han Zhou wrote:
> On Fri, Oct 9, 2015 at 9:21 PM, Ben Pfaff wrote:
> > +/* Connect logical router ports, and logical switch ports of type
> > "router",
> > + * to their peers. */
> > +struct ovn_port *op;
> > +HMAP_FOR_EACH (op, key_node,
On Thu, Oct 15, 2015 at 06:59:19PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote:
> >
> > Until now, ovn-northd has only set up flows for logical switches. With the
> > arrival of logical routers, it needs to set up flows for them too. The
> > stages within logi
On 10/16/2015 11:32 AM, Ansis Atteka wrote:
On Thu, Oct 15, 2015 at 4:52 PM, Saurabh Mohan
wrote:
On 10/15/2015 01:55 PM, Ansis Atteka wrote:
On Wed, Oct 14, 2015 at 5:33 PM, Saurabh Mohan
wrote:
On 10/14/2015 04:58 PM, Ansis Atteka wrote:
On Wed, Oct 14, 2015 at 4:08 PM, Ben Pfaff wro
On Thu, Oct 15, 2015 at 06:31:51PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
> >
> > +char * OVS_WARN_UNUSED_RESULT
> > +ip_parse_masked(const char *s, ovs_be32 *ip, ovs_be32 *mask)
>
> It might be nice to provide a comment
On Thu, Oct 15, 2015 at 06:27:49PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks. Again, I've updated the commit message:
ovn-nb: Add "enabled" column to Logical_Router_Port.
This
Signed-off-by: Gurucharan Shetty
---
tests/atlocal.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 095bc40..b234c52 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -112,7 +112,7 @@ if test "$IS_WIN32" = "yes"; then
fi
Windows has INET6_ADDRSTRLEN defined as 65 whereas
POSIX has it as 46. This difference causes a unit test
failure as the test 'tunnel_push_pop' was looking at o/p
format based on the length of INET6_ADDRSTRLEN.
Signed-off-by: Gurucharan Shetty
---
include/windows/windefs.h |3 +++
1 file cha
On Thu, Oct 15, 2015 at 06:26:54PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks.
I realized when looking at this that I didn't put any rationale into the
commit message. I improved it:
On Thu, Oct 15, 2015 at 05:56:31PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote:
> >
> > In my opinion, "eth.mcast" is a bit more readable than "eth.dst[40]", and
> > so on.
> >
> > Signed-off-by: Ben Pfaff
>
> I think there are a couple of spots in "ovn-north
On Thu, Oct 15, 2015 at 05:17:28PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote:
> >
> > -create_patch_ports(ctx, network, existing_ports, br_int,
> > ovs_bridge);
> > -create_patch_ports(ctx, network, existing_ports, ovs_bridge,
> > br_int);
>
On Thu, Oct 15, 2015 at 05:48:30PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote:
> >
> > diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c
> > index 90c72ff..f25709c 100644
> > --- a/ovn/controller/patch.c
> > +++ b/ovn/controller/patch.c
> > @@ -50,7
On Thu, Oct 15, 2015 at 04:38:57PM -0700, Justin Pettit wrote:
>
> > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote:
> >
> > +/* Add any patch ports that should exist but don't. */
> > +parse_bridge_mappings(ctx, br_int, &existing_ports);
>
> This comment could probably use a bit more info
On Fri, Oct 16, 2015 at 4:07 AM, James Morse wrote:
> "openvswitch: Remove vport stats" removed the per-vport statistics, in
> order to use the netdev's statistics fields.
> "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats
> to user-space, by using the provided netdev_ops t
On Thu, Oct 15, 2015 at 4:52 PM, Saurabh Mohan
wrote:
> On 10/15/2015 01:55 PM, Ansis Atteka wrote:
>>
>> On Wed, Oct 14, 2015 at 5:33 PM, Saurabh Mohan
>> wrote:
>>>
>>> On 10/14/2015 04:58 PM, Ansis Atteka wrote:
On Wed, Oct 14, 2015 at 4:08 PM, Ben Pfaff wrote:
>
>
On Fri, Oct 16, 2015 at 07:50:47PM +0900, Simon Horman wrote:
> * encode: if properties are present include their length in
> value of the length field of the group desc
> * decode: use the value of the length field to calculate the length of
> properties rather than assuming th
On Fri, Oct 16, 2015 at 07:50:48PM +0900, Simon Horman wrote:
> This corrects the parsing of 'fields' specified for groups on
> the command line. 'fields' may be used in conjunction with the
> Netronome selection method extension to describe which fields of
> the flow should be used as by the selec
Until now, the only way to specify multiple fields in the "fields"
parameter for the Netronome groups extension, was to specify "fields"
more than once, e.g. fields=eth_dst,fields=ip_dst
However, this wasn't documented and the code in ofp-print didn't use it,
generating output that couldn't be par
On Fri, Oct 16, 2015 at 08:15:19AM +, Justin Pettit wrote:
>
> > On Oct 15, 2015, at 9:35 PM, Ben Pfaff wrote:
> >
> > On Thu, Oct 15, 2015 at 11:38:34PM +, Justin Pettit wrote:
> >> After reviewing patch 10, I have a few more thoughts on this patch. This
> >> doesn't change my origina
This patch provides the modifications required in netdev-dpdk.c and
vswitch.xml to allow for a DPDK user space QoS algorithm.
This patch adds a QoS configuration structure for netdev-dpdk and
expected QoS operations 'dpdk_qos_ops'. Various helper functions
are also supplied.
Also included are the
On 10/16/15 2:16 AM, David Miller wrote:
From: Thomas F Herbert
Date: Thu, 15 Oct 2015 10:01:52 -0400
This patch accompanies version 14 of the user level openvswitch patch
submitted to openvswitch dev list.
V16,15: Implement reviewer comments.
Missing signoffs, missed handling of feedb
This corrects the parsing of 'fields' specified for groups on
the command line. 'fields' may be used in conjunction with the
Netronome selection method extension to describe which fields of
the flow should be used as by the selection method.
This patch corrects two problems with the current implem
* encode: if properties are present include their length in
value of the length field of the group desc
* decode: use the value of the length field to calculate the length of
properties rather than assuming that the rest of the message
is properties. This assumption is
Hi,
this short series addresses several defects in the implementation
of the group selection method that prevent it from working as
documented under some circumstances.
Simon Horman (2):
ofproto: correct encoding and decoding of group desc properties
ofproto: correct group fields command line
Adding a self-guide for configuring native userspace tunneling in OVS
with/without DPDK ports. This document also provides necessary debugging
commands to identify and resolve the userspace tunneling issues in OVS.
Signed-off-by: Sugesh Chandran
---
README-native-tunneling-DPDK.md | 206 +++
> On Oct 15, 2015, at 9:35 PM, Ben Pfaff wrote:
>
> On Thu, Oct 15, 2015 at 11:38:34PM +, Justin Pettit wrote:
>> After reviewing patch 10, I have a few more thoughts on this patch. This
>> doesn't change my original ACK, though.
>
> This patch is supposed to be mostly moving code around.
> On Oct 15, 2015, at 1:29 PM, Ben Pfaff wrote:
>
> On Thu, Oct 15, 2015 at 01:55:00AM -0700, Justin Pettit wrote:
>> This test exposed a problem that ovn-controller-vtep doesn't properly
>> set up the "Mcast_Macs_Remote" table, which prevents broadcasts from
>> being sourced from the physical s
> On Oct 15, 2015, at 1:11 PM, Ben Pfaff wrote:
>
> On Thu, Oct 15, 2015 at 01:54:58AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> It looks like physical_run() will now iterate through every row in the
> Port_Binding table for each VXLAN tunnel. That seems expensive.
I ag
> On Oct 15, 2015, at 1:19 PM, Ben Pfaff wrote:
>
> On Thu, Oct 15, 2015 at 01:54:59AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> The chassis.c code only verifies the IP address for one of the
> encapsulations, maybe it should do it for all of them, something like
> this:
> On Oct 15, 2015, at 5:21 PM, Ben Pfaff wrote:
>
> On Thu, Oct 15, 2015 at 10:32:51AM -0700, Justin Pettit wrote:
>> Add support for the "allow-related" ACL action. This is dependent on
>> the OVS conntrack functionality, which is not available on all platforms
>> or kernel versions.
>>
>> He
I am also very interested in the “where” clause in “monitor” for OpenSwitch use
and we intended to propose something similar.
Some questions:
What will we do when row A is the only reference to row B and row A doesn’t
pass the “where” condition?
Will A still be sent? or will B exist in IDL with
47 matches
Mail list logo
